The company is not mandatory on the analytic account, and the currency on it
is a related field to the currency of that company, if set. In case it is not
set, we should add a default fallback on the currency of the company of the
manufacturing order.

closes odoo/odoo#72456

X-original-commit: 4fc2ec31
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>

The import logging (ish) assumes that if an exception has at least 2
args the second arg is metadata added by the callee.

As it turns out, `UnicodeEncodeError` has *five* arguments, none of
which is added by us. So if encoding something fails during the
process (e.g. because the file contains a lone surrogate, which leads
to the database insert failing when psycopg2 tries to encode the query
to UTF8), then the `_log` function itself will fail, yielding a very
unhelpful error of:

   dictionary update sequence element #0 has length 1; 2 is required

(because we tried to update a dict using a string).

This issue occurs only during *field conversion* and most fields have
no need to interact with the database (so don't need to encode the
value, which is what fails), however it is a problem when the invalid
string is used as a record name to look for (e.g. an m2o).

Further improve the experience by converting the UnicodeEncodeError to
a ValueError using the stringified UEE: `_log` assumes the first
argument to the exception is an error message of some sort, but for
UnicodeError subclasses it's just the encoding involved in the
error (here `utf-8`), which doesn't really serve as an error message.

Stringifying the exception generates a complete error message which is
quite a bit more helpful.

Issue 2480064

closes odoo/odoo#72398

X-original-commit: a24fe7ff06a03e4a4b477b30ee3feb0ec06a7d0a
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

The tour bubble "animation" that makes it to bounce up and down can cause
issues when its position is at the edge of the bottom of the screen.

In the sale tour, this would make the window constantly resize to show a
scrollbar and then resize to hide the scrollbar, creating quite a sickening
effect visually.

closes odoo/odoo#68391

Task-id: 2480195
Related: odoo/enterprise#17393
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

closes odoo/odoo#66697

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

The company is needed in the context to get the paper format for
instance because of `get_paperformat`

Before this commit, the operations for archived bills of materials are
still displayed in the operations list view. This commit adds a domain
on the action to hide them.

task-2417937

closes odoo/odoo#63433

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

Before this commit: when writing something in signture field in stock.picking
and enable signature field in listview throws traceback.

After this commit: when signature field is set and enabling it in list view
will not throw traceback, traceback was generated because boolean field
was applied on Image field, to fix it simply remove boolean widget on
signature field.

task-2570929

closes odoo/odoo#72276

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Resupplying a product with a purchase order ask to choose the suitable
supplier to put on the purchase order. Another search is perform on top
of that to compute de date to order in order to respect the lead days
promise by the supplier. The issue is that the first search is done with
the orderpoint company into account but not the second one.

This commit passes the company to _select_seller when computing the total
lead days required for an order.

opw : 2557125

closes odoo/odoo#72340

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Issue

  - Install 'addons/website_crm_partner_assign' module
  - Create a partner X without a phone number (edit only name).
  - Save and click on "Opportnuties" stat button
  - Create an opportunity Y and set X as customer
  - Edit it and set "Joekl Willis" as assigned partner
  - Logout then login with portal user (Joel Willis)
  - Go to "My account" page and click on "Opportunities"
  - Select the opportunity Y and edit "Contact"
  - Change phone number then save

  Access error message:
  (not allowed to access 'Contact' (res.partner) records)

Cause

  When editing the opportunity (OPP) phone (or email_from) field,
  if a partner is linked to the OPP and the phone is different,
  we will update also the phone of the partner.
  User portal is not allowed to edit partner.

Solution

  If user has write access on lead, use sudo() to update lead.
  Raise an error if a user want to update a non allowed field
  from portal through the contact lead form.

opw-2530744

closes odoo/odoo#71497

Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

closes odoo/odoo#72350

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Fixes #71691

closes odoo/odoo#71858

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

When a bounce has to be managed on a record already inheriting from blacklist
mixin it shoudl not be counted two times: one for email-based bounce and one
for "all records using that email linked to blacklist mechanism should
bounce".

A mechanism exists to prevent that double increase but it was not correctly
done. Protection was reset in a loop.

Task ID-2547347
PR odoo/odoo#72347

closes odoo/odoo#72371

X-original-commit: odoo/odoo@0fc5f504170f302fffabeeb32e8c321b62c4467d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Since odoo/odoo@f4524f03c32a27b1899562a71cad6f491bfe44ce plus addressing is not used anymore
for handling bounces. Indeed it relies on references / in reply to to find
original message that bounced. It is therefore not necessary to enforce the
use of plus addressing.

As some provider do not support plus addressing as a way to contact left-part
of email with sub-informations people should have a way to deactivate plus
addressing used in bounce aliases.

To preserve backwards compatibility for stable versions old behavior is
retained unless a new `mail.bounce.alias.static` ICP is set with a truthy
value.

Fix https://github.com/odoo/odoo/issues/71242 by dropping requirement of plus addressing.

@Tecnativa TT29827
Closes #71242
Task ID-2547347
PR odoo/odoo#72347

X-Original-Commit: odoo/odoo@6c1fbed523d0b7b83f0d5b3c305f1eb2a7549292

Improve res.patner._compute_on_time_rate performances by calling
mapped('quantity_done') once on all the order_lines.move_ids.

Moving it out of the for loop allows to befinit from the performance
gains of the read_group call in stock.move._quantity_done_compute.

closes odoo/odoo#72068

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

There is a function allowing to close the quick create if we click outside the element.

`RecordQuickCreate._onWindowClicked`

Except that this function is triggered in a "click" event, so if we click on the quick create element and drag the mouse outside, it will detect that we are outside and close the quick create.
This manipulation can happen when you want to select text with the mouse.

This PR prevents this behavior by detecting when a click is from the quick create

opw-2558932

closes odoo/odoo#72259

X-original-commit: 75538bf2a36aa91df8b183ac21ae99a174e1c2fa
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

In 12.0+ when adding an NL VAT number on a contact without specifying the country as Netherlands, an error shows the VAT number as not valid. This is because the method to check specifically NL VAT numbers requires the complete VAT number with country code, when the country code isn't always provided.

With this commit, we allow the check_vat_nl method to take the NL VAT number as argument, with or without the country code.

opw-2536261

closes odoo/odoo#72366

X-original-commit: 75cfe3f484bd56723b182def09141d929a3169a1
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: pvh-odoo <SwagSamaSempai@users.noreply.github.com>

[FIX] account: cash basis taxes: fix the case where an invoice has the same taxes on a negative line

To reproduce:

- Create a cash basis tax
- Make an invoice with two lines, a positive and a negative one (the positive having a higher value), both using this tax
- Post the invoice and register a payment for it

===> It crashes when registering the payment. The SQL constraint ensuring debit/credit consistency fails when creating the cash basis entry.

This is because we were not grouping debit and credit values together on the lines sharing the same taxes; we were summing them separately. The cash basis entry then received line values with both credit and debit set, which is forbidden by the SQL constraint. We now compute the balance first, and set either debit or credit depending on its sign.

closes odoo/odoo#72333

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Steps to reproduce the bug:
- Go to sales app > create two SO with different price lists
- Go to expense app > create a new expense
- Add two expense lines related to the two SO
- Click on the “Submit to Manager” button
- Approve the expense
- Click on “Post journal entries”
- An error is triggered

Problem:
We call the onchange_discount on all SO lines together in the “_sale_create_reinvoice_sale_line function”, while it should be called on each created line separately.

Bug introduced by this commit : https://github.com/odoo/odoo/commit/8815f4d9ab8620428d50abbe603c7f6c63076d6c



opw-2571247

closes odoo/odoo#72349

X-original-commit: fc826640
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>

This update contains a fix about owl error handling.

Release notes: https://github.com/odoo/owl/releases/tag/v1.3.2



closes odoo/odoo#72351

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

When importing a facturx file, the shipping_partner_id on account.move is now processed if it's present in the xml.

closes odoo/odoo#72345

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Scenario:
- Go to Contacts
- Open a contact
- In "Contacts & Addresses" tab, add a child and configure its image
- Once child form is saved, image of the child is not displayed in the
kanban view used for children
It will only appear once the main contact form is saved.
The same issue occurs when editing a child image.
The new image will only be shown once the main contact form is saved.

The issue at the creation is due to the fact the function retrieving
the URL of the image tries to generate the URL from record id, which
is not set.  It should use raw data of image in this case.

For the edition, it is due to the fact that the child form is changing
image_1920 field while the kanban view used for children is displaying
image_128 field.  image_128 is a related field to image_1920, but it
does not appear in the child form.  It is therefore not recomputed (by
onchange) when image_1920 is modified.  Adding it in the child form view
solves the issue.

opw-2516188

closes odoo/odoo#72342

Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

When adding a section or a note on an invoice, default taxes are set on
the account move line, making the corresponding Tax Group to appear on
the invoice.

opw-2541722

closes odoo/odoo#72324

X-original-commit: a8d3f466
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

closes odoo/odoo#72240

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

- Activate anglo saxon accounting
- Have a [DEMO] KIT product in a category using automated
Inventory Valuation with costing method AVCO
- The KIT is composed by C1 and C2 in the same product category
- Define a cost on both C1 and C2
- Open a POS session, order [DEMO], Invoice and complete the order
- Close Session, Validate and display Journal Items

COGS entries will be missing.
This does not occur when making the order without invoicing

opw-2481518
opw-2545758

closes odoo/odoo#71509

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

The frontend enroll message was display as a `<small/>` tag, but it
seems that lxml HTMLParser parse it wrongly, for example:

  html.tostring(html.fromstring('<small data-oe-model="test"><p></p></small>'))

returns:

  '<div><small data-oe-model="test"></small><p></p></div>'

So branding attributes like data-oe-model that are on small tag are not
found on root node that has become a `div` tag after parsing => this causes
a traceback error when saving a change in this part.

Fix: use small as wrapper for `<div/>` tag that is treated correctly by
HTMLParser (span is also treated correctly but div makes more sense
here).

opw-2573955

closes odoo/odoo#72304

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

- Change an image option in mass mailing editor (e.g. Quality)
- save
- edit -> The option can't get the new applied value.

The body_arch's field used in mass mailing editor is
sanitizing attributes and as a consequence, option related data
attrs are removed on save.

task-2327045

closes odoo/odoo#72008

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

In some screen it is very hard to edit the factor.

closes odoo/odoo#66323

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

If a user has no accounting permission, when he opens/closes a POS
session (without any sale), he will not be able to close the session

To reproduce the error:
(Use demo data)
1. Remove all Marc Demo's permissions for the Accounting module
2. Login with Marc Demo
3. Open a POS Session
4. Close the POS Session

Error: "Sorry, you are not allowed to delete documents of type 'Journal
Entries' (account.move) [...]"

Note: if the user processes at least one order during the POS session,
he will be able to close it thanks to sudo mode:
https://github.com/odoo/odoo/blob/369331dfdc144cf852c80c99d00ce8d5da843be1/addons/point_of_sale/models/pos_session.py#L302



OPW-2523187

closes odoo/odoo#72263

X-original-commit: 1e176ba3
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Currently there is an action_assign_serial_show_details button within
the detailed operations form of a serial tracked product move.
Unfortunately there is no way to undo the assigning/creating of move
lines from this action (including via clicking the "Discard" button).
This can lead to a lot of manual work (e.g. 500 SNs produced instead of
50) to remove unwanted move lines. To remedy this, we add in a button
to unlink all of the move's move lines whenever the Assign Serial
Numbers button is visible.

closes odoo/odoo#71820

Task: 2426281
X-original-commit: a6191c43
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When a serial number SN is trying to be consumed and has been unbuilt in the past,
an evaluation is used to check that the # of times SN was unbuilt is equal to
the # of times SN was consumed. However, when counting the unbuild SN it did not take into account if
it was from an unbuild order.

opw:2510294

closes odoo/odoo#71684

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

This commit fixes the case when the reconciliation never ends due to an infinite loop.
This happens when we attempt to reconcile two journal items having differents foreign currencies but an amount_residual = 0.0.
In that case, partials are created everytime with zero amount, zero debit_amount_currency and zero credit_amount_currency.
We don't need to handle such reconciliation because exchange difference journal items are always created using the same foreign currency as the originator line.

The way the reconciliation is made for reversal moves is also edited by this commit to avoid reconciling lines on the same moves but with different currencies.

closes odoo/odoo#71906

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Steps to reproduce the bug:
- Go to Elearning > choose any course or create a new one
- Click on “add content” :
    - Add a title to slide
    - Click on "Go to Website"

Problem:
An error is triggered because we call the "create" method to save the slide, which tries to access the “channel_id”, the course ID in which the slide will be added. However, the field is not set in values.
The "create" or "write" function in "slide_channel" must first be called to save the course, which will then call the create function in "slide_slide"

Solution :
Hide the "Go to website" button as long as the course is not created and therefore has no id

opw-2526541

closes odoo/odoo#72185

X-original-commit: e412ba48
Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>

Before this commit, the number you saw on the stat button was not always
the same as the number of sale order you would see when you clicked on it.
Indeed, there was a domain force on the action to only show confirmed orders,
while the stat button was counting quotations too.

Fixed #70911

closes odoo/odoo#71826

Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

Bug
===

1. Create a new database from the database selector
2. Do not select a country for your company
3. Install CRM
4. Create a new opportunity and select your company
5. The sync "warning" will be displayed, and it should not

The reason for that is the phone of the company is an empty string and the
phone of the lead is False. So we try to sync them and we show the warning
message even if for the user, nothing will happen.

This commit fixes that behavior by correctly checking that False / empty
strings are considered as equel.

TaskID-2499659

closes odoo/odoo#72237

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The printer dialog was not shown when going through the manage order if there
was no printer connected.

In order to fix this issue, the tryReprint doesn't check anymore if a printer is
connected or not. It'll print via printer if connected or show the the printer dialog.

closes odoo/odoo#72215

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

When computing the foreign key name,
`check_foreign_keys` didn't take into account the limit of 63 characters
for constraint names.

Because of this, some constraints were dropped and recreated
over and over while they were correct, during install and upgrades.

For instance, when installing `base`
when adding the foreign key for which the name was computed
`base_partner_merge_automatic_wizard_res_partner_rel_base_partner_merge_automatic_wizard_id_fkey`
Postgresql created the constraint under the name
`base_partner_merge_automatic__base_partner_merge_automatic_fkey`
and therefore, as the name did not match,
the constraint was dropped and re-created.

closes odoo/odoo#71658

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

closes odoo/odoo#72176

X-original-commit: 76584fda
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Before this commit, fields in calendar popover were added
to the $fieldsList after they were appended but appending
is async and so fields could be disordered.

Now, we add fields before the append to have the right order.

closes odoo/odoo#72098

X-original-commit: 312affaf
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

closes odoo/odoo#71844

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>