Skip to content
Snippets Groups Projects
  1. Oct 17, 2019
  2. Oct 16, 2019
    • Debauche Stéphane's avatar
      [IMP] web: many2many_binary, binary, image, add the option ``accepted_file_extensions`` · e981e331
      Debauche Stéphane authored
      
      Purpose
      =======
      We want to add an option on the widgets
      - many2many_binary,
      - binary,
      - image
      
      This option specifies what file extensions the user can pick from the file input dialog box.
      
      Examples
      ========
      ```xml
      <field widget="many2many_binary" options="{'accepted_file_extensions': 'image/*'}"/>
      <field widget="many2many_binary" options="{'accepted_file_extensions': '.png,.jpeg'}"/>
      <field widget="many2many_binary" options="{'accepted_file_extensions': 'application/pdf'}"/>
      <field widget="image" options="{'accepted_file_extensions': '.png,.jpeg'}"/>
      <field widget="binary" options="{'accepted_file_extensions': '.pdf,.svg'}"/>
      ```
      
      How
      ===
      Add an option (accepted_file_extensions) in the template ``HiddenInputFile`` (the widget many2many_binary is using this template)
      So, we can also use this new option in others widgets using ``HiddenInputFile``
      In the many2many_binary, read the ``nodeOptions`` and set the widget attribute ``accepted_file_extensions``
      
      We also have to fix some other widget, because an property ``image_only`` was already existing in the template ``HiddenInputFile``
      (we just need to replace ``image_only=True`` to ``accepted_file_extensions='image/*'``
      
      The widget ``FieldPdfViewer`` (pdf_viewer) now use the new option to filtrate PDF
      (instead of removing the <input/> and adding <input accept='.pdf'/>).
      
      Tests
      =====
      We also test if the option is correctly set on the <input/>
      - binary
      - image
      - many2many_binary
      
      Impacted widgets
      ===============
      - many2many_binary
      - image: this widget use ``options="{accepted_file_extensions='image/*'}"`` instead of ``image_only=True``
      - tablet_image: same as ``image``
      
      Task #2082815
      
      closes odoo/odoo#38351
      
      Signed-off-by: default avatarVincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
      e981e331
  3. Oct 17, 2019
  4. Oct 16, 2019
  5. Oct 17, 2019
    • Odoo's Mergebot's avatar
      [FW][FIX] web: Correctly aggregate values in exported parent groups · 75759d31
      Odoo's Mergebot authored
      
      [FIX] web: Correctly aggregate values in exported parent groups
      --------------------
      When exporting a grouped list view with some nested groups, the aggregate value
      of parent groups are not correct. It always sums aggregated values of children
      whether the group operator is 'sum' or not (could be 'max', 'avg', ...).
      
      This behavior is wrong and can even lead to a crash if the aggregated field is a
      date field (e.g. with group_operator='max'). (Try two sum two dates...)
      
      To avoid the crash a quick fix was merged 85cf47fc just before OXP. This fix
      limited the support of aggregates to only int and float fields.
      This commit remove this limitation.
      
      This commit correctly implements the aggregation for parent group for all
      field types and all group_operator.
      
      This commit also improves the export feature tests.
      
      [FIX] base export: Manage False in groupby title
      --------------------
      Before this commit, when we export a list with a groupby on
      boolean, the groupby title 'False' is replaced by 'Undefined'
      in xls document.
      
      After this commit, with an export and groupby on a boolean, we
      will have correct title: True and False.
      
      --
      I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
      
      closes odoo/odoo#38896
      
      Forward-port-of: odoo/odoo#38373
      Signed-off-by: default avatarlul-odoo <LucasLefevre@users.noreply.github.com>
      75759d31
  6. Oct 16, 2019
  7. Oct 10, 2019
    • ryv-odoo's avatar
      [REM] website_links: remove favicon, icon_src for performance · e0ba61d9
      ryv-odoo authored
      
      The link tracker model (link.tracker) contained favicon (store)
      and icon_src computed fields. Computing favicon took
      {3-6.5%} of installing odoo (with demo data) due to syncronous http
      call to a external link (google).
      Moreover, these fields had no sense to be store in odoo
      and only used in one template. This template was modified to
      display the same information (icon) as before but without storing fields
      and with a lazy loading of icons.
      
      TASK_ID: 2083715
      
      closes odoo/odoo#38405
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      e0ba61d9
  8. Oct 16, 2019
    • fw-bot's avatar
      [FIX] base: Allow default email_from by database · 8c2f6b00
      fw-bot authored
      
      It is possible to get to a situation where Odoo would try to send an email without a `From:` header address.
      
      In such case, you're unlucky if you don't have access to the underlying deployment, or if you use multiple databases in a single Odoo instance and each of them uses a different mail configuration.
      
      To make this configuration easier to use and cover those use cases, here I add support for a new ICP: `mail.default.from`. It will be used when present, so it shouldn't affect existing deployments. When present, it will allow a admin to configure the default sending address just with Odoo itself.
      
      closes odoo/odoo#38874
      
      X-original-commit: 5010ce63
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      8c2f6b00
    • Lucas Lefèvre's avatar
      [FIX] hr_org_chart: Position subordinate popover with rtl lang · f33e7b85
      Lucas Lefèvre authored
      
      With a Right to Left lang.
      Go to an employee form view.
      Click on the small pill with the number of subordinates (in the org chart).
      The popover opens but on the right side of the window instead of next to the
      pill.
      
      Fixes #38722
      
      closes odoo/odoo#38873
      
      X-original-commit: 292d4e7b
      Signed-off-by: default avatarlul-odoo <LucasLefevre@users.noreply.github.com>
      f33e7b85
    • jbm-odoo's avatar
      [FIX] hr: Fix consitency in employee form · 83ab0073
      jbm-odoo authored
      
      Before this commit:
      Private email and phone are related of partner 'address' fields.
      But the phone was read-only and the email is editable.
      
      After this commit:
      As phone and mail are related, they are read-only. We must edit
      them on the partner of Address field.
      
      close #38518
      
      closes odoo/odoo#38872
      
      X-original-commit: ed6fb25c
      Signed-off-by: default avatarjbm-odoo <jbm-odoo@users.noreply.github.com>
      83ab0073
    • jbm-odoo's avatar
      [FIX] web: Kanban height with few element and searchpanel · c0bbd2fc
      jbm-odoo authored
      
      Before this commit:
      When there few elements in kanban and a search panel, all kanban
      cards try to take a maximum of height and become deformed.
      
      After this commit:
      The behaviour of dimensions of kanban cards must be the same with
      or without searchpanel.
      
      closes #38556
      
      closes odoo/odoo#38871
      
      X-original-commit: a95cbbd6
      Signed-off-by: default avatarjbm-odoo <jbm-odoo@users.noreply.github.com>
      c0bbd2fc
    • wan's avatar
      [FIX] account: badly formatted reconciliation proposition · e00532ff
      wan authored
      When a reconciliation proposition's amount is computed from a regex, we
      cannnot be sure the regex captured something. If it didn't we don't want
      to display a badly formatted line so we set the amount to 0.
      
      closes odoo/odoo#38870
      
      X-original-commit: 11149579
      Signed-off-by: default avatarCedric Snauwaert (csn) <csn@openerp.com>
      e00532ff
    • fw-bot's avatar
      [FIX] l1n_pe: forward-port of fixes to l10n_pe · eaa09428
      fw-bot authored
      
      base_vat: Correct management of the check of peruvian VAT without prefix.
      l10n_pe: Correct income account the last one is not correct.
      l10n_pe: Forced Round globally for peruvian companies once l10n_pe is
      installed, and with the onchange.
      l10n_pe: For peruvian companies it does not make sense a sequence per
      year and the year in the prefix is incorrect, we must force XXX- as
      a sequence prefix.
      
      closes odoo/odoo#38854
      
      Forward-port-of: #38764
      Signed-off-by: default avatarJosse Colpaert <jco@openerp.com>
      eaa09428
    • Arnold Moyaux's avatar
      [FIX] mrp_subcontracting: records components on existing line · cddf577a
      Arnold Moyaux authored
      
      In a barcode environemtn or a situation with a lot of stock.move.line
      the subcontract is hard to use with record components because a line is
      created each time the produce wizard is proccessed. Then each line is
      duplicate, one with reservation and the other with effective transfer.
      
      This commit try to merge them in order to limit the number of lines.
      
      Task 2073383
      
      closes odoo/odoo#38689
      
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      cddf577a
    • Arnold Moyaux's avatar
      [FIX] mrp_subcontracting: show lot name · b5ecbd5b
      Arnold Moyaux authored
      Usecase:
      - Set details operations on picking type
      - Create a receipt for a subcontracted product with tracked components
      - Records production
      - Go to details operations
      
      The move line is created however the lot name is invisible.
      It happens due to produce_wizard line creation. It will set the lot_id
      but the field lot_id is invisible if the picking type use the option
      'use_create_lot' and uncheck 'use_exisiting_lot'
      
      In order to fix it set both lot_name and lot_id after the produce
      operation.
      b5ecbd5b
    • Arnold Moyaux's avatar
      [FIX] mrp_subcontracting: correct type for view registry · ec5e63cf
      Arnold Moyaux authored
      When the action is called by a javascript function the view
      is not correctly rendered because the tree type does not exist
      in the registry but the correct type is list.
      ec5e63cf
  9. Oct 11, 2019
    • ryv-odoo's avatar
      [FIX] base, mail: fix multipart alternative order · c8cbf8cc
      ryv-odoo authored
      After the refactor of mail sending with the newest python API
      (18299d7e),
      the order of multipart/alternative was wrong for email.
      Indeed, in the MIME protocol [1], for The Multipart/alternative subtype
      the order is significant: "In general, user agents that compose
      multipart/alternative entities should place the body parts in increasing
      order of preference, that is, with the preferred format last".
      
      This bug caused some issues with mail marketing (see related task)
      with Gmail web client (see the plaintext instead of html mail).
      
      The fix is to inverse the order of adding alternative in the mail
      content.
      
      [1] https://www.w3.org/Protocols/rfc1341/7_2_Multipart.html
      
      
      
      TASK_ID : 2084989
      
      closes odoo/odoo#38490
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      c8cbf8cc
  10. Oct 16, 2019
Loading