Skip to content
Snippets Groups Projects
  1. Jun 12, 2018
    • Andrea Stirpe's avatar
      [FIX] l10n_nl: use tax tag 5b · 375bff66
      Andrea Stirpe authored
      There was a difference in the tax codes Import Buiten EU (2), some had the tag
      '5B Voorbelasting' and other had the tag 'Voorbelasting BTW Bis'.
      
      Link all the codes to '5B Voorbelasting' instead.
      This is more consistent with the rest.
      
      Closes #23119
      375bff66
    • Nicolas Lempereur's avatar
      [FIX] base: depends if no depends is () · e60a8762
      Nicolas Lempereur authored
      
      With saas-11.2's 3fbd86bc some trigger towards other fields are improved
      but this caused an issue when a inherited field towards a custom
      computed field had no depends.
      
      When we created a computed field x_custo on res.partner, we have a
      inherited x_custo on res.users automatically created.
      
      Both these fields have a depends computed to `('',)`, this caused an
      error for the one on res.partner: but this was ignored with dd048ae7.
      
      Since saas-11.2's 3fbd86bc this also caused an error on the inherited
      field but since an inherited field is not "manual" the error was not
      ignored. Thus it was not possible to create custom field on a model
      inheriting of another model if the fields had no depends.
      
      opw-1854786
      closes #25146
      
      Co-authored-by: default avatarRaphael Collet <rco@odoo.com>
      e60a8762
    • rgarnau's avatar
      Update Eficent's CLA · fe15b7a1
      rgarnau authored
      fe15b7a1
    • rgarnau's avatar
      [FIX] stock: scrapping consumable products allowing negative quantities · 46129e75
      rgarnau authored
      As for consumables stock levels are not that important,
      it should be ok to scrap a consumable at all times,
      even if the stock becomes negative.
      
      Tests were added to check what happens with a consumable/stockable
      product if stays positive/goes negative.
      46129e75
    • Tony Gu's avatar
      [CLA] add signed cla Shine IT · 50ee8131
      Tony Gu authored
      50ee8131
    • Tony Gu's avatar
      [FIX] mrp: Unrelated product_template and product_product on the same BOM · 45a179d9
      Tony Gu authored
      Before this fix, we can create a Bom with both product_id and
      product_tmpl_id filled where the product_id is not a variant of the
      product_tmpl_id. This is unlogical and will be even trickier when the
      user is not able to see the variant field on the BOM.
      
      This fix puts the product_id back to False when the product_tmpl_id
      is changed.
      45a179d9
  2. Jun 11, 2018
  3. Jun 10, 2018
  4. Jun 08, 2018
    • Christophe Monniez's avatar
      [FIX] packaging: add BeautifulSoup to py2exe setup · 2da4eb58
      Christophe Monniez authored
      When trying to import an OFX bank statetement under MS Windows, a
      Traceback states that BeautifulSoup is missing.
      
      During the build process, py2exe didn't autodiscover that BeautifulSoup
      is needed by the ofxparse package.
      With this commit, BeautifulSoup is explicitely added to py2exe packages.
      The Nightly VM was updated accordingly.
      
      opw-1848202
      Unverified
      2da4eb58
    • len-odoo's avatar
      [FIX] mrp: help message to disambiguate meaning of duration value · 867bbff5
      len-odoo authored
      The duration field on a workorder computes the total time spent on it.
      The mrp_time_counter widget that is used to display it only computes the total
      time spent on it by the currently logged user (ignoring the field stored value).
      To help the user understand the inconsistency between the two values, we add a
      help tooltip.
      Since this really depends on the widget used to display the value, the tooltip
      is directly put in the view.
      
      opw 1854802
      867bbff5
    • Pedro M. Baeza's avatar
      [FIX] base: Allow to create a contact without type · 64645457
      Pedro M. Baeza authored
      If you don't define an explicit address type, then the
      record is not going to be accessible.
      
      In the ORM:
      >>> env['res.partner'].create({'name': 'Test', 'type': False})
      res.partner(44356,)
      >>> env['res.partner'].search([('type', '!=', 'private'), ('id', '=', 44356)])
      res.partner()
      >>> env['res.partner'].search([('type', '=', False), ('id', '=', 44356)])
      res.partner(44356,)
      
      due to the fact that NULL in the database is undefined and can't be
      compared to a specific key.
      64645457
    • Lucas Perais (lpe)'s avatar
      [FIX] account: in account config, constrain exchange diff journal's domain · f01e298d
      Lucas Perais (lpe) authored
      Before this commit one could choose any journal for the registering exchange rate differences.
      That could lead to accounting errors down the line
      
      After this commit, we apply a domain on the field, and there is no problem afterwards
      
      OPW 1851616
      closes #25101
      f01e298d
  5. Jun 07, 2018
  6. Jun 06, 2018
    • Martin Trigaux's avatar
      [FIX] portal: use expected ID format · 0780f10c
      Martin Trigaux authored
      Introduced during forward port at 6a7db305
      _company_default_get returns a res.company record, not an ID
      
      opw-1855856
      Unverified
      0780f10c
    • Toufik Benjaa's avatar
      [FIX] crm: Access rights issues in contact merging · 4f2442c4
      Toufik Benjaa authored
      - When merging partners with fields restricted to certain groups which the user doesn't belong, an access error is raised.
        To avoid this, we only merge fields that are accessible by the user. We do so by using the method fields_get() that only returns the fields accessible by the current user.
      4f2442c4
    • Oliver Laurent's avatar
      [FIX] base: timeout on smtp connections · a52c545d
      Oliver Laurent authored
      Currently when connecting to a smtp server, if no response is returned
      and no error is raised, the `SMTP()` instantiation method never ends.
      
      This PR is inspired by 54a477d7 related to `fetchmail()`.
      Possibly, a better way exists but it has to change some methods
      signatures.
      
      Closes #24877
      opw-1851030
      a52c545d
    • Damien Bouvy's avatar
      [FIX] pos: reconciliation and performance issues (#24610) · e2efec8e
      Damien Bouvy authored
      Before this commit, the complete list of orders of the pos session
      was processed through the reconciliation mechanism to check if an
      automatic reconciliation was possible (introduced in a controversial
      'bug fix' at fe70f071, itself a backport of a master commit at
      a2319b43). The goal of this auto-reconciliation was to avoid potentially
      silent and numerous customer statements that could be reconciled
      automatically.
      
      This is mostly useless in a lot of cases, since a lot of users do not
      set any partner_id value on the pos order - there is nothing useful to
      reconcile. Going through the whole list of orders is time-wasting
      (especially since the reconciliation method does not scale well).
      
      Combine this with users who do not close their POS session often enough
      and closing a session can suddenly take up to several hours to process
      instead of several seconds with practically no obvious gain.
      
      After this commit, only orders which have a partner set on them will be
      auto-reconciled.
      
      opw-1818838 and opw-1817172
      e2efec8e
    • Adrian Torres's avatar
      [FIX] orm: re-create constraints of extended fields · ea23a1ac
      Adrian Torres authored
      Before this commit:
      
      * Module A defines a field X of model M
      * Module B inherits from model M without touching field X
      * Module C inherits from model M and extends field X by giving an INDEX
      / NOT NULL constraint.
      * Module B and C depend from Module A, but not each other
      
      If all three modules are installed and Module B is updated, the INDEX /
      NOT NULL constraint could be dropped.
      
      This happens because Module B can be loaded before Module C is loaded,
      if that's the case, then after the upgrade of Module B, during the
      schema checking, we verify that the field object we have and the field
      on the DB are the same, since Module B doesn't introduce the index then
      this check is false and we drop the index. When we get to loading Module
      C, we do not do any schema checking because the module is not marked as
      `to upgrade`, therefore the index is lost forever.
      
      To solve this, we re-init the models that belong to the set of the intersection
      between upgraded and modified models and loaded and modified models.
      
      Fixes #24958
      Unverified
      ea23a1ac
    • Goffin Simon's avatar
      [FIX] account: Currency rate conversion issue in vendor bill · 367fadc8
      Goffin Simon authored
      Steps to reproduce:
      
      - Enable multi currencies
      - Make sure that the current rate of a foreign currency (i.e. $) is not 1.0 (i.e. 0.5)
      - Create a purchasable product with a cost (i.e. 100€)
      - Create a vendor bill in a foreign currency (i.e. $)
      - Add the product on the invoice
      
      Bug:
      The unit price was equal to 25$ instead of 50$
      
      Technical reason:
      
      The function "_onchange_product_id" was called twice (the second time by function
      "_onchange_uom_id") and the price unit was converted twice in the currency of the vendor bill.
      The idea of this fix is to only convert in the currency when the unit price is set
      by the system.
      
      Fixes #24751
      opw:1849212
      367fadc8
Loading