This commit aims to allow assigning tags to the taxes
created by the OSS feature by providing the xml_id of their
report.line in the eu_tag_map.py file.

Before this commit:
In l10n_be, the taxes created by OSS (l10n_eu_services) didn't set
the tag +47 on invoice_repartition_lines nor +49 on
refund_repartition_lines.
This make the VAT report for Belgium wrong.

After this commit:
Taxes created by OSS for a company using the belgian CoA will get
their tags set properly and thus will the taxes impact the
belgian tax report correctly.

task: 2770182
ticket: 2768622

Community-PR: https://github.com/odoo/odoo/pull/85607



Design choices:
This fix is currently solving the issue for l10n_be but we have
no doubt that it will be raised for other EU countries too.

In order to provide the tags, we decided to be consistent with
what as been done regarding the tax mapping. Thus we decided to
create and maintain a simple mapping file and to test it.

several other methods were explored:
- create a global variable and update it from all localization
modules. This method would work but is ugly and error prone.

- create a templating method and override it from localization
modules.
The problem is where to set the root of the template method?
The naïve solution would be to create a bridge module between
l10n_eu_services and l10n_be but that would lead to an explosion
in the number of bridge modules which we don't want.

In order to keep things simple and generic, we could put the
template method directly into the account module. But it is kind
of ugly because account shouldn't know anything about the oss
feature and it would encourage such a leaky design to happen
again in the future.

closes odoo/odoo#85607

Signed-off-by: William André (wan) <wan@odoo.com>

Improves l10n_eu_services code readability

Part-of: odoo/odoo#85607

The issue is simply creating a related stored many2many field, which is
pretty easy to do with Studio.  When creating the field, Odoo crashes
with a traceback caused by ondelete being None on the field.

The source of the bug is the fact that the attribute field.ondelete is
set to a sensible default ('cascade') on non-related fields only.  The
fix consists in setting the default value on the attribute itself, so
that the setup of the field never falls on a case where field.ondelete
is unset.

closes odoo/odoo#86136

Signed-off-by: Raphael Collet <rco@odoo.com>

The smartbutton for the number of hours in the attendance smart button
on employees and user did not use the right widget and could display
invalid data like '1.8 hours last month'.

TaskId-

closes odoo/odoo#86032

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

If applied, this PR will enable button_access for all users and portal_customers, letting them
access the documents directly. The button "View Journal Entries" will appear on the notification
email, and by clicking this the user will be directed to the portal page of the invoice/refund.
All users and portal_customers subscribed to the thread should be able to see this button.

A following refactor by TDE (#82167) has addressed this problem in master (for 15.2).
For stable versions, in this PR, we agreed to keep changes limited to the accounting scope.

Ticket link: https://www.odoo.com/web#id=2645653&model=project.task



opw-2645653

closes odoo/odoo#82580

Signed-off-by: William André (wan) <wan@odoo.com>

Current behavior :
SIPS urls aren't available anymore and lead to a 410 error page

Reason :
URLs have been updated and should be replaced
i.e. previous URL : https://payment-webinit.simu.sips-atos.com/paymentInit
should be replaced by https://payment-webinit.simu.sips-services.com/paymentInit
according to SIPS docs [1]

[1] : https://documentation.sips.worldline.com/en/WLSIPS.317-UG-Sips-Paypage-POST.html#Step-3-Doing-tests-in-the-simulation-environment_



OPW-2780969

closes odoo/odoo#86090

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

With this commit, the qemu/kvm VM is using the virtio drivers for
network and drive. This drastically improves performances and avoid
timeout on build system.

Also, the NIC mac address is fixed in order to not confuse the windows
system.

The CPU model was deprecated so it's changed to a more recent one and
its topology is simplified.

Finally, 1024 MiB of memory seemed a bit short for windows.

closes odoo/odoo#86097

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

* fix traceback when vat is not defined, return directly 0.
* remove api.model
* add ensure_one() to avoid misuse of the method

closes #84760

closes odoo/odoo#86072

Related: odoo/enterprise#23977
Related: odoo/enterprise#25116
X-original-commit: 5cd4df74
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>

It's currently confusing: the default value is already 'groups', but the create
method is actually giving another default.

task-2749643

closes odoo/odoo#85860

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Every tax should have a tax repartition line.

closes odoo/odoo#86006

Signed-off-by: Laurent Smet <las@odoo.com>

Before commit, if the 'Receipt' Operation type was archived, the purchase agreements would still use it.
After commit, if stock.picking_type_in record is archived, search for another (non-archived) one.

OPW-2748495

closes odoo/odoo#85474

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Every tax should have a tax repartition line even 0% tax

closes odoo/odoo#85888

Signed-off-by: Laurent Smet <las@odoo.com>

Messages are copied when duplicating a channel

Steps to reproduce:
1. Install Discuss
2. Write a message in the general channel in Discuss
3. Duplicate the general channel (user demo should be a member of this
channel) and give it another name
4. Connect as demo
5. The new message notification is on the general channel (and it should
be the duplicate channel
6. Mark the notification as read
7. Refresh the page
8. The notification is still there even though it has been marked as
read

Solution:
Do not copy the message of the original channel

Problem:
`channel_message_ids` is copied when duplicating a channel

opw-2731842

closes odoo/odoo#85385

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Purpose
=======

On product list we can see that kits are listed with quantity on hand
equals to the lesser quantity of the kit's components.

When applying the filter **Quantity on hand greater than 0**, the kit
disappears from the list.

The issue is that we compute product quantity from stock.quant, for kits
we don't create a quant beacause it's not a physical product.

Specification
=============
To solve the issue, we extend the method **_search_qty_available_new** from
**stock.product** in **mrp.product**, where we fetch all kits and add the id
of the products that verify the given condition.

opw-2717594

closes odoo/odoo#84699

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:
===================
- Create a Sales tax
- Archive it
- Go to Sales and create a SO
The archived tax is available for SO line

Cause:
======
Context {'active_test: False'} is defined on tax_id field of SO line
to still display archived taxes on existing SO.
This context is passed to the field in the form view by default, allowing
archived taxes to be selected in SO creation/edition.

opw-2769057

closes odoo/odoo#85807

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

closes odoo/odoo#83629

Signed-off-by: Arnold Moyaux <arm@odoo.com>
Co-authored-by: Andreas Perhab <andreas.perhab@wt-io-it.at>

The aim of this commit is to correct the compute_all calculation
when it is dealing with an article with 0.00 price and having a fixed
tax included in it.

In this situation, this means the tax is directly taken as an expense
by the company that offers it to its client.

This also solves the situation in which we have a 100% discount because
discount is applied before calling `compute_all` by changing the
unit_price.

Before this commit:
Creating an invoice with a line having a price at 0 or a 100% discount
and a fixed tax price_include resulted in a really weird behavior: the
company had to reimburse the customer for the amount of the tax.
(what a lucky customer :D )

After this commit:
Customer is sad, he only gets the product for free.
The base is calculated as negative, resulting in a debit amount on the base
income line.
The tax is then counterbalance by it.

The form is displaying a negative untaxed amount, a positive tax and the
total is 0.

closes odoo/odoo#85747

Ticket: 2660808, 2637512
Community-pr: https://github.com/odoo/odoo/pull/85747


Signed-off-by: Laurent Smet <las@odoo.com>

Create a 21% tax included in price
Create a 6% tax included in price
Create a fiscal position that will replace the 21% tax included by the
6% tax included
Create a customer and assign this fiscal position
Create a product :
Price = 121€
Tax = 21% tax included
Create a SO with this customer and this product
Create an invoice (from scratch) with this customer and this product

SO : the unit price is 100,00€
Invoice : the unit price is 106,00€

Fix by creating a common method to calculate the price_unit

opw-2699793

closes odoo/odoo#83728

Signed-off-by: Laurent Smet <las@odoo.com>

Problem :
* updating an invoice line on mobile would result in an incorrect untaxed amount, tax amount and total amount on the invoice and an incorrect entries in the journal items
* subtotal of invoice line was not showing in mobile view

Solution :
* the problem was that debit and credit fields were missing from the view so onchange were not trigger

closes odoo/odoo#84982

Task: task-2766245
Signed-off-by: Ruben Gomes <rugo@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>

collections.Set was deprecated since 3.6 and removed at 3.10
https://github.com/python/cpython/blob/3.9/Lib/collections/__init__.py#L62-L65



closes odoo/odoo#85325

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

THe price shown on the order line was not taking into account the
quantities ordered.

closes odoo/odoo#85836

Taskid: 2678064
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Add a check to ensure that the repartition lines have at least one tax line.

Reason: the compute_all fonction skips the taxes with no tax lines
because it only loops over the tax repartition lines to fill taxes_vals

closes odoo/odoo#85771

Signed-off-by: Laurent Smet <las@odoo.com>

* Studio generate computed field "count" when the user add a button
in the button box. Since those lines are written by studio with drag and drop
it should not be counted for the maintenance subscription.

We can detect them because field created by the user in studio start with x_studio
and fields created outside studio does not have studio_customization
xml_id

* Add test to make no standard module introduce customization in the
database during the install the will be counted by cloc

see https://github.com/odoo/enterprise/pull/22664



closes odoo/odoo#80594

Signed-off-by: Christophe Simonis <chs@odoo.com>

If an installed module is only present in the dependency graph through a new,
uninstalled dependency, it was not be selected for upgrade when updating the
`base` module (c.q. `--update all`)

closes odoo/odoo#85516

Signed-off-by: Raphael Collet <rco@odoo.com>
Co-authored-by: Raphael Collet <rco@odoo.com>

When users have same groups, implied_ids can be done in batches,
reducing write operations considerably.

Testing done:

800 users groups_id (all have same groups_id in the end) updated using
old code: took ~10s to complete.

With this improvement, it takes ~1.5s

closes odoo/odoo#84268

Signed-off-by: Raphael Collet <rco@odoo.com>

As of now, the discount field is either only shown in
debug mode or if the sale module is installed and a
setting is set in sale.
This field should be shown in the view, and not depend
on a setting from another app.
This is especially true as it could be filled by the ocr
or when uploading from an edi, and it would be inconsistent
if the user couldn't display it.

Task id #2758965

closes odoo/odoo#84186

Signed-off-by: Josse Colpaert <jco@odoo.com>

Step to reproduce:
- Render negative duration with the duration widget

Example V15:
- Create timesheet entry with negative duration (e.g. -00:30)
- Print the timesheet entry

Current Behaviour:
- Time is rendered as Time-1h (in e.g. -01:30)

Behaviour after PR:
- Time is correctly rendered (in e.g. -00:30)

opw-2731186

closes odoo/odoo#84621

Signed-off-by: Damhaut Florian (flda) <flda@odoo.com>

To generate an e-faktur

1. Settings > Users & Companies/Compagnies:
- Create a new company ‘ID Indonesia’:
- Set the state (e.g Yogyakarta (ID))
- Set the country ‘Indonesia’

Accounting:
2. > Customers > e-Faktur
- Set a range of numbers (which are supposed to be assigned by the
Indonesian government);

3. > Configuration > Settings
- Fiscal Localization: select the Indonesian package

4. > Customers > Customers
- Create a new res.partner:
- Set the country ‘Indonesia’
- Check ‘ID PKP’ field
- Under ‘Accounting tab’: set both accounting entries (Receivable +
Payable)

5. > Customers > Invoices
- Create a random invoice with the res.partner set in point 5. as the
Customer
- Confirm the invoice
- Action > Download e-Faktur

---

When validating the e-faktur users will see the error

Import Faktur Error ETAX-30005 : Error Objek Mapping

This occur because E-Faktur standard update from 3.0 to 3.1
A column 'KODE_DOKUMEN_PENDUKUNG' is now mandatory

opw-2753810

closes odoo/odoo#85312

Signed-off-by: Josse Colpaert <jco@odoo.com>

reserving a chained stock move will compare quantity validated by move
origs and quantity validated by sibling moves. If this number is
negative (i.e the move orig has been updated before reservation). This
can throw an error like "you cannot unreserve more...."

This commit ensure the reservable quantity is always >= 0.

closes odoo/odoo#85528

Opw: 2716369
Signed-off-by: Arnold Moyaux <arm@odoo.com>

Just before deleting records, we mark fields on dependent records as "to
compute", and their actual computation should happen after the records
have been deleted.  The problem is that checking security rules may
trigger the computations that have been prepared.  So we should check
security rules before marking dependent records.

closes odoo/odoo#85522

Signed-off-by: Raphael Collet <rco@odoo.com>

Quite some localizations add some fields in the reversal and debit note
wizard and we need a way to easily hide them when the field is not for
the current country.

closes odoo/odoo#83752

Task-id: 2751825
Related: odoo/enterprise#23891
Signed-off-by: William André (wan) <wan@odoo.com>

When unpacking a package, the quants are not merged

To reproduce the issue:
1. In Settings, enable "Delivery Packages"
2. Create a storable product P
3. Update its quantity: 5
4. Create a planned receipt R with 10 x P
5. Mark R as Todo
6. Put the 10 x P in pack (PK)
7. Validate R
8. Unpack PK
9. Consult the on-hand quantity of P

Error: There are two lines (one with 5 x P and another one with 10 x P).
Both lines should be merged

Backport of 5e08aa3d

OPW-2713407

closes odoo/odoo#85426

Signed-off-by: Arnold Moyaux <arm@odoo.com>
Co-authored-by: Adrien Widart <awt@odoo.com>
Co-authored-by: Florent de Labarre <florent.mirieu@gmail.com>

Steps to reproduce:

  - Install website_appointment module
  - Change website theme and select : Cobalt Theme
  - Go to website
  - In menu, click on Appointment
  - Select anyone, select any date and confirm appointment

Issue:

  Title text on each other.

Cause:

  The custom page_header class (in portal module) override the default
  line-height with 2.1 rem (instead of 1.1).
  In some themes, the headings tags font-size has been changed with
  3.875rem (instead of 2.5rem).
  => font-size is too big regarding the line-height

Solution:

  Remove line-height rule.

ref. commit: https://github.com/odoo/odoo/commit/86ab1c55b4229afb74f630b5041a8354c705f849



opw-2745485

closes odoo/odoo#85347

Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

Steps to reproduce the bug:
Go to a work order that is ready or waiting,  try manually changing the scheduled start or end date > save

Problem:
Traceback is triggered because when we modify the date, we check if the start date is before the end date. But we cannot compare a False with a date

opw-2768054

closes odoo/odoo#85387

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

revert commit https://github.com/odoo/odoo/commit/5f25be8eef9a9efc18a995f2c6405d08a657ac96

Goal:
- Gives the expected tag to the account move line created by the PoS.
- Add tests to the PoS regarding the created account move line

Before this commit:
If the configuration was set to round_globally, a pos.order.line was processed
as a refund only if all order.lines were a refund.
This leads to unexpected results in the tax report. Indeed,
since commit https://github.com/odoo/enterprise/commit/46769076526701d96ee4f2653e44b57604cc0b7a
"Negative" line in PoS (debit) are processed as positive to give a
correct results.
This means that if a line is set as debit and is suppose to lower a
line, it makes it bigger.

Example:
aml from PoS: debit: 10 tags: +03
---> report.line [03] is suppose to make a -10 but will do a +10.
As a result, report line [03] is false.

After this commit:
PoS never use "invoice_repartition_line" to create a refund line.

closes odoo/odoo#85149

Ticket: 2718998, 2714310, 2746890
Community-pr: https://github.com/odoo/odoo/pull/85149


Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

In reality the separator is a comma instead of a dot as can be seen
in the code a bit further below.

closes odoo/odoo#85342

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

closes odoo/odoo#84470

Signed-off-by: Josse Colpaert <jco@odoo.com>

We have a bug when we were computing the invoice rate that is used to
report to AFIP. The rate we were setting was an old rate that references
the day that the invoice was created and not the rate of the day where
the invoice was validated.  This was happening because the
l10n_ar_currency_rate field that stores this value was computed before
posting the invoice. At that time the date field store the value of the
date where the invoice was created and had not been updated yet with the
accounting date.

Moving the l10n_ar_currency_rate field calculation after the invoice
post solves the problem and now the l10n_ar_currency_rate has the rate
of the accounting date.

Part-of: odoo/odoo#84470

If partner is copied, it will copy customer_rank/supplier_rank and it
will be treated as such even though such partner has no references to
invoices for example.

Backport of https://github.com/odoo/odoo/commit/c0161736db4f2415e6a44674d872bf8aa2972287



closes odoo/odoo#85171

Signed-off-by: William André (wan) <wan@odoo.com>