There was inconsistency in the translation for the words "price unit", with this
 commit all the "price unit" are translated the same.

closes odoo/odoo#132890

Task-id: 3262408
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

This PR solve two things:
- Preview: due to the hardcoded width the preview didn't take all the page and
was push on the left.
- PDF: Weird stuff happened with the header, he was hiding information below
 the header.

Task-id: 3262408
Part-of: odoo/odoo#132890

Before this PR, when there is no shipping address, the pdf show an empty
"Shipping Address" header. By changing the colspan dynamically we can manage to
keep the layout like it was and remove the useless section.

Task-id: 3262408
Part-of: odoo/odoo#132890

When the user tries to import the invoice file with space on both sides
of the date value the error will be generated.

Steps to reproduce:
1. Install the `account_edi_ubl_cii` module.
2. Generate one `factur-x.xml` file or import this file
https://drive.google.com/file/d/1RCqLT37j2g6LPkauf75LpOzZt64XHd_L/view?usp=drive_link
3. Go to the invoice app and click the `upload` button.
4. Select the `factur-x.xml` file and an error will be generated at the backend
and nothing to be imported.

This commit fixes the issue by removing the extra spaces in the date value,
if user gives the spaces in the invoice file.

see-
https://github.com/odoo/odoo/blob/a0ea6302a574624604cad7d0903711b30a4802a6/addons/account_edi_ubl_cii/models/account_edi_xml_cii_facturx.py#L315



sentry-4331059603

closes odoo/odoo#132611

X-original-commit: 1f32b5ec
Signed-off-by: Laurent Smet (las) <las@odoo.com>

Currently, the user has access to a "Switch into credit note/refund" but
not the reverse button to go from a credit note/refund to an
invoice/bill. This is now the case.

This is a partial backport of https://github.com/odoo/odoo/pull/103427



task-id 3102251

closes odoo/odoo#132969

Related: odoo/enterprise#46200
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Steps to reproduce:
-------------------
- create a job position without specifying the company;
- being in the first company, create an application for this job position;
- being in the second company, create an other application;
- go to the job position kanban view;

Issue:
------
Despite the selected company, the count for this job application is still two.

Solution:
---------
Include the allowed companies in the query to count the number of applicants.

opw-3453348

closes odoo/odoo#133033

Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

It's possible to specify an existing module as the xml id prefix when
importing records from a file. This will result in `ir_module_data`
records being created with `noupdate` set to False. When the module is
upgraded, these records will be deleted.

This can lead to undesired side effects like journal items for
accounts imported this way being deleted.

This change prevents creating new records linked to existing modules
when importing from a file. Instead, the user should either use no
prefix or the name of a non-existent module, like `__import__`.

opw-3231987

closes odoo/odoo#133053

X-original-commit: 56a53e90
Signed-off-by: Merel Geens <mege@odoo.com>

The aim of this commit is to allow any tax tag to be set on a journal
item and to allow the user to put tax tag from foreign countries in
which they have a VAT number on any tax.

The end goal is to allow the user to impact tax reports from several
country with the same journal item, avoiding the creation of a whole
journal entry and setting the path for some more automation.

Context:
Our user has a company based in Belgium but has a warehouse in
Netherland. Thus, when the company sells anything from that warehouse, it
needs to fill the Dutch tax report directly.
Moreover, the company needs to fill a grid on the Belgian VAT tax report.
That means that the user would need to gather some journal items on both
the Belgian tax report and the Dutch tax report.

Before this commit:
The user can't set tax tag from another country on its tax nor in the same move.

After this commit:
The user can set tax tags from any country for which its company has a
foreign vat number on any tax and in a move

Task-id: 3196547
opw-2810712

backport of https://github.com/odoo/odoo/commit/c45a164b136f3f12eb3b203646463dfa0bddd50b



closes odoo/odoo#131088

Related: odoo/enterprise#45385
Signed-off-by: John Laterre (jol) <jol@odoo.com>

When a model selection record is going to be deleted, a _process_ondelete method is called in order to delete all the records of the corresponding model that have that selection. These records are obtained by calling _get_records, which uses a query that needs a table. Thus, we should avoid cases for non-abstract models that have _auto = False.

closes odoo/odoo#133067

X-original-commit: 408175a7
Signed-off-by: Raphael Collet <rco@odoo.com>

closes odoo/odoo#128827

Related: odoo/enterprise#43982
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>

Commit [1] does not include the amazing feature "apply on variants".
As a result, a legit configuration could lead to a `ValidationError`
(see the new test `test_cycle_on_legit_apply_variants`)

Note about the modifications of `test_11_multi_level_variants`:
because of an ORM limitation, if we create a BoM line directly:
```py
self.env['mrp.bom.line'].create({...})
```
the constraint will not be triggered... We need to write the line
creation directly on the BoM

[1] 4a4f92c5

opw-3200969

closes odoo/odoo#133039

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:
- Create a product in KIT
- The product and components must be AVCO rated.
- Sell product, confirm delivery and post the invoice

Bug:
the journal entries are not reconciled.
the lines are gouped by product but in this case the products don't match
on the stock side it's the components and on the invoice it's the kit

Fix:
match components stock moves of kits to the kit product

opw-3208169

closes odoo/odoo#128009

Signed-off-by: Adrien Widart (awt) <awt@odoo.com>

Steps to reproduce:
- Go to `/blog`.
- Enable "Show Sidebar" in the "Customize" menu.
- Edit the page.
- Click on an icon of the "Follow Us" section of the sidebar.
- Click on the "Link" icon of the editor toolbar.

=> An error popup appears.

In further versions, the link parameters can be edited - but they are
lost upon save.

The social media links sections of the blog and blog post pages is
generated and is not supposed to be editable.

This commits makes these social media links sections non editable.

If a user needs to configure such a content specifically, it can be done
inside the "About Us" section of the sidebar above.
E.g.:
- Deactivate the "Follow Us" section from the "Customize" menu.
- You can use copy/paste to duplicate the existing style of the
"About Us" section if you want.
- Click on the "File / Image" icon of the editor toolbar (or type
"/image" to use the Power Box as of 15.0).
- Select a pictogram.
- Click on the "Shape: Circle" icon of the editor toolbar.
- Select the "Font Color" from the editor toolbar.
- Click on the "Link" icon of the editor toolbar to specify an URL.

opw-3450880

closes odoo/odoo#132024

X-original-commit: 2ba1ab5f
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

This commit:
- updates the DE balance sheet structure to use the correct one.
- updates the account tags used for l10n_de.
- renames the xmlids of the old tags to the new ones.
- updates the CoA for l10n_de.

task-3336261

closes odoo/odoo#127535

X-original-commit: 8b4c4a2c
Related: odoo/enterprise#43720
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Laurent Smet (las) <las@odoo.com>

in commit 5316c903 paypal button was badly placed due to width limit

closes odoo/odoo#132961

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Scenario:
- edit the current document layout and use is_html_empty method in it
- it works in Preview Document, when printing any report, ...

=> it breaks when opening document layout wizard by clicking on
   "Configure Document Layout"

Reason: is_html_empty was added to _get_rendering_context, but the
preview instead the document layout wizard doesn't use this method.

Fix: change the code to use higher order method

opw-3433583

closes odoo/odoo#131354

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This reverts commit 95468505.

The commits break the preview, as docs is not defined in preview (while done in real printing).
Not sure what we will do, with a check on the presence of the field or not, as it was working fine before, only a wrong modification of a view made it visible.
Linked to runbot error 24276

closes odoo/odoo#132941

X-original-commit: e23ff200
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>

The overriding of the placeholder does not work.
It's done to be different than the standard translation (Ciudad).
Modified it to be standard way of overriding placeholders.
Linked to runbot error 6175

closes odoo/odoo#132893

X-original-commit: 7ae5aacc
Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>

This PR odoo/odoo#125747 missed the account 973, which is still not in Ukrainian.
This account should be translated as well.

closes odoo/odoo#132904

X-original-commit: 6acb5660
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Aliya Tastemirova (alta) <alta@odoo.com>

PayPal payment needs to be done through native paypal button component.
Before this commit: in dropin we hid the native button which caused an
error when the user chose paypal as payment method.
After this commit: we show PayPal component with native button when
user selects it to make payment.

opw-3285830

closes odoo/odoo#132680

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Back-port from v16 to v15 of the new l10n_ro_saft module.

For the l10n_ro_saft module that generates the D.406 declaration, we
need to:
- create a new export tax specifically for services (which should be
  reported separately from goods); and
- make sure the Bank, Outstanding Receipts and Outstanding Payments
  accounts are created with codes 5121xx, and the Cash account with code
  5311xx, because codes 5120 and 5130 are not available in the official
  CoA and were therefore causing validation errors in the SAF-T export.
- because the CUI number (found in the company_registry field) for
  partners is required for the SAF-T export, and it is substantially
  the same as the VAT number, re-use logic from l10n_be to automatically
  fill in the company_registry if the VAT exists.

closes odoo/odoo#127120

Task-id: 3172198
Related: odoo/enterprise#43531
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

On the 'resource.calendar', attendance_ids is a computed field and
computation is triggered when company_id is changed.

Now, if we remove company_id, attendance_ids are left empty.
Instead, attendance_ids should be updated only when there is a new company set.

task - 3451264

closes odoo/odoo#131912

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Prior to this commit, when limited product loading was enabled,
scanning a product that had not been loaded yet would trigger a search
for the product without taking into account the available_in_pos field,
and it would also set available_in_pos to true.

This commit ensures that when a product is loaded using its barcode,
the behavior aligns with the changes introduced in this
commit: https://github.com/odoo/odoo/pull/87329/commits/a83c7aea37b06e8b1f04f1f02982ff577d7058e9



opw-3463427

closes odoo/odoo#132241

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Current behavior:
When you settle an order in the PoS and completely validate it, the
remaining moves from the original sales should be cancelled.
However, it was not the case because we were not adding all the picking
in the `waiting_picking_ids` list. And so when we were checking this
list we were not cancelling all the moves.

Steps to reproduce:
- Setup multi-step routes (Inventory > Settings > Multi-Step Routes)
- Change the configuration of the warehouse to use the multi-step routes
- Create a sale order for any product and confirm it
- Open the PoS, and settle the order you just created
- Validate the order
- Go back to the sale order, and check the state of the delivery
- Only one picking has been cancelled

opw-3390529

closes odoo/odoo#129621

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

1) The aim of this commit is to make the tax template more consistent with
the instanciated tax.
Indeed a tax wouldn't pass the constrains if it hadn't all its
repartition line.

2) Make the refund consistent with the rest of the taxes.

closes odoo/odoo#132542

Task-id: None
X-original-commit: c8603a9e
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

When sending an email from a multi-company environment, the automatic
email signature is not corresponding to the company from which the email
is sent.

This is because the user context is not properly forwarded, in
particular the `allowed_company_ids` key.

The issue comes from the new rpc service not autmatically adding the
user context to the request, whereas the legacy rpc service did.

opw-3394780

closes odoo/odoo#132684

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Currently, When the user is adding a double hyphen or space or anything within a
comment in a view's architecture and tries to save the view, then an error
occurs.

To reproduce the issue:
1. Go to Settings > Technical > Views > open a view.
2. In View Architecture comment out a line.
3. Add a double hyphen or space or anything within the comment.
4. Then save manually, the error will occur.

To solve this issue the error has been handled using a try-except block in
'parse_html' method.

sentry-4306359331

closes odoo/odoo#131888

X-original-commit: 43184556
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When the editor is displayed in a modal, the floating toolbar needs a
higher z-index than the modal in order to be visible. This is due to the
fact that the toolbar is mounted on the 'body' element (therefore, behind
the modal in terms of z-index).

The mobile toolbar, on the other hand, is mounted as a sibling of the
editable's element, which means it is always visible when the html field
is in a modal, without the need for a z-index. In fact, the mobile
toolbar, being fixed (no auto-hide) and having a z-index higher than
modals, leads to the undersired effect of being visible over modals that
are displayed on top of the html field. An example can be seen in the
Project app, where the editor is inside the task's description tab and a
modal can be opened for the customer.

This commit fixes such undesired visibility of the mobile toolbar over
modals by not applying the z-index to the toolbar when it's not
necessary (when not a direct child of the 'body' element).

task-3263463

closes odoo/odoo#123918

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Before this commit the floating toolbar would scroll over the headers
above the html field, such as the form view header and the web client
navbar.

This commit ensures the toolbar is hidden when it overflows the scroll
container.

task-3263463

Part-of: odoo/odoo#123918

Before this commit the floating toolbar position was not being updated
on scroll events in certain scenarios. The problem resulted from adding
the event listener to the incorrect scroll container, which was
calculated only once in the Wysiwyg life cycle, on start.

The calculated scrollable container could be incorrect due to:
- changes in the web client resulting from the swich from read to edit
mode taking place after the Wysiwyg was started,
- changes in the web client resulting from a window resize (particularly
when, in the form view, the chatter switches position from right to
bottom and vice-versa),
- the editor being mounted inside an iframe and the scroll container
being an element in the top document.
- the editor being mounter inside an iframe and the scroll container
being the iframe's root element.

This commit solves the issue by detecting scroll events anywhere in the
document (and in the iframe's document when it applies) and updating the
toolbar position when the editable is a descendant of the scrolled
element.

task-3263463

Part-of: odoo/odoo#123918

Manual backport of
https://github.com/odoo/odoo/commit/d1aac322c2201d7b96d43a82f7c130ff2c140776



Use the operator inselect instead of in with a read() before it.
This ensures a subquery is used instead of two separate queries.

When you have a user that is following thousands of tasks and the
security filter depends on this search, all queries are very slow. Using
a subquery prevents from reading these ids and sending back a very long
query to the database.

closes odoo/odoo#121561

closes odoo/odoo#132621

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:
-------------------
- create an event in the calendar;
- click on "Everybody's calendars" filter;
- delete the event.

Issue:
------
The event name is crossed out (declined)
instead of being deleted,
even if we are the organizer.

Cause:
------
The value of `event.attendee_id` inside the
`_onDeleteRecord` is `undefined`.
The condition will therefore never be `true`.

Solution:
---------
Add the organizer's id to the event
so that he can delete it in the case
of "Everybody's calendars" filter.

opw-3230254

closes odoo/odoo#129157

Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>

closes odoo/odoo#132577

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

When the user configures the 'external_layout_din5008' layout template in the
general settings and tries to any QWeb reports, that case generates the
traceback.

Steps to reproduce:
- Install the 'l10n_de' and 'sale_timesheet' modules.
- Settings > General Settings
- Search for 'Document Layout' and configure the 'external_layout_din5008'
  layout.
- Settings > Technical > User Interface > Views
- Search the 'external_layout_din5008'  QWeb template view.
- Search  '<span t-if="not o and not docs">
<t t-esc="company.l10n_de_document_title"/></span>'
  line and replace by,
'<span t-if="company"><t t-esc="company.l10n_de_document_title"/></span>'
- Go to the Sales menu and print any reports from the print menu.
After that, a traceback was generated.
Error:
AttributeError: 'res.company' object has no attribute 'l10n_de_document_title'
Template: l10n_de.external_layout_din5008

The 'l10n_de_document_title' field does not exist in the 'res.company'
object and also this field used in 'l10n_de.external_layout_din5008'
template, and this template is configured as layout.  So, remove this line from
this template.
Code reference:
https://github.com/odoo/odoo/blob/14.0/addons/l10n_de/report/din5008_report.xml#L109



Sentry-4283510443

closes odoo/odoo#132505

X-original-commit: 95468505
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Turkey has adapted its standard VAT from 18% up to 20%
This commit sets the 18% VAT taxes and its tax group to inactive and
introduces the respective 20% taxes and a 20% tax group.

closes odoo/odoo#132425

Task-id: None
X-original-commit: e7d71d0e
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Daniel Kosky (dako) <dako@odoo.com>
Co-authored-by: Ramazan Subaşı <subasiramazan@gmail.com>

To reproduce the issue:
1. Create two products A, B
2. Create two BoMs:
   - Product: A
     - Component: B
   - Product: B
     - Component: A
3. On one BoM, open the report "Structure & Cost"

Error: an Odoo Server Error is raised: "[...] maximum recursion
depth exceeded while calling a Python object"

The error occurs because of the cycle between both BoMs. There is
already a check for that in `:MrpBom.explode`:
https://github.com/odoo/odoo/blob/2a73890d304476833d76bac9a36ef92f12f267a3/addons/mrp/models/mrp_bom.py#L329


But it's too late in the flow. We should not be able to configure
such BoMs.

OPW-3200969

closes odoo/odoo#132477

Signed-off-by: Adrien Widart (awt) <awt@odoo.com>

Current behavior:
If you apply a fiscal position on a POS order, then refund it, the
fiscal position is not applied on the refund order.

Steps to reproduce:
- Create a fiscal position that match 15% of taxes to 0% of taxes
- Create a POS order with a product that has 15% of taxes
- Apply the fiscal position on the order
- Refund the order
- Check the taxes on the refund order, they are not correct

opw-3371028

closes odoo/odoo#128863

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Before this commit:

After applying formatting styles to text that already has some color applied to
it, we encountered an issue where the color pallete would flicker when
attempting to change the color.

After this commit:

Now, the color palette will no longer flicker when trying to change the color of
text that has formatting styles applied to it.

task-3417998

closes odoo/odoo#128352

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

The error can be raised either when a move is in state done or cancel. However, the error message only says we cannot split split if the move is in done, which can be misleading.

closes odoo/odoo#132333

X-original-commit: 45bab967
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Pedro Nogueira (pno) <pno@odoo.com>