Skip to content
Snippets Groups Projects
  1. Sep 06, 2019
  2. Sep 05, 2019
  3. Sep 06, 2019
    • laa's avatar
      [IMP] mass_mailing : improve interface, UI and usability · 2b6ebb3d
      laa authored
      
      In order to improve and clarify the mass-mailing (Email Marketing) module
      several changes have been made
      
      1 - Clarify the name of the application:
      2 - Prevent the “Quick Add/Create” feature in the mailing kanban view
      3 - Label and wording clarification in mailing_mailing form view :
      4 - Clarify button names "Send now" ("put_in_queue")
      5 - Mailing Form view layout
      6 - Clarify the required field
      7 - Clarify the readonly field
      8 - Wording clarification if scheduling mail in the future
      9 - Add a Placeholders tools page in the form view:
      10 - Clarify the Campaigns view
      11 - Clarify the Action Helpers
      
      TASK-ID : 2046078
      
      closes odoo/odoo#36124
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      2b6ebb3d
  4. Sep 05, 2019
  5. Sep 04, 2019
  6. Sep 05, 2019
    • Jérome Maes's avatar
      [IMP] web: formview auto close dialog · ba05c66e
      Jérome Maes authored
      
      Sometimes when using a form view in a modal (e.i.: in a gantt view), we might
      want to have some button in the footer. We expect clicking on buttons to close
      the dialog but nothing happens, since the webclient does not know that this is
      a modal.
      To do so, we provide the `close='1'` attribute on the button, in form view.
      This will trigger the event closing the modal.
      
      This is done with the benediction of aab-odoo
      
      Task-2024216
      
      closes odoo/odoo#36493
      
      Signed-off-by: default avatarJérome Maes (jem) <jem@openerp.com>
      ba05c66e
    • Jérome Maes's avatar
      [FIX] tools: format_datetime with inactive lang · 1b24f60a
      Jérome Maes authored
      When selecting the lang browse record, it can be empty when language is not
      activated. As we don't need that lang to be active to translate the
      format datetime (lang code is enough for Bable lib), we simply
      need to fallback to prevent error.
      1b24f60a
    • Quentin De Paoli's avatar
      [IMP] account: speedup of the aged partner balance · d604decc
      Quentin De Paoli authored
      
      Removed a browse on partners made in a loop, for a substantial gain of time and DB queries.
      
      Observed gain for a real data DB with 500 partners to print in the aged report:
      time (ms)                  # queries
      Before patch               4583                       1623
      After patch                2932                        553
      Gain                       1651 (36%)                 1070 (66%)
      
      closes odoo/odoo#36488
      
      Signed-off-by: default avatarQuentin De Paoli (qdp) <qdp@openerp.com>
      d604decc
    • Sébastien Theys's avatar
      [IMP] website_blog: avoid searching all blogs twice · fec4e77a
      Sébastien Theys authored
      
      The same `search` was done twice in a row.
      
      Part of task-2061122
      
      closes odoo/odoo#36485
      
      Signed-off-by: default avatarJérémy Kersten (jke) <jke@openerp.com>
      fec4e77a
    • Jérome Maes's avatar
      [IMP] hr_expense: posting flow in multi company environment · be8731cc
      Jérome Maes authored
      
      This commit tries to fix multi company problem in Expense application. Indeed, no check
      were done to ensure this business flow. Some technical decisions were made:
      - journal company: the journal define the company in which the accounting entries will be
      created. We know ensure with 'domains' and constraints that the journal have the same
      company as the expense sheet.
      - journal conditionnally required: the journal is only required when posting the expense. It
      is set by defaut on creation, but can be modify by accountant users. This is why the expense
      company determine the journal and not the opposite.
      - company fields required: As we need to use the company from the expense / expense sheet to
      determine the journal field and since expense models are business models, we needed to put
      company fields required.
      
      Business Flow
      When an employee creates an expense, the expense should be in its current company. A
      product from any allowed company can be chosen. Only the taxes of the expense company are
      applied to compute amounts. Then a report (sheet) can be created. We ensure that the expense
      lines of a report belongs to the same company as the report and to the same employee. Once
      submitted and approved by manager, the account journal can be set: it is forced to be in
      the same company as the expense report. The accounting entries are created in the journal
      (and expense report) company. As the analytic account can be shared (company is not set)
      the analytic entries will be in the expense company (handle by the accounting module).
      The payment is now registered in the expense company.
      
      Migration
      As company fields are now required, fill the company fields with the company of the related
      employee, or fallback on the one from the journal.
      
      Task-1999686
      
      closes odoo/odoo#36447
      
      Signed-off-by: default avatarJérome Maes (jem) <jem@openerp.com>
      be8731cc
    • Jérome Maes's avatar
      [IMP] account: multi company domain on product account fields · 14ec06e0
      Jérome Maes authored
      As we have to set account on product and product category to know in which
      account generate some accounting entries in some business flow (e.i.: expense),
      we need to keep some consistence with those accounts.
      Since those fields are company dependent, meaning their value depends on the
      current company, we want to ease the selection for the end user by only displaying
      the relation available in the current company. To do so, specific domain are needed.
      This guidelines should be applyied on each property fields.
      
      Task-1999686
      14ec06e0
    • fleodoo's avatar
      [ADD] crm_iap_lead_enrich: enrich leads based on email address · 1a36d98e
      fleodoo authored
      
      PURPOSE
      
      Allow the user to enrich a lead based on the domain of the email address of
      the client.
      
      SPECIFICATIONS
      
      Following fields will be populated if found using clearbit and if they are
      not yet populated :
      
      * description
      * partner_name
      * reveal_id
      * website
      * street, street2, zip, city, country_id, state_id
      * phone (using the first number found in clearbit)
      * mobile (using the second number found in clearbit, else the same as phone)
      
      A message will also be logged in the chatter.
      
      If no data is found using clearbit no credit is used and a message will be
      logged. If the user has no credits he will be redirected to buy credits for
      the service.
      
      It is possible to enrich using the 'enrich' action in listview or with a
      cron that will run every hour on leads not older than 1 hour.
      
      Add a "Lead Enrichment" setting in CRM installing lead enrichment.
      
      LINKS
      
      Task 193185
      
      closes odoo/odoo#36419
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      1a36d98e
    • Odoo's Mergebot's avatar
      [MERGE] website_{rating, slides}: Manage attachments in review update · e2c1226d
      Odoo's Mergebot authored
      
      PURPOSE
      
      Allow to manage attachments when updating a frontend review.
      
      SPECIFICATIONS
      
      Currently when posting a review in eLearning or eCommerce one can attach
      files to its review thanks for portal composer. Rating popup composer allow
      to update its comment and rating. However this edit mode has two limitations.
      It does not display attachments previously added and does not allow to add
      attachments.
      
      This merge fixes that by
      
      * giving attachment values to the composer, allowing its display by the
      composer display at startup;
      * allowing to give new attachments and properly handle them in slides
      route;
      
      Uploaded and validated attachments cannot be removed by users. Indeed
      message with attachments has probably already be sent to people and removing
      attachments would lead to information loss.
      
      LINKS
      
      Task 2066600 (manage attachments)
      Task 2058595 (eLearning v13 testing)
      
      closes odoo/odoo#36409
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      Unverified
      e2c1226d
    • Louis Baudoux's avatar
      [FIX] account: fix main_attachment_id not set on attachment upload · a6447663
      Louis Baudoux authored
      
      When creating invoices via the 'Upload' button, the
      'message_main_attachment_id' field wasn't set on the record. This
      happened because the message posted in the chatter was linked to the
      wrong 'res_model' which prevented it from being selected as the main
      attachment.
      
      This was causing a bug in the OCR module ('account.invoice.extract')
      where we use this field to determine which attachment must be sent to
      the OCR server.
      
      closes odoo/odoo#36309
      
      Signed-off-by: default avatarFlorian Daloze (fda) <fda@odoo.com>
      a6447663
    • Olivier Colson's avatar
    • Andrea Ulliana's avatar
      [IMP] event: show total of reserved seats in list view · 5eedaad3
      Andrea Ulliana authored
      
      task-2066537
      
      closes odoo/odoo#36417
      
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      5eedaad3
    • oco-odoo's avatar
      eeea5117
    • Simon Lejeune's avatar
      [FIX] hr_maintenance: falsy value in compute · c5834142
      Simon Lejeune authored
      
      closes odoo/odoo#36456
      
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      c5834142
    • wan's avatar
      [FIX] account: prevent multiple event concurency · 5112d046
      wan authored
      * When clicking on the partner m2o selection field before having clicked on the bank statement line, 2 events occured:
      * the bank statement line expanded
      * the partner selection showed
      
      This could lead to unwanted behavior as the renderer could update
      -> Stop the propagation of a click on .o_field_widget to prevent
      flickering and possible update of the statement line widget
      
      * Always recompute the create line as sometimes the value is not correct
      when removing a proposition
      
      closes odoo/odoo#36322
      
      Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
      5112d046
  7. Sep 04, 2019
    • Thibault Delavallée's avatar
      [IMP] website_{rating, slides}: allow to manage attachments when updating reviews · a08845d2
      Thibault Delavallée authored
      PURPOSE
      
      Allow to manage attachments when updating a frontend review.
      
      SPECIFICATIONS
      
      Currently when posting a review in eLearning or eCommerce one can attach
      files to its review thanks for portal composer. Rating popup composer allow
      to update its comment and rating. However this edit mode has two limitations.
      It does not display attachments previously added and does not allow to add
      attachments.
      
      This commit fixes that by
      
        * giving attachment values to the composer, allowing its display by the
          composer display at startup;
        * allowing to give new attachments and properly handle them in slides
          route;
      
      Uploaded and validated attachments cannot be removed by users. Indeed
      message with attachments has probably already be sent to people and removing
      attachments would lead to information loss.
      
      LINKS
      
      Task 2066600 (manage attachments)
      Task 2058595 (eLearning v13 testing)
      a08845d2
    • Thibault Delavallée's avatar
      [FIX] portal: allow portal discuss attachment css to be applied on popup composer · c0769308
      Thibault Delavallée authored
      PURPOSE
      
      Allow to manage attachments when updating a frontend review.
      
      SPECIFICATIONS
      
      Popup composer used notably in website_rating (eLearning, eCommerce) is not
      instantiated inside a frontend chatter. It does not get all available CSS rules
      as those are all set inside o_portal_chatter.
      
      In this commit we move some CSS rules to allow using them in composer or chatter
      independently of how they are instantiated.
      
      LINKS
      
      Task 2066600 (manage attachments)
      Task 2058595 (eLearning v13 testing)
      c0769308
    • Thibault Delavallée's avatar
      [MOV] portal: split portal chatter from composer · bb197b1f
      Thibault Delavallée authored
      PURPOSE
      
      Allow to manage attachments when updating a frontend review.
      
      SPECIFICATIONS
      
      As those widgets grow it is better to have them in separate files in order to
      better understand code organization. Future commits will improve composer
      behavior, notably in attachments management.
      
      LINKS
      
      Task 2066600 (manage attachments)
      Task 2058595 (eLearning v13 testing)
      bb197b1f
  8. Sep 02, 2019
  9. Sep 05, 2019
  10. Sep 04, 2019
  11. Sep 05, 2019
  12. Sep 03, 2019
  13. Sep 05, 2019
  14. Sep 04, 2019
    • Christophe Monniez's avatar
      [FIX] web: avoid some external links in click_all test · 95fefe6c
      Christophe Monniez authored
      
      Since 78565b1d , two menus with an act_url action drive the user to
      external websites. This makes the click_all test very fragile.
      
      With this commit the Apps menus "Theme Store" and "Third-Party Apps" are
      black-listed in the click_all test.
      
      Also, it happens that a filter which is not supposed to work in some
      circumstances is simply hidden. Actually, the click_all test sets that
      filter and leads to  a crash.
      
      With this commit, for a more realistic use case, the click_all test does
      not activate hidden filters.
      
      closes odoo/odoo#36433
      
      Signed-off-by: default avatarChristophe Monniez (moc) <moc@odoo.com>
      95fefe6c
    • Gorash's avatar
      [FIX] website: the rte tour was undeterministic · 35829f20
      Gorash authored
      
      The tour try to click on the language dropdown before the reloading of the
      page if the server is slow.
      To fix it, we avoid the reloading by the rte, and trigger the reload
      in '_reload' method of editor menu who add the class 'o_wait_reload'.
      We add a selector and trigger in the test to avoid undeterministic error.
      
      closes odoo/odoo#36098
      
      Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
      35829f20
Loading