Skip to content
Snippets Groups Projects
  1. Feb 25, 2016
    • Denis Ledoux's avatar
      [FIX] account: better error message when emptying journal account number · 4a65bc38
      Denis Ledoux authored
      The account number field on a journal is a related field to the
      number of the bank account associated to the journal.
      
      As the number of a bank account is a required field,
      any attempt to empty it from the journal fails.
      
      Besides, unlinking the bank account from the journal when emptying
      the account number on the journal form doesn't seem to be
      the appropriate behavior. Imagine you give an account number
      to the journal, then empty it, then re-fill it, you probably
      do not want the journal entries to be associated to a new bank account,
      you probably wanted the same bank account, but renamed, while
      it would be the case if we simply unlink it.
      
      If you would like to delete the bank account, you have
      to do it from the bank accounts list itself.
      
      opw-670472
      4a65bc38
    • Denis Ledoux's avatar
      [FIX] product: price list report without purchase access rights · b9f20695
      Denis Ledoux authored
      Pass the fields parameter in the call to the `read` method,
      so it fetches only the needed fields:
       - Better performances,
       - Avoid possible access rights issues.
      
      In this case, it wasn't possible for a user
      having no access rights to the purchase module
      to print this report.
      
      opw-670449
      b9f20695
    • Denis Ledoux's avatar
      [FIX] res_bank: address format in form view. · 8e2a3099
      Denis Ledoux authored
      Apply the layout as done in the revision
      faa14705
      in the different form containg an address.
      
      opw-670433
      8e2a3099
    • Nicolas Martinelli's avatar
      [FIX] sale_mrp, purchase: delivered quantity · 07ab3543
      Nicolas Martinelli authored
      The quantity delivered must be converted in the product UoM of the BoM
      line. Indeed, the UoM of the BoM line can be different from the UoM of the
      product which is manufactured.
      
      opw-669764
      07ab3543
    • Nicolas Martinelli's avatar
      [FIX] sale_mrp, purchase: BoM quantity · 74eb4cfc
      Nicolas Martinelli authored
      The method `_bom_explode` requires a quantity in the UoM of the BoM.
      
      opw-669764
      74eb4cfc
  2. Feb 24, 2016
  3. Feb 23, 2016
    • Christophe Simonis's avatar
      [FIX] core: parent store compute on registry loading · 53742a4a
      Christophe Simonis authored
      When loading the registry, the parent store are defered at the end of
      the registry initialisation. However, when modules should be removed, a
      brand new registry is build without deleted modules, losing the list of
      models on which parent store should be recomputed.
      53742a4a
    • Stéphane Bidoul's avatar
      [FIX] account: fiscal position in multi-company environments · 4162b8f5
      Stéphane Bidoul authored
      Properties depends on with which companies the records
      are browsed.
      
      When retrieving the fiscal position as sudo,
      the company must therefore be enforced within the context,
      to make sure to get the properties from the right
      company.
      
      This method can totally be accessed as sudo,
      within the crons for instance.
      
      Before this revision, the recurring invoices cron
      could retrieve properties from the wrong company,
      and therefore retrieve the fiscal position of another
      company.
      
      Closes #11039
      4162b8f5
    • Denis Ledoux's avatar
      [FIX] purchase_requisition: fiscal position tax mapping · 3b36bca4
      Denis Ledoux authored
      `map_tax` must be called using the fiscal position
      browse record, not using its id.
      
      Besides, `fpos` is not used further in the code.
      
      opw-670170
      3b36bca4
    • Denis Ledoux's avatar
      c63be58e
    • Denis Ledoux's avatar
      [FIX] account_asset: can't adapt browse record to id · 8a098df7
      Denis Ledoux authored
      During the conversion of the module
      `account_asset` to the new API,
      in revision 6120babb,
      the variables `current_currency` & `company_currency`
      have been changed from identifier integers to
      browse records.
      
      The currency passed in the `create` method
      values must therefore be adapted according
      to this change.
      
      This prevented the correct use
      of the assets when the currency of the assets
      was not the same as the currency of the company.
      
      opw-669571
      8a098df7
    • Denis Ledoux's avatar
      [FIX] account_asset: currency conversion inverted · 7c7ee5d0
      Denis Ledoux authored
      During the conversion of the module
      `account_asset` to the new API,
      the currency conversion in `create_move` has been inverted.
      
      ```
      amount = currency_obj.compute(cr, uid, current_currency, company_currency, line.amount, context=context)
      ```
      has been converted to
      ```
      amount = company_currency.compute(line.amount, current_currency)
      ```
      while it should have been converted to
      ```
      amount = current_currency.compute(line.amount, company_currency)
      ```
      See:
      https://github.com/odoo/odoo/commit/6120bab#diff-e35933343c229da0afceb2a3b9e3639bR356
      
      opw-669568
      7c7ee5d0
    • Nicolas Martinelli's avatar
      [FIX] models: export of booleans · 68f9f99e
      Nicolas Martinelli authored
      In the case of a `raw_data` export, a boolean which has the value
      `False` will not be exported correctly.
      
      The fix handles the `False` value as a valid value for a field.
      
      opw-666142
      68f9f99e
    • Denis Ledoux's avatar
      [FIX] product: add index on pricelist items for better perf · 0cb3ed4e
      Denis Ledoux authored
      With a high number of pricelist items
      (8.000.000 in the observed case),
      the SQL request performed in `_price_rule_get_multi`
      took a significant time (>3000ms)
      to be executed without an index on the `pricelist_id`.
      
      opw-670153
      0cb3ed4e
    • Nicolas Martinelli's avatar
      [FIX] point_of_sale: round price unit · ee335933
      Nicolas Martinelli authored
      The product price unit should be rounded before being used in any
      operation. The PoS calls the method `read` in order to get the necessary
      fields. However, the product price is a non-stored calculated float. In
      old API, such a field is not rounded by the `read` method. It means that
      a product price of 28.067 (for example thanks to the use of a pricelist)
      will be rounded to 28.07 at the server level but not rounded in the PoS
      JS layer.
      
      To lower the impact of the fix, the rounding is done at the JS level,
      and not in the `_product_price` method.
      
      opw-669024
      ee335933
    • qsm-odoo's avatar
      [FIX] web: Dialog closing · 380a1fd5
      qsm-odoo authored
      The Dialog class destroys the modal (and so removes it from the DOM)
      when the dialog closes but leaves the modal-open class on the body
      element if there are still other modal(s) in the DOM.
      
      The problem is that (maily on the frontend side) there may be others
      modal(s) in the DOM (not handled by the Dialog class) but which are
      not shown to the user, and in that case the modal-open class should
      be removed.
      380a1fd5
    • Denis Ledoux's avatar
      [FIX] payment: Translatable thanks message · e7770ed9
      Denis Ledoux authored
      If the help message is translatable,
      there is no reason why the thanks message
      coudln't be as well.
      
      This is a following of the revision
      f37a40c4
      
      opw-670228
      e7770ed9
    • Denis Ledoux's avatar
      [FIX] account: bank statement currency · 2fe11b8a
      Denis Ledoux authored
      If there is no currency set on the journal,
      the fallback currency must be the currency
      of the journal company, not the currency
      of the user company.
      
      This would mean that when you change of company,
      with another currency set,
      the bank statement change of currency, this is non-sense.
      
      opw-670187
      2fe11b8a
    • Iryna Kanivets's avatar
      [FIX] base: wrong currencies · c43889b5
      Iryna Kanivets authored
      The currency of Georgia is GEL not EUR
      The currency of French Guyanais EUR not GEL
      The currency of Ukraine is UAH, not UAG
      
      Closes #10106
      c43889b5
    • Iryna Kanivets's avatar
      [CLA] signature for Luckygirlllll · 06c4bb77
      Iryna Kanivets authored
      Closes #10106
      06c4bb77
    • Goffin Simon's avatar
      [FIX] product_visible_discount: Show Discount not working with multi-currencies pricelist · 8de70d07
      Goffin Simon authored
      The sale price set on the product is in the currency of the company.
      
      opw:669918
      8de70d07
    • Goffin Simon's avatar
      [FIX] account: Missing Partner in account move line · 0f7e6f40
      Goffin Simon authored
      When creating account move lines from an account move, the partner
      set on the account move lines has to be the same than the one on the
      account move.
      
      opw:668322
      0f7e6f40
    • Nicolas Martinelli's avatar
      [FIX] report_intrastat: month used for intrastat.report record · 2230bee0
      Nicolas Martinelli authored
      The month used for an intrastat.report record must be the same as
      the invoice_date set on the invoice.
      
      Backport of d1d89662
      
      opw-668827
      2230bee0
  4. Feb 22, 2016
Loading