[FIX] l10n_eu_service: wizard: don't copy tags when creating the service tax for the selected EU country

This restores the behavior for 12.0; we don't want those amount within the national tax report.

closes odoo/odoo#44881

X-original-commit: bd21046f9259f0c755deeba8a1d207da6578e957
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

This route was public by mistake, probably introduced to test during
ddf32f4f but no reason to make it public, public user has not the write
access on models anyway.

Courtesy of Swapnesh Shah

closes odoo/odoo#44912

X-original-commit: 66ac96b2
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

- Go to Settings > Technical > Resource > Working Times
- Have a Resource Calendar RC with Average hour per day != 8.00
- Have an Employee E with Working Hours == RC
- Leaves > Configuration > Leave Types
- Have a Leave Type LT with Take Leaves in Hours
- Leaves > Managers > All > Allocations
- Create an Allocation A with Employee E and Leave Type LT
- Enter any number in Duration

The number of hours entered changes as we leave the field.

Being totally honest, what happens here is not clear at all, but using
the corresponding `resource_id.calendar_id` field seems to fix the
problem.

opw-2191795

closes odoo/odoo#44895

X-original-commit: e239b354
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before, we had abs() in the report, but we saw it was wrong:
https://github.com/odoo/enterprise/commit/5e7d91d5ea5356fa3c38b6676b68403a713da5be#commitcomment-33050133



Somehow they remained in saas-12.3 and with this we remove them as well.

Thanks to Martijn Kluijtmans
opw-2186942

closes odoo/odoo#44653

X-original-commit: e39d86a85015d833dcf0b87c3d28f7bc3b97a2c1
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Without these magic filters the various options in the activity
widget (late, today, future) will show all activities instead.

opw-2172833

closes odoo/odoo#44817

X-original-commit: 8ddb78c05a97282096bed9f49de0cea8f265994c
Signed-off-by: jorenvo <jorenvo@users.noreply.github.com>

Since we use Promise instead of jQuery deferred, the onRemove method
class was no longer triggered before the actual removal of the elements.

Original fix with https://github.com/odoo/odoo/pull/43918


This PR is the same with the async/await form, not breaking the history
of half of the removeSnippet method's lines.

closes odoo/odoo#44900

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: fja-odoo <fja@odoo.com>

Make sure `force_company` context key is set on the SO in all cases.
Indeed, when the context key is not properly set, an incorrect fiscal
position can be retrieved in:

https://github.com/odoo/odoo/blob/cc557f1e4de88466d0d159c5edf1a606a0c0bc6f/addons/account/models/partner.py#L99-L100



This is for example the case when we go through the route
`/shop/confirm_order`.

opw-2186682

closes odoo/odoo#44451

closes odoo/odoo#44882

Original-signed-off-by: Toufik Benjaa (tbe) <tbe@odoo.com>
X-original-commit: 510bb8cc
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#44875

Signed-off-by: Josse Colpaert <jco@openerp.com>

The typical command to launch odoo in the install documentation is usable as it is after following the complete instructions.
There is two changes done here:
- Remove the ../my_modules from the command, as it is a directory not used in the page at all.
- Remove the db-filter option not mandatory since the 11.0 version and add a '-d' argument. This will create the db instead of showing the database selector to the reader.

closes odoo/odoo#44640

X-original-commit: 5489cc12
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

The filter for Purchase orders in the Purchase report did not filter out Sent RFQ,
despite the fact that they were not really ordered yet.

opw:2158248

closes odoo/odoo#43620

X-original-commit: f112d91dd176865f33fb17f56f1ea2e119708e1b
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

	- Install Website
	- Go on your website
	- Add text block with image
	- Change ONLY the image's alt and/or the image's title text
	- Save dialog
	- Save page

	Not saved

Cause

	The element doesn't become dirty after changes in alt dialog.

Solution

	Trigger content_changed to make the element become dirty.

OPW-2189909

closes odoo/odoo#44853

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

closes odoo/odoo#44239

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Make sure `is_website` is an existing field of the model at creation.

opw-2192139

closes odoo/odoo#44841

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#44838

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Formerly the vendor bills, customer invoices and regular journal items were evaluated by the _check_unique_sequence_number method, but this is wrong and also was overwritten Odoo original constraint error message.

Now the _check_unique_sequence_number evaluate the account.moves that are not vendor bills that use documents because this kind of bills uniqueness depend on the vendor: we can have same name of vendor bill from different partners. This is evaluate in the already existing _check_unique_vendor_number method

closes odoo/odoo#44813

Signed-off-by: Josse Colpaert <jco@openerp.com>

Normally, the number of column option adjusts the width of each column
after changing their number so that they always fit in one row. In
previous versions, the sequence of the code was correct thanks to
jQuery's deferreds executing their then callbacks synchronously if the
promise was already resolved. However, native Promise objects always
put their then callbacks in the microtask queue, and this was resulting
in the column width classes being recalculated before their number had
actually changed.

This commit fixes that by calculating the width of the columns based on
how many columns there will be after addition/removal. It also
introduces a new field on the option that is used to update the UI so
that it displays the correct number.

closes odoo/odoo#44776

X-original-commit: 1745281a1956caf669eb27191b356726c9e65253
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

- install e-commerce;
- In the website settings, orders followup, set a salesperson;
- By something as a public user;
- Pay the order.

Before this commit:
- 2 emails where create to assign the salesperson to the SO, but these
    emails didn't have a from and the salesperson didn't receive the
    emails.
- 1 email was also create to assign the salesperson to the contact, this
    mail is not necessary.

Now, only one email that assigns the salesperson to the SO is sent,
with a correct from address.

opw-2189683

closes odoo/odoo#44717

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

- Activate 'Round Globally'
- Create a 21 % tax included in price
- Create a product costing 21.5
- Add the product in a pos order, make the payment

The `price_subtotal` is saved as `17.768595`, while it should be
`17.77`.

When these amounts are added in [1] (coming from [2]), it can lead to an
inconsistency in the final computation, preventing the closing because
of an unbalanced journal entry.

Actually, the total and the subtotal must always be rounded following
the currency precision, as done in [3] and [4].

It was probably not causing an issue before 13.0 since the creation of
the journal entry from the POS was different.

[1] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/point_of_sale/models/pos_session.py#L381
[2] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/point_of_sale/models/pos_session.py#L557
[3] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/account/models/account.py#L1654
[4] https://github.com/odoo/odoo/blob/b22935caa3df824bc56a0828da9bee921bca5a5b/addons/account/models/account.py#L1740



opw-2181486

closes odoo/odoo#44692

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

On product categories, the `total_route_ids` field is shown without
label. This is confusing for end users since the same route seems to
appear twice.

opw-2173783

closes odoo/odoo#44799

X-original-commit: 91bc6464
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

1) Go to purchasing, and in the search area type "8888"
2) Click on the little arrow next to "Search Product for: 8888"
3) Select "[FURN_8888] Office Lamp"
4) Choose Purchase Order PO00009 which has FURN_8888 on the second line:
5) Choose Action > Duplicate

The 1st line end up with the searched product, not the original product.
This happens because the search add the context key
'default_product_id'. By chance the product.product model has a
'product_id' field which may happen to be not filled.
This cause the model api to look for a default value in the context and the
first line of the order get overridden.

Removing the specific key from the env solve the issue

opw-2188429

closes odoo/odoo#44760

X-original-commit: ed6ac9c6
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#44548

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Usecase to reproduce:
- Set the lot_stock_id as a view location
- Create a PO and validate it

-> The forecast quantity on stat button is correct but it's missing in
the forecast quantity report.

It happens because the condition for stock_move is based on valuation
strategy. However it's not correct since it's not True that a product
is in the stock if it's valuated (as subcontracting, owner, ...)

In order to fix it uses the warehouse in order to define if a move is in
or out (the same way than the _get_domain_locations on product).

- Create a default value for 'Source Location' or 'Scrap Location'
- Create a Scrap Order

the default value is not taken into account since it is overridden by
`_onchange_company_id`.

We avoid changing the location in case the company matches.

opw-2189578

closes odoo/odoo#44753

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Create the following tax:
  Tax Computation: Percentage of Price Tax Included
  Amount: 100 %
  Included in price
- Create an invoice, add a product with this tax
- Save

A ZeroDivision error is raised.

opw-2186998

closes odoo/odoo#44724

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

closes odoo/odoo#44668

Co-authored-with: Xavier Dollé <xdo@odoo.com>
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Have a company with Croatian address but no street2 set.
Create and invoice, print it. On the report the street2 will appear
blank (Empty line).

Correcting the formatting of the address fix the issue

opw-2182621

closes odoo/odoo#44706

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Nothing prevents to delete a bank statement linked to an open pos session,
which leads to a KeyError when validating and posting entries at closure.

closes odoo/odoo#44229

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce the bug:

- Create a journal entry
- Create a line L1 with an account A and a partner P
- Create a second line L2 with an account A and a partner P
- Create a third line by clicking on 'Add line'

Bug:

The account A and partner P was not suggested as in saas-12.3

opw:2188921,2152827

closes odoo/odoo#44656

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Before this commit, it was possible to change the state of the Purchase Agreement when Grouped by `state` on Kanban view which is not Ideal Behavior.

Now we block drag and drop when grouping by State.

closes odoo/odoo#44674

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Steps to reproduce the bug:

- Let's consider a partner P without property_payment_term_id
- Create a SO for P, confirm it and create an invoice I
- In debug mode, on the SO click on the smart button 'invoice'
- On I, click on the 'Set Default' in the debug menu
- Set a payment term PT as default value (ir.default) for all users
- From this view, create a new invoice

Bug:

The default payment term PT was not set on the new invoice

opw:2184367

closes odoo/odoo#44648

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Since synchronization of tables was added in POS restaurant,
requests are frequently made to the server to display the
number of open orders on each table.

The implementation of the counting caused O(num_tables) queries,
and those queries were slow on large databases because there
was no index for the `table_id` column.

This patch fixes both problems, and the counting now uses
3 fast queries regardless of the number of tables.

On a sample database with 2k tables and 50k POS orders,
calls to `get_tables_order_count` went down
from 1 s and 100+ SQL queries to 10 ms and 4 queries.

About 2 orders of magnitude faster, with server load drastically
reduced as well.

closes odoo/odoo#44660

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

Steps to reproduce:
- install sales
- activate units of measures and variants
- set imperial units under general settings (pounds for weight and ft³ for volume)
- create at least 2 variants on a product and access them via the smart button
from product.template

Previous behavior:
the volume remains in m³, it is hardcoded in the template

Current behavior:
the volume is printed just like the weight (generic uom notation)

opw-2186965

closes odoo/odoo#44649

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Before this commit, when printing in safari a receipt that contains
products with long names, parts of the name were overlapped. This occurs
because, in safari, the library that transforms the html into text
mismanages the spaces.
This is a well known problem, see : niklasvh/html2canvas#1654

Now, the name is printed correctly in safari, same behaviour than the
others browsers.

opw-2169656

closes odoo/odoo#44658

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Highlight the 'Validate Inventory' button only if there is at least one
inventory line.

opw-2187225

closes odoo/odoo#44628

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Don't ignore correction layers when computing the anglo saxon price
unit. We use the `stock_valuation_layer_id` field on the layer to point
the correction layer to the corrected layer. When computing the average
price of the delivered things, ignore correction entry but take them
into account when choosing a corrected entry.

opw-2179900

closes odoo/odoo#44498

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

We chose the vendors by searching random res.partner but sometimes
partners of another company are returned, making the _check_company
mechanism raise an error.

closes odoo/odoo#44367

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

in anglo saxon accounting
- receipt products through an rfq
- when creating the vendor bill of the rfq, directly add a landed costs
  product
- post the vendor bill then create the landed cost, validate the landed
  cost
- the aml of the LC is not reconciled with the aml of the vendor bill
  for the lc product because the "You are trying to reconcile some
  entries that are already reconciled." error.

We fix this by filtering out the already reconciled aml.
Not that the flow is behaving as expected if the landed cost is created
in another vendor bill, such as the tests were doing. We thus add
another test.

opw-2184988

If some filter domains use M2O to models current user cannot access,
using sudo() permit to filter even when user cannot access linked
models.

for the accuracy of the fix, add a unit test which reproduce the exact
reported bug.

closes odoo/odoo#43582

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>