Fixes #62214

closes odoo/odoo#62475

X-original-commit: 45afa3a2
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

There is a situation in pos_restaurant such that when an order
is deleted from the ticket screen, it persists to show when the
table is opened. To reproduce:

1. Create an order in T1 then add items to it.
2. Get out of the table (back to floor).
3. Open ticket screen.
4. Delete the order in T1.
5. Close the ticket screen.
6. Open T1, the order is still there (bug).

This commit fixes this behavior such that in step 6, new order should
show and not the deleted order.

Note that we also made a change in the template in order to allow
checking the number of synced orders during testing. We want to make
sure that the table is clicked when the sync finishes to prevent
concurrency issue during testing.

closes odoo/odoo#62403

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

In the hr localization, some of the tax report lines have a line code
without tag name, and are then used in some formulas.

This is incorrect since the tag name is needed to get a balance.

This PR will fix this by removing the codes and their appearance in the
 formulas, since these lines have no incidence in the result.

Task id #2376724

closes odoo/odoo#61413

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Steps:
- Install Contacts
- Have Multi-Companies enabled
- Go to a Contact of type "Company"
- Click "Sales & Purchases"
- Assign it the company you're on
- Save and Edit again
- Remove the assigned company
- Go to a contact of type "Individual" linked to this company
- Click "Sales & Purchases"

Bug:
The company has not been deleted on the linked Individual

Explanation:
When we delete the company of a contact, the value of `vals.get('company_id')` is `False`.
This is why it didn't enter the propagation process.

opw:2391464

closes odoo/odoo#62461

X-original-commit: 80902bee
Signed-off-by: backspac <backspac@users.noreply.github.com>

task-2292595

closes odoo/odoo#62454

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

closes odoo/odoo#61987

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#62434

X-original-commit: 52cd0a74
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit if a product template has no image, no image was
displayed in the website shop for the product

After this commit if a product template has no image, the image of the
first variant is displayed in the website shop

https://github.com/odoo/odoo/issues/52463



closes odoo/odoo#62431

X-original-commit: 643c8a9d
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Steps to reproduce the bug:

- Create a BOM kit K with two components C1 and C2

Bug:

It was possible to set an operation on K

PS: Operation is not supported on BOM kit

opw:2393302

closes odoo/odoo#62427

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

This makes the act of replacing the dummy text easier.

@Tecnativa

closes odoo/odoo#62413

X-original-commit: 115d9a58
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

STEPS:
* Create a BoM with two components purchased the same vendor, but with
different "Delivery Lead Time". First component must have lower value
* Create Manufactoring order, Mark as ToDo
* Open created purchase order

BEFORE: Order Date	is equal "MO planned day MINUS delivery lead time for the first component"
AFTER: Order Date	is equal "MO planned day MINUS maximum amout delivery lead
time for the components"

---

opw-2388031

closes odoo/odoo#62404

X-original-commit: 8f0cc360
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

Fiscal positions shouldn't be deleted if used by existing account moves

closes odoo/odoo#62398

X-original-commit: 6f5801a7
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

The mock implementation of `name_get` does not fully reflect
the real server implementation.

The real implementation is described in tests added in
this commit.

Note: in my wildest dreams, the mock server tests would be run
against the real *and* the mock implementation to ensure they
do not diverge.

closes odoo/odoo#62347

Related: odoo/enterprise#14990
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

task-2387820

closes odoo/odoo#62166

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

What are the steps to reproduce your issue ?

    1. Install "google_calendar"
    2. Log in with "admin"
    3. Create an eventX with "admin" and "demo" has attendees
    4. Run "Google Calendar Synchronization" from "Scheduled Actions"

What is currently happening ?

    eventX is successfully added to Google but without admin
    if you sync Odoo to Google one more time, Google will overwrite eventX
    and it will remove admin from attendees

What are you expecting to happen ?

    Sync Odoo to Google and Google to Odoo without lost attendees

Why is this happening ?

    Because there is a filter that prevent addition of current user to the attendees

How to fix the bug ?

    Remove the filter

This reverts commit 287ee0f8.

opw-2382443

closes odoo/odoo#62406

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Leftover from commit b5e39fc

closes odoo/odoo#62379

Signed-off-by: Nicolas Galler <ngaller@users.noreply.github.com>

Followup on 911ada2d

When modifying the company_id of a pricelist, the check to ensure a website
has a pricelist available wasn't triggered.

This commits ensures the Each website has Valid Pricelist with Correct or
Empty company.

Fixes #50707

closes odoo/odoo#62358

X-original-commit: f196430b
Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

closes odoo/odoo#62395

X-original-commit: 8fdf193c
Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#62377

X-original-commit: 73293a2b
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

For this case, if the invoice currency is different from the invoice company currency, the tax calculation is considered the value in a different currency, and the subtotal is the sum of the amount untaxed + the taxes (wrongly in company currency) result in an incorrect value. This is verified when printing the invoice report

closes odoo/odoo#62386

X-original-commit: 91f152f4
Signed-off-by: Josse Colpaert <jco@openerp.com>

Before this commit the dropzone was relative to div.content. This would create
some bad position where the dropzone was covering the form view but not the
chatter.

task-2389929

closes odoo/odoo#62199

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Fields `views`, `closed_reason_id`, `closed_uid` and `closed_date` should not be copied while copying post.

closes odoo/odoo#60661

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before this commit the close button cross/multiply character was wrongly
translated in some languages (e.g. Spanish)

After this commit the close button cross/multiply character is not a
translatable text anymore

https://github.com/odoo/odoo/pull/60268


task-2365792

closes odoo/odoo#60268

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

When some bills are not paid, some with due date, some without, when registering the payment of these bills as a group payment with checks, it is not possible to print the check

To reproduce the error:
(Need account)
1. Go to Invoicing > Vendors > Bills
2. Create a new one
    - Add at least one line
    - Add the Payment Terms
3. Save & Post
4. Duplicate it, then Save & Post
5. Go back to Bills
6. Select the two bills
7. Click on Action > Register Payment
8. Select Checks, enable Group Payment
9. Click on Create Payment
10. Click on Print Check
11. Click on Print

=> An Odoo Error is raised

The user should be able to print it.

OPW-2389368

closes odoo/odoo#62365

X-original-commit: adeebc5d
Signed-off-by: adwid <adwid@users.noreply.github.com>

The 'On Hand' button triggers action_open_quants on product model. It
do not explode the kit into its component

closes odoo/odoo#62354

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

As default is called numerous times with sometimes all fields, sometimes
only one field we have to ensure we avoid computing and setting unnecessary
or wrong values. We suspect this comes from default_get being called more
often at creation time since Odoo v14.

Default values for some fields in mail composer are dependent on each other.
Especially composition mode and model / res_id(s) are important for some
fields as behavior is not the same in comment or mass mail mode (subject
set / not set, template values rendered / displayed raw, ...).

Especially subject is wrongly computed in mass mail mode. For example use a
mass mail composer action on leads without template. Indeed a default_get
is called on subject alone. As web client adds active_model / active_id
automatically default returns a value for subject while it should not as
other values (model, res_id) are not asked and therefore not correctly
computed. It makes composer compute values in comment mode while it should
stay in mass mode.

In this commit we fix that behavior by

  * computing only requested values (better match returned values and asked
    fields);
  * avoid computing values if context values are not given (model, res_id or
    res_ids, composition_mode);

Task ID-2390314
PR odoo/odoo#62061

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Some tests are currently dependent on bus state when computing number of
notifications sent. For example install Crm then test_mail_full. Some
tests crash as too much notifications are found in the bus.

We therefore clean remaining bus notifications before running tests to
ensure we check notifications during test itself. This make tests more
easy to reproduce.

Task ID-2390314
PR #62061

Purpose is to have some low level tests for composer itself allowing to
ensure its behavior. We add tests notably about default values computation
in mass mailing mode as well as template_id change and values synchronization
in composer model.

In a near future composer will probably be improved (use computed fields,
rewrite part of its logic to improve performances). Having tests done before
those tasks ensure we notice every change that might happen.

Task ID-2390314
PR odoo/odoo#62061

On the accounting dashboard, for bank and cash journals, we are
displaying the number of items to check. Since commit https://github.com/odoo/enterprise/commit/b2dd65b9a9c054570d5796a81f2c390c4d8cb6c4

,
when getting bank statement data, we are filtering the ones that
are not reconciled using is_reconciled computed field. We should
also include is_reconciled = False when getting dashboard data.

closes odoo/odoo#62150

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Since commit https://github.com/odoo/odoo/commit/3ad4abe171e8e7e86ed0e7b7f000e734d8a2ad92


the default invoicing policy of a product is set to 'delivery'. This is
not ok for the delivery products: a delivery product is never delivered.

This is confusing to end users, because they do not realize that a
delivery line is not included in an invoice. This is especially true if
the delivery is free.

This commit sets the default policy to 'order' for master data and for
newly created products from the shipping form view.

opw-2387437

closes odoo/odoo#62345

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce the bug:

- Let's consider a product P with purchase UOM = Unit
- Let's consider a UOM called Box such as 1 Box = Units
- P is invoiced according to its ordered quantity
- Create a PO for 1 Box of P and confirm it
- Create the bill B from PO

Bug:

The quantity of B was 10 and its UOM was Box

PS: When creating a bill from a PO, by default the quantities on the lines of B are always expected
in the UOM of their respective PO line

Introduced by: https://github.com/odoo/odoo/commit/d0455ae64ba3800c8a13c60c6b68a5638ed5d552



opw:2391243

closes odoo/odoo#62311

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Blocks and Rainy / Airy and Zigs merged together
Fix color of Bold 5 and bold 6 shape that are not easy to use due to contrast
with black, now it is grey by default.

task-2357174

closes odoo/odoo#62338

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before this commit Bold shape 10 & 11 had no transparent color

After this commit Bold shape 10 & 11 have a transparent color instead of
their former color #3 (#F6F6F6)

task-2357174
https://github.com/odoo/odoo/pull/59613

The suspense account created doesn't have the type corresponding to the
domain:

https://github.com/odoo/odoo/blob/658d0fa32f35f4c4f9a1828b11fa383d3dad3b46/addons/account/models/account_journal.py#L97



opw-2387857

closes odoo/odoo#62336

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

What are the steps to reproduce your issue ?

    1. Install 'Manufacture' and enable 'Work Order' in settings
    2. Create product 'ProductA', enable 'Manufacture' in 'Inventory' tab
    3. Create a BOM for 'ProductA'
    4. For that BOM, create a new operation called 'OperationA' with PDF worksheet but don't attach any PDF
    4. Go to 'Manufacture' and create a MO with 'ProductA', the 'OperationA' is automatically set in 'Work Orders'
    5. Start the work order

What is currently happening ?

    When you try to pause, an error is raised.
    'TypeError: Cannot read property 'pdfViewer' of undefined'

What are you expecting to happen ?

    Start and pause the work order even without attached PDF.

Why is this happening ?

    'this.pdfViewer = existing.data('PDFViewerApplication').pdfViewer'
    When there is no pdf attached. The data 'PDFViewerApplication' does not exist.

How to fix the bug ?

    Change worksheet default value to text, and make the field mandatory in case of a PDF type

opw-2387428

closes odoo/odoo#62319

Related: odoo/enterprise#14973
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

task-2392114

closes odoo/odoo#62309

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

task-2387822

closes odoo/odoo#62089

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

closes odoo/odoo#62335

Related: odoo/enterprise#14982
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Before this commit, it was impossible to write to a delegated m2o field
if the length of the recordset was greater than 1.

The reason was because the special case for delegated fields inside
fields.Many2one.convert_to_cache would check for `record.id` which is a
bit misleading, since record can be greater than one.

The solution is to check whether any of the records are real records
instead, as if all of the records are NewRecords, then the parent is a
NewRecord too.

Fixes #62069

closes odoo/odoo#62321

X-original-commit: fd211958
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Adrian Torres (adt) <adt@odoo.com>

Purpose
=======

The goal of this contraint is to prevent employees to take a time off
when he's not supposed to work (example: after the end of his contract).

But, in some conditions (example: we change the contract end date), the
number_of_days is not recomputed, and the constraint is raised
when unlinking the time off.

Move the chunk of code at the validation level, to prevent validating
a time off if the employee is not supposed to work.

closes odoo/odoo#62323

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>