Commit [1] introduced at least 2 linter errors, which this commit is
fixing.

[1]: https://github.com/odoo/odoo/commit/6df67a28c2f113572acd4a3db19ab6b1bd37e7da

Part of https://github.com/odoo/odoo/pull/54311

When building the package list of the APT repository, dpkg-scanpackages
reports the following and only output the latest package information in
the Packages file:

```
dpkg-scanpackages: warning: Packages with multiple instances but no --multiversion specified:
dpkg-scanpackages: warning: ./odoo_13.0.20191002_all.deb
dpkg-scanpackages: warning: ./odoo_13.0.20191003_all.deb
[...]
dpkg-scanpackages: warning: ./odoo_13.0.20200630_all.deb
```

Having only the latest version listed in the Packages file makes it
impossible to tell apt to use a specific version through apt-pinning.
It also makes it impossible to revert to a previous version if a
regression is caused by an update.

For these reasons, tell dpkg-scanpackages to include all versions of the
odoo package in the Packages file it generates.

closes odoo/odoo#54302

X-original-commit: f41c00a8
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

X-original-commit: 05d616d9

The linter would miss / fail to warn on injection of *local variables*
in some cases.

Try to improve it to be stricter and more reliable, after discussion
with odo, sql which is "correctly" dynamic should use psycopg2's sql
package in order to bypass the linter (bonus: it should also properly
escape & quote identifiers).

closes odoo/odoo#53938

Related: odoo/enterprise#11718
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

*: web, web_editor

Instead of three lists + one map to define font information and user
choices saved as the index of the related fonts in those lists, the
fonts are now stored in an unique map <font-name> -> <data> and the
user choices are saved as the font name. This allow to have a visually
better definition of the fonts and allows to reorder fonts in the UI
without losing user customization (and actually simplify some code).

Unfortunately any user font customization < 14.0 will be lost, but this
is a small price to pay (users can still rechoose the same font in the
editor UI where they will go anyway to discover all the new shiny
features we are introducing there).

Part of https://github.com/odoo/odoo/pull/54065


task-2291398

closes odoo/odoo#54065

Related: odoo/design-themes#269
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

*: website

Make sure strings are printed quoted and null values are not printed.

Part of https://github.com/odoo/odoo/pull/54065
task-2291398

This is a huge mistery. But this particular `align-items: baseline`
rule, introduced by [1], yields a red runbot ~20% of the time.

As it is not stricly necessary in current master (but necessary if the
font changes which will be the case in the upcoming days), this commit
simply removes the rule temporarily.

[1]: https://github.com/odoo/odoo/commit/94b59b1972e1a18e18dfcd6c2ded495391380b9a

Part of https://github.com/odoo/odoo/pull/54274



closes odoo/odoo#54274

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

A mockRPC was catching the route to transparent.png file which has been
relocated with [1]. This commit solves that unadapted mockRPC and makes
it easier to grep.

[1]: https://github.com/odoo/odoo/commit/94b59b1972e1a18e18dfcd6c2ded495391380b9a

Part of https://github.com/odoo/odoo/pull/54274

- Seta a value for the `ir.config_parameter` `mail.catchall.domain`
- Enroll user A to a course
- Add new content to the course
- Publish it
  => an email is sent to the users enrolled
- Reply to the email

The reply is considered as a review of the course.

It is not intended that users reply to such email; they are 'one-way'
notifications.

A solution is to be able to set the `reply_to` field on the mail
template. This way, it's possible to set it to a `noreply` value.

opw-2290521

closes odoo/odoo#54281

X-original-commit: 7ffc300e7c857bf743d7ab25631f9ee02419dea1
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

In an app using rating (e.g. eLearning), get 3 ratings:
- A 5-star review
- A 3-star review
- A 0-star review

The average is 2.5 stars, while it should be 4 stars.

This happens because the 0-star review is taken into account in the
average computation, while it shouldn't. Indeed, zero star means no
review.

We apply the same login than:
https://github.com/odoo/odoo/blob/0028a602bea6a48aaa2747127ec075394732b324/addons/rating/models/rating_mixin.py#L205



opw-2290617

closes odoo/odoo#54279

X-original-commit: 4f7981f8
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

There are orm models that don't have _rec_name defined. The orm doesn't
allow creation of record via name_create if _rec_name is not defined in
the model. This commit considers this fact, such that if name_create
returns false, we don't proceed on displaying the non-existing record.

Note: _rec_name defaults to 'name' if not specified so only few models
don't have _rec_name.

closes odoo/odoo#54270

Task-id: 2285036
X-original-commit: 676c2b8e4fdf7347d44bc5afb7ca51d39338a527
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Some demo messages have a grey background because they have the subtype_id set to
NULL.
The subtype should be `mail.mt_comment`, like other messages inside the general channel.

task-2278438

closes odoo/odoo#54261

X-original-commit: 9be1079cc62699d119b9c2acc6282bd72f71f9af
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Debugging/improvement of an at install test may be tedious because of
the need to update the module, spending most of the time checking
tables and xml file.

1. This commit proposes to allow to execute test without installing or
updating a module. The test is still executed during the loading, and
the behavior should be close to an execution of tests during an update.

Co-authored-by rco-odoo <rco@odoo.com>

2. keep previous behavior if -i or -u is given

Three solutions were possible:
- The clean one that changes dev habits.
When test-enable or test_tags is given, all tests are always executed,
a test_tags is needed to select tests to execute:
Example: `-u module --test_enable` becomes `-u module --test-tags /module` to keep the same behaviour
This solution is the simplest, and executed tests does not depends on database already installed modules.
- The conservative solution.
When giving -i or -u, the behavior stays the same as before. When giving test-enable
without -i/-u, test are executed on all installed modules.
- The intermediate solution:
When no test_tags is given but a -i and -u is given, only the given modules are tested.
This is quite close to the second solution except that a -i module on a new database won't
test all dependencies on the first install.

The chosen solution is the second one to minimize changes on dev old habits,
only an almost unused feature is impacted: using test-enable without any -i or -u.
Before this pr only post install tests were executed in this case. Now at_install tests are also executed.
This combination is actually used by runbot to execute post_install test in parallel, but a `--test-tags -at_install`
tag is given so nothing to worry about here.

closes odoo/odoo#53499

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Changing the driver on a car shouldn't change the
fleet.vehicle.log.services associated. We should keep the driver
assigned to the car at the time the service was done.

closes odoo/odoo#54264

Taskid: 2208080
X-original-commit: 5422bb8d6e3db5d6932570116af74ea634c40a51
Signed-off-by: Paul Morelle <madprog@users.noreply.github.com>

When creating a new service on vehicle, the first vehicle was always
selected by default due to a wrong default value. Same thing for the
contract.

Taskid: 2289808
X-original-commit: 9ec3875249748929c4a8e0c8a16e7b729ab9f2d9

The license plate was not shown on the view due to a wrong t-if value.

Taskid: 2289808
X-original-commit: 474322a7f5ee346b4d57b07818fd79801b93f574

Adjacent buttons are not displayed in a single column. When the
table overflows, we try to squeeze largest columns to make it fit
into its container (in this case, text may be clipped and an
ellipsis is displayed). Button columns didn't get away from this.

As a consequence, now that a cell may contain several buttons,
some of them may be clipped and replaced by the ellipsis, which
isn't what we want for buttons.

This commit removes the button columns from the list of columns
to squeeze, so we let the browser reduce them as much as it can,
and we keep them as they are.

Task 2282470

closes odoo/odoo#54258

X-original-commit: e00960daa3ed3d1fd3a7572b2acedd3d2fb0448e
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Edit in backend now redirect to related apps, and no more in website Apps

closes odoo/odoo#54208

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Add the possibility to call services from posmodel. At the moment,
this is needed to call the `iot_longpolling` service from `DeviceProxy`.

closes odoo/odoo#54229

Related: odoo/enterprise#11708
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

closes odoo/odoo#54209

Related: odoo/upgrade#1464
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Go to invoice list view.
Select several invoices, click on 'Send and print', switch template to a
different one (possibly a duplicate of the default).
Send

On each selected record there will be a pair of attachment:
- one belonging the the record (ok)
- one duplicate from the first record selected (not ok)
This occur because when switching template the default composition
mode for the wizard is 'comment' (single send), which causes the wizard
to compute and store the attachment of the first record it found.
Later, this get assigned to the list of attachment to send so it
duplicated (and sent) in all other records

opw-2291274

closes odoo/odoo#54255

X-original-commit: 0028a602
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

with this commit ce0700ce401523267b5a8bd5665a368cfea24912
we lose the compatibility with olders version of Odoo

So we keep the vesion of IoT box in the same place
for olders version of Odoo

closes odoo/odoo#54242

X-original-commit: 0215ff3fd7a353c4f191a1cb93fdce6d0db78fa0
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Before this commit:
In helpdesk_timesheet, we have a compute_task_id with super.
But in hr_timesheet, task_id is not a compute field, so this
compute has no effect.

After this commit:
Task_id is changed to compute stored field.

taskId 2285926

closes odoo/odoo#54117

Related: odoo/enterprise#11682
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Update mail alias layout, makes email address
clickable (mailto) and fix a couple of typos.

Task ID 2287394

closes odoo/odoo#53960

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Prior to this commit, the autoscroll on drag feature was accessible and only
used in the web_editor application.

After this commit, the autoscroll on drag feature will be available in the
web application and has been refactored in order to allow its usage
in other application (as for the sign application).

task-2280965

closes odoo/odoo#54072

Related: odoo/enterprise#11656
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

* Make Connect button primary if the Reconcile button is not shown
primary)
* Rollback the change "Create Manually" > "New Invoice"

closes odoo/odoo#54250

X-original-commit: e50b378520aa7d9674ee3dca169365eeb1ecac85
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: wan <william-andre@users.noreply.github.com>

task-2171877
task-2282377
task-2282382

closes odoo/odoo#54249

X-original-commit: acf8eb3e2e49c1ade638ff1f2fed4969f9944053
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

- Follow button is now correctly aligned in document app chatter overlay
- Topbar does not move up anymore on select Send Message or Log note

task-2287136

closes odoo/odoo#54247

X-original-commit: 6f05705158a7a197945e6720f5ac231ce6932686
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Issue

	- Install eCommerce
	- Modify a product image with one which
	  has more than 1024px width/height to
	  enable zoom (I used: https://bit.ly/2VETQZS

)
	- Go on the website preview & hover the image

	Depending on the screen size, a part of the
	flyout is hidden because of overflow-x
	if you want to see it, you should scroll
	right width right arrow key.

Cause

	The flyout has 100% width and is put
	right (position absolute, left: 100%)

Solution

	To avoid this error on all screen size,
	the solution is to compute the max-width
	of the flyout depending on the available
	space on the right.

OPW-2283648

closes odoo/odoo#54222

X-original-commit: c89b4c25
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

Issue

	- Runbot 13.0
	- Website > Contact Form
	- Double click on send button

	Link dialog opened, ok

	- Discard
	- Double click on send button
	- Click link button

	Traceback

Cause

	The next double click doesn't work
	because in rte.js RTEWidget._onMousedown
	we remove the target's contenteditable
	attribute and it's never added back.

	This is because we break if the element
	is not editable.

	The traceback is a side effect,
	since we can't select the button
	anymore, our selection is incorrect
	and getLinkInfo use range.create()
	try to use it.

Solution

	Break only if the target is not
	a '<a>' & non-editable element

OPW-2268595

closes odoo/odoo#54221

X-original-commit: 460bc102
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

1. set a Sales team and add an alias
2. create a contact (customer) with an email and grant them portal
access (under the action)
3. Odoo creates a portal user
4. use the email of the contact to send an email to the alias set under
the sales team

An opportunity is created but the sales person assign to that
opportunity is the customer.

This will revert user if the user has no access to crm.lead

opw-2288442

closes odoo/odoo#54217

X-original-commit: a3fdff3d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Purpose
=======

https://github.com/odoo/odoo/pull/52351

 already improved the display
by hiding some account properties if it wasn't really neeeded on manual
inventory valuation.

Specification
=============

Keep the Account Properties section visible in any cases. The price
difference account is the only field of the section which is only
used in automated valuation.

closes odoo/odoo#54210

Taskid: 2232026
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

opws: 2269230, 2248760
When a database has a lot of projects with many tasks, and needs
to send a lot of feedback mails, the cron tries to send mails to
all tasks at the same time, thus it times out.

This fix will allow to treat projects one at a time so that when
the cron times out, it will not restart from the beginning.

closes odoo/odoo#53922

X-original-commit: 07c828b4
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Issue

	- Create a content in a course with type "web page"
	- Access it frontend and add a "text - image" block, edit the image as a video - save
	- The video is displayed correctly
	- Go into full-screen

	The video is not displayed at all.

Cause

	The content is added after the page and page widgets are started

Solution

	Trigger the widgets start method

OPW-2290233

closes odoo/odoo#54190

X-original-commit: 0f93240e
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

The idea is to avoid useless SQL request as the searching process is heavy (have to look the word in several field and can be in translation tables).
As we at some point fetch all the searched product we do it at the beginning and use its information to gain performance on other queries.

Execution time in e-shop for "test" on client database (160 000 product with 4500 published):
 - Before: ~ 7 sec
 - After:  ~ 2 sec

OPW-2256662

closes odoo/odoo#54202

X-original-commit: ec743deb
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

- Remove no more used ThreadViewer prop : messageListInitialScrollTop
- Remove no more used ChatWindow prop : threadInitialScrollTop
- Rename ThreadViewer field threadCacheInitialPosition to
  threadCacheInitialScrollPosition
- Use the scroll position to set message list scroll on mounted
- Fix old test which was not simulating correctly home menu show
- Add tests to check that scroll position is correctly saved even if
  ChatWindow is folded
- Fix traceback when showing/hiding home menu with a folded chat window

task-2285691

closes odoo/odoo#54198

X-original-commit: 31123a94c156424b3962fe4aebc3cc60a7a89223
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

*: website

Update the visibility (from dependencies and _computeWidgetVisibility
function) for all widgets, including the ones which are children of main
widgets (e.g. new ability to hide some choices from a select depending
on other options).

closes odoo/odoo#54162

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Before this commit, in a grouped kanban view with sample data (e.g.
crm.lead), one could toggle the 'settings' dropdown menu of a
group, and then drag&drop the group by clicking on the muted "Fold"
item in the dropdown.

After this commit, dragging a column is only possible by clicking
on the column title (but not on the 'config' or '+' icons, nor the
config dropdown).

Task 2290197

closes odoo/odoo#54179

X-original-commit: 58c38a024c96eba3469c142a8422b7bd0ab54ea4
Signed-off-by: Mathieu Duckerts-Antoine <Polymorphe57@users.noreply.github.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Issue

	Chrome

	- Sales > Product
	- Select a file
	- Change something in the file
	- Re-select it

	Nothing changed

Cause

	Chrome doesn't trigger change on
	input if the file is the same

Solution

	Clear the input value after the
	parse_preview so we can load a new
	file even if the preview failed.

OPW-2288191

closes odoo/odoo#54175

X-original-commit: f7d2bdf6
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

The 'inset' checkbox of the shadow option was still displayed for no
reason. A "display: none" inline style was added on it but as inline
style is not considered for editor widgets I don't know how it could
have ever worked.

closes odoo/odoo#54168

X-original-commit: b0de225c721e54b76dcbe49f9769ac371db39c05
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>