Revision on https://github.com/odoo/odoo/commit/a55c78836f172dba1cfa6db3df0e927a9c7e6471



Before this commit, marking all messages as read from Discuss inbox
did not update the UI correctly, hence requiring a page reload.

This bug comes from a typo in the commit above, which passed a list
of mail_notification instead of message ids, so that messages were
handled as marked as read by the web client.

Task-Id 2158452

closes odoo/odoo#43109

X-original-commit: 3cc03ee3db90c310dc60fe7ea18e0e6abe741ffa
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Activate Multicurrency
Create a Journal Entry with default currency (USD)
Save

Error will trigger because of the sql constraint
'check_amount_currency_balance_sign'
The currency_id and company_currency_id are the same while they
shouldn't because company_id should be unset if it is the same as the
company_currency.

Fix to update the error message to let the user know that it's best to
keep the field empty so the company_id would not be set

opw-2169523

closes odoo/odoo#43082

X-original-commit: 6a420921
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:
- install contacts and vat number validation
- setup your company country to "Netherlands"
- go to contacts > add a company > try to add a dutch vat number
 (NL264077921B03)

Previous behavior:
Proper vat numbers are considered unvalid and raise a ValidationError

Current behavior:
Specific check added for dutch vat numbers

Related:
http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken
https://business.gov.nl/regulation/using-checking-vat-numbers/
http://www.pruefziffernberechnung.de/U/USt-IdNr.shtml



opw-2166380

closes odoo/odoo#43081

X-original-commit: b7a82684a311d736dfffd822c2fce8896104b96d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: Nicolas Martinelli <nim@odoo.com>

opw-2169164

closes odoo/odoo#43073

X-original-commit: 5432e24a990885a68df5a691388eb5c3584d9759
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Some library versions are outdated since the release of Debian Buster.

With this commit the required libraries versions will match as close as
possible the versions available in the current Debian stable release
(Buster).

Also, the requirements were tested against a Windows Python 3.7 to
ensure that a "pip install -r" can be used without the need of a CPP
compiler.

As Babel format_time now returns 'HNE' (Heure Normale de l'EST) for Fr
locale instead of the zone offset, the test is adapted.

Finally the babel.dates is explicitely imported, otherwise the proper
import of this submodule is relying on a side effect.

closes odoo/odoo#43106

X-original-commit: 32e455bf
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Fix a mixup between `bounced_msg_id` that is sometimes tought as a list
of string or directly as a string.

Now `bounced_msg_id` is always a list or `False` if there is no bounce.

opw-2157793
closes #43084

closes odoo/odoo#43091

X-original-commit: b0e0cee9
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When accessing stock_barcode module to validate pickings, is not
possible to add floating point quantities for any localizaton which uses
',' as decimal separator.
The numeric field is now defined via browser tags <input="numeric"> to
make the numeric keyboard popup automatically on mobile devices
(commit 8f5840369b28962ab2be9edfce7331a836c3df22)
Adding the override to avoid further processing when the input
is already anumber

opw-2154657

closes odoo/odoo#42748

X-original-commit: 1ccc60deeb067f8d461d48cbf51719317c22cb90
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

This commit reverts a previous fix because we found a better one
in enterprise.
So we don't need this line anymore.

opw-2071605
Task ID: 2152160

closes odoo/odoo#43102

Related: odoo/enterprise#7647
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

The matrix data structure awaited by the server is the following :
{
    question_id: {
        'row_id_1': ['col_id1', ..., 'col_idn'],
        'row_id_n': ['col_id1', ..., 'col_idn'],
        'comment': 'This is a comment',
    }
}

Before this commit, the comment was encapsulated into a dict, into an array,
with an incorrect key :
    -> 'questionId_comment': [{'comment': 'This is a comment'}]

This was leading to 2 errors :
- A traceback when nothing is selected in the matrix options
- Comment is never saved.

After this commit, the comment is correctly given to and extracted by the
server. So the comment is saved and the traceback is avoided.

Task ID: 2152223

closes odoo/odoo#43086

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Aurélien Warnon <awa@odoo.com>

This commit fixes the "back button" that appears when the user is taking the
survey, allowing to go back to previous pages or questions.

There was a typo in the name of the parameter.

Task 2152223

closes odoo/odoo#43003

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

From the PoV of the customer, there is no difference between an
authorized payment and a captured payment; they should get redirected to
the confirmation page in both cases.

closes odoo/odoo#42780

X-original-commit: 45267673
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

closes odoo/odoo#42955

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

This feature has been lost when removing the account.invoice model.

closes odoo/odoo#43060

--task: 2154792
X-original-commit: 7615030f
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

- In a multi currency company, create an invoice with the domestic
  currency ($);
- Add a product (500$) with taxes;
-  Change the currency to a foreign one (€);
- The product don't change of amount but only of currency (500€);
- Save the invoice, and print it.

Before this commit, the base_amount_tax of the tax wasn't be updated.
Note that the base_amount_tax it should be expressed in domestic
currency. As this field didn't update in this case, the base_amount_tax
is expressing the amount in foreign currency. As this amount is supposed
to be in domestic, for the sake of the reports, it's change in currency
of the invoice (in this case the foreign one), and it's shown in the
report. The amount shown is not correct.

Now, the base_amount_tax is recompute and setted in domestic currency.

opw-2157853

closes odoo/odoo#43071

X-original-commit: 226a1155
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

With this commit, we can now say "on preview/selection of a widget,
also preview/selection these other widgets". For this, add a
`data-trigger` with comma-separated widget names.

A `data-trigger-value` can also be used to indicate the values these
other widgets should have during preview/selection... but this currently
only works for colorpicker widgets thanks to a big big hack that should
be improved later.

Part of https://github.com/odoo/odoo/pull/42986



closes odoo/odoo#42986

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

* website

This commit is simply about factorizing the code some more and making
sure the user value widgets always trigger a meaningful 'previewMode'
value.

Part of https://github.com/odoo/odoo/pull/42986

* website

This commit is simply about making the related method public instead of
private (allow to better see the diff in upcoming improvement commits).

Part of https://github.com/odoo/odoo/pull/42986

Instead of triggering three different events 'user_value_change',
'user_value_preview' and 'user_value_reset', user value widgets in the
left panel now trigger only one event: 'user_value_update' with a
'previewMode' parameter being false, true or 'reset'.

This allows to simplify the code.

Part of https://github.com/odoo/odoo/pull/42986

Part of https://github.com/odoo/odoo/pull/42986

closes odoo/odoo#41115

Related: odoo/enterprise#7177
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

_log_next_activity was on stock.rule and should have been
@api.model. So it should rather be on product template but
it's probably not necessary to have a function for it since
it's only used by orderpoint process.

Create RFQ with an order by date in futur. It will allow to
discuss RFQ before validate them and to be in time for the need.

today            Order by         Sheduled date of receipt
|_______________|___________________|_____________________|
days to purchase      vendor LT           security days

Task: 1849912

When the scheduler runs, each orderpoint will check the forecast stock
for an infinite time. As example, if we plan a receipt of 10 products in
4 months and need to deliver 5 products next month, procurement will not
be launched since we have a forecasted quantity of 5.

In order to improve it, the orderpoint will compute the total lead days
from rules, suppliers/production delays, security days,...
Those lead days will be added to today in order to know at which date
the forecast stock should be checked and trigger the replenish document
for today in order to be delivered at the correct date.

Task: 1849912

Currently orderpoint run one request at a time. However it's not
efficient since compute are some private methods could be executed
one time in batch instead of record by record.

The strategy in order to improve it is:
- Still cut the orderpoints in batch of 1000 (usefull when using a new
cursor with intermediate commit)
- For each batch of 1000, create a list of procurement values and run
them in batch (commit a2a6b099 for more info)
- Each time a procurement exception is raised, catch the failing
orderpoint and rollback to the state before run. Remove the failing
order point from the current set and run it again.
- run method try to catch a maximum  errors by continuing to process even it
finds error in order to stack them. It would avoid to run the same set
again and again each time an error is raised.

test_orderpoint_1 took 975s before this patch and 100s after.

Task: 1849912

Currently when a procurement fail it will raise a user error.
Some function as run in stock_rule catch the errors and merge
them in a single error.

Also since commit a2a6b099 procurements
are executed in batch and in some cases, we would like to have more
information about the error. For example in orderpoint we would like to
know which orderpoint is responssible for which error.

It would also be possible to return an object with the details but
procurements pass through a lot of different method that already have
their own return signature and a simple exception is easier to manage.

Task: 1849912

Task: 1849912

Orderpoint reference are only set on the first object that is created
from the procurement request. However sometimes we would like to access
it from further object or define another behavior if we come from an
orderpoint.

Now that the we propagate the orderpoint_id, it's important to ignore
po line with an orderpoint AND a chained stock move, else the quantities
will be counted twice by the orderpoint in a 2 steps receipt scenario

Task: 1849912

- lead_days: number of days to add from today in order to define the
procurement request date.
- lead_type purpose is to define if supplier delays should be added
to procurement request date.

Those fields are problematic with the onboarding. The purpose is to
replace them with an automatic computation.

Task 1849912

Move the code from stock warehouse to its own file.

[MOV] stock: adapt warehouse and orderpoint files

This will be use to make testing of the MiPyme FCE document types

closes odoo/odoo#43080

X-original-commit: 4365bd25
Signed-off-by: Josse Colpaert <jco@openerp.com>

Task:2155803
Closes:42845

closes odoo/odoo#43070

X-original-commit: 2e257032
Signed-off-by: Josse Colpaert <jco@openerp.com>

self-explanatory

opw-2161939

closes odoo/odoo#43059

X-original-commit: 05a198bc
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Before this commit, function _get_payment_type was declared twice in SaleOrder model.

closes odoo/odoo#43044

X-original-commit: 5eb55d04
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Using a lazy translator as this file is processed when loading the web
client, no during rendering (the translation memory was not ready yet).
Turn escFormat into a lazymethod to evaluate it only after translation
resolution.

Fixes odoo/odoo#36494

t push de#

closes odoo/odoo#43038

X-original-commit: 05429ca9
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit, the breadcrumb was lost when user validates an
inventory adjustment. Now, it's not the case anymore.

fixes #41891

closes odoo/odoo#43037

X-original-commit: b557f47f
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

closes odoo/odoo#43035

X-original-commit: f2231b30
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Create an invoice, click on send and print without an associated
template.

Traceback will occur because the lang parameter is set correctly only
from a template. Adding a fallback in case there is no template setting

opw-2168623

closes odoo/odoo#43008

X-original-commit: 8fd8fdcf
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Install stock, go to Configuration>Settings, activate "Storage
Locations". Go to Configuration>Locations select locations and print

The reported will not follow the documentation, barcode will be one
after the other and not side by side, arranged in a 2x2 grid.
Fixing require to apply style changes since new bootstrap
code is not handled well by wkhtmltopdf

opw-2162698

closes odoo/odoo#42967

X-original-commit: 7ac26d0e
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>