Cash flow tags were supplemented and useless and empty tax_ids removed.
Additionally account 7990 had a wrongly tag which was corrected.

closes odoo/odoo#80083

X-original-commit: 9de58fc6
Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#80070

X-original-commit: a0c938c9
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

For German language and for the langauges that use the same decimal separator
(use of comma "," to separate decimal digits and use of point "." to indicate
thousands, millions etc.) the tips pop up in payment screen was displaying an
erroneous initial value: ex. '0.84' was displayed instead of '0,84'. This was
causing a miscalculation of the intented tipping amount. Thus, the tipping
amount had to be inserted manually in every occasion.

Solved it by taking into consideration the decimalSeparator in the NumberPopup.

task-2695104
opw-2677249

closes odoo/odoo#80036

Signed-off-by: Masereel Pierre <pim@odoo.com>

[FIX] sale_timesheet : fixed Credit Notes for Vendor Bills not taken into account in project overview profitability

Reproduce :

- Install modules Purchase, Accounting, Project, Sales Timesheet
- In Accounting settings, activate option Analytic Account
- Create a Project and link it with an Analytic Account
- Create a PO then Vendor Bill with this Analytic Account
- Check the Overview for the Project associated with that Analytic Account
- The amount of the bill will show in the "Other Costs" field of the Profitability section
- Go back and add a Credit Note for the vendor bill

Issue :

- The amount of the PO still shows in the "Other Costs" section, where it is expected to be balanced (zeroed) by the Credit Note.

Solution :

- Don't take into account the Vendor Bills for whioch a Credit Note exists.

opw-2527655

closes odoo/odoo#79925

X-original-commit: c584742a
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Steps to reproduce the issue:

- Install "eCommerce" module
- Create 2 attributes with 'Variants Creation Mode' is Never and
  one of them should have at least 2 values.
- Create a product and add the two attributes as variants and
  one of them should have at least one value
- Go to configure variant and select the first attribute and
  exclude one or more values from the second variant
- Go to the website and change the variant to a value from the one
  you excluded and add to the cart directly (you should be fast).

Issue:

  Product with a not possible combination is added to cart.

Cause:

  Not checking if the combination is possible before adding to cart.

Solution:

  When adding product to cart, if element with class
  ".js_add_cart_variants" is present and have children,
  trigger _getCombinationInfo to retrieve last combination info,
  then add it only if the combination is possible.

opw-2569109

closes odoo/odoo#80025

X-original-commit: 81d99313
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

- Create a partner with 2 bank accounts: BNK1 and BNK2

Wrong flow with vendor bill:
- Create an vendor bill => BNK1 is set by default
- Change BNK1 to BNK2
- Register a payment
=> BNK1 is proposed by default instead of BNK2

Wrong flow with customer invoice:
- Set BNK3 on your company
- Create a customer invoice
- Register a payment
=> BNK1 is suggested instead of BNK3

closes odoo/odoo#79737

Issue: 2683197
Signed-off-by: Olivier Colson <oco@odoo.com>

Before this fix, lines of 'entry' type moves on sale journals would have had their
tax audit string sign reversed.

closes odoo/odoo#80069

Task: 2687215
Signed-off-by: Olivier Colson <oco@odoo.com>

Before this fix, all moves of type “entry“ were considered as misc operations in regard to repartition tags and the tax report. And only moves of type “out_refund” and “in_refund” were considered refunds.
Now reverse entries with sale/purchase taxes get their tags set accordingly to repartition lines.

Account                                    D      C      Tax   Tax Grids
700000 Ventes en Belgique (marchandises)   0      1000   21%   -03
451000 T.V.A. à payer                      0      210          -54
400000 Clients                             1210   0

Was reversed to:
Account                                    D      C      Tax   Tax Grids
700000 Ventes en Belgique (marchandises)   1000   0      21%   -03
451000 T.V.A. à payer                      210    0            -54
400000 Clients                             0      1210

Is now reversed to:
Account                                    D      C      Tax   Tax Grids
700000 Ventes en Belgique (marchandises)   1000   0      21%   +49
451000 T.V.A. à payer                      210    0            +64
400000 Clients                             0      1210

Task: 2687215
Part-of: odoo/odoo#80069

This reverts commit 161eb51f7dcdd0c6ba548b816d63dc0ebd0e6675.

FWD commit was made with wrong message and 2 commits squashed in one.
Changes are reapplied in 2 next commits.

Part-of: odoo/odoo#80069

In some cases, it is not possible to print the order changes

To reproduce the issue:
(Use demo data)
1. Point of Sale > Configuration > Order Printers, edit Kitchen Printer:
    - Printed Product Categories: Food
2. Edit the POS Bar:
    - Enable Order Printer
3. Start a session of POS Bar
4. Open table T1
5. Select a Food product and add a note
6. Submit the order to the kitchen
7. Select again the same product without any note

Error: The order button isn't green, it is not possible to sent the
second order line to the kitchen

The issue comes from the logic used in `computeChanges`:
https://github.com/odoo/odoo/blob/75fb0aa6e9c314b61b30d49b5c463fa126dfc835/addons/pos_restaurant/static/src/js/multiprint.js#L215-L222


`old_res` contains the products already sent to the kitchen
As a result, since the line from step 5 and the one from step 7 have the
same product, we consider that the new line (step 7) was already
present. Then, when comparing the quantities, both lines have their
quantity equal to 1, so we consider there isn't any information that
should be sent to the kitchen

OPW-2557518

closes odoo/odoo#80054

X-original-commit: fae78670
Signed-off-by: Masereel Pierre <pim@odoo.com>

stdout:

stderr:
17:35:39.225044 git.c:344               trace: built-in: git cherry-pick 673a66f5b81b36b2eef21153e2471f8d52bbf147
error: could not apply 673a66f5b81... [FIX] account: remove unused variables
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

closes odoo/odoo#79971

Related: odoo/enterprise#22324
Signed-off-by: Olivier Colson <oco@odoo.com>

A wrong company was used in the Kiosk mode, preventing users to check in
/ out.

closes odoo/odoo#80013

Taskid: 2691031
X-original-commit: ed3003c9
Signed-off-by: Kevin Baptiste <kba@odoo.com>

The packages reservations are not correctly done in case of a backorder

To reproduce the issue:
(Use demo data)
1. In Settings, enable:
    - Delivery Packages
    - Multi-Step Routes
2. Edit the warehouse:
    - Outgoing Shipments: 2 steps
3. In Operations Types > Delivery Order, enable:
    - Show Detailed Operations
    - Move Entire Packages
4. Create a Pick P:
    - 1 x [DESK0004] Desk
    - 1 x Large Cabinet
5. Put each product in a separate pack
6. Validate P
7. Create a Delivery Order (Planned Transfer):
    - 1 x [DESK0004] Desk
    - 1 x Large Cabinet
8. Mark as TODO, Check Availability
9. In Detailed Operations, mark one of the packs as Done
10. Validate the DO, Create a backorder

Error: The not-yet-done pack is still on the delivery order and its
status is "Reserved". This line shouldn't be present anymore. Moreover,
the backorder has a line for this pack, its state is "Draft" (instead of
"Reserved") and the state of the BO is Ready.

When creating the backorder, the packages levels of the not-yet-done
moves are transferred to the new picking (i.e., the backorder) However,
these moves does not have a package level defined (due to
9d758fa2). Therefore, when checking the
packs:
https://github.com/odoo/odoo/blob/e7450bee8f018a5334d9628235824f2fc6f32cec/addons/stock/models/stock_picking.py#L822-L832


`package_level_ids` is empty, so a new `stock.package_level` is created
(instead of using the one of the initial delivery order). And
`move_lines_to_pack` is empty too, so the new `stock.package_level`
won't have any move lines and its state will be "Draft"

We should rather transfer the package levels of the moves' lines.

OPW-2659176
closes #77509

closes odoo/odoo#79999

X-original-commit: 68e96ef4
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>
Co-authored-by: Adrien Widart <awt@odoo.com>
Co-authored-by: Florent de Labarre <florent.mirieu@gmail.com>

[IMP] account_edi,account_edi_extended,l10n_es_edi_sii,l10n_it_edi_sdicoop: improve the ability to debug EDI xml

When using EDI, documents often fail to be submitted to the relevant API. This provides the ability to generate and download the XML

Task-2669041

closes odoo/odoo#79160

Related: odoo/enterprise#21970
Signed-off-by: Laurent Smet <las@openerp.com>

Current behavior:
When creating a BOM with quantity different than 1 (here 12) with operation duration 1 minute and work center capacity 23
The BoM Structure & Cost report only changes the time for the operation when the quantity is > 276
However, when planning a MO the expected duration changes to 2 minutes when the quantity is > 23

Expected behavior:
Expected duration should be the same in the MO and BoM report

Steps to reproduce:
- BOM with quantity different than 1 (here 12)
- operation duration 1 minute
- work center capacity 23
- go in BoM report

closes odoo/odoo#79241

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

closes odoo/odoo#79829

Signed-off-by: Josse Colpaert <jco@openerp.com>

Part-of: odoo/odoo#79829

Most GCC countries are required by law to have invoice reports in both arabic in english

Part-of: odoo/odoo#79829

This commit fixes and improves the suggested width that we compute for
images optimizations.
Before, images displayed outside .container elements were resized to
their container size. As a result logos were resized to 2.5rem (40px).

Now, it handles these scenarios :
- The image is in the navbar, it is a logo
- The image is in a container/container-small
- The image is in a container-fluid
- The image is outside a container

Values are read from the css instead of being hardcoded.

Note: another issue remains with our resizing method. Drawing on a
canvas is not performant enough when there are large differences between
the width and the resize width. A solution could be to use
createImageBitmap for the resize, but it is not supported by enough
browsers.
In the meantime, imageSmoothing was enabled on the context.

Note 2: this also fixes rounding issues when computing the optimized
width which may break the UI update as comparing the integer and
floating value returned false.

task-2506205

closes odoo/odoo#72872

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

- Create sale order with section and note
- Go to Sale Analysis
--> Issue : you see count of section and note

closes odoo/odoo#75545

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

I create a method `_prepare_payment_display_name` for inherit.
When you want to set a new name for payment, you can extend this method.

Exp:
I create a new partner type is `employee` in payment for payment with
employee, but with your old code i can't add the key `outbound-employee`
or `inbound-employee`. So, the system will give an error message.

I think if you add this hook method, it will be good for customizers.

closes odoo/odoo#79804

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Currently, if we print the pricelist report after refresh,
the traceback will occur. It has been fixed.

closes odoo/odoo#73225

Task-id: 2584806
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

When we are syncing Outlook events with Odoo events, there is no need
to call back the Outlook API to patch/delete some events.

closes odoo/odoo#79766

Signed-off-by: Arnaud Joset <arj@odoo.com>

Before this commit, when exporting the FEC report, we were using the account journal
name in the initial language set. As it could be confusing for the French administration
to see names in a foreign language, we should use the user language instead to allow the
export of FEC report in French even if another default language was used.

closes odoo/odoo#79901

X-original-commit: 8ba4b760
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Alex Thuyls (alt) <alt@odoo.com>

In case of m event being removed by a change in recurrence further change is then only applied on the existing events and not all past events

closes odoo/odoo#79872

Signed-off-by: Arnaud Joset <arj@odoo.com>

In multi steps configurations, the additional products of a MO could be
missing in the associated picking

To reproduce the issue:
(Use demo data)
1. In Settings, enable "Multi-Step Routes"
2. Update the current warehouse:
    - Manufacture: 2 steps
3. Create a MO for product "Table Top"
4. Edit the MO:
    - Add 1 x Screw in the components
5. Confirm the MO
6. Open the generated Picking

Error: The operations only contains one line for "Wood Panel". There
should be a second line for the "Screw"

When adding the new component, a new stock move is created but the
latter does not have any `group_id` defined. This is the reason why the
generated picking does not include this stock move.

OPW-2671995

closes odoo/odoo#79828

X-original-commit: 57b3364f
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Browse product.product outside of for loop in
inventory_line.create to cache the results and
speedup the product.product_tmpl_id.uom_id.id line.

Replace search_count in for loop in
inventory_line._check_no_duplicate_line by a read_group call.

Add a small test for _check_no_duplicate_line just to be
safe.

opw-2655357

closes odoo/odoo#79587

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Revert signature name change from #78161

closes odoo/odoo#79821

Signed-off-by: Arnaud Joset <arj@odoo.com>

Make microsoft calendar test case time insensitive

closes odoo/odoo#79769

Signed-off-by: Arnaud Joset <arj@odoo.com>

- Get a database with millions of files in the checklist (do not ask how
  this happened)
- Set a cron timeout low enough so that `autovacuum_job` times out

The file GC will endlessly timeout without being able to delete any
file.

This is due to how the `_file_gc` method is built: we first build the
whole whitelist, then we perform the deletion. With millions of
checklist files, the loop which builds the `whitelist` takes ages. It
ultimately leads to a timeout of the scheduled action, and therefore no
file is deleted.

To avoid this, we delete the files progressively. The checklist is split
in chunks, and we check which files must be GC'd in a given checklist
chunk. This way the files are removed even in case of timeout, meaning
that there will be less files to check during the next run. Eventually
the GC won't timeout anymore.

closes odoo/odoo#79807

X-original-commit: dbae5247
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

We introduced a tour for email marketing (see commit[1]) which has one
important step, that asks user to create a new Mailing. However, the
selector for this step is generic, which makes the tour bubble appear
on every other installed app's create button (on the kanban view).

This commit fixes the issue by providing the extra_trigger as
`oe_kanban_mass_mailing` for that particular step, and
thus targeting the button only for the kanban view of the mailing.

Note: Email Marketing and SMS Marketing shares the same kanban view, so
they both will have this tour.

commit[1] - c15f9efe

TaskID-2583760

closes odoo/odoo#72966

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

This PR addresses issue #68761. The issue describes a bug
that results in a field not being automatically updated.

closes odoo/odoo#68766

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When changing any option in Settings, the option "Show Detailed
Operations" of almost all operations types will be enabled

To reproduce the issue:
(Use demo data)
1. Open the Operation Type "YourCompany: Delivery Orders" and ensure
"Show Detailed Operations" is unchecked
2. In Settings, enable an option (e.g., "Default Access Rights")
3. Go back to the form of "YourCompany: Delivery Orders"

Error: "Show Detailed Operations" is checked for no reason

With this commit, "Show Detailed Operations" of almost all operations
types will be directly enabled only if one of the three options (Lots &
Serial Numbers, Storage Locations or Packages) is enabled and none of
these options was enabled before.

OPW-2514993

closes odoo/odoo#79778

X-original-commit: 6f7e9a93
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

On Fifo costing method, the 'value' field of a stock quant was computed using quantity_svl and value_svl of the product_id.
However the method 'with_company()' wasn't used for quantity_svl, resulting in an incorrect 'value' field of stock.quant

This commit add the use of 'with_company()' method to get quantity_svl.

OPW-2652211

closes odoo/odoo#79735

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

There were some usability issues with the popup when a video was
inserted inside it:
- The video would be playing before the popup is shown and the user
  would thus miss part of that video (potentially a lot, depending of
  the set popup delay).
- The video would continue to play in the background after closing the
  popup.

task-2251203

closes odoo/odoo#63634

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: Siddarth Gajjar <sga@odoo.com>

Before this commit, if you add a background video in a popup, the video
frame will not setup properly because the _adjustIframe function cannot
find wrapperWidth and its ratio.

After this commit, _adjustIframe will be called again once the popup
is opened.

task-2251203

Part-of: odoo/odoo#63634
Co-authored-by: qsm-odoo <qsm@odoo.com>

When a backorder is created, the quantities are not reserved. This is an
issue: the module should try to directly assign these quantities.

(Revert of 6b15eab7)

OPW-2658469

closes odoo/odoo#79692

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

task-2345098

closes odoo/odoo#59611

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

The whatsapp sharer was fixed via [1]. This uses https for all sharers
and fix the pinterest one using the logo image with their new API.

[1]: https://github.com/odoo/odoo/commit/62575b75ff48a34df23f8742737226949f13c13c



closes odoo/odoo#53191

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: jpr-odoo <jpr@openerp.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>

When detecting if the assets where already preprocessed, the method
only the last asset type matching was returned and deleted.
In standard, it should not have any impact as all assets are of the
same type but it may be possible to mix it with external modules.

Sign CLA

closes odoo/odoo#79755

X-original-commit: 3a98996e
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>