Improve 06188f61

The user does not have the possibility to create a delivery to the
inter-warehouse transit location (the destination location is
invisible). Same for the receipt.

So, the user should only avoid transferring some products between two
warehouses if the internal transfer is a planned one.

closes odoo/odoo#87797

X-original-commit: 09fd3867
Signed-off-by: Arnold Moyaux <arm@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Demo data to improve the flow of testing the edi. A bank account and a
partner with a street/city/zipcode/codice fiscale are required for the
edi, so having these as demo data is useful.
The demo company vat code and codice fiscale are also changed to those
of a valid company, so that they will be accepted by the sdi testing
environment. The address of the demo company is updated so that, if by
accident, an invoice is sent using the demo company, through the
official channel, the address will make it an obvious test.

closes odoo/odoo#87249

Task-id: 2809328
Signed-off-by: Josse Colpaert <jco@odoo.com>

Open a activity view(record modal), that will show records, clicking on the
'o_activity_btn' of a record will show dropdown and make sure that there are
many scheduled activity there .

Before this commit:

The dropdown was bigger than the record modal which had a scroll bar. It was not
scrollable properly and "+ Schedule Activity" button is not accessible.

After this commit:

The dropdown follows the scroll, and it will be possible to click the button.

Task- 2528111

closes odoo/odoo#72441

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

In a subcontracting flow, the extra_cost on the subcontracted production
is read on the purchase line (via _get_price_unit() ) at the production
creation. In case the price unit on this purchase line change before the
validation, the stock valuation layer linked to the production will not
take this new value into account.

This commit ensures the price unit is the right one at validation

closes odoo/odoo#87689

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

On large databases, the method `_compute_new_application_count` could
take up to 80% of the total loading time of the Job positions as each
job was generating 2 queries.

closes odoo/odoo#87745

Taskid: 2812400
X-original-commit: aa3abd22
Signed-off-by: Kevin Baptiste <kba@odoo.com>

This commit removes the multilang feature on the /web/login/totp controller,
it doesn't really add value since it triggers a redirect and that the page is
all the same translated.

It is a good practice by default for SEO, but in this case it brings
some bug with the IOS apps that doesn't follow the redirect, while we don't
need to optimize this page for Search Engine.

The bug into the IOS apps, create a loop when we request the totp screen.
    Device request /web/login/totp
    Server ask a redirect to /fr_FR/web/login/totp
    Device redirect to /web/login/totp
    Server ask a redirect to /fr_FR/web/login/totp
    ...

closes odoo/odoo#87740

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

closes odoo/odoo#87580

X-original-commit: 288b5460
Signed-off-by: Olivier Colson <oco@odoo.com>

Task: 2760136

Currently, when a credit note is created there is a message in the chatter "Invoice created", which is not coherent.
- Credit Note creation message should be "Credit Note created"

closes odoo/odoo#84526

Signed-off-by: Olivier Colson <oco@odoo.com>

When using an internal transfer to move some products between two
warehouses, the forecasted inventory becomes incorrect

To reproduce the issue:
(Let WH01 be the existing warehouse)
1. In Settings, enable "Multi-Warehouses"
2. Create a second warehouse WH02
3. Create a storable product P
4. Update its quantity: 1 x P at WH01/Stock
5. Create a planned internal transfer (the warehouse does not matter):
    - Source: WH01/Stock
    - Destination: WH02/Stock
    - Operations:
        - 1 x P
6. Mark the transfer as Todo
7. Consult the Forecasted Inventory report:
    - Filters:
        - Forecasted Stock
        - Product: P
    - Group By:
        - Warehouse

Error: The line for WH02 is missing and the line for WH01 is incorrect
(qty is 1 for next days while it should be 0)

The report used (`report_stock_quantity`) does not handle this transfer.
Because both locations (source and destination) are defined, the SM is
not considered as an in-move or out-move:
https://github.com/odoo/odoo/blob/07f0ffad6ecc08f4165902db45ae96e4b41199e8/addons/stock/report/report_stock_quantity.py#L38-L43


Moreover, it would be hard to change the SQL view to generate two lines
(one 'in' and one 'out') from the same SM (the internal move).

The graph on the forecasted report of product P is also incorrect (it
uses `report_stock_quantity` to get the data, so if the user selects a
specific warehouse in the filters, the result will be incorrect)

To easy all computations, the user should rather use two pickings
(delivery+receipt) when moving some products between two warehouses.

OPW-2752017

closes odoo/odoo#87642

X-original-commit: 06188f61
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

task-2783076

closes odoo/odoo#85809

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Italian translation added.

Add string parameter to the fields so that the filter names are more
usable. Since the filter names are taken automatically from the field
names, the string paramter allows us to change the filter names:
L10N It Edi Transaction -> FatturaPA Transaction
L10N It Edi Attachment  -> FatturaPA Attachment
L10N It Send State      -> FatturaPA Send State

closes odoo/odoo#87478

Task-id: 2795241
Signed-off-by: Josse Colpaert <jco@odoo.com>

Before this commit: we assumed an event's recurrence only contains
RRULE, and we were getting the RRULE from the first element in the
list. But it could have EXRULE, RDATE, and EXDATE, so in this case,
the first element could be other items.

The solution is to iterate through all items and return the RRULE.

opw-2797968

closes odoo/odoo#87559

Signed-off-by: Arnaud Joset <arj@odoo.com>

closes odoo/odoo#86315

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Current behavior :
When you delete a record (for example project.task), all the messages related
to this record aren't deleted.
This, in case a user has his notifications managed in Odoo, may prevent him
from accessing the History tab in the Discuss app because these messages are
linked to a record that doesn't exist anymore and it will raise a Missing Record
error

Steps :
*with demo data*
- Install Project
- Make Marc Demo notifications managed in Odoo
- Delete a task project to which Marc Demo is assigned
(*with Marc Demo*)
- Go to Discuss and try to access History tab

OPW-2764855

closes odoo/odoo#87608

X-original-commit: e928ae79
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Claude Thibault (thcl) <thcl@odoo.com>

closes odoo/odoo#87421

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

When entering a date in a datetime field, it will be in the format
`08/01/2022 00:00:00`. If we place our cursor at the end of the
entry (after the hour) and each time we press enter, the timezone
offset is applied (so if offset is +1 it does +1 hour each time)

opw-2754116

closes odoo/odoo#87584

Signed-off-by: Achraf <abz@odoo.com>

Steps to reproduce the bug:
1:/
- Give user access to Marc Demo
- Connect with Marc
- Go to any product
- The "update cost" button is visible

Problem:
Marc can modify the cost, whereas normally only users with manager rights can modify the product

2:/
- remove MRP access to Marc Demo
- connect with Marc
- Go to any product with variant and BOM > variants > then open any variant

Problem:
The user could Compute Price from BoM, while he does not have manager access to MRP

opw-2794179

closes odoo/odoo#87441

X-original-commit: 42898874
Signed-off-by: Arnold Moyaux <arm@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Not all company needs a French TVA number but still needs to provide
FEC file.
Improve that by making the TVA number optional, allowing to export the
FEC file without it. The only difference is that in such case, the vat
number won't be appended to the file name.

Task id #2801629

closes odoo/odoo#87556

X-original-commit: 5ccf115d
Signed-off-by: Olivier Colson <oco@odoo.com>
Signed-off-by: Nicolas Viseur <vin@odoo.com>

Steps to reproduce

  - Install procurement_jit
  - Go to settings
  - Search for 'serv'
  -> Re**serv**ation is highlighted but also ba**se**d

closes odoo/odoo#87550

X-original-commit: 7b52c632
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

Steps to follow

  - Go to Settings
  - Type 'Import' in the search bar
  -> 'Import & Export' is displayed

Cause of the issue

  `_wordHighlighter` works on the HTML as a string

Solution

  - Use textContent to get the correct text value
  - Replace the content of the highlighted element by
    * a textnode with the text before the matched substring
    * a `span.highlighter` with the search word
    * a textnode with the text after the matcher substring

Other issues

  A string concatanated css rule was used to filter the matching elements
  This could cause an invalid selector
  -> Filter nodes by their textContent instead.

opw-2778304

X-original-commit: d7a439f2
Part-of: odoo/odoo#87550

Steps to reproduce the bug:
- Install mrp_landed_costs
- Connect as Admin
- Remove MRP access to Admin and Give him Stock manager access
- Go to inventory settings > Enable “Landed costs”
- Go to inventory > operation > Select any landed cost
- Try to validate

Problem:
An access error is triggered because we check if there are finished moves in the associated pickings and manufacturing orders
before validating the landed cost, but in the "_get_targeted_move_ids" function we access the "mrp_production_ids" field, which is reserved for mrp users.

Solution:
Creating and validating a landed cost is a feature for stock manager users.
We can therefore have users who do not need access to MRP, but who need to  validate and submit landed costs.
So we can give access to all of them even if they are not MRP users.

opw-2800367

closes odoo/odoo#87361

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Change actions to act_window

closes odoo/odoo#87425

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

To reproduce
============

- Sync Google Calendar to Odoo
- Create an event in GCaledar without setting a notification
In Odoo Notification reminder is set

Purpose
=======

we use default reminder given by Google which is notification 30 minutes before even if the event
doesn't have a reminder.

Specification
=============

To solve the issue we use empty reminder instead of the default given by google if no reminder is set.

opw-2792364

closes odoo/odoo#87069

Signed-off-by: Arnaud Joset <arj@odoo.com>

Purpose
=======
As it has been done for Gmail, we want to add the OAuth authentication
for the incoming / outgoing mail server.

Specifications
==============
The user has to create a project on Outlook and fill the credentials
in Odoo. Once it's done, he can create an incoming / outgoing mail
server.

For the authentication flow is a bit different from Gmail. For Outlook
the user is redirected to Outlook where he'll accept the permission.
Once it's done, he's redirected again to the mail server form view and
the tokens are automatically added on the mail server.

Technical
=========
There are 3 tokens used for the OAuth authentication.
1. The authentication code. This one is only used to get the refresh
   token and the first access token. It's the code returned by the user
   browser during the authentication flow.
2. The refresh token. This one will never change once the user is
   authenticated. This token is used to get new access token once they
   are expired.
3. The access token. Those tokens have an expiration date (1 hour) and
   are used in the XOAUTH2 protocol to authenticate the IMAP / SMTP
   connection.

During the authentication process, we can also give a state that will
be returned by the user browser. This state contains
1. The model and the ID of the mail server (as the same mixin manage
   both incoming and outgoing mail server)
2. A CSRF token which sign those values and is verified once the browser
   redirect the user to the Odoo database. This is useful so a malicious
   user can not send a link to an admin to disconnect the mail server.

Task-2751996

closes odoo/odoo#87498

Forward-port-of: odoo/odoo#87294
Forward-port-of: odoo/odoo#87040
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose
=======
As it has been done for Gmail, we want to add the OAuth authentication
for the incoming / outgoing mail server.

Specifications
==============
The user has to create a project on Outlook and fill the credentials
in Odoo. Once it's done, he can create an incoming / outgoing mail
server.

For the authentication flow is a bit different from Gmail. For Outlook
the user is redirected to Outlook where he'll accept the permission.
Once it's done, he's redirected again to the mail server form view and
the tokens are automatically added on the mail server.

Technical
=========
There are 3 tokens used for the OAuth authentication.
1. The authentication code. This one is only used to get the refresh
   token and the first access token. It's the code returned by the user
   browser during the authentication flow.
2. The refresh token. This one will never change once the user is
   authenticated. This token is used to get new access token once they
   are expired.
3. The access token. Those tokens have an expiration date (1 hour) and
   are used in the XOAUTH2 protocol to authenticate the IMAP / SMTP
   connection.

During the authentication process, we can also give a state that will
be returned by the user browser. This state contains
1. The model and the ID of the mail server (as the same mixin manage
   both incoming and outgoing mail server)
2. A CSRF token which sign those values and is verified once the browser
   redirect the user to the Odoo database. This is useful so a malicious
   user can not send a link to an admin to disconnect the mail server.

Task-2751996

X-original-commit: e54d63b3c0f39fd8a05e430442cf84d1d6c8de78
Part-of: odoo/odoo#87498

Purpose
=======
Do not reset the email configuration when unchecking "is Gmail".

Task-2751996

Part-of: odoo/odoo#87498

Bug
===
When we copy a GMail outgoing / incoming mail server, an error
occurs because we try to refetch the access token, based on the same
authorization code (which can be used only once).

To fix this issue, we do not copy the authorization code (and other
related fields).

Task-2751996

X-original-commit: 2879976160bc0777cde1368ed2b69ce821c85ff1
Part-of: odoo/odoo#87498

Steps to reproduce the bug:
1:/
- Create a new MO:
    - Select any product
    - Delete all components
    - Add a work order
    - Save
- Cancel the MO

Problem:
The work order is not cancelled because when we cancel a MO without components,
we only change the status of the MO but do not check if there are WOs to cancel

2:/
when the MO is cancelled, the buttons ('start', 'Pause', 'block' and 'Done') must be hidden

opw-2803052

closes odoo/odoo#87528

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Currently stat button on crm.lead form view still shows page views count of
archived visitor records. This is not coherent with the action performed
when clicking which filters out archived records.

We now correctly count only active visitors page count.

closes odoo/odoo#87447

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#87320

Signed-off-by: Raphael Collet <rco@odoo.com>

Fixes a mistake from 0c468f6c where the uom
autocompletion was lost and adds a test to make sure it won't happen again.

closes odoo/odoo#87495

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Reproduce:
* Create default analytic rules
* Create a quotation/sale order.

Before:
Default analytic rules were not added on sales orders, like they are on
invoices and purchase orders.

After:
Same behavior on all documents.

This behavior was mistakenly removed during a refactoring:
https://github.com/odoo/odoo/commit/3c67bb20feb42f16799b7491411e213b818c4f83



opw-2800936

closes odoo/odoo#87073

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

On a SO, the delivered quantity of a dropshipped kit is incorrect in
case of a return

To reproduce the issue:
1. Activate Dropshipping
2. Create 3 products: KIT AB, A, B:
    - All have the Dropship route and a supplier set
3. Create a BOM of type kit: KIT AB is composed of A & B
4. Create a SO for 1 unit of KIT AB, validate
5. Validate the created PO
6. Deliver the products
7. Create a return for these products
    - Error: On the SO, the delivered quantity is 0 but the return is
not validated yet. This quantity should still be 1
8. Validate the return
    - Error: On the SO, the delivered quantity is now 1, it should be 0

The 'all or nothing' policy should correctly consider the returns: all
moves (to customer) must be done and the returns must be delivered back
to the customer

OPW-2759250

closes odoo/odoo#87180

Signed-off-by: Tiffany Chang <tic@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Test 52d5ff23

Part-of: odoo/odoo#87180

There has been a change in the code for the state_id for Mexico City. Since the beginning of 2022, the new code is CMX instead of DIF.

opw-2801208

closes odoo/odoo#87398

X-original-commit: fd72db46
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Desausoi Laurent (lade) <lade@odoo.com>

Steps to follow

  - Go to the Sales app
  - Search for a entry with a space at the end
  -> No results are returned

The search input should be trimmed, it was in 13.0

opw-2803156

closes odoo/odoo#87383

Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

Have 3 moves named 0, 1 and 2
Delete move 1 to make a hole.
Resequence, starting the sequence at 2.

Expected: new names are 2 and 3

Result: an error because 1 is renamed to 2 but 2 still exists, leading
to a (temporary) duplicated name, which is not allowed.

We clear all the names to be resequenced before doing it in order to
avoid that.

closes odoo/odoo#80986

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

when we are using the sharable support page (url : "/im_livechat/support/"),
There is no "visitor left" message sent to the operator when any visitor left
the channel.
Ideally, when any visitor left the channel from the website or the support page
should notify the operator that "Visitor has left the conversation".

With this commit, the operator will get notified every time when visitor left
the conversation from anywhere.

Task-2210040

closes odoo/odoo#87349

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Have a Reconciliation model [DEMO] without tax
Create a bank statement
Open reconciliation widget
Select 'Manual Operation', select [DEMO], add any tax

Traceback will raise
This occur because the server will generate a line without `tax_ids`
field, that will remain undefined in the frontend

opw-2777191

closes odoo/odoo#86061

Signed-off-by: Quentin De Paoli <qdp@odoo.com>