This commit addresses several issues:

1. The overwrite of `_recompute_completion` was not properly filtering
the partners that had actually completed the course. meaning that
passing through this function could add a course/slide.channel as an
employee skill iven if they did not complete it. Now, we only act upon
employees that have actually finished the course.

2. The function would add the same skill over and over again, assuming
that we could only pass through it once but it is actually called every
time we publish or archive any slide of a course since 9920f20e.
This can lead to a bit of bloat on an employee resume  (See task
attachments). Now, we try to make the function idempotent and only add a
resumé line only once.

3. The addition of a resume line could not be achieved and would raise
an ACL when the current user was not an HR Officer (group `hr_user`).
Since it can be called by any eLearning(`slides`) manager, a sudo
privilege is necessary.

Related Task: 2830016

closes odoo/odoo#93555

Signed-off-by: Kevin Baptiste <kba@odoo.com>

The condition to display the start event warning in the track view was that
the event was not ongoing. This fix adds the condition that the event is
upcoming, preventing the warning to be displayed after the event date.

Task-2692907

closes odoo/odoo#90948

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

This reverts commit 3e877d31.

closes odoo/odoo#94006

Signed-off-by: Julien Castiaux <juc@odoo.com>

Before this commit, with a website using multiple languages, when sharing
any links with a language other than the original language on Facebook,
the content of Optimize SEO always receives the value of the default
language.

The reason is that `og:url` does not change according to the
language of the website because it's using `http.httprequest.url`.

Note that `http.httprequest.url` doesn't contain the lang part since we
already went through the dispatch's rerouting.
So we need to localize `og:url` to fix this.

Steps to reproduce:
1. Set up 2 different languages for your website (e.g. English, Vietnamese).
 Set the default language for the website to English.
2. Create any page, promote seo page for both languages.
3. Share this link on Facebook with Vietnamese language, see the title
and description on preview are still in English.

closes odoo/odoo#93937

X-original-commit: 3e718971
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

closes odoo/odoo#93891

X-original-commit: 7e2e92dd
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

When adjusting the currency rates, the amounts in the edi invoice become
incorrect and the Italian EDI system rejects them (due to contraints on
the content of these fields).

This commit changes the referenced amount to the 'amount_currency' (for
the taxes and the base) for the fields in the EDI templates.

closes odoo/odoo#93927

Signed-off-by: Josse Colpaert <jco@odoo.com>

closes odoo/odoo#93921

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This commit aims at unifying the UBL formats for invoices and credit notes.

Starting from the work of LAS, the module account_edi_ubl_cii contains the templates for UBL and CII,
and provides inheritance for UBL: UBL 2.0 < UBL 2.1 < UBL Bis 3.
It contains also the formats E-FFF, EHF3 (fully covered by Bis 3), XRechnung (in UBL), Factur-x (the only one in CII).
All these formats are also improved to pass the ecosio validator and/or the country specific validator
(for Factur-x: the validator from the FNFE, and Chorus Pro).

Note that the xml files generated contain the pdf of the invoice/credit note encoded in base64.
An xml file alone imported in Odoo will thus automatically retrieve the pdf.

Before generating the xml files, we now also check a series of known constraints and possibly display
a warning on top of the move view if some are not enforced (the xml file is generated anyway but it might not be valid).

Tests were required: a new module was needed with dependency to the tested l10n: l10n_account_edi_ubl_cii_tests.
The prefix "l10n_" prevents runbot from launching the tests everytime.

Backport of: https://github.com/odoo/odoo/pull/88027



closes odoo/odoo#83849

Task: 2628093
Signed-off-by: Laurent Smet <las@odoo.com>

To fix problems with lost payments in Adyen we add loggers

closes odoo/odoo#93902

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Steps to reproduce:
- Create a partner-individual, assign to a company
- Create an invoice and set the new partner as the customer
- Go to the partner view
- Delete it

Issue:
- It is possible to delete it

Cause:
The constraint in "account.move.line" uses the "commercial_partner_id" as the partner

Solution:
- Prevent the unlink if the partner is used in 'account.move' -> To delete in Master
- add "ondelete='restrict' for partner and commercial_parner in 'account.move'

opw-2858789

closes odoo/odoo#93854

X-original-commit: e0f75f73
Signed-off-by: William André (wan) <wan@odoo.com>

Website has no dependency to web_unsplash, we cannot warranty the order
of the execution of the overwrite done in 5ef8300c.
So to avoid to create a new module bridge, with a lot of code, we prefer
to make a check for website user directly in unsplash module.
It is 'safe' since if you don't have website, the group
`group_website_designer` doesn't exists and so it will do a `or False`.

closes odoo/odoo#93842

X-original-commit: 05f9f5db
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Avoid leaks in case of exception.

closes odoo/odoo#93570

X-original-commit: eb579c3dcbc8ae5793e609e215162ebd710db6dc
Signed-off-by: Christophe Simonis <chs@odoo.com>

The call to `commit()` can fail during the flush of the environment
and raise an exception before the actual `COMMIT;`, leaving the
cursor unclosed.

This leaked cursor may hold locks that only be released when the GC
collects it. On low-traffic workers like the CronWorker, this can
lock usual database usages.

X-original-commit: 3b489a1ec0644b4656afa64d6ae869836b98125a
Part-of: odoo/odoo#93570

The text for "Invited portal users and all internal users" in the project
privacy_visibility tooltip is not accurate.

This commit rephrases it.

Follow-up of https://github.com/odoo/odoo/pull/92897



closes odoo/odoo#93822

X-original-commit: 6d417ed3
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Signed-off-by: Larcin Vincent (vila) <vila@odoo.com>

Before this commit, the link "Manage Databases" was present in the
/web/reset_password screen, even if it is disabled.

Fixes odoo/odoo#93678

closes odoo/odoo#93679

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Add a new module that makes three new fields available on the invoices.
These fields are required when using facturx to send invoices to
public services through Chorus PRO.

The original template is updated to make it easier when integrating
the ubl refactoring coming soon, and avoid template issues that would
happen with an inherit if the inheriting module isn't updated after the
refactoring deployment.

opw-2714544

closes odoo/odoo#92954

Signed-off-by: Laurent Smet <las@odoo.com>

Purpose
=======
The Indian government updated its UOM code
https://einvoice1.gst.gov.in/Others/MasterCodes

 (select UQC Codes)

So In this commit, I have updated `l10n_in_code` in UOM Liters, Meter, Cubic Inch
and Cubic Foot.

closes odoo/odoo#93186

Signed-off-by: Quentin De Paoli <qdp@odoo.com>

The project privacy_visibility tooltip doesn't reflect the actual behavior
for the "Invited portal users and all internal users" selection.

This commit rephrases the tooltip of that field in order to correctly match its behavior.
It also slightly changes the name of the options to match the new tooltip.

Task-2871771

closes odoo/odoo#93737

X-original-commit: 74e61dc3
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

After opening the configurator wizard in "edit" mode (through the pencil
icon shown next to the product in edit mode), if you clicked either on
the "Cancel" button or on the "X" to leave/close the wizard,
the product was reset on the SOline.

Cancelling a modification should keep the state before the modification and
not reset the line.

This is a regression from the behavior in saas-12.3.

closes odoo/odoo#93607

X-original-commit: 0f0d3a20
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Steps to follow

  - Go to Sales > Reporting > Sales
  - Switch to the pivot view
  - Click on the Measures button
  - Reduce the vertical height of the browser
  - The dropdown entries are not scrollable

opw-2855411

closes odoo/odoo#93716

X-original-commit: 2d4a4009
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

The alt of images can be displayed slightly after the programatic
scroll which means the scroll height we set and the one we assert
are slightly different (the client height have changed). In order
to solve this issue, all alt attributes are replaed by data-alt
during tests.

closes odoo/odoo#93677

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

This fix profitability total report while using partial refund on customer/vendor invoices.

To reproduce this issue:
* enable Analytic Accounting
* create a billable project
* create an invoice and link to the analytic account and post it (ie: 33 items at $ 10/unit $ 330 HT)
* generate a partial refund and change quantities (ie: from 33 to 3 units => $ 30HT)
* check account analytic lines are correct (get 2 lines +330 - 30 => $ 300)
* go to the project overview and check other revenues and Total Profitability

Before this commit total is $ 0
After this commit total is invoiced amount - refund amount ($ 300)

Fixes #93564

closes odoo/odoo#93593

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Part-of: odoo/odoo#93593

(i.e. orden de compra, guia de despacho) if they are enabled

closes odoo/odoo#93664

Signed-off-by: Josse Colpaert <jco@odoo.com>

*: website

Before this commit the "Thanks" button of the newsletter block could be
saved as visible. This meant that a visitor who did not subscribe to the
newsletter would see the "Thanks" button on loading before it
disappeared. This commit solves this problem by:
1. hiding the "Thanks" button before saving
2. having an option to show/hide the "Thanks" button in edit mode
3. hiding the "Thanks" button before switching to edit mode

Steps to reproduce the fixed bug:
 - Drop a newsletter block.
 - Save and register to the newsletter.
 - Edit
 - Change anything in the newsletter block.
 - Save and Logout.
 - Now the Thanks button appears and disappears when the page is loaded

opw-2802139

closes odoo/odoo#91539

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When using the newsletter block but the "google_recaptcha" is not
installed, the user is spammed by the notification that proposes to
install this module. Every time an option is modified on the block, the
notification appears, even if it's just a preview of the option. This
commit ensures that the user will only be notified once per edition if
they do not have the reCaptcha installed.

opw-2802139

Part-of: odoo/odoo#91539

Homepage was never considered as canonical due to the trailing /
domain.com/fr/ != domain.com/fr

Now _get_canonical_url_localized for homepage is fixed.

Remove all computation related to canonical that is usless for connected
user. It is mainly used for SEO tools/bots/crawler.

Initially planed for 13.0 with [1] but reverted with [2].

[1]: https://github.com/odoo/odoo/commit/33167b3928c767a08fdc7eedc3e6204aac9cac08
[2]: https://github.com/odoo/odoo/commit/deb23450f18196c7f8d9e819db603fccd407b82a



closes odoo/odoo#93191

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce the bug:
- Enable the `Multi-Step Routes` option in the settings
- Go to inventory > warehouses > Select 2-step manufacturing
- Go to inventory overview > Click on Manufacturing
- Create a MO > confirm
- Go to the created picking

Problem:
The state is “ready” instead of “waiting” because the picking is
created in immediate transfer:
https://github.com/odoo/odoo/blob/fd6aa428ce7b7ab03ba920b1c020f5862f56f731/addons/stock/models/stock_picking.py#L137

So when we compute the state, as the picking is in immediate transfer
and the “stock.move” is confirmed, the picking status will be
`assigned`('ready')

https://github.com/odoo/odoo/blob/8c4819882011ba6bbeefe97931a26a96e60d38a3/addons/stock/models/stock_picking.py#L431



Solution:
No need to call `get_action` function to fill the context,
we can return the action directly

opw-2876050

closes odoo/odoo#93400

X-original-commit: 64f00fd4
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Steps to reproduce:

- Delivery module is installed.
- User_1 is stock_manager and sale_manager.
- User_1 creates sale_order with set carrier_id and confirms it
  (Automatically is created a picking P).
- User_2 is stock user/manager but in sale is "Own documents only".
- User_2 open picking P and validates it.
  => Error: cannot validate due to access rules.

closes odoo/odoo#93447

X-original-commit: 3955d48c
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

[REV] l10n_nl: set 'Cost of Revenue' in allowed account types for Vendor Bills journal created for a l10n_nl chart of account

This reverts commit f4235243.

This commit introduced an unwanted effect, by using the
`type_control_ids` to allow an account type on a journal.

But it was intended as a constraint, to limit the account types
allowed on the journal and exclude all the others.

In this case, by allowing the type of the account
`data_account_type_direct_costs`, it also excluded all other
account types on the Vendor Bill journal.

closes odoo/odoo#93608

Signed-off-by: William André (wan) <wan@odoo.com>

For the kanban_activity view (e.g.: in the CRM module), when we have enough
entries to require the scrolling, dropdowns are not displayed at the correct
location.
Furthermore, in kanban views, when dropdowns are opening on the edge of the
parent element (e.g.: in Documents), the dropdowns are partially hidden and not
accessible by the client.

Step to reproduce the issue:
1) Install CRM and Documents module
2) Go to CRM and create multiple leads with at least one activity
3) Go to the Activity view and scroll down and click on an item. The dropdown
is not placed at the correct location -> BUG 1
4) Go to the Documents modules and check the activity (the small clock icon)
of a Document on the right most column. The dropdown is hidden by the
description of the file.

Solution: Firstly, the parent container of the Kanban Activity view did not had
the `overflow: auto` property activated. Consequently, while the children were
somehow taking all the spaces of the screen, Popper (the third party that
handles the dynamic positioning of the dropdowns) was wrongly computing the
positionning.
Secondly, dynamically creating the dropdown via Javascript (through the
JQueryInterface of the Dropdown class in Bootstrap) somehow allows to fix the
issue in Documents. Consequently, it is important to keep them into the
Javascript and not move the arguments into the XML.

opw-2827873

closes odoo/odoo#91209

Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

Some mail client send wrong content-type charset for attachments,
advertising US-ASCCI instead of UTF-8. Using `get_content()` with no
argument, python replaces the incorrect bytes by tofu (the black "?"
character).

In this commit, if the given charset is invalid, we fallback on utf-8
replacing the still incorrect characters by tofu.

closes odoo/odoo#93305

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The Customer Invoices and Vendor Bills bar graphs in the accounting
dashboard skip empty weeks so the following weeks will be displayed
sooner

Steps to reproduce:
1. Install Accounting
2. Go to the accounting dashboard
3. The bar graph of Customer Invoices is not correct: it ends with empty
weeks but they should be in between the data

Solution:
Choose where each query result should be by using the aggr_date to find
in which week the data is included

Problem:
The SQL query didn't return any date for empty weeks so sorting the
result by date would leave some weeks out of the bar graph

opw-2844159

closes odoo/odoo#93527

X-original-commit: 2743d8f3
Signed-off-by: Cedric Snauwaert <csn@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

When purchase is returned, the product may move to internal location first. If
option `Update quantities on SO/PO` is active, it does decrease the qty.
However, when the option is disabled, it increase the qty instead of doing
nothing.

Fix it by making a proper if-else block structure

STEPS:

- Create a PO, confirm it and receive the product
- On the transfer, make a return to a location that is not a child of your warehouse (PhysicalLocations/W/...), for instance, choose the location Physical Locations/Subcontracting Location
- Untick the "Update quantities on SO/PO" (visible in debug), and validate the return transfer
- Check your initial PO

BEFORE: the received quantities have been updated, even if we asked not to do it
AFTER: the received quantities is not changed

opw-2858390

closes odoo/odoo#93394

X-original-commit: eb16b4ec
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Ivan Elizaryev (iel) <iel@odoo.com>

Steps to reproduce the bug:
- Install rental app
- Go to the sales settings and enable the “discount” option
- Create a new rental order
- add 3 products and one of them must be rentable
- save
- edit the rental date of the rentable product

Problem:
A wizard that asks to apply the discount to all lines is displayed,
while we have not changed the discount field

since this commit:
https://github.com/odoo/enterprise/pull/25874/commits/c934267a17e7df71f7a129c0b4cb51f56e1efe93#diff-60c63f93d325ddf63bde80d039a8805fe69b7eea99fbb87e5769178f3fc0fd93R19

when the date is modified, the discount field is reset to 0
in the modified line to avoid applying the pricelist.

Then, we check that the discount field has been modified to call
the function that creates the wizard:
https://github.com/odoo/odoo/blob/696ea173d3f6cb1230444c34d6f19bc4519fda04/addons/sale/static/src/js/product_discount_widget.js#L26-L27

and as all lines have the same discount "0", the popup will be
displayed: https://github.com/odoo/odoo/blob/696ea173d3f6cb1230444c34d6f19bc4519fda04/addons/sale/static/src/js/sale_order_view.js#L30



Solution:
Check that the first order line discount has been changed before
displaying the wizard

opw-2844932

closes odoo/odoo#93134

Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Foreign companies that trade with non-enterprises in the EU may have a VATIN starting with "EU" instead of a country code.

Currently, the user is facing a traceback in this situation since stdnum doesn't have any format method for vat number starting with 'EU'.

closes odoo/odoo#93463

Ticket: 2877716
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

   no need to make rounding during computing qty_available

   STEPS (see the test):

     - create product with uom dozens
     - create product with uom units
     - create bom kit to convert one to another
     - set qty on hand to 1 for product dozens
     - check qty for product units

opw-2849397

closes odoo/odoo#92985

X-original-commit: 83afc178
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

If a user has a website.track with a product from another company than
the one he is currently using, an access rule error will popup.

Several scenarios can trigger this error, but the easiest one would be:

- Activate recently viewed products in the e-commerce.
- Create a product and publish it.
- The portal user visits it and a website.track linked to that product
is created.
- From backend, change the company of the product to one that is
unreachable for the portal user or the website environment he is in.
- Now when the portal user visits another product, an error will show up
warning about the unability to load the recently viewed product.

So only products in the context of the request should be loaded as
recently viewed.

TT36698

closes odoo/odoo#93399

X-original-commit: 0e54d3db
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Fixes a bug introduced by this commit : https://github.com/odoo/odoo/commit/aba9ef6a27eca5f70ab7be87a929846988710048

The problem was that once the type_control_ids were activated,
it would always raise an error due to the journal's default_account_id.

This issue was raised by a community member in this PR : https://github.com/odoo/odoo/pull/92390



A test is also included to prevent having the same issue in the future.

closes odoo/odoo#93395

Signed-off-by: Laurent Smet <las@odoo.com>