Skip to content
Snippets Groups Projects
  1. Sep 18, 2018
  2. Sep 17, 2018
    • Christophe Simonis's avatar
    • ThanhDodeurOdoo's avatar
      [REF] mail: update related_attachment_count field name to match mixin namespace. · 389cb3e8
      ThanhDodeurOdoo authored
      Reason: The Attachment count of mail_thread is used by the new
      attachment button of the chatter, the compute field has been chosen
      over a search_count JS RPC to keep a synchronous chatter and prevent
      flickering.
      
      This commit refactors those changes to follow the naming
      conventions of mail_thread and to optimize the count method for
      eventual reuse follwing TDE's advices.
      
      - Changed the name of a mail_thread's related_attachment_count into
      message_attachment_count.
      
      - Changed the count method to a read_group.
      
      PR: 26989
      Task: 1860031
      389cb3e8
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
      0942a57b
    • Christophe Simonis's avatar
    • Alexandre Kühn's avatar
      [FIX] mail: counter color green in community · 7075142b
      Alexandre Kühn authored
      It was blue over blue with the change of the navbar.
      Before the navbar change, it was blue over black.
      
      To avoid blue over blue, counter is now green, so that
      it is green over blue.
      7075142b
    • Alexandre Kühn's avatar
      [FIX] web_tour: place tooltip above dropdown-menu · 81bce622
      Alexandre Kühn authored
      Before this commit, a tip on a dropdown menu item was visible.
      
      This is due to the positioning of the tip, which was on the
      dropdown-menu (because it has overflow `auto`). The tip was
      appended on the dropdown-menu, and may overflow as a result.
      
      This commit handles specifically the case of dropdown-menu,
      so that dropdown-menu is never a candidate for the placement
      of the tip.
      81bce622
    • Alexandre Kühn's avatar
      [FIX] *: adapt tours for the new community navbar · 38c7ed3c
      Alexandre Kühn authored
      *: crm,
         hr_expense,
         hr_recruitment,
         point_of_sale,
         project,
         sale,
         stock,
         web_tour,
         test_main_flows,
         test_new_api
      
      To sum up:
      - Click on "Apps Menu" then the app item.
        (previously: click on '+' then the app item).
      - Click on navbar section menu item.
        (previously: click on sidebar section menu item).
      38c7ed3c
    • Alexandre Kühn's avatar
      [IMP] web: new navbar in community · 19eacf7d
      Alexandre Kühn authored
      The navbar in community now looks more like the navbar in enterprise.
      
      Here is a sum-up of the changes in community:
      
      - The navbar in community is now in blue, instead of black.
      - No more app list that almost fills the whole navbar: there is
        now an "Apps Menu" in the left-most side of the navbar.
      - No more sidebar for the menus inside an app: those menus are
        now located in the middle part of the navbar.
      
      The navbar in community does not support mobile (< 768px width),
      but it should still somewhat usable on most mobile devices.
      As for the website navbar, it has been unchanged and should still
      support mobile layout.
      
      Task-ID 1878649
      19eacf7d
    • Joseph Caburnay's avatar
      [FIX] point_of_sale: toggle the checkbox correctly. · 5da419a4
      Joseph Caburnay authored
      Clicking the config labels don't toggle the checkboxes, instead show
      dropbox menus (at the upper left screen) for the hidden field when
      the checkbox is inactive. This modification toggles checkboxes correctly.
      
      OPW 1884452
      5da419a4
    • David Beguin's avatar
      [IMP] im_livechat : Fix livechat session and operator reports · 110d37a3
      David Beguin authored
      Session Statistics : To keep only the operators, add a join to
      im_livechat_channel_im_user that keeps the link between who is the operator
      for which channel.
      
      Operator Report : To keep only the users that have really participated
      to the channel, add a join to mail_channel_partner_table that keeps the link
      between who participate to which channel.
      
      The report are only taking into account current operators.
      If, on a livechat channel, an operator is removed and another user is
      set as operator for ths channel. this new operator will have the stats
      of the removed operator. This will stay like this until we add a field
      that records who is the operator at the time the discussion. This field
      should be added on mail_channel_partner table and should be a role.
      So if a user is no more operator, he will still be flagged as operator of
      this particular discussion.
      
      Task ID 1883227
      closes PR #26995
      110d37a3
    • David Beguin's avatar
      [IMP] website_livechat : improves statistics design · 84dfbcc4
      David Beguin authored
      The statistic bar size is now related to the value of the rating
      + Adds small modififications to align correctly the different divs
      + harmonize icons size
      + show white icon for readability
      + Add inline padding to team member icon for readability
      (inline because this part will be completelly reviewed in next version)
      
      Task ID 1883227
      84dfbcc4
    • David Beguin's avatar
      [IMP] im_livechat : adds some design improvements in form and list views · 7ad1d354
      David Beguin authored
      More and more people are using the Live Chat and complaining about it
      because it's not user friendly. This commit modifies a bit the design
      of the form and list view without changing the functionnality
      
      Improves im_livechat.channel kanban cards
      
      Improves the channel form view:
      Introduce tabs to manage the different aspect of the channel :
      Operators, Options, Widget, Rules
      
      Improves the session tree view:
      Sort by date desc, adds the number of messages per session
      and replace the rating last value by his corresponding icon.
      
      Improves livechat session form view:
      Introduce a kanban view that list all the messages of the session
      
      Improves livechat session rating view:
      For congruence inside the module, renaming 'Resource' group By filter
      into 'Code' as the rating resource_name in this case is the same as
      the session code. So we use the same terms in this view and in reports
      
      Task ID 1883227
      7ad1d354
    • Aaron Bohy's avatar
      [FIX] web: datepicker: correctly use lib · c63630d4
      Aaron Bohy authored
      The datepicker lib has been updated to tempus dominus (BS4)
      recently, but our code hasn't been adapted correctly to the
      requirements of the new version of the lib. As a consequence,
      the datepicker didn't close itself when the input was focused
      out anymore.
      
      This required a slight change in the DomainSelector widget as it
      produced a crash when a focused datepicker widget is removed from
      the DOM (before the datepicker is destroyed), e.g. by a call to
      html() on one of its parent.
      
      Task 1878254
      c63630d4
    • Alexandre Kühn's avatar
      [FIX] web, website: root.widget defined even without website · a6516c35
      Alexandre Kühn authored
      Revision on https://github.com/odoo/odoo/commit/0de5c1f076d7e7d0e5361e08c810c727bd41d9e0
      
      With the commit above, the following error was shown in the devtools
      when accessing a frontend page without website that is installed:
      
        missing module "[root.widget]"
      
      This is caused by the fact that there is no root widget in the frontend
      bundle without website installed. This may prevent executing tours
      in some cases, because the tour manager needs a root widget to run.
      
      This commit solves this issue by ensuring a root widget in the frontend
      even when website is not installed, so that tour manager can run.
      a6516c35
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
      b28f705b
    • Gert Pellin - GPE's avatar
      [FIX] point_of_sale: deactivate price change on switch from admin on price control (#26994) · 5dba2b6e
      Gert Pellin - GPE authored
      Usecase:
      * Activate price control on point of sale.
      * In pos session, as administrator, activate pricechange modus.
      * switch to normal user.
      
      Before fix normal user can change the price.
      After fix the modus will automatically switch to quantity.
      Unverified
      5dba2b6e
    • Christophe Simonis's avatar
      69af1df7
    • Gert Pellin's avatar
      [IMP] hr,mail: auto-subscribe departments to channels · 76a557c9
      Gert Pellin authored
      
      Purpose of this commit is to allow to make private channels linked to
      an HR department with an auto subscription.
      
      It will ease the use of discussion channels among employees of a given
      department. Moreover auto subscription is useful to avoid having to
      manually synchronize channel members and department members.
      
      This commit is linked to task ID 1848526 and closes PR #26650 .
      
      Co-authored-by: default avatarGert Pellin <gpe@odoo.com>
      Co-authored-by: default avatarRichard Mathot <rim@odoo.com>
      76a557c9
    • Thibault Delavallée's avatar
      [IMP] base: make demo user lie in the same tz as administrator · 261c72e8
      Thibault Delavallée authored
      Purpose is to have coherent demo data.
      261c72e8
    • RomainLibert's avatar
      [IMP] crm, website_sale: change create date of demo datas · 61f249a4
      RomainLibert authored
      In order to have some data to display in the dashboard views, we need to
      set the create_date of the crm.lead and sale.order so that they are not
      all created today.
      
      We can now set the create date directly in the demo data, so we remove
      the hack that was previously used in website_sale
      61f249a4
    • Nicolas Martinelli's avatar
      [FIX] report_intrastat: delivery address · 034e1d37
      Nicolas Martinelli authored
      Complement of commit d5b46020, applied to the generic
      Intrastat report.
      
      opw-1878590
      034e1d37
    • Aaron Bohy's avatar
      [FIX] web: x2Many: remove deadlock situation · 8993d6ff
      Aaron Bohy authored
      This rev. is similar to db9b91ff, but treats the x2many case.
      Calls to the 'commitChange' function of renderers must not be done
      inside a mutex, mainly since 24170453, as they could end up in a
      deadlock. For x2manys, it was actually the case in practice in
      Inventory > Operations > Inventory Adjustments > Create > select
      'One product only' > select a product > try to edit the real
      quantity in the editable list > focusout > deadlock.
      
      The reason why the deadlock occurred in this view and not in, e.g.
      sale.order, is due to the presence of the field_float_scannable
      widget. Indeed, the barcode engine intercepts input events and
      manually re-triggers them. As a consequence, the 'change' event is
      not triggered on the field, and it does not notify the environment
      of its new value by itself, until the field x2many asks it to
      commit its value. Note that this might be an issue as well, as
      onchanges are thus not triggered.
      
      Task 1878254
      8993d6ff
    • Aaron Bohy's avatar
      [FIX] web: navigate in editable list with custom controls · 4393e48f
      Aaron Bohy authored
      Rev. f2414414 recently added the possibiliy to define custom
      controls (instead of the single  'Add a line') in editable list
      views. However, it didn't take into account keyboard navigation.
      
      Suppose that the focus is on the field preceeding the list, and
      the user clicks on TAB, the code assumed that there was only one
      control, and focused it. However, when there were several control,
      the last one was focused (which is typically the less common one),
      and there was no way to navigate to the others.
      
      This rev. focuses the first control by default, and allows to
      navigate through controls with RIGHT and LEFT. Pressing TAB still
      moves out of the list, to the next field.
      
      Note that i'm not happy with this fix, as the logic doesn't seem
      to be in the right place. Indeed, the notion of controls is the
      concern of the editable list, not the x2many field, so the list
      should handle this logic by itself. Unfortenately, this is not that
      easy to change, as for now the list doesn't even know that we are
      navigating to/from its control(s), until we click on it/them.
      Changing that will be for later, in master.
      
      We also did a linting pass on the concerned code.
      
      Task 1878254
      4393e48f
    • Rémi Rahir's avatar
      0354579c
    • sri-odoo's avatar
      [REF] web, *: redesign login screens · b78b9c87
      sri-odoo authored
      * auth_signup, auth_oauth
      b78b9c87
    • Martin Trigaux's avatar
      [FIX] sale_timesheet: translate correctly labels · 2c7db142
      Martin Trigaux authored
      Introduced at 7081a55c
      
      opw-1884812
      Unverified
      2c7db142
    • Christophe Simonis's avatar
      [FIX] base: mark enterprise modules as uninstallable · 4e85ca8a
      Christophe Simonis authored
      There are actually uninstallable until enterprise is present in
      addons-path.
      The state will be reset by the "Update module list" process.
      4e85ca8a
    • Xavier Morel's avatar
      [FIX] web: remove bootstrap sourceMappingURL · 8e17223c
      Xavier Morel authored
      We're not shipping the sourcemap files, and while the assets minifier
      strips out the mappings they're getting hit in debug=assets which is
      bot useless and problematic when running odoo-bin without a proxy for
      static folders: if sourcemaps are enabled (which is apparently the
      default in all browsers if devtools are opened at this point) the
      browser tries to fetch the sourcemap, which does through the
      SharedDataMiddleware which doesn't find them and passes the query on
      to the regular Application which goes through the entire dispatch &
      NotFound process.
      
      If website is installed, that process ends up rendering website.404,
      which can be pretty costly until everything is properly cached:
      
          # initial request
          "GET /web/static/lib/bootstrap/js/index.js.map HTTP/1.1" 404 - 319 0.198 0.954
          # a few requests later
          "GET /web/static/lib/bootstrap/js/index.js.map HTTP/1.1" 404 - 27 0.022 0.060
      
      And the way sourcemaps are fetched (might be headers, might be the
      stampede as browsers will try to fetch a dozen sourcemaps as fast as
      possible) seems to make this problem much, much worse: instead of 300+
      the requests take 800+ queries each, multiple seconds, and requests
      get worse as time goes on (didn't investigate the exact reason for
      that) *and* they apparently don't ever get cached (at least they don't
      after half a dozen reloads of the client).
      8e17223c
Loading