When the browser is zoomed, the value of the `border-width` CSS
properties obtained through `getComputedStyle` are impacted by the
zoom. Because of this, entering a "10px" border in a Chrome zoomed at
125% turns it into "9.6px" when leaving the input field.

This commit neutralizes the zoom effect by rounding the value up.
The rounding operation was empirically determined by observing values,
see table below.

When zoomed out this does not always work: e.g. at 50% zoom, a value
of 11px becomes 10px. But zooming out is an unxpected use case, that
situation is therefore not handled by this fix.

Observed values of the border-width property:
Set value => `getComputedStyle`
```
Value  Chrome 125%  Firefox 120%
  1px        0.8px     0.83333px
  2px        1.6px     1.66667px
  3px        2.4px     2.50000px
  4px        4.0px     3.33333px
  5px        4.8px     5.00000px
  6px        5.6px     5.83333px
  7px        6.4px     6.66667px
  8px        8.0px     7.50000px
  9px        8.8px     8.33333px
 10px        9.6px    10.00000px
 11px       10.4px    10.83333px
 12px       12.0px    11.66667px
```

Steps to reproduce:
- Drop a "Text - Image" block.
- Select the text column.
- Zoom with ctrl+mouse wheel or ctrl-plus.
- Set a 10px border.
- Leave input field.

=> Border option field displayed a different size.

task-3172235

closes odoo/odoo#125068

X-original-commit: 6398b0c7
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Issue:
------
When we have the link to the form to apply for a job,
even if the job is not published, we can still apply.

Solution:
---------
Check that the job is published before the creation of the record
in the `website_form_input_filter`.

opw-3331717

closes odoo/odoo#124987

X-original-commit: 508f373f
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>

Steps to reproduce the bug:
- Install mrp_plm
- Create a BoM with an analytic account
- Create an ECO
- Start the revision

Problem:
The new BoM version doesn't have the analytic account from the original
one.

opw-3329901

closes odoo/odoo#124841

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

New rows added with TAB in a table were missing a <br> in each cell,
making them appear less tall.

task-2858455 for v16.0
task-3315657 for v15.0

closes odoo/odoo#121624

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

After creating a sales order for a product with cost 0, automatic
inventory valuation and AVCO, and validating the delivery, no account
move is created for the stock move. If an invoice is then created from
the sales order, it will create 0 amount COGS lines. Automatic
reconciliation of the invoice with the corresponding stock account move
will fail because no such entry exists, resulting in unreconciled lines
remaining in the invoices.

This issue can be prevented by either creating a 0 amount journal entry
for the stock move, or preventing the creation of the 0 amount COGS
lines on the invoice. Not creating unnecessary COGS lines is preferable
and this was also the solution used for the same problem with purchase
order invoices: https://github.com/odoo/odoo/pull/106785

 .

So this fix does the same for sales order invoices.

opw-3000320

closes odoo/odoo#125002

X-original-commit: 5de5023d
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Merel Geens <mege@odoo.com>

closes odoo/odoo#123936

Signed-off-by: Josse Colpaert <jco@odoo.com>

Steps to reproduce:
-------------------
- activate "Count Extra Hours" in Attendances settings;
- create attendances for an employee to create an overtime
(select one day of the weekend for example);
- create an Extra Hours type leave for this employee;
- remove the attendance that creates extra hours;

The extra hours of the employee is negative

- refuse the leave created before;

Issue:
------
A Validation Error occurs with the message:
"The employee does not have enough extra hours to extend this leave.".

Solution:
---------
Refuse leave based on extra hours
should not require any control
because we are not trying to extend leave.

opw-3342778

closes odoo/odoo#124219

Signed-off-by: Kevin Baptiste <kba@odoo.com>

The ZATCA edi has an onboarding process which happens per journal.
A private key is generated for the company and with the data from
the company and journal a CSR is made to get a certificate to sign the
invoices.  In that process that contains multiple steps (see account_journal.py),
we also have to send the compliance files which are some example (simplified or not)
invoices/debit and credit notes.  We have a separate folder with those files
and also use them in the tests.  For the onboarding, they still need to be signed however.

For the sending of the customer invoices themselves, UBL 2.1 is used, but
with ZATCA style adaptations.  That is why we inherit from that class
to be able to add those specific adaptations.  This UBL needs to be
signed XadeS and in this case we need to do the hash with the sign information
present but with empty tags.

For ZATCA invoices, as is the case with Ticketbai, the previous hash is needed
for the next invoice and is stored per journal.  (so we have a chain of hashes)

Tests written by Simon (smdc)

closes odoo/odoo#106212

Signed-off-by: Josse Colpaert <jco@odoo.com>

For SA, we need to be able to filter on the taxes exported, as
certain taxes should simply not be reported in the UBL.

Part-of: odoo/odoo#106212

Part-of: odoo/odoo#106212

+ provide a better demo VAT number

Part-of: odoo/odoo#106212

Steps to reproduce:
1) Have Barcode Installed and have Barcode Nomenclature set
2) edit 1st rule(Price Barcodes 2 Decimals) to type Quantity
3) Create a product with barcode 2380201000008
4) Open POS and scan barcode 2380201010007

Bug:
error popup product not found because the callback for this rule
is not set

Fix:
apply same callback as weight (set product quantity)

opw-3213595

closes odoo/odoo#124705

X-original-commit: 36459d26
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

During the forward port of [1] into [2], the call to the asynchronous
version of `mode` inside `start` was lost.

This commit restores that change.

[1]: https://github.com/odoo/odoo/commit/2814c84e78e68e277973b44408a7ba7965f178ae
[2]: https://github.com/odoo/odoo/commit/10779fe5911209d6b6a11c1690a212ab6e4e93f7



task-2990053

closes odoo/odoo#124699

Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>

odoo/odoo#122354 added this test but didn't handle that other models
might trigger systray activities.

On June 12th, the test started failing because calendar has a "Pricing
Discussion" demo calendar event on the 12th of every month. It
probably would have also failed on the 3rd and 22nd which both have
demo meetings for the admin.

Fix by looking up specifically activities of the test model we're
concerned with.

closes odoo/odoo#124600

X-original-commit: 54dce61e
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

This commit changes the way the we-many2one and we-many2many fields work
so that they check if the model they are attached to has a website_id
field, if so, the data loaded from the model will be that related to the
current website.

After this commit, developers can get rid of the website_id field when
they add a many2X field. The domain will be automatically computed.

task-3316278

closes odoo/odoo#121107

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

We added a new method to identify if the current pos.order.line can be discounted
in a global discount, fromt he pos_discount, module.

This in order to be inherited from third ones.

closes odoo/odoo#123208

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

There are some inconsistencies in price between the original record and tax document due to rounding. This issue is now mitigated by having a more accurate decimal place rounding

3019692

closes odoo/odoo#110068

Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

Steps to reproduce:
-------------------
Create leave for an employee on today's date
with a type of leave that does not require
a second approval.
Approve the leave.

Issue:
------
Employee is not absent today.

Cause:
------
The filter waits until the `state` field
is set to `validate1`.
However, the leave has a `state` field
with a value equals to `validate`.

Solution:
---------
The "Absent Today" filter must use `state` field
equals to `validate`.

opw-3339589

closes odoo/odoo#124639

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Steps to reproduce on fresh 15.0:
Connected as Admin:
1. Install l10n_lu_peppol_id,
2. Modify the field 'edi_format_ids'
on a journal (here will be on customer invoices)
to the value 'Peppol BIS Billing 3.0'
3. Invoice a product using this journal and confirm it.
> The XML will be generated and attached to the move.
The mimetype of this attachement will be application/xml

If you do the same step 3 with a user that does not have
the write access right to the model ir_ui_view
(see _check_contents in base), the attachment will be
of type text/plain.

The issue that this trigger, is that the email going out
will have the wrong Content-Type for the attachments.
Which will lead to incorrect management on other provider.

We can bypass the security here as the XML is generated
by Odoo.

opw-3263542

closes odoo/odoo#124507

Signed-off-by: William André (wan) <wan@odoo.com>

Description of the issue/feature this PR addresses:
Before SII resolution 46 from 2022, the only documents for foreign vendors were 110 111, and 112.
After that, SII and accountants are indicated as a practice to issue purchase invoices (Factura
de compra 46) to foreign vendors in order to pay the vat taxes, mainly for digital services.

Current behavior before PR:
It is not allowed by validation restrictions to issue this document type to foreign vendors

Desired behavior after PR is merged:
the validation release the restriction for document type 46

closes odoo/odoo#124379

X-original-commit: ee2485fd
Signed-off-by: Josse Colpaert <jco@odoo.com>
Co-authored-by: Daniel Blanco <daniel@blancomartin.cl>
Co-authored-by: José Moreno Hanshing <jose@blancomartin.cl>

This commit permits to enlarge the answer textarea in the forum.

Steps to reproduce the "issue" resolved by this commit:
- Go to /forum
- Click on a thread
- Click on "Answer"

=> The textarea is too small to write a long answer.

task-2865782

closes odoo/odoo#124590

X-original-commit: https://github.com/odoo/odoo/commit/d5c985e8f2afcdac766e756a1f045c6229a59f1e


Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Dieleman Guillaume (gdi) <gdi@odoo.com>

In the website forum, we checked that the post content is not empty
before posting a post or an answer. Before this commit, it was just a
verification that the content is not an empty string.
Users are also able to post an image and we want to allow them to create
a post or an answer with only an image. This commit changes the
verification to check if the content is empty or if it only contains
images.

Steps to reproduce the issue resolved by this commit:
- Go to the website forum
- Create a new post
- Set a title
- Add an image as description
- Click on "Post Your Question"

=> The post is not created because the content is considered as empty.

task-2865782

X-original-commit: https://github.com/odoo/odoo/commit/2c409278a3d2d67efddebfe71b36a612b2ecb971
Part-of: odoo/odoo#124590

Steps to reproduce:
1. Create Indian Company Database
2. Install Accounting module, Install one more app " Indian - UPI " 
3. Go to Setting > General Settings > Company information update > fill details in "UPI Id" field with 7874353637@paytm

Issue
Create and confirm vendor bill and Print the same at a bottom you will see QR code of our company UPI id.

And we don't want the qr-code to be printed on a bill.

opw-3284324

closes odoo/odoo#123859

Signed-off-by: Josse Colpaert <jco@odoo.com>

Previously, when copy-pasting HTML with styles on styleable tags, those
styles could still be removed by the editor if they had a default value.
This was supposed to be a way to keep the DOM clean and lighter.

However, styles with default values still serve a purpose when
overriding non-default values inherited by their parents. Therefore,
removing them was a conceptual mistake.

One example in the editor where this purpose can be served is in
tables where spans can override the style of the cell or parent span.

This commit ensures we no longer remove style attributes because of
their default value.

Task-3332955

closes odoo/odoo#121862

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

When we create a journal and it gets one of the payment method's value as
False and we input another payment method. it will give an error with the
 message -

'sequence item 0: expected str instance, bool found'

Steps to Produce:-

1. Go to Accounting then configuration
2. Click on 'Journals' under Accounting
3. Create or click on exiting one
4. Input all required fields and select 'Type' as Cash or Bank
5. Delete value of one of either incoming payments or outgoing payments
6. Click on save
7. Remove name of one of the payment method and input other

Trace-back will be generated.

Applying these changes will resolve this issue.

closes odoo/odoo#119787

Signed-off-by: Laurent Smet <las@odoo.com>

TypeError: expected string or bytes-like object

This error occurs when the 'url_from' field is left empty during website rewrite
To reproduce this issue, follow these steps:
1. go to website ->  configuration -> redirects
2. create a new record -> select 308 redirect / rewrite in action
3.  keep 'url from' empty and put any value in 'url to' such as '/'
4.  Click on the save button, and this error message will be displayed.

After applying this commit will fix this issue.

task-3346588

sentry-4229658026

closes odoo/odoo#124510

X-original-commit: 26fa923f
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

The revision dd3f918c
introduced a regression:
it was no longer possible to set an icon in the import module,
and if no icon is provided,
the icon should fall back to the base module icon,
which wasn't the case either.

In this last case, it even leaded to a crash:
```
File "/home/odoo/src/14.0/odoo/odoo/addons/base/models/ir_module.py", line 251, in _get_icon_image
    with tools.file_open(path, 'rb') as image_file:
  File "/home/odoo/src/14.0/odoo/odoo/tools/misc.py", line 176, in file_open
    return _fileopen(name, mode=mode, basedir=base, pathinfo=pathinfo, basename=basename, filter_ext=filter_ext)
  File "/home/odoo/src/14.0/odoo/odoo/tools/misc.py", line 211, in _fileopen
    raise ValueError("Unknown path: %s" % name)
Exception
ValueError: Unknown path: /base/static/description/icon.png
```

opw-3340652

closes odoo/odoo#124471

X-original-commit: 77939849
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

*: web_editor

During the masonry layout calculation of the images wall snippet, the
image height is used to determine into which column each image is
inserted. Their height is zero until they are actually loaded. Because
of this, the column into which an image is inserted can be wrong.

This becomes more obvious in 16.0 because since [1] the image selection
is lost when moving it within an Image Wall because it is replaced by a
clone when using masonry mode.

This commit makes sure that the images are loaded before taking their
height into account when building the masonry layout.

This involves two changes:

1. By awaiting `wUtils.onceAllImagesLoaded(this.$target)` after the
insertion of each cloned image, we are sure that the reached height of
each column is available before deciding where to insert the next image.

2. Before re-selecting the previously selected image, we need to be
sure that it is loaded. Therefore we keep track of the last masonry
layout operation and await for it. This way, we rely on the await of
the last image as described in point 1.

Additionally, as of 16.0, there is a race condition with
`snippet_option_update`: in some situations, `notify` is called before
`snippet_option_update` is completed, and before the masonry layout is
applied.  To make sure it is completed, the whole notify is run within
the mutex through a `snippet_edition_request` event.

To uphold the stable policy, making `mode` async will only be done in
master.
In stable, a new `_modeWithImageWait` is added which is called only
for the situations that causing an issue, and which enables the fix
of the masonry layout.
In 14.0, it is used when computing the layout from `start` and
`addImages`.
In 16.0, it is also used in `notify` when images are removed or moved
around - because masonry clones the images.
In master, it is always applied.

Additionally, this commit also rounds the computed size of images inside
the masonry layout calculations.

Steps to reproduce:
- Drop an Images Wall.
- Add four images, the first one being taller than the others.

=> The fourth image sometimes appeared below the tall image.

[1]: https://github.com/odoo/odoo/commit/0d43aec24baad6420e0fe150a9c19d33c0b74198



task-2990053

closes odoo/odoo#124302

X-original-commit: 2814c84e78e68e277973b44408a7ba7965f178ae
Signed-off-by: Arthur Detroux (ard) <ard@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Inside the Images Wall snippet, images are dispatched to columns
depending on the height already reached by each column. This computation
relies on a sub-pixel height which leads to a confusing behavior.

This commit rounds the sub-pixel height to a visible pixel height to
avoid the confusion.

Steps to reproduce:
In the default images of the Images Wall snippet, the third image (sign)
is one pixel taller than the other ones.
- Drop an Images Wall snippet.
- In 14.0, upload the default images from v15.0.
- Select the "sign" image.
- Move it to the previous position.

=> The sixth image (wine glass) moved as well.

task-2990053

X-original-commit: 1fc45be924e904dc595af61e0845b91cc5d24a49
Part-of: odoo/odoo#124302

If we create a survey and  start a new session. When the session state is in
progress and If the survey creater deletes a question and participant tries to
answer the deleted question and submits it then participant will face the issue
of 'False is not in list'.

This commit will raise an usererror if the survey creater tries to delete the
question when the survey session is in progress.

sentry-4113791861

closes odoo/odoo#119943

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps to reproduce:
- create an invoice with a certain number of items so that when printed there are multiple pages

Issue:
- the invoice name does not appear on each page
According to the French legislation it is mandatory

See https://entreprendre.service-public.fr/vosdroits/F31808



Solution:
- set a config parameter specifically for l10n_fr in stable
- set it in account directly for Master
To allow the footer of the invoice to contain the name (and therefore the number) of the invoice

opw-3199906

closes odoo/odoo#124509

X-original-commit: 18e89e7d
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com>

When user tries to import a module which does not consist of an icon and then
when user tries to access that module the error occurs.

Steps to reproduce:
1. Install web_studio.
2. Import a module(without icon) from apps > import module menu.
3. Now search that module in apps and click on module info.
4. The error will occur.

Applying this commit will fix this issue.

sentry-4206999375

closes odoo/odoo#123210

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Commit 1e82e273 makes ship later option create additionnal account
move line for Cogs at delivery validation. The issue is the accounts was
not correct. The desire result should be the following for a product of
cost 10, sale price 11 and 15% taxes.

 At PoS Closing                             | Debit | Credit
-------------------------------------------------------------
215000 Taxes 15%                            |  0.00 |   1.50
200000 Pos account                          |  0.00 |  11.00
600000 Expenses                             |  0.00 |   0.00
101200 Account Receivable                   | 11.50 |   0.00
110300 Stock interim (delivered)            |  0.00 |   0.00
-------------------------------------------------------------
                                            |       |
 At delivery validation (manually created)  |       |
-------------------------------------------------------------
110300 Stock interim (delivered)            |  0.00 |  10.00
600000 Expenses                             | 10.00 |   0.00
-------------------------------------------------------------
                                            |       |
 At delivery validation (from stock layers) |       |
-------------------------------------------------------------
110100 Stock valuation                      |  0.00 |  10.00
110300 Stock interim (delivered)            | 10.00 |   0.00

closes odoo/odoo#123152

Opw: 3324972
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Commit 1e82e273 adds cogs account move lines for 'ship later'
config at the picking validation. The issue appears if the delivery flow
is in multiple steps. The account move lines will be created for each
pickings.

This commit ensure the last one actually create the aml only

Opw: 3324972
Part-of: odoo/odoo#123152

Before this commit:

 1. Open a POS session configured with any terminal payment method
 2. Click on Payment, pick the terminal payment method
 3. Enter an amount
 4. Click on "Send" to send the amount to the terminal
 5. Click on "Validate" before the terminal returns anything
=>
The ticket is validated at $0.
The actual amount is credited in the terminal but the cash closing does
not contain this actual amount.

After this commit:
An error message appear if trying to validate such an order.
The validate button is also grayed out (but can still be clicked).
The pot file have also been updated

Note: the issue will also happen in version 14.0, but as I am a bit
afraid of the side effects that it might have (angry customers used to
the previous way), I prefer to push it first to the customer version
only. If I don't have echo of angry customers on this, I will do a
backward port and validate the forward ports.

opw-3292442

closes odoo/odoo#122539

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

A rate of 17.5 is wrong for standard rate purchases in Ireland.
The standard Sale and purchase VAT have an amount of 23.

closes odoo/odoo#124280

X-original-commit: 34161c52
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Daniel Kosky (dako) <dako@odoo.com>

When there are too many (millions) of POS order lines associated to
opened POS sessions we get too many taxes, most are duplicated. This
causes a MemorryError.

Example queries from a real DB:
```
> select count(distinct r.account_tax_id) from pos_order_line l join pos_order o on o.id = l.order_id join pos_session s on s.id = o.session_id join account_tax_pos_order_line_rel r on r.pos_order_
 line_id = l.id where s.state != 'closed'
+-------+
| count |
|-------|
| 24    |
+-------+
> select count(r.account_tax_id) from pos_order_line l join pos_order o on o.id = l.order_id join pos_session s on s.id = o.session_id join account_tax_pos_order_line_rel r on r.pos_order_line_id =
  l.id where s.state != 'closed'
+---------+
| count   |
|---------|
| 2504539 |
+---------+
```

opw-3295467

closes odoo/odoo#124194

X-original-commit: 0d220a7b
Signed-off-by: Christophe Simonis (chs) <chs@odoo.com>

It can happen than a popper's reference would
move in the browser's layout because of an unrelated element.
This commit make sure the popper's position is updated
in case its reference has moved in the layout.

**Before this commit**
![before]

**After this commit**
![after]

[before]: https://github.com/odoo/odoo/assets/1159815/3c9cfae7-db68-4707-a73c-ad7e2e71d4bf
[after]: https://github.com/odoo/odoo/assets/1159815/a21f56e0-d8e3-48c1-9509-8e6ee5040d4b



closes odoo/odoo#123942

Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>

When updating taxes, if the amount of a tax of type 'group' changed
between version, it was considered different from the existing tax
and thus recreated. That amount has no impact for a tax of
this type, and should therefore be ignored in the compare method.

opw-3338100

closes odoo/odoo#123954

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>