Steps to reproduce:
    - install a localization which uses the account_edi module;
    - define Lock date for the fiscal period;
    - choose an invoice which was sent before this date;
    - click on the "REQUEST EDI CANCELLATION" button.

Issue:
    We try to cancel the EDI document despite exceeding the fiscal period.

Cause:
	The verification of the fiscal period is done when clicking on the "RESET TO DRAFT" button which, in the flow, is after the request for cancellation of the EDI document.

Solution:
    Make a verification of the fiscal period when clicking on the "REQUEST EDI CANCELLATION" button.

opw-2990873

closes odoo/odoo#106091

X-original-commit: fda04e21
Signed-off-by: Josse Colpaert <jco@odoo.com>

closes odoo/odoo#106055

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Steps to reproduce:

  - Install `Expenses` module
  - Go to Settings > Technical > Email > Aliases
  - Edit the `expense` alias
  - Ensure the model is `Expense`
  - Set `Alias Contact Security` to `Everyone`, then save

  - Send an e-mail to the expense alias, using an e-mail address not
    referenced on one of the employees.

Issue:

  Error in logs related to `currency` variable.

Cause:

  Trying to create an expense for a non-existing user, therefore,
  no currency is set.

Solution:

  If no user is found, no need to create the expense and let the orm
  raise the error that a required field is not set (field employee on
  expense).

opw-3027350

closes odoo/odoo#106048

X-original-commit: a339caa2
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

To Reproduce
============
- create a subscription
- confirm it and create invoice for it then confirm it too
- go back to the subscription and renew it
- from *Action* generate a payment link
- a validation error will be raised

Problem
=======
we can't generate the payment link because the amount is 0, this value came from the fact that we substract
the sum of invoices amount linked to this subscription from the total amount.

Solution
========
The invoices from the old subscription are kept just as history in the new one, and must not be taken into account when
computing the amount, so a condition was added to remove theses kind of invoices from computation of amount.

opw-3052816

closes odoo/odoo#106036

X-original-commit: 0947e91720faba4c161868283070ac38d89b7a49
Signed-off-by: abla001 <abla@odoo.com>

Since [1], the google map UI to search for locations thanks to the
google map API was not working anymore. Indeed, the lib was loaded
inside the iframe (as it should) but not outside of it, preventing to
use the `google` object in the related editor panel widget. The
autocomplete UI style was also broken as the CSS is not available
outside the iframe.

As a fix, the code outside the iframe now use the `google` object from
inside the iframe (no problem seems to come out of it) and the style is
restored via custom CSS (custom CSS already existed and was already
changing most default style anyway).

As a reminder, this snippet is only available in debug mode or if your
google map key is setup, which we do not allow to enter anymore via
standard flow since 16.0 (15.3).

[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b



closes odoo/odoo#105812

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Using the "gps picker" (for example with the "Google Map" snippet) was
not flawless. The autocomplete menu which shows up when the user enters
an address is handled by the gmap API. It was actually not working at
all on Firefox for an unknown reason. Not listening to blur events on
the input seems to solve the issue. This commit also prevents triggering
a value change if the same address is reselected which seems to make
address changes a bit more robust too.

opw-2976261

X-original-commit: 50bf0b7f
Part-of: odoo/odoo#105812

Some part of the google map API was deprecated and showed a warning
at each snippet redraw. Probably harmless but since the related API are
really capricious, best satisfy them as much as possible, even in
stable versions.

opw-2976261

X-original-commit: b761c8fe
Part-of: odoo/odoo#105812

Before this commit, when adding a google map snippet in the DOM, the
user was asked for its API key if not already configured, thanks to an
user-friendly dialog. However, in the case it was misconfigured (while
the editor dialog prevents some misconfiguration, configuration via the
backend allow any random key to be given), the UX was terrible: the
google map is simply removed without any notification.

Misconfiguration can be:
- Invalid API key
- "Maps JavaScript API", "Places API" or "Maps Static API" not enabled
- Billing not enabled

Now notifications/messages warn about those things and reopens the key
configuration dialog, which contains links to the gmap API documentation
and now more information.
Hopefully, this can be improved even further later. Indeed, this is
still not perfect as there is no reliable way to understand google
responses. E.g. even with the three mentioned API and billing enabled,
sometimes the google map API still returns errors indicating "not
enabled APIs" but it cannot be reproduced reliably. During my test it
was systematic for 15min at some point but now there is none, ever. Like
if there was a delay after enabling an API on the google console before
it stops sending errors... although the API works immediately.

Notice that in 15.0, this snippet is shown in debug mode only and we
encourage users to use the new "Map" snippet which does not require any
configuration.

opw-2976261

X-original-commit: e969ee899ebef9927a6eac197dfa5dba22619d29
Part-of: odoo/odoo#105812

Steps to reproduce:
- Go to Purchase -> Reporting -> Dashboard
- click on the "expand" arrows of the pivot view
- favorites - add to dashboard

Bug:
adding a view with no actionID causes the dashboard to crash on load
this [commit] prevents adding a view with no actionID

Fix:
added a default value of False to add_to_dashboard actionId
only display the option to add_to_dashboard for views that have actionId

opw-2965036

[commit]:https://github.com/odoo-dev/odoo/commit/7180d948f084d4f68d1660cb884c95aaf41288fa



closes odoo/odoo#106037

X-original-commit: b627c7c1121b9c581a89752a4364a688617a183b
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

Sending a context when you are closing a `pos.session` will allow you to
make some validations/actions only when the closing is being done from the UI.
For example, sending values for new fields or a message that includes
something from the pos, like the Cashier ID, name, etc.

Also, it will help more when it is necessary to inherit the function in a
simpler way, to avoid having to overwrite it.

closes odoo/odoo#106033

X-original-commit: 3f7d6833
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Steps to reproduce
==================

- Use a mobile phone / mobile view in devtools
- Go to Accounting > Customer invoices
- Click on one item
-> A traceback occurs, the uom is missing

Cause of the issue
==================

The field is declared as
  `<field name="product_uom" groups="uom.group_uom"/>`

The raw value is accessed with
  `<t t-esc="record.product_uom.value"/>`

Solution
========

Add the missing group

opw-3070671

closes odoo/odoo#106038

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps to reproduce:
- Activate debug mode
- Go to Sales and open a quotation (actually any form view from any
  module will do)
- Start Studio
- Select the "Confirm" button (or any of the top buttons)
- Check the "Set approval rules" box
- Edit the domain by clicking the 'filter' icon next to the 'trash' icon
- Add a condition. You can just keep the default one.
- Click save to save the domain.
- Again, click on the 'filter' icon.

You should see that the domain in the text editor is malformed.
Furthermore, should you change the domain in the text editor (let's say,
change 1 to 2) and hit save, an error message will pop saying the domain
is not properly formatted.

opw-3001622

closes odoo/odoo#106034

X-original-commit: 9535026e
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/a17522c8

 [FIX] interactive merge: remove useless user confirmation

closes odoo/odoo#105996

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

Current behaviour:
When rendering a calendar view with "Year" option,
the weekday headers may be incorrect in some cases
when the timezone is set to a negative timezone GMT.
For ex. it renders "S S M T W T F" instead of "S M T W T F S",
if the first day of the week is Sunday.

Expected behaviour:
Formatting should be consistent with the first day of the week,
and be indepedent of the timezone.

Steps to reproduce:
- Change your system timezone to somewhere in Alaska
- Install TimeOff
- Open TimeOff and switch to the yearly view.
- Observe that the weekdays headers are incorrect.

Reason for the problem:
The custom calendar header formatter was trying to generate
the end result directly based on the date marker, which is
incorrectly set in that context. This patch doesn't fix the root
cause of why the `info.date.marker` starts at an incorrect date.

Fix:
A formatter shouldn't read state. Since we are using the luxon plugin,
we use the `"EEEEE"` format, which is equivalent to the `"narrow"` options
from JS's `Intl.DateTimeFormat()` available in all browsers.

Affected versions:
- 16.0
- master

opw-3033464

closes odoo/odoo#104718

Signed-off-by: Bruno Boi (boi) <boi@odoo.com>

When a picking is a dropship type (i.e. having the vendors as source
location and the customers as destination locations), then the
warehouse_id is removed.
This will add consistency between automatically generated "Dropship"
type and the manually created ones.

Part of task-2985735

closes odoo/odoo#102436

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Avoid raising an error if `warehouse_id` isn't in the vals.

Steps to reproduce :
Inventory -> Configuration -> Operation Types -> Create a new Operation
Type.
Then, either the warehouse field is empty because it doesn't appear due
to the multi-warehouse not being activated yet, or its saved when the
field is empty.

Changes the onchange into a compute to have a better consistency between
the frontend and the backend.

Part of task-2985735

Part-of: odoo/odoo#102436

Before this commit:

When we try to copy paste link into another link then url of the old link does
not change and only lable change.

After this commit:

Now when we try to copy paste link into another link then the url of the link
changes with the label.

Task-2768541

closes odoo/odoo#105960

X-original-commit: ea1e410f
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Steps to reproduce:
    - logged in as user with admin or officer permissions;
    - create time off request with config for sick time off request;
    - try to delete partially approved time off request from calendar view by pressing delete button.
    (The button is in the window that opens when you select a time off)

Issue:
    Partially approved time off request are not deleted when using delete button in calendar view.
    (It can only be deleted via the list view)

Cause:
	The function which deletes the element is not called.

opw-3061570

closes odoo/odoo#105842

Signed-off-by: Kevin Baptiste <kba@odoo.com>

In grouped kanban, when having groups but no record to display, the
group creation button (ie. "+ Stage" in Project) and its related column
are muted instead of being the regular colors (like for the groups'
titles).

This commit fixes it by applying a fix similar to the group's title one
(cf. odoo/odoo@cbefc9cd51b3c903a6c54d8e3f95bf2b592cf402)
for the quick create column element.

Steps to reproduce:
- Open Project
- Create a new project and open it in kanban view
- create a few stages
=> the quick create column is "muted"
- dismiss the quick create column (ESC or click outside it)
=> the "+ Stage" button is muted

closes odoo/odoo#105746

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Before this commit, when the database is launched on an Apple computer,
the demo data in sale_timesheet module cannot be installed because of
the emoji is not correctly managed by a OS version of Apple.

This commit removes the emoji to be able to launch an odoo database on a
Apple computer.

closes odoo/odoo#105887

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

When manualy create a productivity log on the workorder form, you are
always asked to choose a time_id(productivity). But by default, the
field is hidden. Make this field shown by default for better use
exprience.

closes odoo/odoo#104517

Related: odoo/enterprise#33399
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Adapt tests for other moudules to use

ENT PR odoo/enterprise#33399

Part-of: odoo/odoo#104517

closes odoo/odoo#105950

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Part-of: odoo/odoo#105950

The account 81 to 89 were misclassified, this PR fix the issue

closes odoo/odoo#105723

X-original-commit: d282b8c6
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

the context passed to the method _get_product_purchase_description for the seller_id is wrong. system is expecting to get product.supplierinfo record set in this context key and from this function res.partner record set is passed, which results in the below error:

Record does not exist or has been deleted.
(Record: product.supplierinfo(70,), User: 2)

closes odoo/odoo#105012

Signed-off-by: Tiffany Chang <tic@odoo.com>

https://github.com/odoo/o-spreadsheet/commit/bd9787b1 [FIX] edition: Handle too long formulas
https://github.com/odoo/o-spreadsheet/commit/577995ed [FIX] composer: Allow to paste text in the composer
https://github.com/odoo/o-spreadsheet/commit/0876cfe3 [FIX] functions: dichotomicSearch handle 2d array
https://github.com/odoo/o-spreadsheet/commit/8a61a4a1 [FIX] grid: capture IME altered inputs
https://github.com/odoo/o-spreadsheet/commit/763b9490 [FIX] sheet: prevent creation of sheet with the same id
https://github.com/odoo/o-spreadsheet/commit/a66f5173 [FIX] figure: prevent duplication of figure id
https://github.com/odoo/o-spreadsheet/commit/7b9aa031 [FIX] config: Allow to build outside of git repository
https://github.com/odoo/o-spreadsheet/commit/17542407 [FIX] grid: remove old component
https://github.com/odoo/o-spreadsheet/commit/b147649c [FIX] selection: update default selection anchor on dispatched commands
https://github.com/odoo/o-spreadsheet/commit/c610857c [FIX] selection: don't reset selection on Autofill
https://github.com/odoo/o-spreadsheet/commit/3732f9f5 [FIX] selection: Properly add merge when adding them to the selection
https://github.com/odoo/o-spreadsheet/commit/7276c912

 [FIX] model: do not replay core commands in ui plugins

closes odoo/odoo#105836

Related: odoo/enterprise#34026
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>

Steps to reproduce:
- Install `sale_timesheet`
- In Sale, create a so with a 'service' product with invoicing policy
  set on `Based on Timesheets` for customer A
- Confirm the SO
- Create a new project and check Billable and Timesheets
- Edit the Project and set customer to A
- Go in the `Invoicing` tab
- Enter the SO line you created before.
- Create employee mappings on the SO line you created before
- Click on the Save manually button
- Click on the Invoice button
- Chose Down payment (percentage)
- Set the percentage to 10%
- Click on `Create Invoice`

Issue:
A traceback is displayed when trying to create a downpayment on a project.

Cause:
Currently we filter the sol that are to invoice (`invoice_status` set to 'to_invoice')
prior to provide them to the wizard `sale.advance.payment.inv`.
As the result is an empty recordset, no sol ids are passed to the wizard.
Thus when trying to create a downpayment, no related sol is provided and
the error is thrown.

Fix:
As the `sale.advance.payment.inv` handles the fact that there are items to invoice
when choosing `regular invoice` there is no risk passing so line with an
`invoice_status` set to 'no' which will be used in this use case.

Closes odoo/odoo#104720

closes odoo/odoo#105967

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Steps to reproduce:

-Go to Account app > Configuration > Chart of Accounts.
-Here change the view to kanban view.

Issue: The "Type" field is displaying "[object, Object]" for every
account instead of the proper type.

Solution: The "Type" field view in kanban view was missing the ".value".
So instead of "record.account_type" we should have
"record.account_type.value".

opw-3063341

closes odoo/odoo#105949

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

In rating/controllers/main.py, the method action_submit_rating accepts
only post request. This creates a problem when you're trying to use the
web editor on the template as well as when you just paste the url in
your browser, for those are get request. The current behavior is a crash
with 'method not allowed'. This commit's purpose is to change the method
so it also accept get request. The use case of editing the feedback
rating page is arguable but it schould not crash.

The behavior after this commit is that the web editor is enable for the
page, and relaoding the page does not crash anymore.

task-3047893

closes odoo/odoo#105942

X-original-commit: aa1310b8503edf14d408811345bdb4a71ebc44d6
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

It is not possible to consume a component tracked by serial that comes
back from a scrap location

To reproduce the issue:
1. In Settings, enable "Multi Routes"
2. Create two storable products P_compo, P_finished
    - P_compo is tracked by serial number
3. Update the on-hand qty of P_compo:
    - 1 x P_compo with serial SN
4. Process a manufacturing order MO:
    - Product: P_finished
    - Compo: 1 x P_compo with SN
5. Unbuild P_finished
    - It brings SN back to stock
5. Scrap one P_compo with SN
6. Unscrap it (thanks to an internal transfer)
7. Repeat step 4

Error: a user error is raised: "The serial number SN used for component
P_compo has already been consumed"

When checking the SN uniqueness of a component, we don't consider the
case where a product came back from a srap location

OPW-3055252

closes odoo/odoo#105924

X-original-commit: 476dbb6f2138294200ba7bfef96553e5d89b1a0e
Signed-off-by: Adrien Widart <awt@odoo.com>
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce the bug:
- Create a storable product ”P1” with 2 BoM:
    - BoM 1:
        Type: manufacture
        Component: C1
    - BoM 2:
        Type: manufacture
        Component: C2
- Create a MO:
    - Add the product “P1”
    - The BoM 1 is automatically set and the component “C1” is added
    - Save the MO
- Edit The MO:
    - set the BoM 2 instead of BoM 1

Problem:
The component C2 is added, but the component “C1” linked to BoM 1 is
not deleted

To delete the existing lines, we check if the product has changed,
but we do not check if the BoM has changed:
https://github.com/odoo/odoo/blob/16.0/addons/mrp/models/mrp_production.py#L694



Solution:
clear “move_raws” if BoM change.
No need to check if the product has changed to clear component,because
if the product changes, the bom changes too

opw-3069283

closes odoo/odoo#105922

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Before this commit, once a user was disconnected from internet (eg.
network failure, laptop screen closed), the code disconnected the user
from the peer to peer network and upon reconnection to the internet
network, the code did not try to reconnect to the peer to peer network.

This created a network partion in the peer to peer network each time
a user disconnected and reconnected to the internet network.

When there is a partition in the peer to peer network, the last subnet
to write to the record erased the changes of another subnet without
notification.

This commit prevent the code to disconnect from the peer to peer network
when there is any disconnection signal triggered.

closes odoo/odoo#105897

X-original-commit: 8bce8cd5
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

activate warnings from purchase settings and open any purchase order and click the create alternatives button from alternatives page. in the next wizard, Warning Messages field is visible always, upon checking the view, it seems the visibility condition given is wrong and thus it get visible always.

closes odoo/odoo#105635

Signed-off-by: Tiffany Chang <tic@odoo.com>

Steps to reproduce:
    - go to e-commerce app;
    - select a product;
    - try to return to the shop with the browser's back arrow.
    (if the URL contains `\@\`, is not necessary to click on a "action", otherwise we must)

Issue:
    It is not possible to go back.

Cause:
	Modifying the hash modifies the history of the browser.

Solution:
	Change hash without changing browser history.
	`window.location.replace` documentation: https://developer.mozilla.org/en-US/docs/Web/API/Location/replace



opw-3061027

closes odoo/odoo#105570

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

An inventory user can't open the forecast report.

To reproduce the issue:
(Use demo data)
1. Edit the user Marc Demo:
    - Inventory: User
2. Log in with Marc Demo
3. Open the product 'Acoustic Bloc Screens'
4. Open its forecasted report

Error: There is an access error "You are not allowed to access 'Stock
Valuation Layer' (stock.valuation.layer) records"

We use `read` on the outgoing stock moves, but the current user does not
have the access rights to all relational fields of that records (for
instance, `stock_valuation_layer_ids`, which is a `2many` field to the
model `stock.valuation.layer`: an inventory user does not have any
access to this model).

OPW-3056287

closes odoo/odoo#105566

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

The preview of a mailing was displayed twice:
- after a save and when clicking on the preview button
- when double-clicking on the preview button
This solves those problems.

Technical notes: quick explanation of the fixes:
- double display after a save: the click event was registered twice (same for
the code preview button), the fix unregister the click before registering it
again.
- double display when double-clicking quickly on the button: the modal is not
displayed immediately and the button remains active a brief moment allowing a
second click. The fix disables the button when the button is clicked and
reenables it when the modal is closed.

Task-3047479

closes odoo/odoo#105178

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

New class `fields.Json` is introduced in v16. The feature lacks some converting
methods for export/import. This commit fills the gap.

Example: field `line_ids/analytic_distribution` in `account.move` (Invoices)

opw-3056669

closes odoo/odoo#105133

Signed-off-by: Ivan Elizaryev (iel) <iel@odoo.com>

Exporting a Binary field with a value of type dict from a record raises
an error

Steps to reproduce:
1. Install Accounting
2. Open Accounting and go to Vendors > Bills
3. Open any posted bill and register the payment
4. Go back to the list view and export the bill in payment
5. Add field Invoice Payments Widget to the exported fields and export
6. An error is thrown

Solution:
Make the field attribute `exportable` work (pass it in the field
description)
Make fields `invoice_outstanding_credits_debits_widget` and
`invoice_payments_widget` non-exportable as they contain computed
aggregated data for the client's benefit and it doesn't make sense to
export them

Problem:
xlsxwriter's `write` doesn't support type dict

opw-3054184

closes odoo/odoo#105043

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>