- Change an image option in mass mailing editor (e.g. Quality)
- save
- edit -> The option can't get the new applied value.

The body_arch's field used in mass mailing editor is
sanitizing attributes and as a consequence, option related data
attrs are removed on save.

task-2327045

closes odoo/odoo#72008

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

In some screen it is very hard to edit the factor.

closes odoo/odoo#66323

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

If a user has no accounting permission, when he opens/closes a POS
session (without any sale), he will not be able to close the session

To reproduce the error:
(Use demo data)
1. Remove all Marc Demo's permissions for the Accounting module
2. Login with Marc Demo
3. Open a POS Session
4. Close the POS Session

Error: "Sorry, you are not allowed to delete documents of type 'Journal
Entries' (account.move) [...]"

Note: if the user processes at least one order during the POS session,
he will be able to close it thanks to sudo mode:
https://github.com/odoo/odoo/blob/369331dfdc144cf852c80c99d00ce8d5da843be1/addons/point_of_sale/models/pos_session.py#L302



OPW-2523187

closes odoo/odoo#72263

X-original-commit: 1e176ba3
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Currently there is an action_assign_serial_show_details button within
the detailed operations form of a serial tracked product move.
Unfortunately there is no way to undo the assigning/creating of move
lines from this action (including via clicking the "Discard" button).
This can lead to a lot of manual work (e.g. 500 SNs produced instead of
50) to remove unwanted move lines. To remedy this, we add in a button
to unlink all of the move's move lines whenever the Assign Serial
Numbers button is visible.

closes odoo/odoo#71820

Task: 2426281
X-original-commit: a6191c43
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When a serial number SN is trying to be consumed and has been unbuilt in the past,
an evaluation is used to check that the # of times SN was unbuilt is equal to
the # of times SN was consumed. However, when counting the unbuild SN it did not take into account if
it was from an unbuild order.

opw:2510294

closes odoo/odoo#71684

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

This commit fixes the case when the reconciliation never ends due to an infinite loop.
This happens when we attempt to reconcile two journal items having differents foreign currencies but an amount_residual = 0.0.
In that case, partials are created everytime with zero amount, zero debit_amount_currency and zero credit_amount_currency.
We don't need to handle such reconciliation because exchange difference journal items are always created using the same foreign currency as the originator line.

The way the reconciliation is made for reversal moves is also edited by this commit to avoid reconciling lines on the same moves but with different currencies.

closes odoo/odoo#71906

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Steps to reproduce the bug:
- Go to Elearning > choose any course or create a new one
- Click on “add content” :
    - Add a title to slide
    - Click on "Go to Website"

Problem:
An error is triggered because we call the "create" method to save the slide, which tries to access the “channel_id”, the course ID in which the slide will be added. However, the field is not set in values.
The "create" or "write" function in "slide_channel" must first be called to save the course, which will then call the create function in "slide_slide"

Solution :
Hide the "Go to website" button as long as the course is not created and therefore has no id

opw-2526541

closes odoo/odoo#72185

X-original-commit: e412ba48
Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>

Before this commit, the number you saw on the stat button was not always
the same as the number of sale order you would see when you clicked on it.
Indeed, there was a domain force on the action to only show confirmed orders,
while the stat button was counting quotations too.

Fixed #70911

closes odoo/odoo#71826

Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

Bug
===

1. Create a new database from the database selector
2. Do not select a country for your company
3. Install CRM
4. Create a new opportunity and select your company
5. The sync "warning" will be displayed, and it should not

The reason for that is the phone of the company is an empty string and the
phone of the lead is False. So we try to sync them and we show the warning
message even if for the user, nothing will happen.

This commit fixes that behavior by correctly checking that False / empty
strings are considered as equel.

TaskID-2499659

closes odoo/odoo#72237

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The printer dialog was not shown when going through the manage order if there
was no printer connected.

In order to fix this issue, the tryReprint doesn't check anymore if a printer is
connected or not. It'll print via printer if connected or show the the printer dialog.

closes odoo/odoo#72215

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

When computing the foreign key name,
`check_foreign_keys` didn't take into account the limit of 63 characters
for constraint names.

Because of this, some constraints were dropped and recreated
over and over while they were correct, during install and upgrades.

For instance, when installing `base`
when adding the foreign key for which the name was computed
`base_partner_merge_automatic_wizard_res_partner_rel_base_partner_merge_automatic_wizard_id_fkey`
Postgresql created the constraint under the name
`base_partner_merge_automatic__base_partner_merge_automatic_fkey`
and therefore, as the name did not match,
the constraint was dropped and re-created.

closes odoo/odoo#71658

Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

closes odoo/odoo#72176

X-original-commit: 76584fda
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Before this commit, fields in calendar popover were added
to the $fieldsList after they were appended but appending
is async and so fields could be disordered.

Now, we add fields before the append to have the right order.

closes odoo/odoo#72098

X-original-commit: 312affaf
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

closes odoo/odoo#71844

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Since f17506676 if when editing a page there was several elements
matching:

    .oe_structure.oe_empty, [data-oe-type="html"]

If at least one was empty we would not be able to edit any of them.

opw-2572176
opw-2572151
opw-2571217

closes odoo/odoo#72172

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

In fb556ed0 the middle vertical line is removed from the timeline
widget because the display was changed to table.

We need display:block so this commit override the value (adding
"height:100%" also fixed it but not for all browser (eg. in safari)).

opw-2558670

closes odoo/odoo#71988

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When changing the color of the header with the custom colorpicker and
saving the changes, the autohideMenu widget was destroyed before
finishing the rendering.

The commit fixes the destroy method of this widget, testing if the
variables are defined before using them.

task-2519545

closes odoo/odoo#71521

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

The background color displayed on the blog posts list page was static,
instead of being the background_color_class saved from the
CoverProperties. Also, on the blog post page itself, the two were
combined which made no sense.

Part of https://github.com/odoo/odoo/pull/71593


task-2497846

closes odoo/odoo#71593

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

This commit fixes a bug happening when changing the background with the
CoverProperties SnippetOption from the blog posts list page.
As it selects the default sizing class and applies it, the min-height
css property was applied and breaking the layout.

The covers min-height is now set as !important to not be overriden in
that context.

Part of https://github.com/odoo/odoo/pull/71593
task-2497846

As [1] added `!important` flag on .o_full_screen_height and
.o_half_screen_height global classes, the current override in
website_blog was not effective anymore.

Also, the value of the height override is also changed to offer more
differences. Also, simply restoring the old rule would "restore" 13.0
databases but "break" 14.0 databases which relied on it. So a compromise
between both was chosen.

[1]: https://github.com/odoo/odoo/commit/7cc6fdf36569be85e995c962321f2926822ac604

Part of https://github.com/odoo/odoo/pull/71593
task-2497846

Variable `mutations` may have thousands of records. Using `.push(...mutations)`
would lead to error

STEPS:
* install website_sale
* create many categories:

```
for x in range(0, 4000):
    env['product.public.category'].create({'name': str(x), 'parent_id': 9})
```
* open /shop
* click [Edit]

BEFORE:

```
Uncaught RangeError: Maximum call stack size exceeded
```

---

opw-2515707

closes odoo/odoo#72132

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

closes odoo/odoo#72131

Signed-off-by: Josse Colpaert <jco@openerp.com>

We call the status of the hostapd in each request of 'get_odoo_server_url()' and 'get_ssid()'
And this call display in the log the status '0' or 'inactive' in the log

With this commit we hide this useless information

closes odoo/odoo#72120

X-original-commit: e5e9f9f9
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Without this patch, each time the compute reaches the line with `.filtered()`, it needs a new fetch from the database. With too many sale orders, this becomes a bottleneck.

Now, before getting to that line, Odoo knows that it'll need all sale.order.line records, so it can fetch them all at once.

In a production database, loading the sale.order list goes down from 7s to 500ms with this patch.

@Tecnativa TT30390

closes odoo/odoo#72090

X-original-commit: 254b2a08
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The consumption feature is used as well for subcontracting, but we can't
select other value from the default, as was hidden for all BoM types
except normal ones.

As the only BoM that doesn't apply the consumption feature are the kits,
then let's hide the field only on that case.

Similar can be applied to picking type, as it at least used here:

https://github.com/odoo/odoo/blob/cc0e63561f310b21511b8005c34fe99c88854cb0/addons/mrp_subcontracting/models/stock_move.py#L172



TT30389

closes odoo/odoo#72103

X-original-commit: 30f62dcb
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

- Install Sale, Project, Purchase, Timesheet, Accounting
- Enable pricelists, discount, analytic accounting
- Create a pricelist [PRICELIST]:
  * Discount all product by 50%
  * Discount Policy: Show public price & discount to the customer
- Create a product [SERVICE]:
  * Type: Service
  * Timesheet on task
  * Create a task in sales order project
- Create another product [TEST]:
  * Price: 100
  * Re-Invoice Expenses: At cost
- Create a SO with pricelist [PRICELIST], product [SERVICE], confirm
- Create a PO with [TEST], specify analytic account from SO
- Receive the product, create the bill & confirm

Back to the SO, the unit price of [TEST] is set to 50, when invoicing it
will be cut of another 50%, resulting in 25

opw-2491693

closes odoo/odoo#72083

X-original-commit: 538400e9
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

Also make this a configurable value, from the server.

This is the limit of the SAAS servers.

closes odoo/odoo#71973

X-original-commit: 71bb3a89
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>

On a product form, if the purchase UoM is different from the default
UoM, this will lead to an error when creating a RfQ.

To reproduce the error:
(Need stock)
1. In Settings, enable "Unit of Measures"
2. Create a product P:
    - Cost: 100
    - UoM: Units
    - Purchase UoM: Dozens
3. Create a RfQ:
    - Add P

Error: The quantity is 1 and UoM is Dozens, however the unit price is
$14400. The ratio has been applied twice.

When setting the product, an onchange method computes the unit price.
However, the computation is wrong: it first converts the product's
standard price using the purchase UoM of the product. Then, it converts
the result, this time using the UoM of the PO line.

OPW-2519294

closes odoo/odoo#72038

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When demo data is installed, requests to the proxy are blocked and we simulate a successful result by default and the proxy.
- an account_edi_proxy_client.user is created even though it's counterpart on the proxy doesn't exist.
- sending invoices is successfull and checking the status return simulate the invoice was accepted.
- the cron checking for incoming invoice returns immediatly and no new invoice is created.

closes odoo/odoo#71998

Signed-off-by: Josse Colpaert <jco@openerp.com>

To reproduce the error:
1. In the settings of a POS, enable "Header & Footer"
2. Add this footer: "0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4
5"
4. Start a session
5. Validate an order
    - Note that in the footer, there is a line break after the third '3'
6. Print Receipt
    - Error: the line break is after the third '5'
7. Send the receipt by email
    - Error: in the receipt of the mail, the line break is after the
third '2'

The appearance should be the same in the three cases. On step 5, here
are the values used to display the receipt:
https://github.com/odoo/odoo/blob/6c1172922505cd955d278bc80d327423fc6867a6/addons/point_of_sale/static/src/css/pos.css#L1680-L1692


This fix applies the same ratio `width/font-size = 18.75` on values used
to print the receipt (`266 / 18.75 = +-14`) and the ones used to
generate the receipt in the mail (`512 / 18.75 = +-27`). That way, the
appearance of the receipts remains similar.

OPW-2528558

closes odoo/odoo#71900

Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

To reproduce the error:
1. In the settings of a POS, enable "Header & Footer"
2. Add a header (with at least one line break)
4. Start a session
4. Validate an order

Error: The header of the receipt is incorrect, line breaks are not
applied

OPW-2528558

      Fix the  error 'Expected singleton for company' when user try to open MO ( user have many companies selected)

closes odoo/odoo#72013

Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>

On account analytic lines, employee_id can be null.
https://github.com/odoo/odoo/blob/c63af09774414a004ef34644b4f38b4fdb1d12bd/addons/hr_timesheet/models/hr_timesheet.py#L48



```
Traceback (most recent call last):
  File "/tmp/tmpowipzc_d/migrations/base/tests/test_mock_crawl.py", line 155, in crawl_menu
    self.mock_action(action_vals)
  File "/tmp/tmpowipzc_d/migrations/base/tests/test_mock_crawl.py", line 245, in mock_action
    mock_method(model, view, fields_list, domain, group_by)
  File "/tmp/tmpowipzc_d/migrations/base/tests/test_mock_crawl.py", line 335, in mock_view_kanban
    self.mock_web_search_read(model, view, [domain], fields_list)
  File "/tmp/tmpowipzc_d/migrations/base/tests/test_mock_crawl.py", line 394, in mock_web_search_read
    data = model.search_read(domain=domain, fields=fields_list, limit=80)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 4839, in search_read
    result = records.read(fields)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 3020, in read
    return self._read_format(fnames=fields, load=load)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 3040, in _read_format
    vals[name] = convert(record[name], record, use_name_get)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 5666, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "/home/odoo/src/odoo/14.0/odoo/fields.py", line 1019, in __get__
    self.compute_value(recs)
  File "/home/odoo/src/odoo/14.0/odoo/fields.py", line 1175, in compute_value
    records._compute_field_value(self)
  File "/home/odoo/src/odoo/14.0/addons/mail/models/mail_thread.py", line 410, in _compute_field_value
    return super()._compute_field_value(field)
  File "/home/odoo/src/odoo/14.0/odoo/models.py", line 4061, in _compute_field_value
    getattr(self, field.compute)()
  File "/home/odoo/src/odoo/14.0/addons/sale_timesheet/models/project.py", line 90, in _compute_warning_employee_rate
    dict_project_employee[line['project_id'][0]] += [line['employee_id'][0]]
TypeError: 'bool' object is not subscriptable
```

```
❯ psql test_14 -c '\d account_analytic_line' | grep employee_id
 employee_id            | integer                     |           |          |
    "account_analytic_line_employee_id_fkey" FOREIGN KEY (employee_id) REFERENCES hr_employee(id) ON DELETE SET NULL
```

Observed on upgrade request 16289
opw-2525553

Steps to reproduce on runbot (or local db with -i sale_timesheet and
deoma data)
1. Select Project > Office Design
2. Change project settings:
  Settings tab > Billable=True
  Invoicing tab > Invoice Tasks to=A unique customer
                > Pricing=Employee rate
3. Save
4. Delete Employees > Eli Lambert
5. Open Project main menu -> Traceback

closes odoo/odoo#71970

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When registering a payment on an expense, we are currently using the first
bank account set on the partner if no account is set on the account move.
We should use the bank account defined on the employee instead, and
fallback on the partner only if it is not set.

closes odoo/odoo#71611

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

In case we register one payment on a single accounting entry, we can manually
specify the bank account that will be used. In case we register one global payment
for several entries, the bank account is not visible in the payment register wizard.
We should use the first bank account set on the partner as a default case to allow
it and not block the whole process.

closes odoo/odoo#71603

Related: odoo/enterprise#18685
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Small fixup of recent commit 5800f20c.

It can happen that line_residual is equal to line_residual_after_reconciliation.
This should lead to a zero reconciled percentage instead of a ZeroDivisionError.

closes odoo/odoo#71930

Signed-off-by: William André (wan) <wan@odoo.com>

Prior to this commit:

    - If a user without access to sales tries to add timesheets on a task that
      comes from a sale order, the following access error is raised:

        Access Error

        You are not allowed to access 'Sales Order Line' (sale.order.line) records.

After this commit:

    - A user without access to sales will be able to add timesheets to a task that
      comes from a sale order without any error.

task-2566750
opw-2525342

closes odoo/odoo#70510

Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

Improve _compute_sale_order_ids performances by saving
stock.move.line search results to defaultdict before going
through records in self.

closes odoo/odoo#71949

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

When importing vendor credit note from an italian e-invoice xml file with a "DettaglioPagamento" section,
the data import will fail and you will have the "Unsupported image format" message on top of the invoice.

The use of '_compose_info_message' function is not possible on a 'account.edi.format' object and was
changed to use the 'invoice' parameter.

opw-2500569

closes odoo/odoo#71814

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>