Import an italian E-invoice of type TD04 (Nota di Credito).
The invoice type is marked as 'in_refund', but the bank information will
still be parsed from the contact info instead of taking the currenct
company info.
This will fail the check 'validate_partner_bank_id' and
the user will see the error 'The account selected for payment does not
belong to the same company as this invoice.'

Skipping the bank info when we have a credit note

opw-2239652

closes odoo/odoo#49825

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:
- install website, crm
- go to crm > settings > activate leads
- add a contact form to your website and submit
- go to the created lead

Previous behavior:
state_id is shown as false when geoip data is empty

Current behavior:
state_id is not shown if geoip is if the state found in geoip
does not not exist on the Odoo instance

opw-2218498

closes odoo/odoo#49379

Signed-off-by: mightyjol <jhk-odoo@users.noreply.github.com>

- Create a product P with 10 units on hand
- Create a SO with 5 units, validate
- Create another SO with 5 units, validate
- Update the quantity on hand to 8

The picking linked to the first SO as 2 units unreserved, while one
would expect the unreservation on the second picking.

When unreserving, sort the move lines according to the picking scheduled
date. The latest schedule date comes first.

opw-2233331

closes odoo/odoo#49770

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Prevent unexpected country creation when creating a state. Indeed,
there is usually no reason to create a new country.

opw-2239697

closes odoo/odoo#49713

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

- Go to the calendar list view
- Click on 'Create'
- Tick 'All Day'
- Set a start date

The end date is set to the day before.

This happens because in this case, the default duration is zero.

opw-2236766

closes odoo/odoo#49670

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Have a [DEMO] employee with an active (i.e. open) contract
Encode an holiday (i.e 15->16 April)
Encode a time off for [DEMO] which overlaps the holiday (i.e. 13->17
April)
Try to generate a payroll for the employee

Traceback will popup, blocking the auto generation of the "worked days"
lines. This happens because the holiday overlaps causes a recordset
filled with multiple values to be queried for the id. Taking just the
first one should be ok since the period taken into account is the full
one (merged overlaps).

opw-2236420

closes odoo/odoo#49598

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The validity_date and/or remaining_validity_days fields on the sale order
could be wrong due to different timezones.

Furthermore, using datetime.now to create a date is unnecessary.

closes odoo/odoo#44268

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

When editing the followers, the "pencil" icon that leads to the edition
of subtypes should be always be displayed, and not only when "debug"
mode is activated. This commit restores this behaviour, as it was not
the case any more.

opw-2144399

closes odoo/odoo#41565

closes odoo/odoo#49566

Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Similar to commit c545783b but for the
`name` field on `account.invoice`.

opw-2224866

closes odoo/odoo#49414

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Continuation of 456eceb0 in case
products are not shared.

opw-2228350

closes odoo/odoo#49532

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Use `float_compare` when checking if 'Mark as Done' must be displayed.

opw-2234824

closes odoo/odoo#49427

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

1. Set Decimal Accuracy of "Product Unit of Measure" to 6
2. Create new Unit of measure: "Thousand(s) of units", with ratio 1000.0
3. Set accuracy for Unit(s), Thousand(s) of units, kg to 0.000001
4. Create two products: "parent" (UoM: Thousand(s)) and "child" (UoM: kg)
5. Create Bill of material: parent needs 0.12 of child
6. Add 10000 of child product to stock
7. Create manufacturing order for 100.123456 of parent product.
8. Click "Produce".

The decoration of the lines is incorrect.

This happens because of Float representation at the JavaScript level,
leading to comparison such as:

`12.014999...8 < 12.015000`

It's not possible to use some kind of rounded comparison. As a
workaround, we change the way the float are compared.

opw-2234824

after this commit, cost analysis report will
be there even if bom product qty is 0.

Fixes-2224779

closes odoo/odoo#49387

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

closes odoo/odoo#49459

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Issue

	- Install Website
	- Go on your website
	- Add Media & Text
	- Replace media by video
	- Add youtube URL
	- Save
	- Play the video

	The fullscreen button is disabled

Cause

	We do not allow fullscreen on the iframe

Solution

	Allow fullscreen, it is already done for the preview

OPW-2224696

closes odoo/odoo#49423

X-original-commit: a0d9ccfa
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps to reproduce:
- install timesheet
- go to general settings > set documents layout to use 'external_layout_boxed'
- go to timesheets > list view > select all > print > timesheet entries

Previous behavior:
the first line of the report's table is missing a border

Current behavior:
borders are consistent

opw-2230710

closes odoo/odoo#49393

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Bug
===
We can not share a text with the "share content popover" widget
if the text contains a single quote (').

Task-2223641

closes odoo/odoo#48260

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#49365

X-original-commit: d82f1256
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

SIPS sometimes send empty notifications. I have been unable to find out
why or to reproduce the issue; it seems to be linked to a delay on their
end since these notifications usually arrive after a customer is
redirected back to Odoo (at least on their test account).

I'd rather log a warning for those cases (since nothing is wrong on
Odoo's side, there's just no info to act upon) instead of a full
traceback.

closes odoo/odoo#49160

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Render the payment form and process feedback from the provider.

SIPS date format can be somewhat variable, some sanitation is required
before using the data raw for the ORM.

opw-2224926

Co-authored-by: Nicolas Martinelli <nim@odoo.com>

- Create a kit product K, all storable and invoicing based on delived
  quantity
- Create a SO with K
- Validate => a picking is created
- Cancel the SO => the picking is canceled
- Reset the SO to draft, validate => another picking is created
- Validate the other picking

The delivered quantity remains zero.

The computation of `qty_delivered_method` must filter out cancled
picking as done in:

https://github.com/odoo/odoo/blob/0754590abe1b84874aa2a685fea5cbf2569383e4/addons/sale_mrp/models/sale_mrp.py#L21



opw-2232350

closes odoo/odoo#49311

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue

	- Install eCommerce
	- Create a SO
	- Add a section
	- Add a note with big text
	- Customer Preview

	The word are not broken correctly

Cause

	We added a break-all to prevent
	long URL/words overflow.

Solution

	Use work-break: break-word which
	will break the word correctly.

	Use overflow-wrap/word-wrap
	(same usage but we need both
	to ensure browsers compatibility)
	which makes sure the long string
	will wrap and not bust out of the
	container

OPW-2222814

closes odoo/odoo#49282

Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

Create a product with UoM Dozens
Sold 5x via POS
Go to the product page

The smart button does not reflect the correct quantity
(0.42 instead of 5).

Fixing by editing the SQL query, the POS already provide
the correct quantity of sold goods as it is not possible
to change the UoM. This aim to match the behavior of sale (where
is necessary to account for possible differences between the uom
reported on the sale order line and the one specified in the product
page)

opw-2227482

closes odoo/odoo#49015

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

* Outdated xml

See https://stackoverflow.com/questions/53160591/extending-default-template-odoo-12/53162439#53162439

Courtesy of EvgenijjKum from #41970.

* Outdated javascript

See https://stackoverflow.com/questions/41061604/odoo-10-how-to-create-snippets-javascript-option#41062045



closes odoo/odoo#44983

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Backport of the l10n_ch part of https://github.com/odoo-dev/odoo/commit/89d87c31801507df8e055c19bcac75c05599bd4f



closes odoo/odoo#48901

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

This number is intended to be used on payment to match them with the invoice they were made for, so it's totally sound to use it in that field.

A long time ago, commit [1] increased the limit of displayed badges
inside a many2many_tags widget, from 40 to 1000 (a large limit that
should never been reached with such a widget).

However, this solution was specific to the many2many_tags widget,
and didn't apply to its extensions (like the many2many_tags_email
widget). For instance, open the chatter full composer, add 40
partners in the recipients field and try to add one more: nothing
happens.

This commit sets the limit on the widget itself. That way,
extensions automatically have the same limit, and can override it
if needed.

[1] d4cf4374

Task : 2091027

closes odoo/odoo#47492

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Also non-browser jsonrpc (as it goes through a similar process): for
internal performance reasons, name_search and read_group have been
converted to a *lazy* name_get, so the "display name" is not
unnecessarily computed.

However this is an issue for the RPC endpoints (/xmlrpc and /jsonrpc)
as they have no support for `lazy` and thus tend to blow up and / or
do the wrong thing when trying to output a lazy:

* xmlrpc has no way to handle lazy at all and straight blows up
* jsonrpc falls back to `json_default` so they try to stringify the
  lazy, which might have worked except

*Problematically* both endpoints delegate the actual work to
`dispatch_rpc` which handles dispatching between various services and
ultimately creates a *new* cursor before calling model
methods (`object` service and `execute`/`execute_kw`).

This means by the time the result is serialized to be output, the
lazy's cursor has long been closed, and thus any access to an
unevaluated `lazy` errors out when trying to fetch the underlying
item.

This also means we can't just add a hook to serialize the lazy
in the xmlrpc marshaller, though we do have to do that. We *also* (for
both xmlrpc and jsonrpc) have to force evluation of lazy values before
our cursor is closed, meaning it has to be done right after the method
is invoked, iterating the entire response.

Related to task 2170343

closes odoo/odoo#47801

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Python 3.7 is required for function datetime.datetime.fromisoformat to
work.
Ref: https://docs.python.org/3.7/library/datetime.html?highlight=fromisoformat#datetime.datetime.fromisoformat

This is a temporary revert, to avoid rejecting perfectly valid
transactions.

Ref: https://github.com/odoo/odoo/pull/48581


opw-2179123

closes odoo/odoo#49077

Signed-off-by: Richard Mathot (rim) <rim@openerp.com>

- Activate "Product Packagings" in the Sales Settings
- Define a package on a storable product with a contained Qty of 1.8
- Sell 5.4 units of this product in an SO and use the package.

A warning is raised.

This happens because 5.4 % 1.8 = 2.220446049250313e-16

opw-2228859

closes odoo/odoo#49042

X-original-commit: f1e79c74
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

The 'Configure Variant' button doesn't show any relevant information in
case of a product variant. It is only useful for a product template.

opw-2229881

closes odoo/odoo#48965

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

before this commit: from commit: https://github.com/odoo/odoo/commit/d58d6e270f4106d717821438490f60bc4f71306e

 parent context
was propagated to sub views, propagating whole context to sub view creates
issue as it contains default_* key inside it, there is a chance that sub view
has same field name which matches with default_fieldName in context,
e.g. go to sale order form view and create sale order line, while selecting
product, write in product_id field so that Create and Edit option comes,
select Create and Edit option, so whatever previously written in product_id
field will be added in product.product form's context as default_name,
now go to Purchase tab of product form and try to create Supplier, but note
that Vendors One2many should be editable, if it is not then to produce this
issue, make Vendor o2m list editable top/bottom, as soon as you click on
Vendor o2m's create button traceback generated which comes from name_get of
res.partner, issue raised because vendor o2m has m2o of res.partner and field
name is 'name', when default_get for vendor o2m is called it will propagate context
and context has default_name='typed string in product_id', as name field is
m2o with res.partner it will generate traceback as m2o accepts (id, name) tuple
not string

after this commit: propagate context to sub view but remove default_* keys
from parent context

task-2121161

closes odoo/odoo#48990

X-original-commit: b3704989
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Currently, there's only one tax for non deductible VAT on purchase, but although the
most common one (21% percentage), it's not the only one. There can be cases where
there's 4% or 10% VAT that is not deductible.

With this PR we add that percentages to the CoA.

closes odoo/odoo#48956

X-original-commit: 5b61898a
Signed-off-by: Josse Colpaert <jco@openerp.com>

In 10.0 having a `section`, `subsection` or `subsubsection` on a footer
element would replace the content with the page top three level of
headings.

This was removed in 11.0 with b446930d after which only `page` (current
page number) and `pages` (total number of page) classes would work.

This commit reintroduces the above-mentionned classes.

opw-2226700

closes odoo/odoo#48791

X-original-commit: 14c6b947
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Co-authored-by: Nicolas Lempereur <nle@odoo.com>

Since Bootstrap 4, a popover object does not have an `option` attribute,
as it has been renamed to `config` instead.
This occurrence must have been missed out when we migrated.

closes odoo/odoo#48730

Signed-off-by: fja-odoo <fja-odoo@users.noreply.github.com>