Steps to reproduce
==================

- Enter debug mode
- Go to "Settings / Technical / User Interface / Views"
- Click on the "View Type" column header
- Click on any record
- Use the breadcrumbs to go back

Issue: the list is not sorted anymore by "View Type"

Cause of the issue
==================

When there is an `orderBy` param passed to `DynamicList`, it takes
precedence over the previous exported state.

We should only use the params.orderBy if it is not the initial one.

Solution
========

In order to know if we are using the initial order by, we need to export
it. With that, we can check if the `params.orderBy` is the initial one.
If it is the same, use the `state.orderBy`
If not, use the `params.orderBy`

opw-3202088

closes odoo/odoo#120537

Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>

And open interview forms on a new tab as well
task - 3293231

closes odoo/odoo#120067

Signed-off-by: Kevin Baptiste <kba@odoo.com>

When using a different invoicing address for a partner on a sale order,
an error is thrown up. This is caused by checking the wrong partner in
the access token.

opw-3298228

closes odoo/odoo#120759

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Steps to reproduce
==================

- Use an android phone
- Go to Timesheets
- Click on Add a line
- Click on the Hours Spent input

The keyboard is missing the colon `:` symbol

It is then only possible the enter a time in the float format.

Cause of the issue
==================

The inputmode=decimal attribute prevents a user from entering a `:`
symbol

Note that this doesn't happen on IOS, since the inputmode is ignored for
other reasons.

opw-3278089

closes odoo/odoo#120697

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Before this commit changing priority and state from sub-task
and block-by task saves the unsaved change or even create new
records even though user discard that changes.

This commit add 'auto_save' false to prevent auto save for
sub-task and block-by task page.

task-3282848

closes odoo/odoo#119330

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Before this commit state selection and priority both
field are saved we change its value even though we
are not saving records and because of that changing
state or priority in sub-task or block-by task
and discarding changes does not set them to their
previous state and it'll create new record without
saving if we change one of those field.

This commit add 'auto_save' option to prevent auto save
on state and priority from sub-task and block-by task
page.

task-3282848

Part-of: odoo/odoo#119330

Duplicate the default Account Payable (211000)
Set the default Account Payable to Deprecated
Create a Vendor Bill with a line
Save

Error will raise
The account Account Payable (211000) is deprecated.

opw-3199157
opw-3229350

closes odoo/odoo#120725

X-original-commit: 4305ea5a
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

In this commit the resupply subcontractor source location is changed from
virtual production to WH/stock

Task id: 3263796

closes odoo/odoo#120709

X-original-commit: 13f078e4
Signed-off-by: Tiffany Chang <tic@odoo.com>

Previously WO duration per unit was not getting updated in WO report, since
there was no code for updating WO duration per unit while triggering immediate
production.

With this commit, WO duration per unit is updated in WO report when immediate
production is triggered.

TaskID - 3251232

closes odoo/odoo#117441

Signed-off-by: Tiffany Chang <tic@odoo.com>

Steps to reproduce
==================

- Go to a kanban view with lots of records, for example products
- Remove any filter and group by name

There is only 80 groups, and there is no way to get the next ones

Cause of the issue
==================

The `web_read_group` uses a limit, by default of 80

Solution
========

For kanban grouped views, we don't want to set a limit on the groups

opw-3283004

closes odoo/odoo#120119

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

The commit: https://github.com/odoo/odoo/commit/58a88b7731ace08ca106f3df47dd455520136248
prevents the deletion of a 'free shipping' line
if it is not the last one in the cart.

The fix: https://github.com/odoo/odoo/commit/7004b17ee5433e3b14561358348b42326f549261


calculates the sequence of the 'free shipping' line
so that it is the last one in the cart.

Issue:
In case we have enough points to get the 'free shipping' reward
without the actual products in the cart,
if we want to delete the product, we raise an error.

Cause:
It is no longer possible to calculate the free shipping sequence
as this is based on the non-reward lines (and we have just deleted this line).

Solution:
We have to add a default value for the sequence
in case the 'free shipping' is the last item in the cart.

opw-3269594

closes odoo/odoo#120078

Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>

Database: Runbot 16

Exact steps (or video) to reproduce the issue (on runbot):
Dashboard
Sales
Select Last seven days
The figures do not include today
Remove the filter
The Order now shows but the Quotations is at zero. In the Top Quotations and Top Sales Orders sections we can see there is one of each, but the quotation
doesn't show

opw-3251869

closes odoo/odoo#118022

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

	Currently `report.stock.quantity` has a field defined in it called `move_ids`:
	`move_ids = fields.One2many('stock.move',readonly=True)`

	This virtual field has no corresponding inverse field so when performing a search_read on the model, it fails
	in fields.py when trying to do:	`inverse_field = comodel._fields[inverse]`

	In addition, this field is apparently not used anywhere in the source code and not queried in the SQL View.

	This means the model can never be search_read by default.

	Since this field is never used, it isn't stored, and the model is `_auto = False`, removing it won't break any database.

closes odoo/odoo#120696

X-original-commit: e3b1a887
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Andrew Gavgavian (andg) <andg@odoo.com>

Current behavior:
When settling a pos order containing 2 different product, the qty of the
2 products would be modified even if you only deliver one of them
through the pos order.

Steps to reproduce:
- Create 2 product A and B
- Create a sale order with 1 product A and 1 product B
- Open a PoS session, and settle the order you just created
- Deliver only 1 product A
- Close the PoS session
- Go the the sale order delivery, you will see that the qty are not
  correct

opw-3227053

closes odoo/odoo#120642

X-original-commit: 7dd5e78596718120f4c04b7ce1757ff0bd38d665
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Engels Robin (roen) <roen@odoo.com>

Before this commit, when scheduling an activity from document
inspector, there was the following crash:

```
this.saveRecord is not a function
```

This happens because scheduling an activity necessarily reload the
chatter. Chatter is mostly in form view, but in documents the chatter
is shown in kanban. `saveRecord` does not exist, as this is a form
view-specific feature.

This commit solves the issue by not calling `saveRecord` if it
doesn't exist.

opw-3295227

closes odoo/odoo#120674

Related: odoo/enterprise#40775
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Starting on version 16.0, the HTML/CSS editor is very hard to resize.
This is due to 16.0 introducing an iframe for the website: as soon as
your mouse enters the iframe, the editor loses focus and cannot be
resized anymore.
This commit fixes that.

task-3006138

closes odoo/odoo#118178

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When calculate Days to Prepare Manufacturing Order, we didn't take into
account Days to Purchase and Security Lead times for Purchaseing of the
company. In this commmit, if the (sub-)bom has company_id set, these two
days will added to the calculation.

Task-3078049

closes odoo/odoo#116563

Related: odoo/enterprise#38713
Signed-off-by: Tiffany Chang <tic@odoo.com>

In this commit, when user has created a transporter from the invoice view and if it's forget to enter GSTIN
Then we throws error to set GSTIN in transporter

transporter always have GSTIN, without having GSTIN any one is not allowed to transport goods in India.

task - 3262215

closes odoo/odoo#120146

X-original-commit: d09c9358
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

Steps to reproduce
==================

- Go to /web/signup
- In the password field, type something
- Clear the input

Cause of the issue
==================

A bunch of conditions evaluates to NaN inside
`ConcretePolicy.score(password)` when passing en empty string as a
parameter.

Solution
========

An empty password should always have a score of 0 anyway, so we can
do an early return. (The lengthscore would be 0, and we multiply by it
at the end)

opw-3269555

closes odoo/odoo#120672

Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>

The documentation PR https://github.com/odoo/documentation/pull/4315/


adds a new doc page about cookies bar. This commit adds a link in the
Website settings, next to the cookies bar feature.

Task-3297795

closes odoo/odoo#120639

Related: odoo/documentation#4315
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps:
- In eCommerce activate Filter by prices and Attributes & variants filters
- select one attribute with >1 item (e.g. aluminum legs)
- put a price limit.
- the attribute filter is removed.

The commit will prevent the removal of the 'variants attribute filter'
when an attempt is made to apply a price range.

task-3101343

closes odoo/odoo#120647

X-original-commit: 28bb2cc7
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Steps to reproduce
==================

- Open a product form view
- Enter .5 in the Cost field

It is parsed as 5 but it should be 0.5

Cause of the issue
==================

When trying to strip the currency symbol from the input, the leading
decimal separator was also removed

Solution
========

Adapt the regex by adding the decimal separator in the list of
characters to not exclude

For that, we first need to replace the decimal by a dot as it could be multiple
characters long. (The same is done in `parseNumber`)

opw-3270039

closes odoo/odoo#119651

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

closes odoo/odoo#120603

X-original-commit: 8aefb386
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

In V16 visitor are unlinked after 60 days https://github.com/odoo/odoo/blob/16.0/addons/website/models/website_visitor.py#L351

 (in V14 it is archived). After a migration a large database should unlink lot of visitor.
Before this commit the time to unlink are very long (some days).
After some hours.

closes odoo/odoo#120454

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

On small viewports, and with the "Same as desktop" option enabled on
header, The "autohide menu" adaptation is disabled and overflowing
menu items are visible.

The goal of this commit is to fix this behaviour by keeping the
"autohide" feature enabled on expanded navbar.

task-3261909

closes odoo/odoo#120395

X-original-commit: 615ef8d0
Signed-off-by: loco-odoo <loco@odoo.com>

Previously, a user could link his own expenses to a expense sheet
of someone else.

This would not be allowed upon creation but was allowed when updating
the values of the expense.

This commit add a simple check at the beginning of the write()

closes odoo/odoo#120610

X-original-commit: 7bcd64c5
Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>

The correct behavior for the gift cards should be that the value of the gift card is equal to the value of the order line.
For example :
- 50$ giftcard -> Apply discount 50% on the order line -> 25$ gift card
If we want to apply a discount on a gift card we need to use the global discount

The commit we are reverting was forcing the value of the gift card to be the base value of the order line.

This reverts commit 83ceeecde76a859749d0659d6c387d95155c8425.

OPW-3264945

closes odoo/odoo#120579

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Steps to reproduce:
- create an expense product, re-invoice: "at cost"
- create a sale order with the product and set an analytic account
- create a purchase order with the expense product and the same analytic account
- create the bill
-> a new line on the SO is created with the same "Quantity Delivered" as the "Quantity Invoiced" for the purchase order
- for the bill, create a Credit Note of x unit
-> the purchase order has the Quantity Invoiced diminished of x

Issue:
- the Sale Order has not taken into account the new quantity after refund
- Since the line is an "analytic" one, the quantity delivered cannot be changed even if we wreate a credit note for the invoice

Solution:
During the processus of creation of new analytic lines, instead of creating new so lines we adapt the analytic line

closes odoo/odoo#120370

X-original-commit: 024e9c6c
Signed-off-by: William André (wan) <wan@odoo.com>

Create 3 invoices for customer (A: $100, B: $300, C: $200)
Have a customer payment of $500
Reconcile the payment, in the widget add the line in the order:
- Payment line
- Invoice A
- Invoice B
- Invoice C (partial payment)
Reconcile
Check invoices

Issue:
C will be fully paid, the partial payment will be applied to B
After 5b2c1d24
We order the lines by amount currency but the user provided order is
lost. Moving the original fix to point of sale

opw-3240586

closes odoo/odoo#119726

X-original-commit: 46974c0f
Related: odoo/enterprise#40310
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Override the button_draft method, in order to
reset the expense and expense_sheet state
when resetting a move to draft.

Steps:

- Create an expense
- Submit and approve the report
- Post journal entry and register payment
- Reset the JE to draft
-> The expense and expense sheet states
   remain the same as before resetting
   to draft. They should be respectively
   'approved' and 'post'

opw-3279364

closes odoo/odoo#120585

X-original-commit: 9122f4158c7188db656810f01822c063e1da5b76
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>

Portal shows all Sale Orders available for current user. For example, salesman
can see his sales. If such a user can download digital files via product form in
backend, it makes sense to let user download them via SO page on portal.
However, it wasn't the case because /my/download requires product be purchased
by current user [1]. Fix it by checking read access first.

STEPS

* in backend create SO with digital product (customer must be different from
current user)
* create invoice and register a payment
* navigate to portal  (without using customer's token),
* open SO, click download on digital product

[1]: https://github.com/odoo/odoo/blob/1a24477fab4dd323cf94c010321d8942fb2c1a01/addons/website_sale_digital/models/account_invoice.py#L14-L22



opw-3144600

closes odoo/odoo#120571

X-original-commit: 17780c6a
Signed-off-by: Morgane Demesmaeker <edm@odoo.com>

To reproduce the issue:
1. Install `mrp`
2. Send a RPC to create a new BoM:
   - `{"product_tmpl_id": 1, "product_qty": -1}`

Error: It will generate a traceback

Because of the negative product qty, the RPC triggers a SQL constraint
that we try to return. However, the context does not have any `lang`,
hence the traceback

sentry-4088426130

closes odoo/odoo#119341

Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>

Partial revert of b15116179e71040ffa01bb35161e32b16aac477d .
This fix introduced a new bug: when creating an write-off with taxes from the bank reconciliation widget, signs were all inverted in the tax report, because that commit was forcing the values of tax_tax_invert in a wrong way.

The proper fix is to fix the computation of the is_refund field in community, so that negative repartition lines are taken into account ("debit" is a refund for a "sales" tax only for positive repartition lines, for example).

Community part is in https://github.com/odoo/odoo/pull/120152



closes odoo/odoo#120152

Related: odoo/enterprise#40553
Signed-off-by: Laurent Smet <las@odoo.com>

Cash basis taxes use a distinct transition account on their tax lines; the tax account set on the repartition lines is only used when the payment is received, on the cash basis move.

In enterprise, the bank reconciliation widget allows setting a tax on the manual write-off done for a statement line. When doing so, we expect the tax to behave just like on an invoice. For cash basis taxes, this means the "final" tax account has to be used instead of the transition one ; it wasn't the case.

OPW 3255511

Part-of: odoo/odoo#120152

This test will help making stats on routing_map generation performances

This will help to mesure the time for the main `None` routing map as
well as for website1, the idea being that it would be possible to
mutualize a part of this computation between routing maps.

closes odoo/odoo#120544

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

This commit updates the documentation link in the settings tooltip, as
introduced by the documentation PR
https://github.com/odoo/documentation/pull/3762/


A redirection rule is added in that doc PR to act as a fallback.

closes odoo/odoo#120526

Related: odoo/documentation#4333
Signed-off-by: Tiffany Chang <tic@odoo.com>

Before this commit:

When a new link a created on a new sentence, and clicked on it opens a popover,
when your start hitting backspace then as your reach the extreme left it throws
a trace-back error.

After this commit:

Trace-back error is not thrown while deleting backward it does not throw
back.

closes odoo/odoo#118583

Task-id: 3252709
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Steps:
- Go to website/shop (with price range widget enabled)
- Change the language to Arabic

Issue: the numbers on the price range widget are overflowing

Cause:
The element leftCounter's right style property is always set to 0px.
So when changing the direction it's always on the right as his position
is absolute.

Solution:
Built-in handle by Bootstrap with end-0

Fixes #108557
opw-3221051

closes odoo/odoo#117144

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

The file uploader uses a context key `default_journal_id` to identify the journal to upload to. With commit https://github.com/odoo/enterprise/commit/0d7d1a2994f14b80cd8f3644871f87a472821741

, we attempt to reconcile imported transactions immediately. When reconciling, if there is a partner and an account number, the res.partner.bank is created.

Problem:
When creating a partner bank account, the default_journal_id is in the context, and is interpreted as a default value, which causes a stack trace.

Solution:
Explicitly specifiy the journal_id when the partner bank account is created, so there is no invalid value when obtaining defaults.

task-3299109
opw-3291805
opw-3291064
opw-3291024

closes odoo/odoo#120509

Signed-off-by: Laurent Smet <las@odoo.com>