- Create 3 products: A, A1 and A2
- Create a BOM kit: A is a kit containing A1 and A2
- Purchase 1 unit of A
- Receive the quantities

The Received Quantity is set to 2 instead of 1.

This happens because `_update_received_qty` is not called as expected.
Indeed, `purchase_mrp` must depend on `purchase_stock` since it
overrides `_update_received_qty`.

opw-2166749

closes odoo/odoo#43097

Related: odoo/enterprise#7712
Signed-off-by: Christophe Simonis <chs@odoo.com>

Previous versions of this action had a context. It was removed at odoo/odoo@2d3e6d7383aaa3c1589f22
Set explicitly an empty context to force the removal when upgrading the module. Fine tunning of odoo/odoo@93465630090e2c42

closes odoo/odoo#36007

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

The `unsubscribe` feature of mass mailings repose on having a link with
HREF attribute `/unsubscribe_from_list` inside the mail message.

When the mass mailing is sent:

- relative URL are replaced by absolute URL (`/unsubscribe_from_list` is
  replaced by `{system parameter web.base.url}/unsubscribe_from_list`)

- `{system parameter web.base.url}/unsubscribe_from_list` is replaced by
  the real mass mailing link containing info that will be used to
  unsubscribe the user.

But there was an issue in the case of multiple domain, if this scenario
happened:

- system parameter web.base.url is http://domain1
- a user use "Test" button on a mass mailing
- system parameter web.base.url becomes http://domain2


- the mass mailing is sent

The unsubscribe link is broken, this is because the implementation of
"Test Mailing" feature would update the mass mailing with absolute
links, so if the domain change, we the `unsubscribe` link will no longer
be found and replaced into the source.

opw-2124890
closes #42373

closes odoo/odoo#43277

X-original-commit: e5311b9ddb89b223486a8e1050e5c7a2d017ea07
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Fixes https://github.com/odoo/odoo/issues/43122


Before this commit, Creating Journal without Bank account number will be failed as, It tries to update Related field 'l10n_ch_postal' while bank_account_id is not set.

In this commit, we update 'l10n_ch_postal' if 'bank_account_id' is present on Journal

closes odoo/odoo#43158

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

- Create the FIFO & Automated products:
  Kit ABC: 2 variants, e.g. Black and White, invoice on delivered qty
  Kit A
  Kit B
  Kit C
- Create the BOM for the variants of Kit ABC, in this order:
  Black: 1 unit of Kit A and 1 unit of Kit B
  White: 1 unit of Kit A and 1 unit of Kit C
- Receive the components
  Kit A: 10 USD
  Kit B: 12 USD
  Kit C: 13 USD
- Create a SO for Kit ABC (Black)
- Validate the picking, create and validate invoice

The COGS is incorrect: the amount is 23 instead of 22.

This happens because the BOM selected is always the first BOM of the
product template instead of the product-specific BOM.

We select the BOM the same way it is done when it is exploded in:

https://github.com/odoo/odoo/blob/95348a5e1dc4e69ce0edaf89de1124fe55ce4ec8/addons/mrp/models/stock_move.py#L161



Note that if the BOM changed between picking creation and invoice
validation, it will fail.

opw-2153629

closes odoo/odoo#43266

X-original-commit: 7714f7ca
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: Nicolas Martinelli <nim@odoo.com>

The option is supposed to be supported:
https://github.com/odoo/odoo/blob/3316fd49247d14dd2ab39c1267ed940feafdc664/addons/web/static/src/js/views/pivot/pivot_model.js#L363



Closes #39692
opw-2169539

closes odoo/odoo#43255

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce the bug:

- Install Sales
- Configure Paypal payment acquier
- Add extra fees such as 10€ of domestic fee
- Create a customer C with an email E and with no country
- Create a quotation Q of 100€ for C and send it by email to C
- Go in the email box of E and click on the link
- Click on 'Sign and Pay' button
- Sign Q and click on 'Pay'
- Choose Paypal as payment acquier
- Process the payment with Paypal

Bug:

An error log was displayed saying:

Paypal incorrect data:
mc_gross received 100 instead of 110

PS: the domestic fee was not counted because the partner_country_id
was not set in function render defined in model payment.acquirer

Inspired from function create defined in model payment.transaction
(addons/payment/models/payment_acquirer.py +961) where the domestic fee
is counted.

opw:2167104

closes odoo/odoo#43197

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Before this commit, if the records had to be sorted according a
many2one field, and there was a sequence field on the many2one
comodel, the sequence was ignored. Now, the sequence is taken into
account like the actual server does.

Linked to odoo/enterprise/pull/7407

closes odoo/odoo#42595

Related: odoo/enterprise#7407
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

https://github.com/odoo/enterprise/pull/7407#discussion_r362451701

opw-2128922

`purchase_stock` is a required dependencies because the `stock.rule`
`stock_rule_drop_shipping` use `buy` as `action` [1].
However, it is added to the selection by the module `purchase_stock` [2].

[1] https://github.com/odoo/odoo/blob/c4b6273c9df5d8e3f3a5ee3cf52541741526280e/addons/stock_dropshipping/data/stock_data.xml#L32
[2] https://github.com/odoo/odoo/blob/c4b6273c9df5d8e3f3a5ee3cf52541741526280e/addons/purchase_stock/models/stock_rule.py#L14



closes odoo/odoo#43218

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

[FIX] mail: fix issue when posting a message on a document whose first message / parent is not readable

How to reproduce
================

Have a portal user commenting a task on the customer portal. He may experience
a crash if previous message / first message is not available, for example
if it is internal or not published.

This is due to reference computation used in outgoing emails as it is based
on parent messageID. Accessing it crashes although it should not as it is
used only for technical purpose.

Fix
===

In this comme we fix that issue by browsing the reference message as sudo
to access its messageID. A test is added to avoid regressions.

Task ID 2061760
PR #36845

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: jpr-odoo <jpr@openerp.com>

Steps to reproduce the bug:

- Create an analytic account AA
- Create a journal entry with a debit(L1) and a credit(L2)
- Set an analytic account on L1
- Validate the journal entry and an account analytic line AAL has benn created
- Go on the journal item  L1 by the menu Journal Items
- Remove the analytic account of L1

Bug:

The account analytic of AAL was still AA

The AA of a journal item cannot be changed when the entry is posted.

opw:2158057

closes odoo/odoo#43214

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Steps to reproduce:
- install sales
- go into debug mode
- dev tools > start tour > sale_tour

Previous behavior:
tour would fail after creating the "Agrolait" partner.
the test would not wait for the return value of the
customer selection.

Current behavior:
the test waits for the customer to be fully selected and does not fail.

closes #40569
opw-2091797

closes odoo/odoo#43172

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce the bug:

- Create a Sale Tax T and the field account_id set and let the field refund_account_id empty
- Create a customer invoice CI with a line with T
- Validate CI
- Add a credit note and fill the reason
- Click on 'Add credit note'

Bug:

An error was raised.

opw:2154932

closes odoo/odoo#42488

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Followup to odoo/odoo#43117 (backporting from something which breaks
in 12.3): if the o2m somehow has an id field, this field should be
ignored when extracting values to save, for the purpose of both
actually saving and extracting values for e.g. default_get.

closes odoo/odoo#43204

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

In the SSF, o2m updates get initialized with no values (1, id,
{}). The record data is only fetched when the "record" gets updated
explicitly from which updates will hopefully get properly tracked &
saved.

However if the "record" was first initialized through an onchange
values which are updated by the onchange (diverging from the db) those
would not get tracked and thus wouldn't get saved when the record is
saved.

* use more specific placeholder (None) for "o2m records to update but
  we don't have values yet"
* once we have values, always store them as an update-tracking dict
* if we don't have values yet for an o2m and an onchange is trying to
  write to it, initialize with values from database first (might
  eventually be a good idea to initialize upfront though there's the
  question of what happens for default values and recursive views)
* mark anything coming back from the onchange and differing from local
  values as changed (so they get sent out on save)
* properly reify parent values for onchange instead of sending them
  as-is
* the evaluation context for contexts (and domains) needs properly
  formatted values so use `_values_to_save` to get them, however it
  cares about neither required-ing nor filtering out e.g. unmodified
  fields, therefore add an awful toggle to handle this

Task 2150302

Probably todo in the future:

* better UI for change-tracking dict, should have "snapshot"
  support (to freeze / discard previous changes)
* cleanup save, it's unclear that it properly resets the form

closes odoo/odoo#43117

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Steps to reproduce the bug:

- Let's consider a delivery method DM with fixed price of 10€ and a margin of 20%
- Let's consider a storable product P
- Create a SO for P and get the rate (12€) but don't add it on the SO
- Confirm the SO and process the delivery

Bug:

A SO line was created for the freight cost without the margin. So it was 10€
instead of 12€.

opw:2144894

closes odoo/odoo#43083

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

It happens that people modify the product on done stock.move.line
(it's not possible without customisation, at least allow to import or
to modify product and lot_id in the same view).

During the write on stock.move.line only the lot,locations,package and
owner are update on the quant. Not the product since it's not suppose to
be modify. It leads to a stock.move.line with a correct information but
a total mess on the quants with a lot updated and the previous product.
Since the product is not modified, the product on the quant and the
product on the lot linked to the same quant are different.

closes odoo/odoo#43145

Task: 2119471
X-original-commit: 3ec96c30
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Closes #21527

closes odoo/odoo#42778

X-original-commit: 4e8ec502
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

In this commit,
-The behaviour of drag and drop is blocked when grouping the
 operation type and warehouse on inventory dashboard.

closes odoo/odoo#42929

Task-id: 2167610
Related: odoo/enterprise#7651
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>

Issue

    - Install Projects & Studio
    - Go into projects app
    - Edit a project (... => Edit)
    - Click on x attachments stat button

    You can't edit with studio

Cause

    Writing the action manually instead of using the base one
    result with an empty xml_id (and a lot of missing data).

Solution

    Use base.action_attachment like others modules do (e.g. helpdesk).

OPW-2146741

closes odoo/odoo#43108

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Issue from rim:

    In runbot 12.3
    - Go to Purchase
    - Create a PO with one product line: qty 1 / unit price 1000
    - Validate the PO and create the Invoice
        => DON'T VALIDATE THE INVOICE YET
    - Go back to the PO, change the unit price to 2000
    - Go back to the invoice, validate it
    ==> the PO is marked as "fully invoiced" because the qty "1 unit"
        is counted as "invoiced"

    => we should not be able to change the price of a line that has
        already been invoiced, even in draft

Cause

    It seems that in all the PO's invoices state, we can edit a PO line.
    No restriction?

Solution

    Set the line price column to read only when they have a linked
    invoice.

OPW-2161477

closes odoo/odoo#42749

X-original-commit: f65fe4c409f86ee859d0713354aaac4d032100b6
Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>

Backport of commit 9ba3fc4c8767498890f7b5c4126f3bf2017efc97

Usecase to reproduce:
- Set a product with routes: MTO + Buy
- Create and valide a SO
- Cancel the delivery
- Cancel the RFQ linked

-> The delivery will be switch to confirmed state while it should remain
cancel.

It happens because the button_cancel on purchase.order call
_recompute_state on move. _recompute_state modify the state to confirm,
partially_available or available depending the reservation status.
Howver it should never be call on 'draft', 'cancel' or 'done' moves
since it would modify their state.

A fix would be to filter the set of moves in order to exclude moves that
are cancel, done or draft before using _recompute_state. However this is
easy to forget and the issue would be probably redo in the future.

A more stable fix is to add the filter in the _recompute_state directly.

closes odoo/odoo#43051

Task: 2157543
X-original-commit: 856ac41a
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

closes odoo/odoo#43020

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:
- install contacts and vat number validation
- setup your company country to "Netherlands"
- go to contacts > add a company > try to add a dutch vat number
 (NL264077921B03)

Previous behavior:
Proper vat numbers are considered unvalid and raise a ValidationError

Current behavior:
Specific check added for dutch vat numbers

Related:
http://kleineondernemer.nl/index.php/nieuw-btw-identificatienummer-vanaf-1-januari-2020-voor-eenmanszaken
https://business.gov.nl/regulation/using-checking-vat-numbers/
http://www.pruefziffernberechnung.de/U/USt-IdNr.shtml



opw-2166380

closes odoo/odoo#43023

X-original-commit: 1dcd03d1
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: Nicolas Martinelli <nim@odoo.com>

closes odoo/odoo#42994

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Using a lazy translator as this file is processed when loading the web
client, no during rendering (the translation memory was not ready yet).
Turn escFormat into a lazymethod to evaluate it only after translation
resolution.

Fixes odoo/odoo#36494

t push de#

closes odoo/odoo#42502

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

- Create a journal.
- Create a vendor bill on this journal.
=> Odoo allows you to set a starting sequence number for your invoice.

This number must always use the sequence used when posting the invoice.
However, the invoice date was taken instead of the accounting date.

Before this commit, when setting an invoice date at Y and an accounting date at Y - 1,
the edited sequence was the one in Y - 1 but at the one in Y was used at the validation.

closes odoo/odoo#42915

X-original-commit: d7320c15
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

closes odoo/odoo#40907

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>

Steps to reproduce the bug:

- Create two fiscal positions fp1 and fp2
- Create a customer C with fp1
- Create a SO for C and set fp2
- Create an invoice for the SO

BUG: The fiscal position of the SO was set to fp1.

Now the fiscal position of the SO is kept when creating an invoice
from a SO (technically, is changed and restored back).

It was solved in c2f15d3f, but due to the refactoring introduced in 389bd53a,
it was lost again due to merge slots.

This code is optimized. Doing this way, we avoid side effects of the onchange executed after the creation of the invoice.

@Tecnativa TT20585

closes odoo/odoo#40156

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: Jairo Llopis <jairo.llopis@tecnativa.com>

Install stock, go to Configuration>Settings, activate "Storage
Locations". Go to Configuration>Locations select locations and print

The reported will not follow the documentation, barcode will be one
after the other and not side by side, arranged in a 2x2 grid.
Fixing require to apply style changes since new bootstrap
code is not handled well by wkhtmltopdf

opw-2162698

closes odoo/odoo#42913

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Fix an error which occurs during an attempt to access the string
attribute of a non existing measure
If a pivot view is defined with a "string" attribute of a field of
type "row", e.g.

   <field name="stage_id" string="Stage" type="row"/>

an error was raised "TypeError: measures[name] is undefined"

closes odoo/odoo#42844

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Issue

    - Install Blog
    - Create a post
    - Remember the last update date
    - Visit the post
    - Check the last update date

    After visiting the post, the last update date changed.

Cause

    In the web_blog main.py controller, we increase the visit
    count with a write, so the write_date is updated.

Solution

    Keep the old write_date by forcing it.

OPW-2166289

closes odoo/odoo#42897

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Steps to reproduce:
-install fleet, studio, invoicing
-go to fleet > create a vehicle with no driver
-go to invoice > create
-add a many2one field related to "vehicle"
-create an invoice and check the vehicle list

Previous behavior:
vehicles with no driver are not shown in the list
(this does not happen in 13.0)

Current behavior:
vehicles with no driver are shown

opw-2156160

closes odoo/odoo#42542

Signed-off-by: mightyjol <jhk-odoo@users.noreply.github.com>

closes odoo/odoo#42729

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce the bug:

- Creante a vendor V with a lang in French
- Set lang English on your user U
- Log with U
- Create a lunch.order.line for V
- Click on Lunch: Order meals

Bug:

The email was sent in the lang of U instead of V.

Fine tuning of 8708ef16

opw:2155628

closes odoo/odoo#42736

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

- Create a customer invoice.
- Validate it.
- A payment reference (`reference`) is given.
- Refund it in any of the options.

The `reference` field is kept, so when the refund is validated the same
reference is used.

The `reference` field should be cleared so a new one is generated.

opw-2159166

closes odoo/odoo#42818

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

`run_action_` hooks don't always return a value, in which case
invoking run() over RPC will raise a TypeError (though the call itself
should still succeed).

Somewhat oddly, "standard" hooks (e.g. in mail) generally do
things safely and return a `False`, but the "builtin" hooks (code,
object create and object write) tend to return nothing, and thus break
when invoked over RPC.

Fixes #42268
Closes #42272

closes odoo/odoo#42790

X-original-commit: 9ad01ef2
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>