Missing translation

opw:2782254

closes odoo/odoo#86139

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

- Steps :
Create 4 Services :
	> Product Type : Service
	> Create on Order : Project & Task
	> Unit of Measure -respectively- :
		>> Hours (H),
		>> Days  (D),
		>> Units (U),
		>> g     (Other).
Create a SO with the for of them (1 uom_qty for each) and confirm.

- Expected :
For both the 'Planned Hours' on the Tasks
and the section 'Sold' of the Project Updates,
the conversion to time should be processed as follows :
H     : qty =     uom_qty [Hours]
D     : qty = uom_qty * 8 [Hours]
U     : qty =     uom_qty [Hours]
Other : qty =           0 [Hours] or uom_qty [uom]

- Issues :
The Task linked to SOL (Other) has 1 Planned Hour i/o 0.
In Project Updates, uom (U) is Units i/o Hours
and uom (Other) is Hours i/o g.

- Fix :
This fix corrects everything as expected.

opw-2784992

closes odoo/odoo#87469

Signed-off-by: Xavier <xbo@odoo.com>

If we add the graph view of project in the dashboard
And we access the dashboard a traceback appears

Cause: Unable to evaluate the context because the following information
is missing: "active_id" which is used in the domain

https://github.com/odoo/odoo/blob/4d864c05dfa8f9be25d41bbae318f75a61d0cde2/addons/board/static/src/legacy/js/board_view.js#L254

the solution is to add `globalContext` to the `contextToSave`

https://github.com/odoo/odoo/blob/7e77bb74bfa1bfef92c6d385dedc2d89e0040780/addons/board/static/src/add_to_board/add_to_board.js#L37-L43

`View` is `undefined` because the `project_graph` view is made with OWL
and board is still in legacy

https://github.com/odoo/odoo/blob/4d864c05dfa8f9be25d41bbae318f75a61d0cde2/addons/board/static/src/legacy/js/board_view.js#L274

Since https://github.com/odoo/odoo/pull/84864



The solution is to add a legacy version of the `project_graph`

Apply the same fix for `project_pivot`

opw-2791672

closes odoo/odoo#86571

Signed-off-by: Achraf <abz@odoo.com>

Before this commit
On mobile, clicking on a powerbox item called the first command.

After this commit
On mobile, clicking on a powerbox item call the clicked item command.

task-2751059

closes odoo/odoo#83813

Signed-off-by: Antoine Guenet <age@odoo.com>

task-2751059

Part-of: odoo/odoo#83813

Demo data to improve the flow of testing the edi. A bank account and a
partner with a street/city/zipcode/codice fiscale are required for the
edi, so having these as demo data is useful.
The demo company vat code and codice fiscale are also changed to those
of a valid company, so that they will be accepted by the sdi testing
environment. The address of the demo company is updated so that, if by
accident, an invoice is sent using the demo company, through the
official channel, the address will make it an obvious test.

closes odoo/odoo#87809

Task-id: 2809328
X-original-commit: f8da2dbe
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Daniel Kosky (dako) <dako@odoo.com>

This commit removes the multilang feature on the /web/login/totp controller,
it doesn't really add value since it triggers a redirect and that the page is
all the same translated.

It is a good practice by default for SEO, but in this case it brings
some bug with the IOS apps that doesn't follow the redirect, while we don't
need to optimize this page for Search Engine.

The bug into the IOS apps, create a loop when we request the totp screen.
    Device request /web/login/totp
    Server ask a redirect to /fr_FR/web/login/totp
    Device redirect to /web/login/totp
    Server ask a redirect to /fr_FR/web/login/totp
    ...

closes odoo/odoo#87772

X-original-commit: 4dea1b9b
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Jérémy Kersten <jke@odoo.com>

Improve 06188f61

The user does not have the possibility to create a delivery to the
inter-warehouse transit location (the destination location is
invisible). Same for the receipt.

So, the user should only avoid transferring some products between two
warehouses if the internal transfer is a planned one.

closes odoo/odoo#87808

X-original-commit: 09fd3867
Signed-off-by: Arnold Moyaux <arm@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

On large databases, the method `_compute_new_application_count` could
take up to 80% of the total loading time of the Job positions as each
job was generating 2 queries.

closes odoo/odoo#87773

Taskid: 2812400
X-original-commit: b5988a23
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Task: 2760136

Currently, when a credit note is created there is a message in the chatter "Invoice created", which is not coherent.
- Credit Note creation message should be "Credit Note created"

closes odoo/odoo#87758

X-original-commit: c45d641d
Signed-off-by: Olivier Colson <oco@odoo.com>
Signed-off-by: Tastemirova Aliya (alta) <alta@odoo.com>

Reproduction:

1. Duplicate an expense and save it
2. The subtotal field is not copied to the new expense

Reason: the field untaxed_amount is a compute field which is not copied
by default

Fix: set the copy to True for this field. It’s a patch for fix:
45fcd62205aeb73937cc6def35939e63eee01400

opw-2725901

closes odoo/odoo#87755

Signed-off-by: Kevin Baptiste <kba@odoo.com>

When an event is created in Outlook by an Outlook user (user A) who does not
exist in Odoo but who invites an Odoo user (user B) who syncs his calendar with
his Outlook calendar, the event will appear in the user B Odoo calendar.

If user A cancels this event in Outlook, then when user B syncs his Odoo calendar,
the event must be removed.

closes odoo/odoo#87542

Task-id: 2746046
Signed-off-by: Arnaud Joset <arj@odoo.com>

If applied, this commit will fix the following bug by changing the
price used in the discount calculation equation to be the real price.
the two prices differs when mapping a tax inculded price to a tax
excluded price

Steps to reproduce:

1- install sales - accounting
2- create a product p with customer tax t
3- create a fiscal position for a country (belgium for example) that
maps t to a lower value tax.
3- create a pricelist pl with discount d
4- create a new SO, add a customer from belgium, add p, then select pl,
 click on update prices
5- the discount is not d, it is calculated based on
(p price - customer tax)

in comparison to:
4- create a new SO, add a customer from belgium,  select pl first, add p
5- the discount is d.

Bug:

the wrong price is being used for discount calculation

Fix:

calculate and use the correct price similar to the normal behavoir when
the pricelist is selected first

OPW-2745421

closes odoo/odoo#86984

X-original-commit: f3469cba
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Feyens Victor (vfe-odoo) <vfe@odoo.com>

Step to reproduce:
- In the accounting setting 'Line Subtotals Tax Display' set on
 'Tax - Included'
- 2 taxes: One with Taxes included (B2C) and one with taxes
 excluded (B2B)
- 1 Rental and selling product with tax-included price
- 2 clients: one is particular and the other is a company
- Fiscal position assigned to company client:
 Fiscal position map B2C tax with B2B one

Current behaviour:
- Tax mapping apply multiple times and end up with
 a wrong displayed price
- This is because rental price should not be recomputated
 on qty change

Behaviour after PR:
- Tax mapping is only applyed once in the rental wizard

PR in enterprise odoo-dev/enterprise#

opw-2783040

closes odoo/odoo#86290

Related: odoo/enterprise#25216
Signed-off-by: Damhaut Florian (flda) <flda@odoo.com>

When using the widget res_partner_many2one (e.g. in the customer invoice
form view), the VAT number disappears when being in 'edit' mode.

This is caused by the '_getDisplayNameWithoutVAT' function, which was introduced
in PR https://github.com/odoo/odoo/pull/29189

, because the VAT appeared in edit mode
but disappeared when saved at that time.
Since the VAT no longer disappears when saved, we no longer need this function
removing the VAT from the edit mode.

task-2749331

closes odoo/odoo#84537

Signed-off-by: Laurent Smet <las@odoo.com>

In the dashboard of Time Off, when clicking on New Time Off, there is a difference of
one day between the start and end date and the duration of the time off shows one day.

By default, when clicking on the New Time Off button, the start and end date should be
the same with a duration of one day.

task-2760487

closes odoo/odoo#84279

Signed-off-by: Kevin Baptiste <kba@odoo.com>

In hr_holidays_attendance, the model that inherits from res.users adds a request_overtime field.
This field is used to allow the user to request overtime based on the total overtime.
The domain for the time off type includes has_valid_allocation. If the user doesn't have any allocation,
he won't be able to deduct extra hours

task-2701128

closes odoo/odoo#82126

Related: odoo/enterprise#23203
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Have 3 moves named 0, 1 and 2
Delete move 1 to make a hole.
Resequence, starting the sequence at 2.

Expected: new names are 2 and 3

Result: an error because 1 is renamed to 2 but 2 still exists, leading
to a (temporary) duplicated name, which is not allowed.

We clear all the names to be resequenced before doing it in order to
avoid that.

closes odoo/odoo#87395

X-original-commit: f6eec2c0
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>

https://github.com/odoo/odoo/pull/86101

 introduced a check of the number of days
of the allocation when a time off is taken.

The _compute_from_holiday_status_id method search for allocations based on employee_id.
If a holiday has multiple employees, no allocation will be found and the validation error
message asking to split the request to fit in their number of days will appear

task-2812415

closes odoo/odoo#87720

Signed-off-by: Kevin Baptiste <kba@odoo.com>

closes odoo/odoo#87591

X-original-commit: 288b5460
Signed-off-by: Olivier Colson <oco@odoo.com>

Follow up of send is_main with the attachments.

task-2783076

closes odoo/odoo#87708

X-original-commit: 9a24133f
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

When using an internal transfer to move some products between two
warehouses, the forecasted inventory becomes incorrect

To reproduce the issue:
(Let WH01 be the existing warehouse)
1. In Settings, enable "Multi-Warehouses"
2. Create a second warehouse WH02
3. Create a storable product P
4. Update its quantity: 1 x P at WH01/Stock
5. Create a planned internal transfer (the warehouse does not matter):
    - Source: WH01/Stock
    - Destination: WH02/Stock
    - Operations:
        - 1 x P
6. Mark the transfer as Todo
7. Consult the Forecasted Inventory report:
    - Filters:
        - Forecasted Stock
        - Product: P
    - Group By:
        - Warehouse

Error: The line for WH02 is missing and the line for WH01 is incorrect
(qty is 1 for next days while it should be 0)

The report used (`report_stock_quantity`) does not handle this transfer.
Because both locations (source and destination) are defined, the SM is
not considered as an in-move or out-move:
https://github.com/odoo/odoo/blob/07f0ffad6ecc08f4165902db45ae96e4b41199e8/addons/stock/report/report_stock_quantity.py#L38-L43


Moreover, it would be hard to change the SQL view to generate two lines
(one 'in' and one 'out') from the same SM (the internal move).

The graph on the forecasted report of product P is also incorrect (it
uses `report_stock_quantity` to get the data, so if the user selects a
specific warehouse in the filters, the result will be incorrect)

To easy all computations, the user should rather use two pickings
(delivery+receipt) when moving some products between two warehouses.

OPW-2752017

closes odoo/odoo#87653

X-original-commit: 06188f61
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>

Since fb9c8cd6 if and inexistant
view was called after an existant view, the inexistant view would
be skipped as it wasn't called last.
This fix ensure that the last view exist before skipping the first.

Step to reproduce:
- Go to Lunch
- In kanban view click on an item

Current beahviour:
- No wizard pop-up
- Wizard is skipped because we try to open a form view in `_onOpenWizard`

Behaviour after PR:
- Wizard pop-up

opw-2809120

closes odoo/odoo#87543

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

In case you applied inventory in batch the system would create a lot of useless
stock moves and stock move lines.

closes odoo/odoo#87492

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

In version 15 when product is added or deleted, it is shown accordingly in customer display.
However, when product quantity is changed through popup, Customer Display does not update until another product
is added to order. One way to reproduce issue is to have french localization while using PoS. Since french
anti-fraud module does not let user to simply delete the added product, instead it will show popup to alter
the quantity of the product. Once user changes product quantity and closes the popup, they'll notice that
customer display will not be updated.

With this fix, customer display will update every time orderline is updated.

fixes OPW-2734487

closes odoo/odoo#87467

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Current behavior:
In some particular cases bootstrap was throwing an error "Uncaught Error: Please use show on visible elements"
wich appeared on the users screens.

Steps to reproduce:
- Could only reproduce on copy of clients Db
- Go in CRM and go in any lead
- Create a new activity
- Swap to an activity with less fields
- Then quickly put your mouse on the top of a field that just disappeared
- The "Please use show on visible elements" error appears.

Here's a video where I reproduce it on clients Db : https://watch.screencastify.com/v/gksBwwF0McirZzSFwaAP



opw-2720853

closes odoo/odoo#86743

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Italian translation added.

Add string parameter to the fields so that the filter names are more
usable. Since the filter names are taken automatically from the field
names, the string paramter allows us to change the filter names:
L10N It Edi Transaction -> FatturaPA Transaction
L10N It Edi Attachment  -> FatturaPA Attachment
L10N It Send State      -> FatturaPA Send State

closes odoo/odoo#87705

Task-id: 2795241
X-original-commit: 6473aa55
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Daniel Kosky (dako) <dako@odoo.com>

Current behavior :
When you delete a record (for example project.task), all the messages related
to this record aren't deleted.
This, in case a user has his notifications managed in Odoo, may prevent him
from accessing the History tab in the Discuss app because these messages are
linked to a record that doesn't exist anymore and it will raise a Missing Record
error

Steps :
*with demo data*
- Install Project
- Make Marc Demo notifications managed in Odoo
- Delete a task project to which Marc Demo is assigned
(*with Marc Demo*)
- Go to Discuss and try to access History tab

OPW-2764855

closes odoo/odoo#87663

X-original-commit: d3e5fd80
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Signed-off-by: Claude Thibault (thcl) <thcl@odoo.com>

Because the `savepoint` and `clear` calls are nested inside the
`assertRaises` context, if one of them happens to throw *the exception
we're looking for* the interpreter will jump back to the `with`, the
`assertRaises` will swallow the exception (and count it as a success)
and the function will end having not gone through a `yield`.

This is rather frustrating to debug as it's easy to forget that a
`with` is a control flow structure, leading to a seemingly impossible
error.

We can fix this by initializing and `__enter__`-ing the savepoint
first, but doing this by hand is a bit iffy and not really
future-proof as the addition of more fallible steps during the
initialization phase of `_assertRaises` could lead to the savepoint
not being properly disposed of. Furthermore once in the scope of the
"actual" assertRaises we want the savepoint to unwind first (otherwise
the savepoint won't be rolled back when the exception *we are
expecting* gets raised).

As it turns out `ExitStack` offers the solution to our woes though
it's a bit tricky at first glance: while modifying the cleanup queue
in-place is haram, `pop_all` allows moving cleanup callbacks from one
queue to the next.

This means we can first add the savepoint to one stack and get its
errors (if any) correctly reported, cover the rest of the
initialization, then move the savepoint from one stack to an other, in
order to correctly order the coverage of the `yield` (and the userland
code).

closes odoo/odoo#87427

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Have a Reconciliation model [DEMO] without tax
Create a bank statement
Open reconciliation widget
Select 'Manual Operation', select [DEMO], add any tax

Traceback will raise
This occur because the server will generate a line without `tax_ids`
field, that will remain undefined in the frontend

opw-2777191

closes odoo/odoo#87358

X-original-commit: affdd8d6
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

closes odoo/odoo#87648

X-original-commit: 256869b8
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

When entering a date in a datetime field, it will be in the format
`08/01/2022 00:00:00`. If we place our cursor at the end of the
entry (after the hour) and each time we press enter, the timezone
offset is applied (so if offset is +1 it does +1 hour each time)

opw-2754116

closes odoo/odoo#87634

X-original-commit: 33e8540d
Signed-off-by: Achraf <abz@odoo.com>

Reproduce:
* Create default analytic rules
* Create a quotation/sale order.

Before:
Default analytic rules were not added on sales orders, like they are on
invoices and purchase orders.

After:
Same behavior on all documents.

This behavior was mistakenly removed during a refactoring:
https://github.com/odoo/odoo/commit/3c67bb20feb42f16799b7491411e213b818c4f83



opw-2800936

closes odoo/odoo#87494

X-original-commit: ac95c4d8
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>

Purpose
=======
As it has been done for Gmail, we want to add the OAuth authentication
for the incoming / outgoing mail server.

Specifications
==============
The user has to create a project on Outlook and fill the credentials
in Odoo. Once it's done, he can create an incoming / outgoing mail
server.

For the authentication flow is a bit different from Gmail. For Outlook
the user is redirected to Outlook where he'll accept the permission.
Once it's done, he's redirected again to the mail server form view and
the tokens are automatically added on the mail server.

Technical
=========
There are 3 tokens used for the OAuth authentication.
1. The authentication code. This one is only used to get the refresh
   token and the first access token. It's the code returned by the user
   browser during the authentication flow.
2. The refresh token. This one will never change once the user is
   authenticated. This token is used to get new access token once they
   are expired.
3. The access token. Those tokens have an expiration date (1 hour) and
   are used in the XOAUTH2 protocol to authenticate the IMAP / SMTP
   connection.

During the authentication process, we can also give a state that will
be returned by the user browser. This state contains
1. The model and the ID of the mail server (as the same mixin manage
   both incoming and outgoing mail server)
2. A CSRF token which sign those values and is verified once the browser
   redirect the user to the Odoo database. This is useful so a malicious
   user can not send a link to an admin to disconnect the mail server.

Task-2751996

closes odoo/odoo#87554

Forward-port-of: odoo/odoo#87498
Forward-port-of: odoo/odoo#87040
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Purpose
=======
As it has been done for Gmail, we want to add the OAuth authentication
for the incoming / outgoing mail server.

Specifications
==============
The user has to create a project on Outlook and fill the credentials
in Odoo. Once it's done, he can create an incoming / outgoing mail
server.

For the authentication flow is a bit different from Gmail. For Outlook
the user is redirected to Outlook where he'll accept the permission.
Once it's done, he's redirected again to the mail server form view and
the tokens are automatically added on the mail server.

Technical
=========
There are 3 tokens used for the OAuth authentication.
1. The authentication code. This one is only used to get the refresh
   token and the first access token. It's the code returned by the user
   browser during the authentication flow.
2. The refresh token. This one will never change once the user is
   authenticated. This token is used to get new access token once they
   are expired.
3. The access token. Those tokens have an expiration date (1 hour) and
   are used in the XOAUTH2 protocol to authenticate the IMAP / SMTP
   connection.

During the authentication process, we can also give a state that will
be returned by the user browser. This state contains
1. The model and the ID of the mail server (as the same mixin manage
   both incoming and outgoing mail server)
2. A CSRF token which sign those values and is verified once the browser
   redirect the user to the Odoo database. This is useful so a malicious
   user can not send a link to an admin to disconnect the mail server.

Task-2751996

X-original-commit: e54d63b3c0f39fd8a05e430442cf84d1d6c8de78
Part-of: odoo/odoo#87554

Purpose
=======
Do not reset the email configuration when unchecking "is Gmail".

Task-2751996

Part-of: odoo/odoo#87554

Bug
===
When we copy a GMail outgoing / incoming mail server, an error
occurs because we try to refetch the access token, based on the same
authorization code (which can be used only once).

To fix this issue, we do not copy the authorization code (and other
related fields).

Task-2751996

X-original-commit: 2879976160bc0777cde1368ed2b69ce821c85ff1
Part-of: odoo/odoo#87554

Fixes a mistake from 0c468f6c where the uom
autocompletion was lost and adds a test to make sure it won't happen again.

closes odoo/odoo#87504

X-original-commit: b8ed1ac3
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

[REF] pos_restaurant: Split _get_payment_lines method in order to make it more inheritable, now we can add more payment fields and expand them

closes odoo/odoo#86067

Signed-off-by: Masereel Pierre <pim@odoo.com>