Skip to content
Snippets Groups Projects
  1. Oct 12, 2016
  2. Oct 11, 2016
  3. Oct 10, 2016
    • Nicolas Martinelli's avatar
      [FIX] account: analytic account on write-off · d60354aa
      Nicolas Martinelli authored
      When an analytic account is specified on a write-off move, it should be
      written on the move line linked to the write-off account, as it was the
      case in v8.
      
      opw-688635
      d60354aa
    • Nicolas Martinelli's avatar
      [FIX] base_import, base_action_rule: fix traceback · 2990060b
      Nicolas Martinelli authored
      When importing an action rule, an error occurs:
      - The import is committed when the user clicks on "Validate"
      - The import fails with a traceback when the user clicks on "Import"
      
      This is because commit 7d648542 introduces a `cr.commit()` in the
      `_update_registry`, while nothing should be committed upon import
      validation.
      
      opw-683874
      2990060b
    • Martin Trigaux's avatar
      [FIX] base: correct the translation of auth_ldap module · 3f192aba
      Martin Trigaux authored
      Invalid rst made the description rendering to crash
      
      Fixes #13695
      Unverified
      3f192aba
    • Martin Trigaux's avatar
      [FIX] point_of_sale: remove unvalid ACL · a26b805f
      Martin Trigaux authored
      The field bank_statement_id was removed at c04065ab
      The rule is no longer working and we have no link between a cashbox and a bank
      statement anymore.
      
      Fixes #13550
      Unverified
      a26b805f
    • qsm-odoo's avatar
      [FIX] website: fix FAQ Roller opening on old apple devices · f242721e
      qsm-odoo authored
      On old apple devices (IPad 2, IPhone 4, ...), the FAQ Roller could not
      be opened on click. This is because the snippet does not use standard
      bootstrap correctly and put the toggle on a <div/> element instead of
      a <a/> element.
      
      This fix forces an empty click handler on these <div/>, which allows
      standard bootstrap to work.
      f242721e
    • Christophe Simonis's avatar
      3cdf429f
    • Christophe Simonis's avatar
      67d285b9
    • Jeremy Kersten's avatar
      [FIX] stock_dropshipping: Prevent dropshipping settings erasable by code update · e2ede312
      Jeremy Kersten authored
      These data should be in no update. Else at next update, it can change the configuration
      of the production.
      
      This commit closes #13404
      Courtesy of @bealdav
      e2ede312
    • Jeremy Kersten's avatar
      [FIX] web: fix styling in many2many tag input · b770c3e5
      Jeremy Kersten authored
      Since Chrome 53.0.2785, the input select is hover the existing tag.
      With this fix, the existing tag are displayed at the right side of
      the input to create a new one.
      
      This commit closes #13655
      
      Courtesy of @8cells
      b770c3e5
    • Nicolas Martinelli's avatar
      [FIX] event_sale: confirm registration · 9548fcb2
      Nicolas Martinelli authored
      When a user registers for an event on the front-end, the confirmation of
      the associated SO will also confirm the registration. However, if a SO
      is created manually and a ticket event is added to it, the confirmation
      of the SO will not trigger the confirmation of the registration.
      
      In the second case, the registration simply doesn't exist yet at
      confirmation and is created by the method `default_get` of
      `registration.editor`.
      
      We make sure to confirm these registration when we make the final
      reservation.
      
      opw-688665
      9548fcb2
    • Nicolas Martinelli's avatar
      [FIX] account: check exchange rate · a1d6c2d6
      Nicolas Martinelli authored
      An issue occurs in the following situation:
      - Define a currency exchange rate at day 1 and day 2
      - Create an invoice at day 1, and calculate the taxes. Do not set an
        invoice date!
      - Validate the invoice at day 2
      
      The exchange rate for taxes is the rate at day 1, while the exchange
      rate for other amounts is the rate at day 2.
      
      There is actually no way to know what was the rate applied for the
      taxes at invoice validation. There are two solutions:
      - recompute the taxes at validation
      - force the user to set an invoice date and recompute manually the
        taxes
      
      The first solution might have unexpected effects, therefore the second
      solution is applied.
      
      Fixes #13473
      opw-688517
      a1d6c2d6
    • Sébastien Beau's avatar
      [FIX] purchase: copy company in picking · 1c2a7b8e
      Sébastien Beau authored
      In a multi-company environment, we need to make sure to copy the company
      of the PO to the company of the picking. Otherwise, it might happen than
      the PO as a different company than the picking.
      
      Closes #13129
      1c2a7b8e
  4. Oct 09, 2016
  5. Oct 06, 2016
    • Michael Brown's avatar
      [FIX] models: fix behaviour of 'defer_parent_store_computation' · d477dcc3
      Michael Brown authored
      
      If a model uses nested sets to maintain a hierarchical record
      ordering, then bulk inserts (e.g. via a CSV import) are likely to
      suffer from an O(n^2) performance penalty, since there is a high
      chance that each new record will require many of the existing records'
      parent_left and parent_right fields to be updated.
      
      The context parameter 'defer_parent_store_computation' may be passed
      to the load() method, in order to defer updating the parent_left and
      parent_right fields until after the bulk operation is complete.  This
      appears to have last been fully supported in version 7 (via the old
      import_data() method).
      
      It is still possible to specify 'defer_parent_store_computation',
      e.g. via an XML-RPC call such as
      
        m.execute_kw(dbname, uid, password, 'stock.location', 'load', [],
                     {'fields': fields, 'data': data,
                      'context': {'defer_parent_store_computation': True}})
      
      This will currently defer the recalculation of parent_left and
      parent_right, but does not correctly call _parent_store_compute()
      after the bulk operation is complete.
      
      Add the missing call to _parent_store_compute() to perform a one-time
      update of the parent_left and parent_right fields if needed after the
      import operation is complete.
      
      Also fix the child_of_domain() and parent_of_domain() expression
      methods, so that the 'child_of' and 'parent_of' operators give correct
      answers when updates to parent_left and parent_right have been
      deferred.
      
      Signed-off-by: default avatarMichael Brown <mbrown@fensystems.co.uk>
      
      Closes #13688 (part 2/2)
      Unverified
      d477dcc3
    • Michael Brown's avatar
      [FIX] expression: pass context to hierarchical domain operators · 22c4a0c1
      Michael Brown authored
      
      The expression context is currently passed to to_ids() but is missing
      from all calls to child_of_domain() or parent_of_domain().  These
      methods are effectively always passed a context of None.
      
      Signed-off-by: default avatarMichael Brown <mbrown@fensystems.co.uk>
      
      Closes #13688 (part 1/2)
      Unverified
      22c4a0c1
    • Denis Ledoux's avatar
      [FIX] purchase_double_validation: from waiting approval to cancel · 964f42fb
      Denis Ledoux authored
      It wasn't possible to cancel a purchase order
      within the state "Waiting for Approval", despite
      the fact the button cancel is displayed.
      
      Clicking on the cancel button just did nothing.
      
      This is now properly working, thanks to the additional
      path added by this revision, between the workflow states
      `CheckForApproval` and `cancel`.
      
      opw-688685
      964f42fb
    • Michael Brown's avatar
      [FIX] product: speed up product.template bulk record creation · 1b3d60d9
      Michael Brown authored
      
      Bulk inserts of product definitions (e.g. via a CSV import) will
      suffer from an O(n^2) performance penalty due to an unfortunate cache
      invalidation bug.  The underlying cause is difficult to determine due
      to the labyrinthine nature of the relationship between product.product
      and product.template, but some key elements are:
      
      - The "product_variant_count" field is a non-stored computed field,
        and so gets invalidated by the call to recs.modified(upd_todo) in
        BaseModel.create()
      
      - Field.determine_value() will call _prefetch_field() to repopulate
        "product_variant_count" by refetching all records from the database,
        despite the fact that "product_variant_count" is not stored in the
        database.
      
      Using the length of "product_variant_ids" directly (instead of going
      via "product_variant_count") seems to avoid this problem, possibly
      because the definition of "product_variant_ids" conveys more
      information about the circumstances in which its value must be
      invalidated.
      
      An alternative solution of making product_variant_count a stored field
      (using the same trigger as for other variant-derived fields such as
      volume and weight) works but still results in some unnecessary fetches
      and invalidations.
      
      Signed-off-by: default avatarMichael Brown <mbrown@fensystems.co.uk>
      
      Closes #13689
      Unverified
      1b3d60d9
  6. Oct 04, 2016
  7. Oct 03, 2016
Loading