This account is intended to be used on a bank journal instead of the bank account. Making it reconcilable is required so that it can be reconciled with a statement made in another bank journal (representing the actual bank account).

https://github.com/odoo/odoo/commit/7df9704845f99ad985607940386bacf691ef28db

 changed this account's type to liquidity, but that breaks the above use case, as a liquidity account is not supposed to be reconcilable at all (and so, instead of creating a writeoff, only statement_line_id is set on the check's line, and the statement balances of each journals don't match the general ledger).

OPW 2356956

closes odoo/odoo#63476

X-original-commit: 1ebc22bd
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

With a recent commit[1], we fixed the issue of false warning while changing
the partner on lead. But that fix ignored the fact that the lead has an
automatic formatting that may lead to false warning.

Right way to detect a phone number change is
  * lead phone is different from partner phone;
  * lead formatted phone is different from partner formatted phone;

If those two conditions are met we are quite sure numbers are different and
not only differs in their formatting.

In this commit we also fix inverse of phone number. When updating lead phone
value we have to use the same heuristic to update partner phone value. That
was we avoid unnecessary partner update when only formatting differs.

Tests are added to ensure new behavior and that ribbon message is effectively
trig erred with correct content.

LINKS

Task ID-2390287

[1] - https://github.com/odoo/odoo/commit/d29862c1de6208f7fdb7c8104afe0d35241d130b



closes odoo/odoo#62397

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Ijas Ahammed <ija@odoo.com>
Co-authored-by: Thibault Delavallée <tde@odoo.com>

The goal of this commit is to update the default theme
tour (steps, changes on snippets...) as in other themes tours.

The url was changed in "registerThemeHomepageTour" function since
the homepage tours are supposed to start in edit mode.

task-2375011

closes odoo/odoo#61733

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before Commit :
-when user archive a course content, it's still visible
 on the course itself, without real difference between
 active content and archived. it was confusing.

After Commit :
-now when user archive a course content, it's not visible
 anymore on the course.

closes odoo/odoo#63204

Task-id: 2411211
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

In some languages, if the thousands/decimals separators are different
from ','/'.' , when scanning a barcode that contains a decimal quantity,
the conversion won't be correct.

To reproduce the error:
1. Go to Settings > Inventory
2. Enable "Units of Measure"
3. Go to Point of Sale > Products > Products
4. Create a Product P
	- Set a barcode, e.g. 2112345000008
	- Set UoM to 'kg'
5. Go to Settings > Translations > Languages
6. Add and switch to French (BE)
7. Run one POS
8. Use the debugging window to simulate a scan
	- Enter the code, e.g. 2112345087550
		(It means 8.755kg of product P)
	- Click on "Scan EAN-13"

=> Here is the error: it actually adds 8755kg of P-product. This comes
from the quantity conversion. The barcode provides the qty as a number with
basic decimal notation (.) but later, it is converted using the user's
language configuration.

OPW-2412561

closes odoo/odoo#63406

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

If a POS has more than 5 payment methods, the display is not correct:
the list is full width when it should be on left (as long as the screen
is large enough).

This fix ensures the display is the same as the previous version,
see (from v13):
https://github.com/odoo/odoo/blob/732ba5ca51e628b9d9a7427acd30d01d83e85068/addons/point_of_sale/static/src/css/pos.css#L1213-L1215



So, if the screen is larger than 768px, the width of the list will be
limited to 34% of the display area.

OPW-2400629

closes odoo/odoo#63363

Signed-off-by: adwid <adwid@users.noreply.github.com>

Fine tuning of this commit: https://github.com/odoo/odoo/commit/6e374e25943106be84711233f3960f2f3a4b9aa9



To fix the issue when l10n_ch_qriban is not installed

opw:2416809

closes odoo/odoo#63467

X-original-commit: fd9f6aeb
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Steps to reproduce the bug:

- Let's consider a company C with l10n_ch installed
- Try to create a vendor bill

Bug:

A traceback was raised.

PS: Function _is_qr_iban has an ensure_one and when creating a vendor bill
the function _is_qr_iban by _compute_l10n_ch_isr_needs_fixing was called with no partner_bank

opw:2416809

closes odoo/odoo#63431

X-original-commit: 6e374e25
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

STEPS:
* Update cron "Calendar: Event Reminder": set Execute every 2 minutes
* create a recurring event:

  * date: now() - 8 weeks
  * time: now() + 1 hour + 3 minutes
  * Repeat every 1 week, until "now() + 8 weeks"
  * Reminders: "Notification-1 hour", "Email-1 hour", "SMS-1 hour"

* wait 3 minutes
* Wait 0-5 minutes
* Check menu ``[[ Settings ]] >> Technical >> Discuss >> Messages``
* Check menu ``[[ Settings ]] >> Technical >> Phone / SMS >> SMS``

BEFORE: you get mail/sms/UI notifications for all passed dates

AFTER: you get mail/sms/UI notifications only for the comming event

WHY: in v13.0-, recurring calendar.event records were virtual, so
_get_occurrences was used to generate those virtual records. In Odoo v14+ it's not needed

---

opw-2389877

closes odoo/odoo#62701

Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

To reproduce this issue, install the module "Accounting" in English,
then switch language to Dutch, and go to a user's form.  The selection
field for accounting groups is missing from the users' form view.

The source of the bug is the special case introduced for accounting
groups in d8c5cc13.  The groups in that
selection field are not totally ordered, and the non-ordered elements
are de facto ordered by name, which is a translated field!  In the
example above, the English version uses the field name
`sel_groups_22_23_24_25` while the Dutch version uses the field name
`sel_groups_23_22_24_25`.  Because the first one is used in the form
view, and it is not found in the model's documented fields (which uses
the second one), the field is discarded from the view.

The patch modifies the override of method `fields_get()` to consider all
the possible names for that selection field, and returns them all.

OPW-2394209

closes odoo/odoo#63423

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

This was the case before the refactoring.

task-2411114

closes odoo/odoo#62942

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Currently, scheduling the activity from the document chatter does not
appear on the kanban record on activity button.
and the 'onchange' action receives the ID of the activity that was
marked as done and thus the 'Missing record' error

So in this commit, on creation and done of activity reload the view to
update the record on kanban card.

The opportunity is taken to make a pass on all of the "reload" to add the
`keepChanges` flag to prevent from losing pending changes on reload, especially
useful in form view.

closes odoo/odoo#60397

Taskid: 2362964
Related: odoo/enterprise#14235
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Before this commit, an event listener was still active after the removal
of the attachment viewer, which caused the the onLoad function to be
called on an removed component if the component was unmounted before
the image was loaded. This commit fixes this issue by adding the
eventListener through the owl template.

Additionally, when a new image was loading, the old image was kept in
the dom until the end of the loading of the new image, this commit
also fixes this issue by adding a t-key on the image element.

part of task-2363522

closes odoo/odoo#61560

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Before that, that field was located under "Outgoing payment", which made no sense.

closes odoo/odoo#63432

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

Before this commit, quickly clicking on the unlink button of an
attachment could result in a traceback if the click happened right
after the deletion of attachment but before the rendering of the DOM.

part of task-2363522

closes odoo/odoo#63366

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Steps:
- Go to "Website" > "Go to Website"
- Click Edit
- Add an image gallery
- Add an image to the gallery
- Click the image
- Click on the Link button in the bottom-right of the side panel
- Add a link and save

Bug:
The image is too large.

Explanation:
The flex layout is not carried over to `img` when it's nested into an `a` tag. Redefining the flex layout on the `a` tag fixes the issue.

This fixes portrait images:
```css
height: 100%;
width: 100%;
```

And adding this also fixes landscape and smaller images:
```css
display: flex;
```

opw:2394953

closes odoo/odoo#63364

Signed-off-by: backspac <backspac@users.noreply.github.com>

Using group of taxes with type_tax_use='none' children messed up the sign of the tax_base_amount and line tags.

closes odoo/odoo#63418

X-original-commit: fb39ebcb
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

1) Extra Items

    Issue: Adding an extra to one menu item, automatically adds it to the other food items in the same order.

    Expected Behavior: When adding an extra, it should only be associated to
    the food item for which it was selected, and NOT applied to the other ordered items.
    For example, if I select a "Ranch" dressing for the "Chef Salad",
    the ranch should not appear as an extra for the "Cheeseburger" or "Cookie of the Day".

2) Unable to Submit Certain Orders

    Issue: Odoo prevents the user from submitting an order in the following case
    (better illustrated through an example). If you select a "Chef Salad", you will be prompted to select a "Dressing Choice",
    because the configuration is set to select one and only one extra.
    You cannot add the salad to the cart without selecting a dressing,
    nor can you proceed if you have more than one dressing selected;
    this is functioning as expected. The problem, however, comes when you
    select a dressing and add the salad to the cart, and now you try to add a
    dressing as its own order item (separate from any salad). Even though the
    salad has its own dressing selected, and the separate dressing is its own item,
    the error message: "You have to order one and only one Dressing choice" appears and
    prevents the order from being submitted. This issue may be a consequence of the behavior observed in the first issue.

    Expected Behavior: The user should be able to submit the order in
    this case because the salad had only one dressing associated with it,
    and the extra dressing is supposed to be its own item.
    This should not create a conflict with the "only one" extra logic.

Step to reproduce (edv)
Reproducible on runbot.
1) Extra Items
https://drive.google.com/file/d/1yos9coFqd55pq8qNbNs1OqGNMNSdgxDX/view

2) Unable to Submit Certain Orders
https://drive.google.com/file/d/1M0ZEElu-hYwU9bmCwEx_tqEZRAPG_UEt/view



opw-2391070

closes odoo/odoo#63228

Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

When you create a new record, you will have in this order:

- default_get
- onchange (can trigger a warning)
- _pushController => close all dialogs since ea2207af

This is an issue since the possible warning is directly hidden to the
user.

Without the change, the added test failed with:

 Warning modal should be opened
 "executing a window action with onchange warning do not hide it":
 Found 0 elements to click on, instead of 1

opw-2342273
opw-2374051
closes #61732

closes odoo/odoo#63270

X-original-commit: 0784d9ab
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Stock Valuation Layers are used for the MRP Cost Analysis feature.
Therefore, they are useful for consumable.

opw-2412668

closes odoo/odoo#63393

X-original-commit: c68e572f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

task-2330277

closes odoo/odoo#63235

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

closes odoo/odoo#63058

X-original-commit: 48f40f23
Signed-off-by: Josse Colpaert <jco@openerp.com>

This crash is caused by some of our integration code with summernote.
When clicking on a button of the toolbar, we attempt to create a range
from the current selection so that we can show the image toolbar if the
selection contains an image, but there was no check to see whether the
current selection was actually inside of the editable part of the page.
This causes issues later when we attempt to generate layoutInfo for the
image, as it will look for the editable area that contains the image and
fail.

This commit fixes that by making sure that the current selection is
inside of the editable area before adding it to the styleInfo.

opw-2376794

closes odoo/odoo#63373

X-original-commit: b26c57b4
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

closes odoo/odoo#63241

Related: odoo/design-themes#429
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

In the DB with a warehouse with a lot of stock location.
The forecasted widget return a traceback due to a memory error due
to the `_get_domain_locations_new`
(`_get_report_lines`->`read(['qty_available'])`->`_compute_quantities`
->`_compute_quantities_dict`->`_get_domain_locations`)
how returns a extremely long domain (one expression
by location in the context) to compute child location.
But the locations (put in the context) contain already
children locations because of
`('id', 'child_of', warehouse.view_location_id.id)`.

TO SOLVE
Instead of adding location in the context
(for fix 1aa6a323),
add the warehouse in the context before
calling the `_get_report_lines` in the `_compute_forecast_information`.

closes #61666

closes odoo/odoo#63217

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Steps to reproduce the bug:

- Let's consider a bank journal BJ with manual numbering activated
- Create a customer payment CP using BJ as journal and confirm CP
- Create a vendor payment VP using BJ as journal, select Check as payment method
- A Check Number with 0001 is automatically assigned to VP
- Confirm or save VP

Bug:

An error was raised saying that:

The following numbers are already used: 0001

PS: When creating the customer payment, a check number was assigned to CP even if
customer payment has nothing to do with check numbers

opw:2415170

closes odoo/odoo#63174

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

What are the steps to reproduce your issue ?

    1. Install website
    2. Connect on the website
    3. Choose Customize > HTML/CSS/JS Editor
    4. Choose "Web layout" (in "XML (HTML)" )
    5. Modify the HTML code by adding any <script> before the existing <script> (console.log whatever)
    6. Save
    7. Refresh

What is currently happening ?

    Traceback: TypeError: Cannot read property 'user_context' of undefined

How to fix the bug ?

    Target the odoo script by id in the xpath.

opw-2375490

closes odoo/odoo#63357

X-original-commit: 0b7ba571
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

What are the steps to reproduce your issue ?

    1. Install "contacts"
    2. Select list view and select one or more contacts
    3. Select "Export" actions

What is currently happening ?

    When filtering fields with text, the system only displays the corresponding
    fields, but when clicking on sub-field the text written just before
    is deleted, which prevents us to return to all fields without filter

What are you expecting to happen ?

    Filter fields and select sub-field without deleting the filter text

opw-2411928

closes odoo/odoo#63329

X-original-commit: d947ea60
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

When the topbar goes to multiple line due to too much text content to fit its
currently available space (depending for example on length of text after
translations), it will look bad before this commit because the "send message"
and "log note" have a visual effect when they are open that requires them to be
directly above the composer to look good.

Part of task-2413814

closes odoo/odoo#63320

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

This commit fix a previous fix : https://github.com/odoo/odoo/pull/62244



opw-23789781~[FIX] account: Negative fixed taxes on 100% discount

closes odoo/odoo#63089

X-original-commit: 294b25ac
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: tdetry (det-odoo) <tdetry@users.noreply.github.com>

Steps to reproduce the bug:

    - Create new project P with "Billable" unchecked
    - Create a new task T in P and log hours on the timesheet TS
    - Go to Timesheets > All Timesheets and filter for "Billable"

    Bug:

    TS was displayed even if P was not billable

opw:2394624

closes odoo/odoo#62954

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: IT-Ideas <ltu@odoo.com>

This commit updates owl from v1.0.13 to v1.2.0

See [1] and [2] for the list of changes.

[1] https://github.com/odoo/owl/commit/abb9d0b364da3a976915c092ab8d2696e5e524e5
[2] https://github.com/odoo/owl/commit/144b323d2bac7384114eb6b63670991f42943e67



closes odoo/odoo#63327

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

closes odoo/odoo#63317

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

The field is exportable but always returns false

opw-2409324

closes odoo/odoo#63070

X-original-commit: a187f45a
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

closes odoo/odoo#63298

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Journal entries coming from PoS are based in UTC instead of local time.
This commit is an improvement over 23d3856f
to add the timezone info

opw-2371863

closes odoo/odoo#63074

X-original-commit: 30ee2eba
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

Step to reproduce:
1. Install module "sale_project"
2. In Project > Configuration > Settings, turn on "Recurring Tasks"
3. Create a recurrent task
4. Set the "next_recurrence_date" for the recurrence ahead of today
5. Run scheduled action " Project: Create Recurring Tasks"
=> error: 'project.task' object has no attribute 'is_fsm'

Reason:
"is_fsm" is defined in the module "industry_fsm" and the module "sale_project" does not depend on that module.

opw-2412370

closes odoo/odoo#63027

Related: odoo/enterprise#15272
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Consider a model M with a one2many field with comodel L, such that
deleting records in M cascade-deletes records in L.  Import a bunch of
records in M with one2many lines having specific external ids.  Delete
the imported records: the database cascade-deletes the corresponding
lines, but the lines' external ids are not deleted.  Now re-import the
same records: this crashes, because the import process finds the lines'
external ids and tries to update the deleted lines!

The fix consists in checking that an external id's record actually
exists.  The existence check was removed for performance reasons by
https://github.com/odoo/odoo/pull/26496

.  We reintroduce it by resolving
the external id with a join on the model's name, which checks the
record's existence faster than an extra query.  This patch allows to
re-create the imported records' lines.

Another patch is necessary to actually update the external ids that
refer to deleted records, otherwise they remain dangling, and importing
the same records again duplicates the lines, because their external ids
do not match any existing record.

OPW 2409649

closes odoo/odoo#63077

Related: odoo/enterprise#15202
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

[FIX] account: reconciliation models: fix auto-reconciliation result when the reconciliation doesn't cover the whole invoice

Before that, using an auto-validate reconciliation model to match an invoice with a statement line with a lesser amount resulted in the creation of an payment entry with which the invoice got fully reconciled, and the difference amount was fowarded to the suspsense account in an additional line. This wasn't correct, as we expect the invoice to be only partially paid in that case (with an amount equal to the statement line's).

closes odoo/odoo#63111

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>