Skip to content
Snippets Groups Projects
  1. Nov 27, 2020
  2. Nov 26, 2020
  3. Nov 27, 2020
    • Achraf (abz)'s avatar
      [FIX] website_sale_comparison: Compare product with single variant · 7ce7452c
      Achraf (abz) authored
      What are the steps to reproduce your issue ?
      
          1. Install "website_sale_comparison"
          2. Create a product with only one variant with one attribut
          3. Click on "Go to website" smart button
          4. Enable "Customize/List View Variant"
          5. Click on "Compare" button
      
      What is currently happening ?
      
          Nothing
      
      What are you expecting to happen ?
      
          Add product to the comparison list
      
      Why is this happening ?
      
          Because the product has just one variant and attribut so odoo don't
          display it on the product page. The system cannot find the ids as
          they are not on the page
      
      How to fix the bug ?
      
          Specify the product id in this case
      
      opw-2377711
      https://www.odoo.com/web#id=2377711&action=4043&model=project.task&view_type=form&cids=1&menu_id=4720
      
      
      
      closes odoo/odoo#62419
      
      X-original-commit: dd37cd06
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      Signed-off-by: default avatarAchraf <abz-odoo@users.noreply.github.com>
      7ce7452c
    • Nicolas Martinelli's avatar
      [FIX] mrp: UoM category mismatch · 4716390f
      Nicolas Martinelli authored
      
      - Create Product A with UOM of type Unit
      - Create Product B with UOM of type Unit
      - Create BOM of type Kit on Product A with Product B as a component
        with UOM of type Unit
      - After saving BOM, change the UOM of Product B with UOM from another
        categories (e.g. kg) and save the product
      - Try to access product list
      
      A warning appears and prevent showing the products in any way.
      
      It is caused by the call to `_compute_quantities`.
      
      In this case, it is ok to skip the error. Indeed, it will raise later on
      when trying to use the kit. But at least, it gives the possibility to
      the user to access the product list.
      
      opw-2393711
      
      closes odoo/odoo#62531
      
      X-original-commit: 6de2537a
      Signed-off-by: default avatarNicolas Martinelli (nim) <nim@odoo.com>
      4716390f
  4. Nov 26, 2020
    • wan's avatar
      [FIX] account: do not precompute name of payment · 3a8247f6
      wan authored
      
      Reproduce:
      * On a fresh db, create a payment
      * Change the date to another month
      * Validate
      
      Issue:
      * The name is computed before creation because it is the first of
        journal/period.
      * It is not visible
      * It is given to the create vals of the move_id, so it is not correctly
        recomputed
      * The sequence/name  are not in sync.
      
      opw-2390747
      
      closes odoo/odoo#62297
      
      Signed-off-by: default avatarLaurent Smet <smetl@users.noreply.github.com>
      3a8247f6
  5. Nov 25, 2020
  6. Nov 27, 2020
  7. Nov 26, 2020
    • Adrien Widart's avatar
      [FIX] l10n_id_efaktur: generate efaktur · 978e1168
      Adrien Widart authored
      
      When generating an efaktur, an error is raised
      
      To reproduce the error:
      (Use empty DB)
      1. Set the company's country to Indonesia
      2. Install Accounting (account_accountant)
      3. Accounting > Customers > e-Faktur
      4. Create & Save
      5. Accounting > Customers > Customers
      6. Create a customer
      	- Set country to Indonesia
      	- Add a TVA number
      7. Accounting > Customers > Invoices
      8. Create one for this customer
      	- Add a product
      9. Save & Confirm
      10. In Action, "Download e-faktur"
      
      => An error is raised.
      
      OPW-2387843
      
      closes odoo/odoo#62435
      
      Signed-off-by: default avataradwid <adwid@users.noreply.github.com>
      978e1168
  8. Nov 27, 2020
  9. Nov 26, 2020
    • Andrea Grazioso (agr-odoo)'s avatar
      [FIX] base: avoid infinite recursion on attachments search · 9fe632e0
      Andrea Grazioso (agr-odoo) authored
      
      Steps to reproduce:
      
      Create a new local Odoo DB
      Create another company on the DB
      install the CRM module
      Create an opportunity on the CRM app for each company.
      Execute This server action (CHANGE THE res_id TO THE IDs OF THE OPPORTUNITY CREATED):
      ```
      for _ in range(0, 300):
        for _ in range (0, 75):
          env['ir.attachment'].sudo().create({'name': 'test','res_model': 'crm.lead', 'res_id': 31, 'type': 'binary'})
        for _ in range (0, 75):
          env['ir.attachment'].sudo().create({'name': 'test','res_model': 'crm.lead', 'res_id': 45, 'type': 'binary'})
      ```
      go to the Settings / Technical / Database Structure / Attachments.
      
      Server will look in endless call because the search try to retrieve
      `limit` records, but after applying company record rule we have
      `limit - e`, so it begin a second search for e records.
      Even the second search will look for limit and possibly will find less,
      starting a third...
      
      If the sub call is aware of how much records we actually need after
      checking permission, we can return the recordset if we have collected
      enough
      
      opw-2369722
      
      closes odoo/odoo#62448
      
      X-original-commit: 6a8f28c4
      Signed-off-by: default avataragr-odoo <agr-odoo@users.noreply.github.com>
      9fe632e0
  10. Nov 23, 2020
    • Andrea Grazioso (agr-odoo)'s avatar
      [FIX] stock: fix quantity on return chain · f0331181
      Andrea Grazioso (agr-odoo) authored
      
      Create a sale order for a stored product, save and confirm.
      Validate delivery
      Return and validate.
      Return (the return, so delivery again) and validate.
      Try return again.
      
      The quantity to return in the widget will be 0.
      Attempting to fix manually will worsen the situation creating negative
      quantities on further action.
      
      This occur because when creating the return the system tries to identity
      other sibling return moves to set the correct quantity
      This commit fine tunes 73de0645b730e1f1183b7c770e878b4c4ff1e0f1 aiming
      to collect quantities only on actual sibling returns (moves sharing the
      same parent)
      
      opw-2379663
      
      closes odoo/odoo#62165
      
      X-original-commit: fe8c6db1
      Signed-off-by: default avatarWilliam Henrotin <Whenrow@users.noreply.github.com>
      Signed-off-by: default avataragr-odoo <agr-odoo@users.noreply.github.com>
      f0331181
  11. Nov 27, 2020
  12. Nov 26, 2020
    • Nicolas Galler's avatar
      [FIX] mrp: carry over origin from source move in 3-step mfr · 0281dee6
      Nicolas Galler authored
      
      Behavior prior to this commit:
      
      - when the warehouse uses a 3-step manufacturing process, if I create a
      Sales Order, the MO generated does not show the SO# as "Source", instead
      it shows the MO#
      
      Behavior after this commit:
      
      - the MO source shows the SO# (similar to how it works when using the
      2-step or the 1-step manufacturing process)
      - the origins are assigned thus:
        - Delivery Picking = SO name
        - Post-prod Picking = SO name
        - MO = SO name
        - Pre-prod Picking = MO name
      
      Note:
      
      - there is no implementation change in this commit - we just ported the
      test from the original commit in 13.0 (the behavior in 14.0 was already
      OK)
      
      opw-2380717
      
      closes odoo/odoo#62432
      
      X-original-commit: 0bc86a8d
      Signed-off-by: default avatarNicolas Galler <ngaller@users.noreply.github.com>
      0281dee6
  13. Nov 27, 2020
    • Aaron Bohy's avatar
      [FIX] web: BasicModel: nested x2many and unknown fields · 2b7670e6
      Aaron Bohy authored
      
      Consider the following situation:
       - have a form view with an x2many field displayed as a list
       - the x2many field has a form view that contains an x2many field,
         which isn't in the list
       - for that x2many field, we can also open a form view to see/edit
         the related records.
      
      As the x2many field isn't in the list, when we open a subrecord, we
      modify the fieldsInfo to add the information about the x2many field
      we didn't know before. Doing so automatically applies raw changes
      that we might have stored earlier (from onchanges) for that field,
       because we couldn't apply them before knowing the type of that
      field.
      
      Before this commit, the function that applies the raw changes was
      called recursively on the dataPoint and all its children (thus on
      the x2many list datapoint), which produced a crash as this function
      is designed to work on dataPoints of type record.
      
      Actually, calling it on sub datapoints is useless, as it properly
      works recursively, and applies raw changes on x2many fields itself
      when necessary.
      
      This commit ensures that we don't call this function on list
      datapoints anymore.
      
      Closes #62334
      OPW 2389991
      
      closes odoo/odoo#62399
      
      Signed-off-by: default avatarGéry Debongnie (ged) <ged@openerp.com>
      2b7670e6
    • Xavier Morel's avatar
      [IMP] requirements: resolve compatibility issues for 3.8 and 3.9 · 648635de
      Xavier Morel authored
      
      Only updates outdated requirements which actively cause issues:
      
      * freezegun broken in 3.8 (removal of time.clock)
      * xlrd broken in 3.8 (removal of time.clock)
      * also monkeypatches xlrd.xlsx for 3.9 (removal of
        Element.getiterator, breaks because of defusedxml)
      * jinja triggers DeprecationWarning in 3.8
      * pillow triggers warning in 3.9
      * lxml, greenlet don't compile in 3.9
      * reportlab doesn't work in 3.9
      
      New versions try to match those of Debian Bullseye.
      
      Also adds a script to more easily compare dependency versions between
      the requirements files and what's in various distributions (currently
      supports checking against debian and ubuntu).
      
      Furthermore updates warnings filtering:
      
      * removes xlrd (mischeck was monkeypatched as noted above)
      * removes setuptools (was for older versions, one would hope this
        isn't an issue anymore)
      * adds babel: python-babel/babel#684 fixes the deprecation warning but
        is not part of any release yet
      * ignores error related to `random.sample` on a set, this is a
        diagnostics bug because recordsets implement both Sequence and Set,
        and the stdlib checks for Set first (bpo-42470)
      
      See #59980
      Closes #61103
      
      closes odoo/odoo#62380
      
      Signed-off-by: default avatarXavier Morel (xmo) <xmo@odoo.com>
      648635de
    • Anh Thao Pham (pta)'s avatar
      [FIX] website_slides: fix quiz karma won · d8254c13
      Anh Thao Pham (pta) authored
      
      - Install website_slides
      - Connect with an user (i.e. Mitchell Admin)
      - Go to Website and open a Course quiz for the first time
      (i.e. "Test Yourself" from "Basics of Furniture Creation" Course)
      - Answer correctly
      The number of won karma is the one from the last attempt reward and is not saved
      in user's total xp.
      
      When submitting the quiz, quiz_attempts_count is incremented via a SQL query,
      but its value is not updated in cache directly.
      When the karma gain is computed from the attempts count, the value used is the
      old one in cache.
      
      opw-2389969
      
      closes odoo/odoo#62421
      
      Signed-off-by: default avatarJérémy Kersten (jke) <jke@openerp.com>
      d8254c13
    • Leo Tran's avatar
      [CLA] Viindoo signs Odoo's CCLA · 5a5ab9cd
      Leo Tran authored
      
      Done at #62137
      
      closes odoo/odoo#62478
      
      X-original-commit: 60d723cb
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      5a5ab9cd
    • Christophe Monniez's avatar
      [FIX] requirements: remove gevent double requirements on win32 · 4ce94234
      Christophe Monniez authored
      
      Fixes #62214
      
      closes odoo/odoo#62475
      
      X-original-commit: 45afa3a2
      Signed-off-by: default avatarChristophe Monniez (moc) <moc@odoo.com>
      4ce94234
  14. Nov 26, 2020
    • Joseph Caburnay's avatar
      [FIX] pos_restaurant: order remained after deletion · e6e2a739
      Joseph Caburnay authored
      
      There is a situation in pos_restaurant such that when an order
      is deleted from the ticket screen, it persists to show when the
      table is opened. To reproduce:
      
      1. Create an order in T1 then add items to it.
      2. Get out of the table (back to floor).
      3. Open ticket screen.
      4. Delete the order in T1.
      5. Close the ticket screen.
      6. Open T1, the order is still there (bug).
      
      This commit fixes this behavior such that in step 6, new order should
      show and not the deleted order.
      
      Note that we also made a change in the template in order to allow
      checking the number of synced orders during testing. We want to make
      sure that the table is clicked when the sync finishes to prevent
      concurrency issue during testing.
      
      closes odoo/odoo#62403
      
      Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
      e6e2a739
  15. Nov 27, 2020
  16. Nov 26, 2020
  17. Nov 19, 2020
  18. Nov 26, 2020
  19. Nov 25, 2020
    • Lucas Lefèvre's avatar
      [FIX] web: mock all name_get behaviors · c8f59bfd
      Lucas Lefèvre authored
      
      The mock implementation of `name_get` does not fully reflect
      the real server implementation.
      
      The real implementation is described in tests added in
      this commit.
      
      Note: in my wildest dreams, the mock server tests would be run
      against the real *and* the mock implementation to ensure they
      do not diverge.
      
      closes odoo/odoo#62347
      
      Related: odoo/enterprise#14990
      Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
      c8f59bfd
  20. Nov 23, 2020
  21. Nov 26, 2020
  22. Nov 25, 2020
  23. Nov 26, 2020
Loading