Skip to content
Snippets Groups Projects
  1. Jun 22, 2018
    • kujiu's avatar
      [IMP] Improve compatibility with screen readers (accessibility) (#24574) · 9de1bc0e
      kujiu authored
      Today, Odoo is really tricky to use without seeing the screen, it must be improved to be usable.
      
      This PR forbid to use labels without a "for" attribute, add some title, rule and aria attributes in HTML. With that, Odoo will be fully usable with a screen reader.
      
      
      * [IMP] Labels must have a for attribute. Improve accessibility.
      * [IMP] Better error message when trying to read a missing cached value
      * [FIX] Add some aria-label and title attributes for screen readers.
      * [FIX] Template name is not included in the error message in case of SyntaxError in QWeb
      * [FIX] Improve the Tour failed at step error message to be more explicit.
      * [IMP] Add aria-labels
      * [FIX] Add missing aria-label on failing test
      * [IMP] aria-hidden means hidden. Fix all bad aria-hidden and hide aria-hidden for all.
      * [IMP] Color names on kanban views and many2many tags
      * [IMP] Add some checks on views for accessibility.
      * [IMP] Add `alt` attribute on `img` tags.
      * [IMP] Add aria-label and title on non-described icons
      * [IMP] Add button role to widgets with btn class
      * [IMP] Translate aria and formatted attributes.
      * [IMP] Remove wrong aria-labelledby
      * [IMP] Add menu role on dropdowns
      * [IMP] Buttons must be focusable
      * [IMP] Add aria attributes on progress bars
      * [IMP] Improve accessibility of basic widgets
      * [IMP] Change main layout to more semantic tags
      * [IMP] Add menuitem role when missing
      * [IMP] Remove wrong role='presentation'
      * [IMP] Improve accessibility of tab panels
      * [IMP] Add aria-invalid on invalid fields
      * [IMP] Add aria-sort on ordered columns
      * [IMP] Add role on alerts
      * [IMP] Use dialog role, header, main and footer tags for modals
      * [IMP] Add labels on o_status
      * [IMP] Improve accessibility of kanban view with feeds and articles
      * [IMP] Add alerts in case of new messages
      * [IMP] Add widget, navigation or img role to aria-labelled items
      9de1bc0e
    • Romain Derie's avatar
      [IMP] account*: update invoice page view on customer portal · 86435720
      Romain Derie authored
      *account_payment, l10_in(_sale), sale(_stock), web
      
      With this commit:
      The invoice preview in portal (/my/invoices..) is now the HTML version of the
      PDF report.
      The HTML preview is based on the invoice report to closely match what is
      already done in Odoo.
      
      The invoice preview is displayed in an 'iframe', it is mandatory since:
      1. Reports are rendered as a separate page as it returns the whole page after
         rendering, which has tag <html>, <head> etc
      2. Reports are having their own layouts and their own assets that we we cannot
         load in the page directly or it will break the website layout.
      3. We can not use report template with t-call because internally reports are
         using extra params like context_timestamp, company, DateTime, user etc which
         is used in header/footer
      
      --
      
      There will be a chatter (as a modal) to display/see the history of the document
      
      --
      
      For responsive purpose, we use new tables with limited column (Description,
      Quantity and Amount) for responsive purpose (small screen).
      It also adds some bootstrap classes to reports for responsive purpose.
      
      --
      
      The 'Pay Now' button remains if you already paid with 'wire transfer'.
      (It disappears for Credit Note)
      
      --
      
      Add margin after the header and before the footer to look like the real printed
      document, without alterating the real printed version
      
      --
      
      In every portal module, the pager is now generic in the generic breadcrump
      
      --
      
      Task ID: 39876
      Closes #24938
      86435720
    • Romain Derie's avatar
      [FIX] account(_payment): display `Pay Now` btn only for out invoices · d6956db9
      Romain Derie authored
      1. Only facture client should see pay now*, not credit note etc
      2. Pending transaction should be handled like:
         * Manual & (wire) transfer pending transaction should display pending but still
           show the pay button
         * Other pending transaction should display pending & hide the button
         * Exception: A wire or manual pending transaction should have the status "Waiting for payment"
                      and not pending in /my/invoices status
      
      * and "amount due" aswel so clients won't complain about the payment arriving too late
      d6956db9
    • Romain Derie's avatar
      [FIX] web: `background layout` should not apply margin-top on footer · 694f80cd
      Romain Derie authored
      1. `background layout` report template should keep the min-height property to
      avoid breaking the pdf report template.
      This property is needed to display the background image at the right position
      (avoid image to be crop if not a lot of invoice lines). see https://github.com/odoo/odoo/commit/41c75ad0c37d567dd43e418fda927c7ae38a3add
      
      2. margin-top can't be applied or it will also break the pdf layout.
      `min-height` will ensure that the html rendered will be high enough to looks
      like the real pdf invoice anyway.
      
      opw-39876
      694f80cd
    • Romain Derie's avatar
      [FIX] account, portal: use new syntax in sidebar widget · 3a77deb6
      Romain Derie authored
      There is a new syntax for widgets, among other things it allows the widget code
      to be partly executed before the DOM is ready, speeding the process.
      
      Courtesy of QSM
      opw-39876
      3a77deb6
    • Romain Derie's avatar
      [IMP] account(_payment), payment, web: show residual amount.. · a7e2bd86
      Romain Derie authored
      .. & hide transaction list + page numbers on HTML report.
      
      1. Before this commit:
         Portal Invoices were displaying the total amount instead of the residual
         amount. The pay button would also trigger a payment for the total amount
      
         Now:
         If part of the invoice is already paid, we show the residual amount and
         payment transaction amount are set to residual amount so the client is asked
         to pay what he really needs to pay.
      
      2. Processed transaction results in a bootstrap alert message displayed at the
         top of the page, showing warning, success or alert depending of the result.
         This alert is supposed to show thank message `post_msg` only if it set.
      
         Before this commit:
         Since `post_msg` is an html field and editable through summernote, it will
         never be empty. Indeed, empty field with summernote are replaced by a `br` tag
         inside a `p` tag.
         The condition would never be false, resulting in an empty `p` with a `br`
         inside being displayed at the bottom of the alert, making it looks like it is
         bugged.
      
         Now:
         The condition also consider summernote's empty string as such.
      
      3. Remove the transaction list from the invoice portal template since it is not
         an important information to the client.
         Some client would not even understand what it is.
      
      4. Hide page numbers on HTML report since they are not split in pages and page
         number remains empty, resulting in `Page: /` (Or empty square with the
        'clean layout.)
      a7e2bd86
    • Romain Derie's avatar
      [FIX] account, portal: Adapt sidebar to be more responsive · 3d7e6b47
      Romain Derie authored
      1. Print & Download button can't be next to each other for some responsive
         reason:
         * On small computer screen size, there is not enough spaces so one button is
           pushed on a new line.
         * Button is also pushed on a new line even on big screen on other languages
           where the words can be a lot bigger (e.g: french "Imprimer/Télécharger").
         * Inverse problem appear if the words are smaller, both buttons won't fit
           all the available width and it will breaks the layout
      
      2. There is an issue on big phone resolution in landscape mode.
         (iPhone X, Pixel 2 XL,..)
         Indeed, they are detected by bootstrap as 'MD' and not 'SM'.
         This was causing the sidebar to be displayed as for computer (fixed on the
         left side) but since there is not enough vertical space (height) in
         landscape, the bottom part of the sidebar would be hidden off the screen.
      
         Side effet: On small computer screen, it will now also be displayed like in
         mobile. This is in fact better since the invoice being displayed on
         col-sm-8 on these small screen would be completely squashed (since not
         enough width available to display things correctly).
      
      opw-39876
      3d7e6b47
    • Romain Derie's avatar
      [IMP] account, portal, *: Move pager in breadcrump · e6b42cf3
      Romain Derie authored
      *project/purchase/sale/website_quote
      
      Before this commit:
      Some module having a portal page (Quotation, SO, Purchase..) would display a
      pager in the page, sometimes on the document header, sometimes in the middle
      of it.
      Every template would have to t-call the `portal.record_pager`.
      
      Now:
      The generic portal breadcrump will now display the pager directly on the top
      right. It means every portal template setting `prev_record` and/or
      `next_record` will automatically have the pager displayed without having to
      call it.
      Plus, it will be displayed at the same position for every template, making
      the behavior more consistent.
      
      Plus, it will also remove the background color from the breadcrump and hide the
      home button when you are already on the home page.
      
      opw-39876
      e6b42cf3
    • Jitendra Prajapati's avatar
      [IMP] account*: update invoice page view on customer portal · cea2a454
      Jitendra Prajapati authored
      *account_payment, l10_in(_sale), sale(_stock), web
      
      With this commit:
      The invoice preview in portal (/my/invoices..) is now the HTML version of the
      PDF report.
      The HTML preview is based on the invoice report to closely match what is
      already done in Odoo.
      
      The invoice preview is displayed in an 'iframe', it is mandatory since:
      1. Reports are rendered as a separate page as it returns the whole page after
         rendering, which has tag <html>, <head> etc
      2. Reports are having their own layouts and their own assets that we we cannot
         load in the page directly or it will break the website layout.
      3. We can not use report template with t-call because internally reports are
         using extra params like context_timestamp, company, DateTime, user etc which
         is used in header/footer
      
      --
      
      There will be a chatter (as a modal) to display/see the history of the document
      
      --
      
      For responsive purpose, we use new tables with limited column (Description,
      Quantity and Amount) for responsive purpose (small screen).
      It also adds some bootstrap classes to reports for responsive purpose.
      
      --
      
      The 'Pay Now' button remains if you already paid with 'wire transfer'.
      
      --
      
      Add margin after the header and before the footer to look like the real printed
      document, without alterating the real printed version
      
      Task ID: 39876
      cea2a454
    • Jitendra Prajapati's avatar
      [IMP] portal: add a generic PortalSidebar widget to be used in customer portal · 949ce027
      Jitendra Prajapati authored
       with this commit, this generic widget allow to basic functionality for portal sidebar like: print btn (direclty print the document),
       set due or delay label of the document (based on given date), used affix to locked to an area on the page for sidebar.
       Purpose is to reuse it in account customer portal and online quotes notably.
       some css code convert to the less file to have working portal sidebar skeleton, which is already used in website_quote
      
       Task ID: 39876
      949ce027
    • Quentin De Paoli's avatar
      [IMP] account: onboarding improvement · 07c111fa
      Quentin De Paoli authored
      Improves the 'chart of account' step by showing all the accounts in the list instead of the default limit
      
      Was part of task 1838269.
      07c111fa
    • eco-odoo's avatar
      [IMP] account: update dashboard sales and purchase journal graph · 52a03950
      eco-odoo authored
      The sales journal graph  should show the cash-in forecast of invoices.
      In order to do that we need to display residual amount to be received
      based on the invoice due date.
      
      The purchase journal graph should show the cash-out forecast from
      invoices. In order to do that we need to display the residual amount to
      be paid based on the invoice du date.
      
      Was task: 1855081
      Was PR #25344
      52a03950
  2. Jun 21, 2018
  3. Jun 20, 2018
    • Pieter Paulussen's avatar
      [FIX] account: fix account_move_line's default_get() · 50ee1c96
      Pieter Paulussen authored
      When creating a journal entry manually, the value proposed as next line was not taken into consideration all existing lines.
      
      Was PR #25298. Courtesy of Pieter Paulussen (Dynapps)
      50ee1c96
    • Quentin De Paoli's avatar
      [FIX] account: cash based taxes mixed with regular ones · 6424111f
      Quentin De Paoli authored
      Previously, the use case where a cash basis tax and a regular one were combined on the same invoice line (for example) was not supported (technically, there's a single boolean for the tax exigibility of the sale/purchase line). Since it appears this is a real need, this have been improved in the generic tax report (in enterprise repo) in revision https://github.com/odoo/enterprise/commit/f7e33b8114d4d649551a155d0ca8cc4f43f1fc01 and this commit fixes the community side, to copy only the base line of the tax exigibile on payments in the cash basis move
      6424111f
    • Romain Derie's avatar
      [FIX] sale: unify both pricelist & sale option to show discount · 27825cbf
      Romain Derie authored
      Sale module has an option to show or hide discounts on order lines.
      Pricelist also have a field to include the discount in the price or display the
      full price strikethroughed.
      
      Before this commit:
      If the sale option was disabled, the pricelist option would be hidden, possibly
      left enabled.
      This will cause a strange behavior in frontend where user would still see the
      strikethroughed price even if the sale module option was disabled.
      
      Now:
      If the sale option got disabled, we also disable the pricelist option
      
      Closes #14741
      27825cbf
  4. Jun 19, 2018
  5. Jun 18, 2018
  6. Jun 15, 2018
  7. Jun 14, 2018
Loading