In enterprise, when doing a comparison between multiple periods with values carried over to them, auditing the carryover values (through the dedicated button in the popup, in debug mode) always opened the latest period.

This was due to the fact the main options of the report were directly used, instead of the ones corresponding to the column group owning the value.

closes odoo/odoo#135658

Related: odoo/enterprise#47476
Signed-off-by: John Laterre (jol) <jol@odoo.com>

This commit excludes off-balance accounts from appearing in tax
repartition lines.
Previously, off-balance accounts were included in the selection, which
was causing confusion and unnecessary clutter in the interface.

The need for this change was raised due to the observation
that off-balance accounts are never actually used in tax repartition
scenarios.
Including them only complicates the account selection process without
adding any functional value

closes odoo/odoo#135763

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

When trying to customize Swiss invoice report with QR-Bill
through Studio an error was thrown because it tries to _compute_name()
on a dummy 'account.move' record with self.id=0.

This is part of a more general task in master around report customization
but it make sense to backport the fix in all stable versions.

task-id:3492033

closes odoo/odoo#135681

X-original-commit: d95aae51
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>

Steps to reproduce:
* create an invoice with a line
* change the receivable account
* duplicate the invoice

Result: the receivable account is recomputed to the default one.
Expected: we should keep it.

task-3504443

closes odoo/odoo#135366

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Example: Copy the Belgian P&L, try to open the copied report => error message saying some aggregation terms cannot be expanded. If you open the its form view, you can see that line BE_PL_14's balance formula has been translated from this

BE_9906.balance + BE_791.balance - BE_691_2.balance + BE_794.balance - BE_694_6.balance

to this on the copy:

BE_9906_COPY.balance + BE_791_COPY.balance - BE_691_2_COPY.balance + BE_794.balance - BE_694_6.balance

This is buggy ; BE_794.balance and BE_694_6.balance should be BE_794_COPY.balance - BE_694_6_COPY.balance, in order for them to match the other lines of the copied report properly.

This bug touches other reports more generally. It was due to the fact we replaced the codes in aggregations while we were copying the lines, and not after copying all the lines. Because of that, lines that were referrenced by an aggregation expression belonging to a line coming before them in sequence were not taken into account, as they were not part of the code_mapping dict yet.

OPW-3505592

closes odoo/odoo#135467

Signed-off-by: John Laterre (jol) <jol@odoo.com>

Before this commit, the fiscal position is not used to determine account.

closes odoo/odoo#135289

X-original-commit: 4a447759
Signed-off-by: Cedric Snauwaert <csn@odoo.com>
Co-authored-by: Miquel Raïch <miquel.raich@forgeflow.com>

In case of the user have no access to all account.payment, the record can be deleted.

closes odoo/odoo#129253

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Steps to reproduce:
- Create an invoice
- Select a partner
- Add an invoice line (without a product): a default account will be computed
- Change the account
- Add a second invoice line (with a product)
- Change the account
- Select another partner
The account for the invoice line without a product will be recomputed, while
the account for the invoice line with a product will not.

The computation of the account should happen when the line is added.
If the account has been changed, it should not be recomputed to a default one
when changing the partner.
The behavior for aml without product should be the same than aml with a product.

opw-3474469

closes odoo/odoo#135027

Signed-off-by: William André (wan) <wan@odoo.com>

It is not possible to add a block at the bottom of the invoice report
with Studio

Steps to reproduce:
1. Install Invoicing and Studio
2. Open Invoicing, toggle Studio and open Reports
3. Open the Invoice report
4. Try to add a text block after the payment terms, Studio doesn't let
   you

Solution:
Put all the content of the invoice in the page div

opw-3443086

closes odoo/odoo#134651

Signed-off-by: William André (wan) <wan@odoo.com>

Steps to reproduce:

  - Install `account` module
  - Activate another language (e.g. French)
  - Create a partner with the new activated language
  - Create an invoice for this partner and sent it by mail

Issue:

  Some words in the external layout of the email are not translated;
  button and title

Cause:

  The language of the partner is not taken into account (except for the
  model name in the button) when creating the external layout of the
  mail.

Solution:

  Call send_mail with the partner language in the context.

opw-3301607

closes odoo/odoo#133744

Signed-off-by: William André (wan) <wan@odoo.com>

If a bank account is added through the onboarding step and the user creates one instead of linking it,
the dashboard is not reloaded to show the completion of the step and the new account.
To make sure that the view is reloaded to show new data,
the easiest fix would be to return a reload action in `validate`.

task-3431961

closes odoo/odoo#133057

Related: odoo/enterprise#46250
Signed-off-by: William André (wan) <wan@odoo.com>

Implemented support for the BACS payment scheme as per the latest
technical specifications, enabling the processing of BACS Direct Credits
and Direct Debits. Included the mandatory requirement of a Service User
Number (SUN) for businesses conducting transactions via BACS.

closes odoo/odoo#128069

Task-id: 3326945
Related: odoo/enterprise#43923
Signed-off-by: Quentin De Paoli <qdp@odoo.com>

- Added ondelete='cascade' to account_payment_method_line's
field definition.
- Fixes the foreign key constraint failure during module uninstallation
by automatically deleting dependent records.

task-3326945

Part-of: odoo/odoo#128069

Currently, when a journal is created during import, we just use the journal name as the code.
However, that gets truncated to 5 characters on create, which can conflict with existing journals.
The import should be as flexible as possible, as it's better to let users import and fix things
after the import rather than debug the import file.
- If there is a journal with a shortcode that matches the truncated name of the new journal,
  just use the existing journal (enterprise PR)
- If the shortcode conflict arises within the imported file
  (so the journals don't exist before the import), keep track of the codes in `vals_list`.
  The `get_next_bank_cash_default_code` is modified to avoid duplicating code.

See also odoo/enterprise#46101

closes odoo/odoo#132715

Signed-off-by: Laurent Smet (las) <las@odoo.com>

Summary
-------
This commit addresses an issue where fixed taxes were not calculated
correctly when applied to a line with a price of 0.

Steps to reproduce
------------------
1. Create a fixed tax with an amount of 5.
2. Create an invoice with a line having zero price and apply the fixed
   tax.
3. Save the invoice. You should have a total of 5.
4. Change the quantity of the invoice line, to something like 2.
5. Save the invoice.

We expect the total to be 10, but we get 5.

opw-3212536

closes odoo/odoo#134153

Signed-off-by: William André (wan) <wan@odoo.com>

There was inconsistency in the translation for the words "price unit", with this
 commit all the "price unit" are translated the same.

closes odoo/odoo#134107

Task-id: 3262408
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>

Steps to reproduce:
- Set "To Check" for a bill in the Bill list view
- go back to the dashboard

Issue:
There won't be the "To Check" shortcut as it was the case in 15.0

opw-3455414

closes odoo/odoo#133296

Signed-off-by: William André (wan) <wan@odoo.com>

Steps to reproduce:
- set a tax lock date
- create a new move
- set the accounting date prior to the tax lock date
- set an invoice_line with a tax

Issue:
The banner teeling you information about the tax lock date won't appear unless the move is created.

opw-3370727

closes odoo/odoo#134259

Signed-off-by: William André (wan) <wan@odoo.com>

When having a payment terms with several lines,
the payment term lines are not displayed when
printing the invoice if this one has been
partially paid.

opw-3482256

closes odoo/odoo#133934

Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>

It can be that the name field on the account_move_line is an empty
string (as opposed to NULL). This can happen, for instance, when
generating the payment term line for Switzerland without the appropriate
fields on the company.

Since there are instances when the payment term's name is an empty
string, we can retrieve these lines and automatically match them with
payments from  the bank reconciliation model. This can happen
automatically, with exact matches between a payment with a near-empty
reference (when the payment ref is just "/" or "?", this is sanitized
and ends up as an empty string for the purposes of comparison), and
these empty string payment term invoice lines.

The query that fetches the candidate lines for exact matches already
excludes those lines with a NULL move_line name, move ref, move name.
The natural extension of this behaviour is just to exclude the empty
string in these queries also.

closes odoo/odoo#133005

Signed-off-by: Laurent Smet (las) <las@odoo.com>

Issue:
======
- Display of monetary values in kanban views is wrong in rtl language
- Pivot display has multiple erros in rtl language: values are left
  aligned and they are supposed to be right aligned like in ltr lang,
  negative numbers has the sign in the wrong place, the (plus/minus)
  icon placement is wrong (it should be before the title and not after)

Steps to reproduce the error:
=============================
- Install accounting and rlt language (arabic for example)
- Go to accounting (display of monetary fields is wrong)
- Go to accounting/accounting/journal items/pivot view
- Choose residual amount in view (it has some negative values)

Solution:
=========
Kanban Solution:
- I fixed the direction of the display to be ltr always for monetary
  values and added the class to the appropriate tags.
Pivot Solution:
- I fixed the direction and text-align style for the values to always
  display the same like rtl.
- displaying the icon and then the title will always give the desired
  display since the direction will reverse their order itself when it's
  rtl

enterprise fix : https://github.com/odoo/enterprise/pull/46675



opw-3295573

closes odoo/odoo#132843

Related: odoo/enterprise#46675
Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com>

Versions:
---------
- 16.0
- saas-16.1
- saas-16.2
- saas-16.3
- saas-16.4

Steps to reproduce:
-------------------
1. install the purchase and account_accountant modules
2. create a purchase order using a non-default currency;
3. create bill;
4. switch to a journal without set currency.

Issue:
------
Currency of bill automatically changes from the one used
by the order to the company default.

Cause:
------
The `account.move` model only looks at bank statements, journal,
and the company default when computing currency, ignoring any
value that might already be present in the invoice:
```
def _compute_currency_id(self):
    for invoice in self:
        currency = (
            invoice.statement_line_id.foreign_currency_id
            or invoice.journal_id.currency_id
            or invoice.journal_id.company_id.currency_id
        )
        invoice.currency_id = currency
```

Solution:
---------
Try to retrieve currency from `invoice.currency_id` before
falling back on the company default.

opw-3434518

closes odoo/odoo#131366

Signed-off-by: Levi Siuzdak (sile) <sile@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>

Currently, the user has access to a "Switch into credit note/refund" but
not the reverse button to go from a credit note/refund to an
invoice/bill. This is now the case.

This is a partial backport of odoo#103427

task-id 3102251

closes odoo/odoo#133497

X-original-commit: 6f9593a
Related: odoo/enterprise#46492
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Louis Baudoux (lba) <lba@odoo.com>

The following commit https://github.com/odoo/odoo/commit/0015662d166f5e07bcbd6c5e9e14f8837ffa58a3

 was incorrectly done because the records are already limited to a 100 in the search query. We therefore remove redundant loop.

We also moved up all possible UserError in the _post() method before the soft computation such that if any UserError is raised (with the autopost cron for example), the soft computation will not be executed.

task-3482939

closes odoo/odoo#133485

Signed-off-by: William André (wan) <wan@odoo.com>

closes odoo/odoo#133408

Signed-off-by: William André (wan) <wan@odoo.com>

Since Odoo 16 [1] account module uses some non-storable computed Binary fields
to compute and access structured data. Those data is not transformed into binary
data and is not supposed to be used outside of server environment. There are
still use cases when ORM tries to process such fields as normal Binary fields.
For example, on using export wizard [2].

This commit fixes similar problem on reading `account.move{.line}` records via
rpc.

STEPS: create `account.move` record and read it via an RPC call [3]

```
account_move_id = 666
models.execute_kw(db, uid, password, 'account.move', 'read', [account_move_id])
```

SOLUTION

1. Add missing `exportable=False` to the fake Binary fields
2. Block access to such fields via method `check_field_access_rights`

[1]:
https://github.com/odoo/odoo/commit/d8d47f9ff8554f4b39487fd2f13c153c7d6f958d
[2]: https://github.com/odoo/odoo/commit/c925ecb2a22750524020f0d111888fd76eedb0cb
[3]: https://www.odoo.com/documentation/16.0/developer/api/external_api.html



opw-3099975

closes odoo/odoo#110699

Signed-off-by: William André (wan) <wan@odoo.com>

With Python 3.11, PyPDF2 2.12.1 is used and the exception raised when
the encryption type is not supported is now `NotImplementedError`
instead of `PdfReadError` in previous version.

In order to support both version, this commit adds a catche for the
`NotImplementedError` too.

closes odoo/odoo#133149

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Some companies require their clients to pay them always for the 10th day
of the month (for instance), and if we're the 15th already, then pay the
10th of the next month.

However, with the changes in the payment terms, we can now only ask the
client to pay for the 10th of the next month, which is not satisfying.

Therefore, we now allow negative days/months to meet this demand.

task-id 3127965

closes odoo/odoo#133148

Signed-off-by: Laurent Smet (las) <las@odoo.com>

When creating a reconciliation model line on
a new record, by activate the boolean toggle on
`force_tax_included` field, the line is save
but as the reco model is not, `check_company`
will raise an error.

Steps:

- Create a new model
- Before saving, create a line, set a tax and
  click on Tax included toggle button
-> Error is raised

opw-3473189

closes odoo/odoo#132942

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Problem
---------
Fix a display bug happening when manually modifying taxes in bills.

Objective
---------
Get the same behavior as in 15.2

Solution
---------
Colspan was acting weird when clicking the tax to input. It would
expand to the full size allowed. To avoid this behavior, I made the tax
display width to 0%. This makes it impossible for the input to expand
upon clicking.

task-3397951

closes odoo/odoo#128774

Signed-off-by: Laurent Smet (las) <las@odoo.com>

Issue :
After the last fix https://github.com/odoo/odoo/pull/124663


there is still an issue of currency placements and alignement
of numbers in rtl language at the total and subtotals.

Steps to reproduce the isse :
1-create an invoice and confirm it.
2-install accounting
3-go to accounting/customer invoices and choose the created invoice

Origin of the problem :
The fields displayed didn't have the appropriate classes and the
style for number and monetary values for rtl language is missing from
the css folder.

Fix:
I applied the class on the `td` tag and `span` tag.

opw-3295573

closes odoo/odoo#128376

Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>

Accounting > Configuration > Settings > Enable cash basis
Create [Tax 1] as follows:
- Name: Tax Exigible
- Tax Type: "Purchase".
- In the Tax Repartition Lines, add a different tag for each repartition line
- Tax Exigibility "Based on Payment".
Create [Tax 2] as a standard tax for purchase
Create a [Tax Group] as "Group of Taxes" using [Tax 1] and [Tax 2].
Create a Bill that uses [Tax Group], Confirm and Register payment.

Issue:
The CABA entry will not have tax and tax tags set up correctly,
[Tax 1] information will be missing.
Because tax information is missing during the creation of CABA entry
an exchange rate is created when it is not necessary

opw-3435601

closes odoo/odoo#131813

X-original-commit: 82f6ef76
Signed-off-by: John Laterre (jol) <jol@odoo.com>

Introduced by:
https://github.com/odoo/odoo/commit/ba82fbe1b08108178a9fd7bade82b625c987e36e



The rate of the opposite line must remain the same when fallbacking on the company currency.

closes odoo/odoo#132213

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

Before this, there was a computation of cash basis moves for each reconciliation
done during FEC import and it can slow down a lot the import for nothing since
no taxes will be in the imported entries so no cash basis will result from
reconciliation.

Now, the cash basis moves computation is skipped to improve the performance.

Here are the stats of reconciliation time on fresh database using a FEC file
of ~76000 amls including ~15000 reconciled.

V15 without fix => 8 min 15 s
V15 with fix => 5 min 27 s

V16 without fix => 9 min 36 s
V16 with fix => 1 min 33 s

opw-3274391

closes odoo/odoo#131572

X-original-commit: 5076744e
Related: odoo/enterprise#45633
Signed-off-by: Laurent Smet (las) <las@odoo.com>

Resolved an issue where follow-up reports linked to a partner weren't
visible in the follow-up menu due to 'partner_rank' not incrementing
after a misc entry. The commit ensures the correct update of
'partner_rank', making all relevant reports accessible.

closes odoo/odoo#129917

Task-id: 3437930
Signed-off-by: Laurent Smet (las) <las@odoo.com>