- Apr 10, 2018
-
-
Thibault Delavallée authored
This commit proposes to limit cache invalidation at some cases that will trigger some behavior change when dealing with mail messages : * creating messages linked to a document; * update model or res_id of a message; * updating notifications, as notified people could change some computed fields on the record; This commit also invalidates only mail-related fields as updating messages should not invalidate other things than some computed fields linked to mail.
-
Thibault Delavallée authored
Cache invalidation when subscribing people has been added at e6f038a8. Indeed subscribing partners to a record may lead to an access right update as some of them are based on followers. This is why a cache invalidation is necessary to avoid access rights issues. However subscribing people to a record should change their rights only on the records involved in the subscription mechanism. We can therefore give ids to the cache invalidation to limit to updated records. Cache invalidation is also limited when writing on followers if writing on model, res_id or partner_id fields. Indeed changing subtypes or channel of a subscription should have no impact on cache and access rights. Cache invalidation done manually in _message_subscribe is not necessary as subscription create or update mail.followers records since f9c21092. Create and write of mail.followers records already ask for cache invalidation. It is therefore not necessary to invalidate cache twice. This commit allows to save a few queries on some tests, notably about activities that deal with subscription and messages. As cache is now kept it is not necessary to refetch some data, leading to a few query gain. We gain about 1K queries on com runbot. A side effect of limiting cache invalidation is that some unit tests require a manual cache invalidation to have up to date results. Indeed record not being up to date in cache was hidden by the invalidation we just removed.
-
Thibault Delavallée authored
When notifying partners or channels of a message, a cache invalidation is currently done if the message has a parent. This invalidation has been done when migrating the mail module at the new API at 4b122ad4. In that time notifying people of a message lead to the creation of notifications of the parent message, if any. It was due to the chatter being threaded and therefore displaying message with their header message. Adding notifications for the parent was necessary to avoid access rights issues when fetching parent message data. Indeed as being notified is one of the rule to see a message record adding notifications was done. A cache invalidation has therefore been added to clean the message cache and ensure everything was fine. Commit 88b8cd05 changed the way notifications are modeled in Odoo. Notification on parent message was removed and access rights changed. Threaded mode for Chatter has also been removed. However cache invalidation has been kept probably by fear of removing it. It does not seem to have any viable reason to invalidate cache when a message has a parent. Posting a message does not push other messages in users's Inbox meaning there should not be any issue with the cache preventing to see messages. Removing this cache invalidation allow to gain queries in performance tests. It has an impact on each process involving message creation which is quite common in Odoo.
-
Vincent Schippefilt authored
repro : open any editor (like tasks), empty its content and hit SHIFT+TAB before this fix: you get a traceback after this fix: you don't get a traceback
-
Vincent Schippefilt authored
1. Added the ability to navigate within the kanban view using UP, DOWN, LEFT and RIGHT keys. 2. By defaults, the focus should be set on the search input field. 3. From the search input field, using the DOWN key, the focus goes to the first card of the kanban 4. From the search input field, using TAB key, the focus goes to the create button 5. From the create/import buttons, using TAB or DOWN key goes to the first card of the kanban, then UP and DOWN keys moves the focus from card to card in the same column or if it is not a grouped view from left to right. 6. In grouped view, LEFT and RIGHT keys moves the focus to the next column 7. When on a card, hitting ENTER opens the view of that card. Not included in this commit 1. Memorize the position on the kanban when opening an card, than restoring when going back to that kanban
-
Vincent Schippefilt authored
1. Added the ability to navigate within the List view using UP and DOWN keys. 2. By defaults, the focus should be set on the search input field. 3. From the search input field, using the DOWN key, the focus goes to the list 4. From the search input field, using TAB key, the focus goes to the create button 5. From the create/import buttons, using TAB or DOWN key goes to the first row of the list, then UP and DOWN keys moves the focus from item to item in the list. 6. When on a row, hitting ENTER opens the view of that row. Also in this commit 1. When on the first row, hitting the UP key does nothing 2. When on the last row, hitting the DOWN key does nothing Not included in this commit 1. Memorize the position on the list when opening an row, than restoring when going back to that list 2. Navigation on grouped list using the keyboard
-
Vincent Schippefilt authored
This commits aims at adding an accesskey (a shortcut) to all buttons in odoo. This is done by either by assigning an accesskey in the view XML or by automatically assigning a key to the buttons using the first available (not yet assigned as a shortcut key) letter of the text of the button, failing that we use the latin alphabetical order to find the first unused key. Included in this commit: 1. Using the ALT key, automatically assign 2. When the ALT key is pressed, show the assigned shortcuts 3. Assign a number to the menu items (enterprise) 4. Activate number accesskeys without using SHIFT 5. Extra logic to support the activation of the alphabetical accesskeys without needing to add the SHIFT key in the key combination (except for Firefox on linux) 6. Assign a fixed accesskey to the search field Not done: 1. Executing the primary action on dialogs using SHIFT+ENTER 2. Show the input using TAB on the appswitcher screen Things to consider: 1. Fixing more access keys on forms that share the same features (b.e. Validate in customer invoice and vendor bills) 2. Not assigning keys to the chatter section
-
Vincent Schippefilt authored
The goal of this commit is to allow fast entry of the same model using the keyboard for navigating through the form once, by blocking the user from advancing in the form if there is a required field or once they went through the form once to get them to a primary action (button) This commit includes the following changes 1) Enable moving forward from field to field using the TAB key 2) Entering the one to many and many to many using the TAB key a. When entering it, set the focus on the "add new line" link or button b. When adding a new line, set the focus on the field visible editable field of the new line c. Discard adding a new line with ESC key d. If the user leaves the first field empty and uses TAB, we will cancel the adding of a new line and move to the next field of the form 3) When a field is required and not filled in, do not allow the user to move out of the field using the TAB key (the user is still allowed to use the mouse though), mark the field as invalid instead 4) After going though the form once, using the TAB key on the last field will move the focus to the first primary button of the page 5) When the focus is on a primary button (EDIT/SAVE), the user cannot move the focus forward using the TAB key. Hitting TAB again will display a tooltip telling to hit ENTER to activate the button. The mouse is still available to move the focus. 6) When the user saves, the focus is placed on the first primary button of the form renderer (like VALIDATE for a new invoice) 7) On dialogs, primary buttons should stop the users from moving out of them, and showing a popup if the user tries 8) When closing a dialog, the focus will be moved back to the widget that opened it. This commit does not include the following features 1) Navigation with the keyboard on a selection one to man 2) Navigate between tabs in a form using the keyboard 3) Cancelling the adding of a new line in a many to many using the ESC key do not set the focus correctly 4) Enhancing the focusses fields (like blue underline)
-
Christophe Monniez authored
Since Python 3.2, close_fds parameter is True by default on POSIX platforms. On Windows, it's set to False when one of the standard descriptors is set. This commit will give the opportunity to run phantom js tests on Windows.
-
Prakash Prajapati authored
There was a filter 'Bom Components', that didn't filter anything. So we make it work to show the products/product templates that are used as components in BOM. We've also added a filter 'Manufactured Products' that show the products/product templates that have at least one BOM TASK-54350
-
Prakash Prajapati authored
Some of the workorder views had 'workcenter' in their name instead of 'workorder', so we changed them to be consistent with the models. TASK-54350
-
- Apr 09, 2018
-
-
Hiral Bhavsar authored
Before this commit, badge, user,... was available when a forum is archived. Now we display a msg to explain to the user that the forum has been archived. Related to task-33955
-
Jeremy Kersten authored
-
Jeremy Kersten authored
Rename zoom option Now, enable Automatic Zoom without zoom will work. Merge 2 zooms into same separator. Add / Remove margin-padding...
-
Thibault Delavallée authored
Commit 565ab7a2 added a bypass to message subscription because some auto subscription is done without the right to edit the record. However there are two issues with this commit * message_subscribe API changed and code tried to pass now removed parameters; * sudo-ing without checking any access rights before is a security issue; This commit fixes the call and add an access right on read. As few people (mostly HR officers and managers) can read a leave request it solves the issue of auto subscription while a better solution is found.
-
RomainLibert authored
Due to a record rule, it is not possible to add a follower to a validated leave, as we should be able to do it, we subscribe through sudo.
-
RomainLibert authored
We need to have a clear distinction between holidays managers and holidays officers. For this a number of improvements have been done in hr_holidays. For more informations about the changes see the docstrings of hr.leave and hr.leave.allocation. Task #34222 Closes #19270
-
Thibault Delavallée authored
Query count for some mail tests is not always the same for a given test. This leads notably to runbot being randomly red although there is no real error. This commit lessen the issue of having red runbot or wrongly incremented tests by using the recently-introduced margin parameter on performance tests. Some work is still ongoing to find why some tests are not completely reproducible. In the meantime let us have some warnings instead of errors. Manual forward-port and improvement of 81a08520.
-
Thibault Delavallée authored
Purpose of this commit is to avoid errors for some performance tests that have a slightly variable number of queries. Indeed some tests in test_mail module vary of 1 or 2 queries due to a behavior still not found that does not seem deterministic. This should not be considered as a real error, but should not be considered as completely valid. This is why a margin is accepted in some tests that will raise a warning instead of an error. This warning tells people to check if they have increased the query counter or if it is due to a random effect in query count. This is a manual forward-port of saas-11.2 commit 3fe0ee5a .
-
XavierDo authored
Remove the support to replace emojis by images. Most browser now support colored emoji or at least black and white emojis. The emojis list have been updated to ensure a correct support for most os/browser. Users have the possibility to install fonts localy if their os does not have one of the default emoji font installed. After default os emoji font, one of twemoji, emojione or noto color will be selected. The emoji list is now hardcoded in js in order to reduce the number of records in shortcodes. Also include a small fix for livechat to display message field when rating is bad. Task #36898 PR #23689
-
Sanjay Jamod authored
remove shift between set price and bom cost task-39561
-
Sanjay Jamod authored
task-39561
-
Sanjay Jamod authored
- Display correct bom count for product, before this commit it was not displaying the bom count when we have bom for template without variant. task-39561
-
Sanjay Jamod authored
- Tested the flow and verify computation made in hierarchical order - Tested with different Unit of Measurements - Tested with 3 level of componets and sub-componets - Tested with Work Operations - Tested with Inventory Valuation task-39561
-
Sanjay Jamod authored
Purpose ======= Compute cost of product(s) based on it's BoM Specification ============= real_time: not with FIFO otherwise open the wizard with the bom price as default new value periodic: directly set the cost on the form view Add a server action in order to directly set the price on selected product. When getting price from a bom with a sub-bom it will take the cost of the sub bom except if the sub-bom is set with the bom itself in the server action (in this case the sub bom cost will be used). Capacity is not used for this functionality task-39561
-
Sanjay Jamod authored
task-39561
-
Thibault Delavallée authored
Purpose of this merge is to link reminders to notes. The whole feature is therefore moved to node module that extends activities and systray. See sub-commits for more details. This merge is related to task ID 1833628. Closes #24129.
-
Akash Bhavsar authored
This commit allow to sort blog tag by category. And display archives by default folded to avoid 5 years x 12 months => 65 list items open Task-34417
-
Alexandre Kühn authored
Before this commit, the livechat button was not visible at all. This is due to missing resources in the external lib of livechat. Task: 1834875
-
Dharmang Soni authored
This commit refactors f488dc58 that added reminder feature in activities. After merging it was suggested specifications were not correct and it has been decided to move the whole reminder feature in note. Reminders are now notes instead of activities. Now when having note appµ systray proposes to create a note / reminder. A note.note record is created with info given by the user. If a date is given in the systray quick create then an activity is scheduled on this note. This means user can create records in activity systray that are not activities but notes used as reminders. Those will use the first availableµ note column for the user. As reminders are now notes the support of activities not linked to any document is removed, as well as archiving activities and tests linked to that behavior. This commit has been not carefully tested nor in-depth reviewied. It is considered as too important for the upcoming freeze. This closes task ID 1833628. Closes #24129 . Many thanks to @dpr-odoo for its quick development and good work on this task.
-
Dharmang Soni authored
Purpose is to maximize size of editor to focus more on the note content edition.
-
Dharmang Soni authored
Indeed notes will soon be more about todo-list and reminders.
-
Dharmang Soni authored
Purpose is to have first column holding all todos and reminders. We then add a few columns for today / tomorrow / later to help people organize themselves.
-
Prakash Prajapati authored
Rename 'Purchase Bill' into 'Vendor Bills' to be consistent with the labels of module purchase. TASK-38741
-
Prakash Prajapati authored
- We show the completion date of a picking when it's done - We add the filter that show canceled picking - We remove the filter that show confirmed picking as it doesn't exist anymore TASK-38741
-
Prakash Prajapati authored
TASK-38741
-
Pierre Masereel authored
- Set groups on group by and filters TASK-38741
-
Prakash Prajapati authored
TASK-38741
-
Prakash Prajapati authored
TASK-38741
-
Prakash Prajapati authored
- Delivery slip of a picking not done will show the initial demands - Delivery slip of a picking done will show details of what have been processed - Remove the shipment backorder message - Remove the Weight and show the Shipping Weight TASK-38741
-