The currency field shows as a badly aligned "in USD".
This PR adds a proper handling of the combinations
of accounting and multi_currency groups.

Original PR in v15: https://github.com/odoo/odoo/pull/104013



closes odoo/odoo#107963

X-original-commit: 1ee8d10b
Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>

An option to disable the automatic wrapping of inline nodes into p at
editable root is needed by Studio's report editor.

task #2995601

closes odoo/odoo#105585

Related: odoo/enterprise#33886
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Current behavior:
When a global discount is applied, it is considered as a regular
orderline when computing the order discounts. Because of this if you
applied a coupon and a global discount, the pos would add a discount of
infinity value.

Steps to reproduce:
- Create a promotion with a discount of 10%
- Create a product with no taxes
- Enable the global discount feature, and make sure the Discount product
  has a tax set on it.
- Create a new order, add the product, apply the promotion, and apply
  the global discount.
- The order will have a discount of infinity value.

opw-3094784

closes odoo/odoo#107833

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

row

When it comes to closing POS sessions, both the frontend and the backend
currently have some way to prevent the same operations from executing
simultaneously because of repeated clicks. `closeSession` in the
frontend has a `closeSessionClicked` boolean that prevents the operation
 from triggering multiple times at once. `close_session_from_ui`
in the backend checks if the session state isn't already `closed`.

A flaw in the current logic is that
`update_closing_control_state_session`, which is called by the frontend
before `close_session_from_ui`, doesn't check the session state before
writing it to be `closing_control`. This means that if you time things
in such a way that the `closeSession` logic in the frontend triggers
again right after it finishes, it will call
`update_closing_control_state_session` and `close_session_from_ui`
again, which will happily close the session again, duplicating stock
moves and account moves resulting from it.

This fix has `update_closing_control_state_session` check if the session
is already closed and raises a UserError if so. This prevents the
duplicate closings and records from happening.

There were two variants in the UI I observed when the issue occurred:
the first is when the repeated execution of
`update_closing_control_state_session` and `close_session_from_ui`
successfully finished. In that case the session would be closed with
duplicate stock moves and journal entries.

In the second variant, from the repeated calls only
`update_closing_control_state_session` executed but not
`close_session_from_ui`. This could happen if the timing of the
frontend was such that it redirected to the POS dashboard before it was
able to call `close_session_from_ui`. In that case, the session would
be in the `closing_control` state, which is visible in the POS dashboard
. If the user then closed the session, it would be closed twice and the
duplicate records would again be created.

opw-2988701

closes odoo/odoo#107873

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Currently _compute_bulk_weight and _compute_weight are
going through each picking in self and each stock_move_line
in picking.move_line_ids to compute the pickings' weight.

This can be slow when there are lots of move_lines by pickings
as the field cache will be filled by the move_lines records
and uom._compute_quantity will be called once by move_line.

This is especially true for pickings with SN-tracked products.
For SN tracked products there will be one move_line by product_qty
(so a picking with 1 SN tracked product with a qty of 100 will have
 100 move_lines). In this case doing a read_group yields the highest
speedup.

Following the same reasoning a search_count is done in _compute_packages
before retrieving package.move_line_ids.
When package.move_line_ids.result_package_id is empty doing a count
is much faster as it avoids calling _in_cache_without for the package
move_line_ids. The search_count overhead is negligeable in the other
case so adding it leads to an overall speedup on average.

opw-3017013

closes odoo/odoo#107868

X-original-commit: ccac6fce
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

No view is available for the mobile form of change.password.wizard. The
default behavior of the framework is to generate one using the backend
model. This result on showing some hidden fields to the user, some of
them (like in this case `Wizard Id`) is impossible to fill in.

opw-3027797

closes odoo/odoo#107857

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The linked overtime record was not deleted when deleting a time off.
Meaning that those hours were lost.

task-3097259

closes odoo/odoo#107713

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Steps to reproduce
- Install Accounting
- Create user and employee, "user_acc", with Accounting-Accounting and no Expense rights
- Take the expense in "To Submit" state for the employee different than user_acc and create report
- Save the report.

Bug - expense lines disappear.

task - 3099142

closes odoo/odoo#107845

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Computing the recurrences of a task repeating every X months until a
certain date generates too much dates

Steps to reproduce:
1. Install Project
2. Go to Settings > Project > Tasks Management and enable Recurring
   Tasks
3. Open any project in the Project app and create a new task then edit
   it
4. Enable the Recurrent field of the task
5. In the Recurrence tab, edit:
   - Repeat Every: 6 Months
   - Until: End Date: one year from now
6. The recurrence message says there are 11 tasks but there should only
   be 2

Solution:
Generate the recurrences until the `repeat_until` date is reached if the
`repeat_type` is 'until', otherwise generate as much recurrences as the
count
Also relax the constraint on the `repeat_day` and `repeat_until` to not
raise an error if `repeat_until` is the last day of the month

Problem:
The recurrence of a task with `repeat_unit` month and `repeat_interval`
different than 1 with a `repeat_type` until creates too much tasks,
exceeding the `repeat_until`

opw-3076593

closes odoo/odoo#107817

X-original-commit: f94dbfe0
Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>
Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

This PR (https://github.com/odoo/odoo/pull/105748

) introduced a bug
by having an extra `OR` operator in the domain.

This commit fixes the error.

opw-3099849

closes odoo/odoo#107819

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

currently the provided documentation link is of 14.0, updating it to correct version

closes odoo/odoo#107447

Related: odoo/enterprise#34769
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Steps to reproduce the issue:

- Accounting > Configuration > Journals
- Click on Journal
- View metadata of Journal

Bug:

Even if no modification has been made to the journal, it marked current time
in Latest Modification By/Date

opw:3089551

closes odoo/odoo#107816

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Without this change, upgrades would generate the `pos_config_main`
record even in dbs with otherwise-well-organized structure.

Also, it might cause issues[^1] hard to solve otherwise.

[^1]: https://upgrade.odoo.com/web#active_id=421039&cids=1&id=421039&menu_id=107&model=upgrade.request&view_type=form



closes odoo/odoo#107716

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

closes odoo/odoo#107711

Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>

In the QUnit type definitions, there is a QUnit namespace and a QUnit
interface. When using a jetbrains IDE, it is confused between the two
and thinks the global QUnit is the namespace.
This means that it can't resolve QUnit.test, QUnit.module, etc

This fixes this issue by disambiguating between the two.

Part-of: odoo/odoo#107711

update the module name of l10n_ma. Morocco is the real country name and currently upon searching with country name, app is not listed.

closes odoo/odoo#107612

X-original-commit: d332f38f
Signed-off-by: John Laterre (jol) <jol@odoo.com>

*: website

The fields of a form that are mandatory because of the model they need
to be used in cannot be removed. When such a field is selected, the
remove button displays a tooltip giving this information.
Disabling the overlay button is done by removing the specific class -
which makes the event selector not linked to the button, but also
impacts the applied CSS rules.

In stable, this commit only updates the CSS to keep the look-and-feel of
the remove button when it is disabled.

In master, this commit will add an `o_disabled` CSS class upon disabling
buttons and adapt the event selectors accordingly - making it possible
to not impact any `oe_snippet_*`-specific CSS rule.

Steps to reproduce:
- Drop a "Form" block.
- Select the "Phone Number" field.
- The overlay's delete icon has a reddish background.
- Select the "Your Email" field.
=> The overlay's delete icon had a dark gray background instead of a
reddish one.

task-2950433

closes odoo/odoo#107574

X-original-commit: 166dca8a
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>

Steps to reproduce:
-install l10n_sa_invoice module
-switch to a company in Saudi Arabia (SA company)
-create and print an invoice with a product that has arabic translation

Bug:
When adding a product and the Arabic translation.
If we add an internal reference it is added to the template,
Odoo directly concatenates this with the product name.
The result is the product name being duplicated.

Fix:
display line name and add the translation if it's different

opw-2829934

closes odoo/odoo#107792

X-original-commit: ad585bc4
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>

Field `has_partner_email` depends on `partners_domain` field, which uses domain
widget. The domain widget may generate broken value.
This commit fixes it by checking that value in the onchange method.

STEPS:

1) go to coupon programs
2) click generate coupon
3) select <Number of Selected Customers>
4) click on domain field, and click the arrow back (nothing is in the domain)
5) if you click on the scrollbar, error appears (the same for any other click
that triggers onchange)

Alternative solution could be fixing the domain widget. But this looks as an
overkill for v14 for few reasons. First, the js client was heavily updated in v15+.
Second, the problem is quite specific for this module and v16 has not such usage
examples in standard modules.

opw-3062969

closes odoo/odoo#107764

X-original-commit: 1f6d84e3
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

The journal id from a purchase order was not
taken into account when creating the bill

Override _prepare_invoice method and add
the journal_id to the vals.

opw-3080805

closes odoo/odoo#107790

X-original-commit: ce2b0f8d
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>

Follow-up reports were previously not handled by the commit fixing
invoices. This commit aims to fix that.

closes odoo/odoo#107770

X-original-commit: 768cfbe0
Signed-off-by: Florian Daloze (fda) <fda@odoo.com>
Signed-off-by: Solan Delvenne (sode) <sode@odoo.com>

Before this commit, following this flow:
- Add a form
- Add a selection field
- Add an option starting with a number
- Save
=> The created form's option value is only the number

From the website_form options, the options HTMLElement of a form field
are generated using the field's records ids for their html element value
attribute (see FormEditor._renderField).

When [1] refactored the website_form options to use a generic
ListUserValueWidget, the list records id computation changed to use
parseInt instead of strings.

This commit changes the detection of parsable int to match only strings
that are made only of digits, and less than 16 of them so that their
value is not lost.

[1]: https://github.com/odoo/odoo/commit/9304f8fa7bb94f21dd4caa83f9679ffd1642691b



opw-2980760

closes odoo/odoo#103825

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: Younn Olivier <yol@odoo.com>

closes odoo/odoo#107051

Signed-off-by: Julien Castiaux <juc@odoo.com>

`website_sale` module has custom handler for form submit event. That handler
ignores `noFuzzy` attribute. As result, adding `data-no-fuzzy="1"` to
`input[name=search]` works everywhere, but not on shop product list pages.

STEPS:

1. Settings > Technical > Views > website_search_box_input & website_search_box > Code in data-no-fuzzy="1" into the <input> tag
2. Go to Website >.Shop > Customize > Enable ecommerce categories
3. Search for a product on the main shopping page and enter > Observe the URL > There is no noFuzzy param
4. Go to any product's page on the website > search for a product through the search bar and enter > Observe the URL > there is a noFuzzy param passed

opw-3051319

closes odoo/odoo#106674

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

When a record is `forcecreate=0` and a reference of one of its fields is missing, the update of the corresponding module fails. In this case, we can skip the creation of this record.

An example of this issue is this [record](https://github.com/odoo/enterprise/blob/6411ae071ace980834befeb8040c94b1a05c8034/documents_account/data/data.xml#L17) in `documents_account` module (enterprise) when the reference of this [field](https://github.com/odoo/enterprise/blob/6411ae071ace980834befeb8040c94b1a05c8034/documents_account/data/data.xml#L20

) is missing.

This can be reproduced as follows:
1. Create a DB with `documents_account` module
2. Uninstall `documents_account` module
3. Remove `documents.documents_finance_status`
4. Reinstall `documents_account`

```
Traceback (most recent call last):
  File "/home/ayman/src/odoo/15.0/odoo/tools/convert.py", line 680, in _tag_root
    f(rec)
  File "/home/ayman/src/odoo/15.0/odoo/tools/convert.py", line 567, in _tag_record
    f_val = self.id_get(f_ref)
  File "/home/ayman/src/odoo/15.0/odoo/tools/convert.py", line 663, in id_get
    res = self.model_id_get(id_str, raise_if_not_found)
  File "/home/ayman/src/odoo/15.0/odoo/tools/convert.py", line 669, in model_id_get
    return self.env['ir.model.data']._xmlid_to_res_model_res_id(id_str, raise_if_not_found=raise_if_not_found)
  File "/home/ayman/src/odoo/15.0/odoo/addons/base/models/ir_model.py", line 1943, in _xmlid_to_res_model_res_id
    return self._xmlid_lookup(xmlid)[1:3]
  File "<decorator-gen-35>", line 2, in _xmlid_lookup
  File "/home/ayman/src/odoo/15.0/odoo/tools/cache.py", line 90, in lookup
    value = d[key] = self.method(*args, **kwargs)
  File "/home/ayman/src/odoo/15.0/odoo/addons/base/models/ir_model.py", line 1936, in _xmlid_lookup
    raise ValueError('External ID not found in the system: %s' % xmlid)
ValueError: External ID not found in the system: documents.documents_finance_status
```

closes odoo/odoo#105673

Signed-off-by: Christophe Simonis <chs@odoo.com>

Commit [1] improved the "sanitation" of this field for special
character. For instance, when copy pasting the following terms:

|      Input      |      Before      |       After     |
|-----------------|------------------|-----------------|
| fée d'été à 40€ |    f-e-d-t-40-   |  fee-dete-a-40  |
| Nội dung có Dấu |  n-i-dung-c-d-u  | noi-dung-co-dau |

But it actually came with a bad behavior which was not noticed: it
prevents to type `-` at the end of the input, which sounds good but is
not.
Indeed, when typing `a-word`, you will type `a` then try to type `-`
which won't work as considering a (forbidden) trailing slash, even if
you actually want to type something after.

This commit allows trailing slashes again, it's not a big deal and one
can remove it if he wants to.

[1]: https://github.com/odoo/odoo/commit/bb43d4dbb5745be84f0f9462e768989e50607bea



opw-3075419

closes odoo/odoo#107672

X-original-commit: 427ce767
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

JSON content can be rendered nicely by browsers when using the
appropriate mimetype

closes odoo/odoo#107699

This commit enables the switch between the different tabs of a custom
tabs even in the editor mode.

Steps to reproduce the bug:
- Drag & drop a tabs snippet on the website.
- Save it ("save the block to use it elsewhere") as a custom block.
- When the editor mode is "on", it is impossible to switch between the
different tabs of the custom tabs.

The goal of this commit is to differentiate the ID's of the tab panes
located on the website and the ones of the corresponding custom model
located on the edit bar. In the case of the tabs snippet, it is
important in order to link the anchors of the tabs to their correct
tab pane. Indeed, before this commit, two tab panes (the one on the
website and the custom model on the edit bar) had the same ID's. The
anchors of the tabs on the website were linked to the tab pane located
on the edit bar.

opw-2988215

closes odoo/odoo#107657

X-original-commit: 5569fbf9
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

A bug prevented the QR code for the KRA ITAX portal being rendered
properly on the invoice. This resulted in a small, empty box in the
place where the QR code should be.

This fix adapts the code in the template so that it correctly renders
the QR code.

closes odoo/odoo#107641

Task-id: 2950308
Signed-off-by: Josse Colpaert <jco@odoo.com>

Activate 'Purchase Receipt' in Account Settings
Accounting>Vendors>Receipts
Create a new receipts
Add a line with tax

Computed tax dictionary is not editable via widget (it is in Vendor Bills)

opw-3080972

closes odoo/odoo#107483

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

For some reason, safari on mac is not showing the sidebar menu content
at all. It remains a white div without content.

Seems like a bad implementation of that browser for this case, or at
least an implementation which is not shared by all other browsers.

Note that removing `z-index`, `position:absolute` or `overflow` css
property from the `wrapwrap` will make the menu appear.
!!! Also note that having a non scrollable page (not enough content),
like an empty homepage, will make the menu appear too. !!!

As this issue is quite critical:
- All mac/safari users are not seeing your website menu..
- And the admin don't event know it most of the time (as not on mac)
And since:
- It's been going for months without someone finding a proper fix
- It's hard to investigate as devs generally don't have mac to
  investigate and have to use browserstack which is really bad for such
  work
This commit is a fix attempt using `calc` which is probably not ideal.

Step to reproduce:
- Select the sidebar header template
- Visit the website on safari
-> The menu will be invisible, like if the navbar was empty

opw-2984536
opw-2896939

closes odoo/odoo#107581

X-original-commit: ffa34d84
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Prior to this commit, when using a background video on the cover of the
website_slides homepage (/slides), after saving, a traceback would
occur and the video would not be displayed.

Steps to reproduce:
- Install website_slide
- Go to /slides
- Enter edit mode
- Change the cover of the page by a video
- Save
- Traceback

The reason for that is that the cover snippet used on the homepage of
elearning is the root of an XPath instead of its own oe_structure. (This
was changed in 16.0)
[1] made it so that the style and class attributes are saved but did not
save any data attributes needed for the background-video widget to work.

This commit adds those data attributes.

[1]: https://github.com/odoo/odoo/commit/5b252215dc375526af87c31a32256dd1a9582f02



opw-3063043

closes odoo/odoo#107547

X-original-commit: 86dc4d43
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce the bug:
- Create a BoM with components
- Archive one of the components

Problem:
No warning is displayed for the user to inform that the product is
used as a component in a BoM

opw-3089104

closes odoo/odoo#107555

X-original-commit: 92fc5f61
Signed-off-by: William Henrotin (whe) <whe@odoo.com>

## Steps to reproduce
* Using Firefox, Go to Accounting > Invoices > create a new invoice.
* Add a line to the invoice and remove the label.

You should see that there's no indication that the label field is
required. (It works well in Chrome)

## Cause
This is happening because the table borders (that become red when a
field fails validation) are not displayed in Firefox.

opw-3040299

closes odoo/odoo#107523

X-original-commit: 74726c64
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Signed-off-by: Nshimiyimana Serge Séna (sesn) <sesn@odoo.com>

Needed for task-3046679

closes odoo/odoo#107538

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Dropping a table of content inside another table of content triggers an
infinite loop of generated menu content updates.

This commit prevents dropping a table of content into another table of
content, be it from its thumbnail or from a previous location inside the
page.

task-2752391

closes odoo/odoo#107532

X-original-commit: d93bf1dc
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Context:
    In some companies, we want to give employees a day off.
    Unfortunately, their working hours do not correspond to those of the company.
    To remedy this, we set the work hours at: 00:00 until 23:59.

Steps to reproduce:
    - set work hours to 00:00 until 23h59;
    - give one day off to a department;
    - view statistics on a employee (who belongs to the department).

Issue:
    We notice that in the statistics, the dates are wrong.
   Indeed, it is indicated that the leave is over two days.

Cause:
    When we receive the dates via the rpc call to display them, they are character strings.
    The browser interprets them with the computer's timezone (even if it is UTC).
    The hours of work being at the limit of the day, we overflow on a second day.

Solution:
    As we know that the timezone used to store dates in the database is UTC, we can calculate an offset and apply it before displaying the result.

opw-3063177

closes odoo/odoo#107524

X-original-commit: 7d18d99d
Signed-off-by: Kevin Baptiste <kba@odoo.com>

When an employee was their own manager, the org chart would be filled
with their own name.

task-3093917

closes odoo/odoo#107497

X-original-commit: 53f9359d
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Kevin Baptiste <kba@odoo.com>

When website resolves its menu to the backend, it calls
`load_menus_root`. Unlike `load_menus`, that does not nicely handle
missing menuitems, so *if* one of the root menus was created manually
(hence doesn't have a xid) the website will crash either immediately
or when trying to open the backend menu (depending on version).

Fix by adding a similar fallback to that of `load_menus`.

closes odoo/odoo#106812

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>