Incorporate Andy Quijada (ajqn9094) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#117697

X-original-commit: 53fc292a
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce:
- Activate Analytic Account
- Create a Service Product - create project on order
- Create a quotation with the product
- Confirm the quotation
- Go on the project -> analytic account is "order # - partner_name"
- On the quotation - Create Invoice

Issue 1:
- The invoice has "order #" has the analytic account and not the "order # - partner_name"

Issue 2:
- if you create an invoice and wants to select the analytic account
  you cannot search it by the partner name, only by the "order #"

Cause:
When confirming the quotation, we create an analytic account. The
default name of the analytic account is the order name:
https://github.com/odoo/odoo/blob/bba5b6a440544151cc610bbc6848adfbadb38bfb/addons/sale/models/sale_order.py#L1416

Why is the analytic account displayed correctly on the project?
Because we use the `get_name` is triggered:
https://github.com/odoo/odoo/blob/bff34e0e8a8b2d211ef90ffea4f43c514e8cad28/addons/analytic/models/analytic_account.py#L115-L123



In the analytic distribution view, we only render the name of the
analytic account as it is defined primarly.

opw-3165655

closes odoo/odoo#113737

Signed-off-by: William André (wan) <wan@odoo.com>

duration_percent field is a stored integer.
In postgresql, integer are 4 Bytes long, which create a range of -2147483648 to +2147483647.
With a small duration_expected, and a big duration, we can easily break these limits.

OPW-3253333

closes odoo/odoo#117737

X-original-commit: 97892d04
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: David <dafr@odoo.com>

closes odoo/odoo#117685

X-original-commit: 8b98ad868f7810d9fdcf26a355a646b3eed53410
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

[FIX] account_edi_ubl_cii: wrong journal selected when uploading an invoice in a company with multiple journals of the same type

Steps to reproduce:
- Create two sales journals
- Select the second journal
- Upload an invoice
- The invoice is in the first journal instead of the second

Fix:
We can simply use the context to retrieve the current selected journal
if it's given, otherwise we use the previous fallback (infering the
journal with the move type)

task-id 3258956

closes odoo/odoo#117491

Signed-off-by: William André (wan) <wan@odoo.com>

steps:
project > kanban card > task analysis > list view of report

cause:
trying to open a project from the list view

issue:
looking for __count in read_group

fix:
add no_open to project_id in the list view because we can open a project from
kanban card and configuration

task-3111378

closes odoo/odoo#110405

Related: odoo/enterprise#34517
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Before this commit, having an accrual plan with no
level before a certain amount of time would result
in a crash because no relevant level is found.
This commit avoid that error.

closes odoo/odoo#117635

Signed-off-by: Kevin Baptiste <kba@odoo.com>

Current behavior:
In the pos order report the margin is not shown for products with no
cost.

Steps to reproduce:
- Create a product with no cost
- Open a pos session, add the product to the order and validate it
- Go to the pos order report and check the margin for the product
- The margin is not shown

opw-3232131

closes odoo/odoo#117328

X-original-commit: 08fa7015
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
Signed-off-by: Engels Robin (roen) <roen@odoo.com>

Since 8fb53c53, Order model is no longer
a backbone model therefore, we can no longer call the "trigger" method
on it. Normally, the old "trigger" call means we want to rerender the
screen and persist the new order information in the local storage.
The order object is already setup to do those mentioned (rerendering
and saving to local storage) when it's mutated. Therefore, we can just
simply remove the "order.trigger" and "this.render" calls as proposed
in this commit.

closes odoo/odoo#116642

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Incorporate Rolando Duarte (rolandojduartem) as Vauxoo's contributor.

I confirm I have signed the CLA and read the PR guidelines at:
www.odoo.com/submit-pr

closes odoo/odoo#117600

X-original-commit: 4c633bbe
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

On a calendar event, the 'free' option does not hide the element.
So that the user doesn't expect this behavior,
you have to modify its description.

opw-3047999

closes odoo/odoo#117599

X-original-commit: ecc850f4
Signed-off-by: Arnaud Joset <arj@odoo.com>
Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>

Current behavior:
When you create a contact and a delivery adress for this contact. If you
add the delivery adress as a vendor to a product, and purchase this
product from the delivery adress, the contact will be added to the
product vendor list.

Steps to reproduce:
- Create contact C
- Create delivery adress D for C
- Create product P
- Add D as a vendor to P
- Create PO for P from D, and confirm it
- Go to P, and check the vendor list (C is there)

opw-3177309

closes odoo/odoo#117594

X-original-commit: c98a0d0454150a2f9d2fae56daf60a45ebe2fa84
Signed-off-by: Engels Robin (roen) <roen@odoo.com>

If applied, this commit will solve the issue of the archived pos config issue
while session accessed from another tab, another device, or another user.

Steps to produce:
- Open the pos session.
- From another device or another tab archive the pos.config record.
- Refresh the opened session.

sentry - 4057306284
see - https://tinyurl.com/2opdugz4



closes odoo/odoo#117584

Signed-off-by: Achraf <abz@odoo.com>

PaymentScreenTotalDueWithOverPayment result to random runbot error because the
test is performing a series of steps that clicks the validate button which will
randomly result to going to the ReceiptScreen which is not the goal of the test.

In this commit, we replace the use of `pay` method with a more granular series
of steps to make sure that the test doesn't click the validate button and will
properly make the succeeding checks on the amounts in the PaymentScreen.

closes odoo/odoo#117501

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Steps to reproduce the bug:
- Create a Storable product “C1” tracked by Lot:
    - Update the Qty to 10

- Create a Storable product “P1”:
    - Add a BoM:
        - add 1 unit of  “C1” as component

- Enable 3 steps for the manufacturing operation in warehouse settings

- Create a Mo to produce 1 unit of “P1”:
    - Confirm the MO
    - Click on related transfer:
        - Select the “Pick component”
        - check that the qty is reserved correctly
        - Try to validate it without setting Qty done
        - The immediate transfer is triggered, validate it

Problem:
The backorder's wizard triggers when it shouldn't

To know if we should create a backorder, we check if the qty reserved
is equal to the qty done, and as the qty done was not set correctly
during the validation of the immediate transfer, the two quantities
are not identical, therefore the widget is trigger:

https://github.com/odoo/odoo/blob/15.0/addons/stock/models/stock_picking.py#L1128-L1132



opw-3240264

closes odoo/odoo#117467

X-original-commit: dff171b22cd38bb33a360ef87bf82dafbab953cd
Signed-off-by: Steve Van Essche <svs@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>

Current behaviour:
Cannot add a Work Order to a Manufacturing Order
if the analytic account linked to the MO doesn't
have an associated company.

Expected behaviour:
Should be able to add a WO to a MO even
if the linked analytic account doesn't have
an associated company.

Steps to reproduce:
1. Activate analytic accounts
2. Activate work orders
3. Create an analytic account without company associated
4. Create a Manufacturing Order
5. In miscellaneous, link the analytic account
6. Try to add a WO line
7. Error log

Reason for the problem:
When trying to add a WO line, if the MO has been linked
to an analytic account, it checks for the currency in
the company in the analytic account, which was not
existent, since the company didn't exist.

Fix:
When trying to access currency, if the company in the analytic
account doesn't exist, it defaults to the company in the WO.

opw-3210708

closes odoo/odoo#117410

X-original-commit: b7826da2
Signed-off-by: Tiffany Chang <tic@odoo.com>
Signed-off-by: Demany Antoine (ande) <ande@odoo.com>

closes odoo/odoo#115770

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

task-2917720

Part-of: odoo/odoo#115770

There is a very nice and clear system that helps the user to figure
what are the available area to drop content inside, and what will they
do: are they shared between products, or product specific etc.

The issue is that once you have dropped a snippet inside, that helper
message is not shown anymore, but it's still not obvious which area is
used for what, actually you have no clue which one is which, especially
if you come back on the page later: at best remember there were 2
separate zones but you don't especially remember which one is which.

Keeping the message helps in that regard without any negative impact.

Note that making the message appear when there are already a snippet
will work out of the box in the sense that the message will be
duplicated and shown twice: one at the very bottom of the area and one
at the very top.

Note that there is 5 cases to consider here:
- Empty website.page in edit mode (no drag & drop)
- Empty website.page with drag & drop
- Non empty website.page with drag & drop
- Empty product description with drag & drop
- Non empty product description with drag & drop

This commit also takes care of fixing the text color issue where the
"editor message" could not be read because of text color too close to
bg color.

task-3160416

closes odoo/odoo#111515

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

before this commit, in the list view of
fleet (fleet.vehicle),
services (fleet.vehicle.log.services) and
odometer(fleet.vehicle.odometer) the vehicle_id
and model_id field with many2one_avatar is
not showing the image of vehicle and model.

* open fleet -> fleet -> fleet
* switch to list view
* model field will be with empty image
* similarly in services and odometer menus

after this commit, the widget will be removed
from the field as the avatar field doesn't
exists in the model level.

closes odoo/odoo#117585

X-original-commit: 31de5c56
Signed-off-by: Kevin Baptiste <kba@odoo.com>

When creating a quotation in the sales app with a different shipping address, this is not shown on the invoice report from the point of sale.
Before it was always using the pos order partner address.
Now we check if the sale order had a different shipping address before setting the address on the report.

closes odoo/odoo#117447

Task-id: 3258679
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

The test tour `time_off_request_calendar_view` would fail once the first
Thursday of the year was not visible to the user (e.g. on the 1st April)
as the MouseEvents would not be fired.

closes odoo/odoo#117488

X-original-commit: 70f84099
Signed-off-by: Kevin Baptiste <kba@odoo.com>

when customer upgrading their database to the 16.0 from
older versions then it, they are facing an issue in discuss app
during opening the chat

```
UncaughtClientError > TypeError
Uncaught Javascript Error > Cannot read properties of undefined (reading 'channel')
TypeError: Cannot read properties of undefined (reading 'channel')
    at model.compute (https://69.test.upgrade.odoo.com/web/assets/157609-0cec86b/web.assets_backend.min.js:11716:504)
    at Listener.onChange (https://69.test.upgrade.odoo.com/web/assets/157609-0cec86b/web.assets_backend.min.js:10422:252)
    at ModelManager._notifyListenersInUpdateCycle (https://69.test.upgrade.odoo.com/web/assets/157609-0cec86b/web.assets_backend.min.js:10446:226)
    at ModelManager._flushUpdateCycle (https://69.test.upgrade.odoo.com/web/assets/157609-0cec86b/web.assets_backend.min.js:10433:64)
    at ModelManager.update (https://69.test.upgrade.odoo.com/web/assets/157609-0cec86b/web.assets_backend.min.js:10357:62)
    at model.update (https://69.test.upgrade.odoo.com/web/assets/157609-0cec86b/web.assets_backend.min.js:10504:137)
    at model._handleGlobalWindowFocus (https://69.test.upgrade.odoo.com/web/assets/157609-0cec86b/web.assets_backend.min.js:11803:184)
    at owl.EventBus.trigger (https://69.test.upgrade.odoo.com/web/assets/157608-48bb818/web.assets_common.min.js:1535:63)
    at onFocusChange (https://69.test.upgrade.odoo.com/web/assets/157608-48bb818/web.assets_common.min.js:6255:165)
    at https://69.test.upgrade.odoo.com/web/assets/157608-48bb818/web.assets_common.min.js:6258:84
```

for more clear: https://www.awesomescreenshot.com/video/16178967?key=69054b02935378a1708a3cdc726614fa



issue-3183156,3232109

closes odoo/odoo#117468

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Steps to reproduce
==================

- Go to elearning
- On the "Trees, Wood and Gardens" card, click on "view course"
- Click on Main Trees Categories

The slide name is outside the view
Also, the XP badge is cropped

opw-3225999

closes odoo/odoo#116781

Signed-off-by: Hubert Van De Walle <huvw@odoo.com>

closes odoo/odoo#117515

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Before this commit:
- A portal user cannot access the project if he's not a
follower but a public user can do that and it doesn't
make sense for portal users to have less access than public users.

- Technically the problem was that we call _check_project_sharing_access
with the portal user instead of sudo, so when trying to access
self.collaborator_ids, an exception is raised saying that
the portal user cannot access to project fields.

After this commit:
- Portal users can access the project in read-only when they are not
followers.
- Technically, we preferred searching over just adding self.sudo()
to get the result directly in one query for a better performance.

task-3205644

closes odoo/odoo#117401

X-original-commit: 0130508e
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Before this commit, in the website profile frontend, if we filter the users
using 'This week' or 'This month' filters we always get a '+' displayed before
the karma gain.

If user gained negative karma, lets say -500, currently it displays as follows
--> +-500 , instead of -500.

After this commit, if the gained karma during the period is it will show
-500 instead of +-500.

closes odoo/odoo#117018

X-original-commit: d4068589
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#114547

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

English term changed in source. Dutch and French via Transifex.

task-3193776

closes odoo/odoo#113780

Related: odoo/enterprise#37578
Signed-off-by: William André (wan) <wan@odoo.com>

- Create an account of type current asset
- Add him a Sales Tax and a Purchase Tax
- Create invoice
- Add a line
- Remove the taxes from this line
- Change the account to the one you created

=> A purchase tax is applied to the line.
It should not happen, so we prevent it.

closes odoo/odoo#117481

X-original-commit: 8c8d657c
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>

It takes a too long to load project task kanban view.
And ~85% of this time is spent in `ProjectTask._get_all_subtasks`,
which is a recursive method returning the children of the children,
while any, of the task, for each task, just to display their count.

We replaced this recursive method with a SQL request,
which is way faster. Also, it can be called in batch.
It will return a dict {id: subtask_ids}.

task-3246085

closes odoo/odoo#116570

Related: odoo/enterprise#38723
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Bug:
Currently, creating an intra-community bill and reconciling it with an
early payment can break the tax report.

Steps to reproduce:
1. install the Austrian localization (l10n_at)
2. set `Cash Discount Tax Reduction` to `On early payment`
3. create a €1000 intra-community bill (you can just use the tax called
   `IGE 20%`)
4. set the payment term to`2/7 Net 30` and confirm
5. reconcile the bill with a payment within the discount period
   (2% discount: €980).
6. check the Tax Report: line 5.4 of the report should be €196. If you
   reconciled the bill with a back statement directly, sections
   `Innergemeinschaftliche Erwerb` and `Bemessungsgrundlage` will be
   wrong as well.

Cause:
Since the intra-community applies here, the bill will produce two tax
lines. And because `Cash Discount Tax Reduction` is set to `On early
payment`, those two tax lines will be reduced when an early payment is
made.
However, because of the way the `is_refund` property of
`account.move.line` field is computed on moves of type `entry`, one of
those *tax reduction line* will be considered a refund and the other
will not. Furthermore, the computed tags are correct only because the taxes
are recomputed again when creating the payment.
After removing this extra taxes computation, both tax_tag_ids/tax_tag_invert
are invalid.
So the solution is to fix the method computing the taxes for cash discount lines.

opw-3112197

Enterprise PR: odoo/enterprise#39181

closes odoo/odoo#114801

Signed-off-by: Laurent Smet <las@odoo.com>
Co-authored-by: Laurent Smet <las@odoo.com>

Before this revision, a date/datetime field was displayed in UTC instead
of in the user timezone.
This revision fixes this issue.

opw 3127742

closes odoo/odoo#114529

X-original-commit: odoo/enterprise@4bbf70f
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>

_create_or_update_picking() is a time-consuming method.
On some Purchase, all the purchase.order.line may be written with 'product_qty' in 'values', even though it did not change.

OPW-2978569

closes odoo/odoo#117350

X-original-commit: 5575fe2d
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: David <dafr@odoo.com>

In the MO form view, the total quantity was broken: it was appearing bellow the line.

Steps to reproduce:

Go to Manufacturing App
Click on some Confirmed MO
The quantity field in MO forms is appearing bellow the line and broke the view
This issue was happening because the button was automatically using class "btn" and it was using a padding style that was moving them bellow the expected position.

OPW-3244574

closes odoo/odoo#117020

Signed-off-by: Adrien Widart <awt@odoo.com>

Reverts 90b856dc: for the reasons
noted by @rco-odoo on the PR the relaxation of the regex was not
sufficient, and the NULLS clause would not *just* be ignored, in the
case of m2os it would break DESC clauses (that is `DESC NULLS LAST`
would be entirely ignored).

While this is fixable (and probably improves that code), it was
considered a bit too risky to be implemented in 16.0 directly, so it's
going to be implemented in master, then maybe get backported later.

closes odoo/odoo#117437

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Since BS5 integration in v16.0, the pdf of the sale and purchase report have changed. Borders would be present in the body of the report and the total detail.

Came back to v15 display by using the table-borderless class on those elements.

closes odoo/odoo#117431

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Before this commit: if the user wanted to generate a
POS Inalterability Check statement, an IndexError was raised.
This commit raises a more understandable error.

opw-3237383

closes odoo/odoo#117364

X-original-commit: 9cc56fc3
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>

Before this commit: the `product.display_name` field could contain
line breaks, which prevented it from being matched correctly by
regular expressions. This commit fixes the issue by modifying the
`_product_search_string()` function to remove line breaks.

opw-3239830

closes odoo/odoo#117352

X-original-commit: 80d8a057
Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>

This commit is a security reinforcement.

Before this commit:

ir.action.act_url was able to handle and redirect to protocols like
file:, javascript:, date: ... This is unnecessary in the context of
this action. It could potentially be abused by a poorly written custom
module

It also would not isolate the landing page in case of a new tabs.
It means that chrome would still consider the tab to be from the
previous domain in case no url was passed and js was executed.
This would allow the newly open tab to still make query's to the
referrer using the referrer's cookie. While not stricly necessary
if we already prevent url that start with "javascript:", it is a
nice to have.

After this commit:

New tabs are not able to access referrer informations or execute
javascript interacting with the referrer. Also, it is now impossible
to redirect to protocols other than http and https directly from
the ir.action.act_url

Test update:

All new tabs are required to have the "noreferrer" argument

Tested an example of an unsupported protocol.

closes odoo/odoo#117329

X-original-commit: 69b086eb
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Vranckx Florian (flvr) <flvr@odoo.com>