* = hr_holidays, im_livechat, sms, snailmail, website_livechat,
    website_slides

Move tests files into `static/tests`.

Task-2759560

closes odoo/odoo#86581

Related: odoo/enterprise#25375
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Create a 21% tax included in price
Create a 6% tax included in price
Create a fiscal position that will replace the 21% tax included by the
6% tax included
Create a customer and assign this fiscal position
Create a product :
Price = 121€
Tax = 21% tax included
Create a SO with this customer and this product
Create an invoice (from scratch) with this customer and this product

SO : the unit price is 100,00€
Invoice : the unit price is 106,00€

Fix by creating a common method to calculate the price_unit

opw-2699793

closes odoo/odoo#86514

X-original-commit: 8ab56af6827a640a3f41a87905778432b3786c00
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Task-2793280

closes odoo/odoo#86466

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Task-2793280

closes odoo/odoo#86459

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

When applied, this commit will add correct classes and structure to fix
the style of upload notifications in the web editor. When an user
uploads an image, he gets a progress and validation (or error)
notification. We changed how notifications look at [1], but this
particular notification did not get the correct style.

[1]: https://github.com/odoo/odoo/commit/2629348090d6eabe8f9d3ae70a41f7ff7d45bbb6



task-2791078

closes odoo/odoo#86172

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Currently, the tax report contains the lines for tripartite trade,
but no taxes have been made for these.
As the EC list report use these taxes it, these needs to be implemented.

closes odoo/odoo#86658

Task: task-2759470
X-original-commit: 2fcf3f14
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Julien Alardot (jual) <jual@odoo.com>

On 19e775b3 we added the same rules that
exists in test_lint on the tooling, but we didn't add the globals.

closes odoo/odoo#86649

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Two lines have been inverted in ``_get_access_action`` override, leading
to access rights not being correctly checked. This currently leads customers
with token to land on portal without token, which is not the expected
behavior.

Followup of odoo/odoo@a018735

closes odoo/odoo#86646

X-original-commit: dd7d60aca8718763aaa211e138f684d8797f5d8c
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Task-2793280

closes odoo/odoo#86450

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Task-2793280

closes odoo/odoo#86446

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Prior to this commit the create_employee check box was always shown when
using the view_users_simple_form, it will now only show when the record
does not exist yet.

TaskId-2797251

closes odoo/odoo#86636

Signed-off-by: Kevin Baptiste <kba@odoo.com>

When we were doing a price modification on a product and this orderline was refund, the displayed price on the product screen was changed to the new value.

Example:
  - Default price: 33
  - Paying with a price set to: 2
  The order is refund:
  - Product price is set to 2
  It should only be 2 on the order refunded.

The fix doesn't change the price of the product after a refund anymore.

closes odoo/odoo#86627

X-original-commit: 62512893
Signed-off-by: Masereel Pierre <pim@odoo.com>

When codice fiscale is not the same as the partita IVA, the template was
utilising the wrong value for IdCodice in <IdTrasmittente>. It should
use the value of codice fiscale, and if it's not found, then use the vat
value (e.g. when it's not an Italian company).

closes odoo/odoo#86621

X-original-commit: e961ff22
Signed-off-by: Josse Colpaert <jco@odoo.com>

The issue is that the config param is data, which means that when the
module is updated, the config parameter will be updated (i.e. reset to
the 'demo' state), which will cause havoc on client databases. Even if
we set the record to 'noupdate=1', the existing clients will have the
record updated.

The solution is to remove the config param from the data entirely, thus
preventing it from being updated when updating the module, and instead
have a 'post_init_hook' that sets the parameter to 'demo' (this will
only happen when the module is installed, and never again).

closes odoo/odoo#86607

X-original-commit: 1d3cd7ee
Signed-off-by: Josse Colpaert <jco@odoo.com>

PrezzoUnitario causes an error when the discount is 100% as it tries to
divide by zero. Fix this by just using the unit price when the discount
is 100%.

closes odoo/odoo#86614

X-original-commit: 23e84145
Signed-off-by: Josse Colpaert <jco@odoo.com>

The EDI rejects the xml if the <IdDocumento/> is longer than 20
characters long.

X-original-commit: 2c76293c
Part-of: odoo/odoo#86614

*: hr_holidays, im_livechat, mail, mail_bot, sms, snailmail, test_mail,
website_livechat, website_slides.

Mail tests are currently relying on this during tests to make env, widget,
data available. We don't wan't to add magic keys to this anymore.

task-2792108

closes odoo/odoo#86559

Related: odoo/enterprise#25341
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Task-2793280

closes odoo/odoo#86449

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Task-2793280

closes odoo/odoo#86443

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Consider the following case:

1) Create a 42% cash basis tax, impacting different grids on each repartition line
2) Create a misc entry using this tax, with the same lines as an invoice, with base amount of 100
3) Create a payment and reconcile it with the invoice-like move from step 2. This will create a cash basis move.
4) Cancel reconciliation
===> In the tax report, instead of seeing 0 in the base grid, we see 200. Amounts are doubled instead of being cancelled, they shouldn't. Tax grid is fine.

This is due to the fact tax_tag_invert is going to be computed, and will hence not have the same value as on the original move, since debit and credit on base and tax lines are inverted in the reverse move. Tax line is fine because it relies on tax_repartition_line_id, which is kept from the original move.

We now force keeping the same value for those moves as in the original one, to force full cancellation.

OPW 2769340

closes odoo/odoo#86229

X-original-commit: 338c2e90
Related: odoo/enterprise#25182
Signed-off-by: Laurent Smet <las@odoo.com>

Prior this commit,`o_AttachmentViewer_toolbar`,
`o_AttachmentViewer_viewIframe` and buttons used CSS properties with
arbitrary values.

To keep the layout consistent and remove more raw css, this commit uses
component and utility classes instead.

task-2781992

closes odoo/odoo#85772

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

Part-of: odoo/odoo#85772

Prior to this commit:
- The test tour was falling in some circumstances, when additional reads
  were done right after the last step.

After this commit:
- Adding the last step which is returning the the project app menu will
  prevent having those additional reads after the last step.

closes odoo/odoo#86558

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

We have added the name of the group to Email Content to minimize the
indexing on xpath.

Task-2710557

closes odoo/odoo#86555

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

A file was accidentally pushed in the context of a last rebase
prior to merge.
See odoo/odoo#82634

closes odoo/odoo#86564

Signed-off-by: Laurent Stukkens (ltu) <ltu@odoo.com>

Move model definition files from `models/thing/thing.js` to
`models/thing.js` and remove the now empty intermediate directory.

Task-2759582
 * = calendar, crm_livechat, hr, im_livechat, mail_bot, sms, snailmail,
     website_livechat, website_slides

closes odoo/odoo#86464

Related: odoo/enterprise#25291
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

 * : mail_bot, website_livechat
Task-2759560

Part-of: odoo/odoo#86464

Prior this commit, the dark color was the same as the Bootstrap color.
It wasn't contrasted enough and was therefore replaced by raw css in
some situations.

To keep consistency with the overall layout, this commit applies the
darkest gray as the $dark variable to improve the value and now
encourages the use of utility classes instead of raw values.

task-2788931

closes odoo/odoo#86046

Related: odoo/enterprise#25100
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

In a recent fix, the default values generated for datetime fields in
custom filter was incorrectly set, as the returned date objects were
lost instead of being assigned.

This commit restores the intended behavior.

closes odoo/odoo#86538

X-original-commit: 2720c5be
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

In the mobile review of all apps, some behaviors have to be corrected.

After this commit :
- When you want to select a feedback template to send, the list is showed with less information so that it's easier to read.
- The ask feedback is open to any employee of the company, not only the users of the app. The email will be sent with a link available to anyone.
- When state is Done, the add buttons on skills does not appear anymore.

TaskID : 2743968 [Appraisal] Usability

closes odoo/odoo#84053

Related: odoo/enterprise#24044
Signed-off-by: Kevin Baptiste <kba@odoo.com>

Prior this commit, the popover arrow was in raw SCSS and used only
the four basic directions (top, right, bottom, left).

After this commit, the popover uses the Bootstrap arrow and this
arrow can also use the additional directions defined in
`position_hooks.js`.

It also revamp the SCSS of the component.

task-2748120

closes odoo/odoo#83646

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

Part-of: odoo/odoo#83646

Changes:
- remove all of o-popper-position... auto applied classes system
- add a onPositioned callback to the options
  Usage
    usePosition(reference, {
      /**
       * @param {HTMLElement} popperElement
       * @param {{
       *  direction: "top" | "right" | "bottom" | "left",
       *  variant: "start" | "middle" | "end"
       *  top: number,
       *  left: number,
       * }} position
       */
      onPositioned: (popperElement, position) => {
          const { direction } = position;
          // ...
      }
    });

Part-of: odoo/odoo#83646

As component.el is removed: see https://github.com/odoo/owl/blob/master/CHANGELOG.md#9-componentel-is-removed

Part-of: odoo/odoo#83646

Prior to this commit an 'oi-fw' icon width was assigned directly to its
:pseudoelement and eventually refined according to sizes classes.

Despite being useful in some circumstances, this behavior was causing
inconsistencies when 'oi-fw' icons were rendered beside 'fa-fw' ones.

This commit reviews how fixed-width icons are achieved, providing a more
consistent visual result between '.fa' and '.oi' classes.

task-2795108

closes odoo/odoo#86508

Signed-off-by: Pierre Paridans (app) <app@odoo.com>

Since [1] when resetting the background color of the header, the footer
or the copyright, the 'menu-custom' property is saved as the 'false'
string.
There is no visual effect of this problem, but in case that property is
used in an SCSS `color-yiq` function call, it will trigger an error.

This commit solves this by removing the root cause of this 'false'
string: during the initialisation of color palettes a list of named
colors is built by browsing the color buttons and associating their
data-color attribute to their background-color, except for buttons
containing a gradient color.
Unfortunately this inventory also looked at the "Custom" gradient
button: this button has no background color (and was thus not detected
as being a gradient and therefore not excluded from the inventory) and
it has data-color="false". It therefore introduced a mapping between ""
and "false" - thus making the reset operation's empty string mapped to
the "false" string. This commit removes that button from the named
colors inventory.

Steps to reproduce:
- select the header
- open the "Colors" palette
- click on the None button (the trashcan icon)
=> the customization properties attachment contained a line
```
'menu-custom': 'false',
```

[1]: https://github.com/odoo/odoo/commit/a48a30f954afcb6ff3a59c4f32b05fd0c2cfcd2b



task-2633169

closes odoo/odoo#86548

X-original-commit: 2f28c37f
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Query counter tests related to account composer are actually dependent on
l10n due to extra queries, related to account.move fields and/or COA
specific code. Moreover some COA might skip or delay the sending, leading to
emails not being sent.

Purpose would be to run those tests only with generic_coa. Those tests will
be moved and improved soon, removing it currently to avoid frictions with
L10N builds.

This reverts odoo/odoo@d0e0db3b8eee381def04442ddaecfb82ff9859cc

closes odoo/odoo#86540

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#86279

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#86265

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Part of the overall v16 SCSS optimization/restyle, task-2704984

task-2781992

closes odoo/odoo#86173

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>