Skip to content
Snippets Groups Projects
  1. Jul 17, 2020
    • Joseph Caburnay's avatar
      [FIX] point_of_sale: touch events are passive and allow resize with touch events · ce8cb110
      Joseph Caburnay authored
      
      1. Methods associated to touchmove and touchstart listeners should not
      call preventDefault because they are passive by default. Calling preventDefault
      will do nothing but in chrome browser, error message is issued.
      2. We now allow resize based on touch events.
      
      closes odoo/odoo#54612
      
      X-original-commit: c6b7133d9c9dc52a8d283124b5a4497940e54682
      Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
      ce8cb110
    • Joseph Caburnay's avatar
      [FIX] point_of_sale: no need for disableRubberbanding · f6f1ea6f
      Joseph Caburnay authored
      The primary goal of disableRubberbanding is to disable scrolling during
      touch event by default and to allow only selected descendants to have scrolling
      active during touchstart+touchmove event. Only elements with class="touch-scrollable"
      are allowed for touch scrolling. This restriction can be a good idea but it
      results to bug-ridden explicitness which is not necessary because scrolling
      should be allowed automatic by default in the first place. In this commit, we
      allowed scrolling by default by:
      
      1. We remove disableRubberbanding.
      2. We set the position property of .pos to fixed. This is to accomplish the
      original goal of disableRubberbanding (fixing the root element in its position).
      3. We remove the touch-scrollable class as they are not needed anymore and
      no style associated to it.
      
      Removing the disableRubberbanding method also fixes the Intervention error during
      touch scrolling event. The reason for that error is we are calling preventDefault
      in the event that is passive. touchmove and touchstart events are passive by default
      - which means that preventDefault won't work.
      
      X-original-commit: 54f7fb49dae3aab6a005402a1ac60262bbd15edc
      f6f1ea6f
  2. Jul 16, 2020
    • Thibault Francois's avatar
      [FIX] doc: update cloc documentation · 02d613b5
      Thibault Francois authored
      
      After the commit 2a57a156
      Cloc excluded by default one more folder, it should appear
      in the documentation of the tools
      
      closes odoo/odoo#54609
      
      X-original-commit: 93261c78
      Signed-off-by: default avatarVictor Feyens (vfe) <vfe@odoo.com>
      02d613b5
    • Didier (did)'s avatar
      [IMP] mail: focus the next chat window when closed by ESC · c1b6c066
      Didier (did) authored
      
      This allows user to close multiple windows with ESC key.
      
      task-2283891
      
      closes odoo/odoo#54604
      
      X-original-commit: bac3d7792a48f86a39f92e0fcfc18d522ce00d94
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      c1b6c066
    • Xavier Dubuc's avatar
      [FIX] mail: fix activity template (t-if placements) · 9ba8eb4a
      Xavier Dubuc authored
      
      odoo/enterprise#11836
      task-2296875
      
      closes odoo/odoo#54600
      
      X-original-commit: 687628fa35063db5b44abcc758cae0a597df5ffe
      Related: odoo/enterprise#11904
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      9ba8eb4a
    • Jeremy Kersten's avatar
      [FIX] website_forum: fix traceback on comment · b9b228f1
      Jeremy Kersten authored
      
      Before this commit, try to post a comment will raise a traceback in front end
      because textarea is not found.
      
      Now, we check that we are writing in textarea content and no more in textarea
      comment.
      
      closes odoo/odoo#54595
      
      X-original-commit: 867458456b13daf9b5586c17b7475e68d9d008e1
      Signed-off-by: default avatarJérémy Kersten (jke) <jke@openerp.com>
      b9b228f1
    • Xavier Dubuc's avatar
      [FIX] mail: show subject of the message in inbox if set · decf5147
      Xavier Dubuc authored
      
      task-2280146
      
      closes odoo/odoo#54599
      
      X-original-commit: 3114c7dab3c7f0f63e59f01fd06237fdc109203a
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      decf5147
    • Yannick Vaucher's avatar
      [FIX] l10n_ch: Swiss QR names len limit · 9afee4f2
      Yannick Vaucher authored
      
      Limit must be 70 not 71
      
      closes odoo/odoo#54587
      
      X-original-commit: 7d808675
      Signed-off-by: default avatarJosse Colpaert <jco@openerp.com>
      9afee4f2
    • fw-bot's avatar
      [FIX] mrp: avoid consumption check for null additional components · 679a746b
      fw-bot authored
      
      Adding additional product to a production but consuming 0 on it will
      trigger the consumption warning wizard while no difference with the bom
      are occurring. This commit do not trigger the consumption issue in that
      case.
      
      Task : 2278147
      
      closes odoo/odoo#54561
      
      Related: odoo/enterprise#11885
      Signed-off-by: default avatarArnold Moyaux <amoyaux@users.noreply.github.com>
      679a746b
    • fja-odoo's avatar
      [FIX] mrp: fix _set_qty_producing · eedbcfbe
      fja-odoo authored
      
      On a MO which product_id has a serial tracking, some components and 2
      or more WO:
      The method _set_qty_producing of a WO will call the MO _set_qty_producing
      method even if no changes is made on qty_producing which can produce an
      undesired aditional move line when creating the MO.
      
      On a MO which product_id has a serial tracking and some components:
      Changing the qty_producing on a MO was adding a line on the component
      move.
      
      Since the _set_qty_producing method is called when creating a WO it sets
      the qty_producing of the MO to 0. As it does not make sense to have a WO
      set the qty_producing of a MO to 0 we will not replicate it.
      
      task-2278147
      
      closes odoo/odoo#54579
      
      X-original-commit: ca8275aa28010b73cad14f667068e9cfc6c651a5
      Related: odoo/enterprise#11896
      Signed-off-by: default avatarArnold Moyaux <amoyaux@users.noreply.github.com>
      eedbcfbe
    • Rémy Voet (ryv)'s avatar
      [FIX] stock: remove empty move line · 8a8d5eba
      Rémy Voet (ryv) authored
      _set_quantity_done_prepare_vals is call to (re)create move line
      during some onchange/compute. But it never removed empty line.
      Then remove empty line (when no reserved quantity and no done quantity)
      
      task-2278147
      
      X-original-commit: a1ab74d6cd75cee64fcd432d387180299fd64c72
      8a8d5eba
    • Martin Trigaux's avatar
      [FIX] *: do not import tests folder · 09fa76af
      Martin Trigaux authored
      
      The tests must be only imported in a test context, not in a running
      context.
      Since 92a7f8c1 a new test requirement was added but it should
      not be necessary to run a module, only to execute the tests.
      
      closes odoo/odoo#54578
      
      X-original-commit: 15f2bbd4
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      09fa76af
    • Xavier Morel's avatar
      [FIX] core: handle recordsets in traverse_containers · c0745584
      Xavier Morel authored
      
      Since recordsets are self-recursive, they should be treated like
      strings (where iterating a string yields a string, infinitely) in case
      somebody happens to return a non-downgraded recordset from a method.
      
      closes odoo/odoo#54572
      
      X-original-commit: 6d88845f
      Signed-off-by: default avatarXavier Morel (xmo) <xmo@odoo.com>
      c0745584
    • Swapnesh Shah's avatar
      [IMP] crm: Improve field label · fde2b7a9
      Swapnesh Shah authored
      
      Improving field's string to make it alignes with all other fields in
      Odoo.
      
      closes odoo/odoo#44055
      
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      fde2b7a9
    • jbm-odoo's avatar
      [FIX] hr_recruitment: Keep phone number with mail template · a8a77588
      jbm-odoo authored
      
      Before this commit:
      If a template_id is put on the first stage, a partner is
      automatically created at the creation of the applicant. And if the
      applicant had a phone or a mobile, they are removed.
      
      After this commit:
      The phone and mobile are saved on partner and not removed from
      applicant.
      
      taskId 2299970
      
      closes odoo/odoo#54574
      
      X-original-commit: 3735c3363f422d01ae1ff96e761a1b206fc32a69
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      Signed-off-by: default avatarjbm-odoo <jbm-odoo@users.noreply.github.com>
      a8a77588
    • Laurent Smet's avatar
      [IMP] delivery: Remove dependency to AccountTestCommon · 18360d80
      Laurent Smet authored
      
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      closes odoo/odoo#54444
      
      --task: 2296213
      Related: odoo/enterprise#11833
      Signed-off-by: default avatarQuentin De Paoli (qdp) <qdp@openerp.com>
      18360d80
    • Laurent Smet's avatar
      [IMP] stock_landed_costs: Remove dependency to AccountTestCommon · e936437d
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      e936437d
    • Laurent Smet's avatar
      [IMP] purchase_stock: Remove test_stockvaluation dependency to AccountTestCommon · 3849b154
      Laurent Smet authored
      Also, this commit fixes the usage of the 'invoice_policy' field in test that is introduced by the 'sale' module.
      
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      3849b154
    • Laurent Smet's avatar
      [IMP] membership: Remove dependency to AccountTestCommon · 15a45be0
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      15a45be0
    • Laurent Smet's avatar
      [IMP] payment(_*): Remove dependency to AccountTestCommon · 85e187eb
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      85e187eb
    • Laurent Smet's avatar
      [IMP] account: Remove test_settings dependency to AccountTestCommon · d421934f
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      d421934f
    • Laurent Smet's avatar
      [IMP] account: Remove test_account_move_rounding dependency to AccountTestCommon · ce8eb6e9
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      ce8eb6e9
    • Laurent Smet's avatar
      [IMP] account: Remove test_reconciliation dependency to AccountTestCommon · 3b4962cc
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      3b4962cc
    • Laurent Smet's avatar
      [IMP] account: Remove test_account_incoming_supplier_invoice dependency to AccountTestCommon · 5340e321
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      5340e321
    • Laurent Smet's avatar
      [IMP] product_margin: Remove dependency to AccountTestCommon · 33539080
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      33539080
    • Laurent Smet's avatar
      [IMP] repair: Remove dependency to AccountTestCommon · 7a57363c
      Laurent Smet authored
      l10n runbot builds are all failing when running at least one test depending of AccountTestCommon because it:
      - doesn't create a sandboxed testing environnement to manage the multi-currency, multi-company, the default company's currency, the exchange rates...
      - doesn't setup a testing user then all tests are done using the superuser.
      - doesn't provide a fully setup chart of accounts: exchange difference journal is not set, accounts have bad types, etc...
      - is run sometimes at-install.
      
      --task: 2296213
      7a57363c
  3. Jul 15, 2020
  4. Jul 16, 2020
    • Martin Trigaux's avatar
      [FIX] *: do not import tests folder · 14940225
      Martin Trigaux authored
      
      The tests must be only imported in a test context, not in a running
      context.
      Since 92a7f8c1 a new test requirement was added but it should
      not be necessary to run a module, only to execute the tests.
      
      closes odoo/odoo#53628
      
      Related: odoo/enterprise#11882
      Signed-off-by: default avatarMartin Trigaux (mat) <mat@odoo.com>
      14940225
    • Martin Trigaux's avatar
      [IMP] stock: keep coherant action name · e61a3bc1
      Martin Trigaux authored
      At bee938e0 (following task-id 2042303), the label of the action was
      changed globaly.
      The action is however shared with multiple menus like Inventory Report.
      The Update Quantity label only makes sense when coming from the
      product where the quantity will be updated.
      
      Closes odoo/odoo#50523
      e61a3bc1
    • Adrian Torres's avatar
      [FIX] core: mapped() does not prefetch as expected · 9fefa087
      Adrian Torres authored
      
      Before this commit, calling `mapped()` on a relational field of a single
      record inside a for loop does not correctly propagate the prefetch ids
      from the bigger recordset down to the record inside the loop:
      
          [rec.line_ids.mapped('name') for rec in recs]
      
      To be more precise, `recs` correctly propagates prefetching information
      down to `rec.line_ids`, but method `mapped()` does not pass it along to
      the record that triggers the prefetching.
      
      This resulted in one query per record in `recs`, so if `recs` were a
      1000 records recordset, at least 1000 queries would be necessary.
      
      With this commit, the `mapped()` function correctly propagates the
      `_prefetch_ids` of the larger recordset (`rec.line_ids`) so that the
      prefetching works properly and the 1000 queries are brought down to 1.
      
      This commit is a followup on #42611.
      
      closes odoo/odoo#54565
      
      X-original-commit: 0e97053fee36c0c76b70cb94be5340c3144b178b
      Signed-off-by: default avatarRaphael Collet (rco) <rco@openerp.com>
      Signed-off-by: default avatarAdrian Torres (adt) <adt@odoo.com>
      9fefa087
    • Xavier Morel's avatar
      [FIX] core: mis-updated SQL queries · 65b8751e
      Xavier Morel authored
      
      odoo/odoo#53938 improved the SQL linter and used psycopg2.sql to
      silence the linter where that still made sense. However I forgot to
      mark table names (pretty much exclusively) as `sql.Identifier` in a
      few somewhat rare callsites, which consequently break when invoked as
      a simple string is not a Composable and psycopg2 therefore rejects it
      when composing the query.
      
      closes odoo/odoo#54556
      
      Signed-off-by: default avatarXavier Morel (xmo) <xmo@odoo.com>
      65b8751e
    • Jorge Pinna Puissant's avatar
      [REF] mail: extract the compute of date deadline to be used in hr · 11784de3
      Jorge Pinna Puissant authored
      
      opw-2265631
      
      closes odoo/odoo#54548
      
      X-original-commit: c029bfeb3e04b5b314663db34db0a56b6165a6b7
      Signed-off-by: default avatarNicolas Lempereur (nle) <nle@odoo.com>
      Signed-off-by: default avatarJorge Pinna Puissant (jpp) <jpp@odoo.com>
      11784de3
    • Jorge Pinna Puissant's avatar
      [FIX] hr: activity type configuration on hr plans · 793edf32
      Jorge Pinna Puissant authored
      revert of 0f4ec369 and bf8a9af1
      
      - Employees > Configuration > Planning Types and ensure the activity
          type "To Do" is set to scheduled date several days after previous
          activity (default should be 5 days);
      - Check that onboarding Plan has at least 2 activities with activity
          type "To Do";
      - Click launch plan.
      
      The activity type configuration is ignored and all activities are due
      tomorrow. The previous commit uses the function
      _onchange_activity_type_id to fix this issue.
      
      The problem with this commit, is that the _onchange_activity_type_id
      function will also change the responsible, the notes and the summary to
      set them to their default value.
      
      Now, the activities are due taking into account the activity type
      configuration without modifying the already set responsible, notes and
      summary.
      
      opw-2265631
      
      X-original-commit: 81e4745a31567af7b58064bd8b4e9bae0756354f
      793edf32
    • Jorge Pinna Puissant's avatar
      [FIX] hr_timesheet: timesheet button in employees view · e0baa3be
      Jorge Pinna Puissant authored
      
      Before this commit, only the users with timesheet 'Administrator' rights
      can see the Timesheet button in the employees view.
      
      Now, the users with timesheet 'See all Timesheet' rights can see the
      Timesheet button in the employees view.
      
      This is the behaviour in version 12.
      
      opw-2285695
      
      closes odoo/odoo#54543
      
      X-original-commit: c839ecda
      Signed-off-by: default avatarJorge Pinna Puissant (jpp) <jpp@odoo.com>
      e0baa3be
    • Xavier Dubuc's avatar
      [FIX] mail: fix moderation accept multiple messages button · 978f8ca4
      Xavier Dubuc authored
      
      Once global "Accept" button is clicked, the accepted messages were not
      unchecked causing the button to stay hidden until next page reload.
      
      task-2285430
      
      closes odoo/odoo#54549
      
      X-original-commit: 5594de16f463507498e852c2d49d1cbe74ed7381
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      978f8ca4
    • Raphael Collet's avatar
      [FIX] core: update of one2many field on new record with origin · a21e8afd
      Raphael Collet authored
      
      An onchange method can remove an existing line from a one2many field of
      a new record with command 2, such as:
      
          move.line_ids = [(2, <NewId origin=42>), ...]
      
      The processing of the command 2 above incorrectly tries to remove the
      new line from the origin record, instead of the new record.
      
      closes odoo/odoo#54545
      
      X-original-commit: 7d138a44
      Signed-off-by: default avatarRaphael Collet (rco) <rco@openerp.com>
      a21e8afd
  5. Jul 15, 2020
    • Joseph Caburnay's avatar
      [FIX] pos_restaurant: split bill screen responsive · 800fa081
      Joseph Caburnay authored
      
      The layout of the split bill screen is broken after the responsive pos ui.
      This fixes the split bill screen and make it also responsive.
      
      New classes are introduced because reusing proved to be very difficult.
      One benefit of declaring a new classes (then styling them) is that we can
      target the particular elements that we wanted to change without the concerns
      that another elements are changed.
      
      closes odoo/odoo#54529
      
      X-original-commit: 51f0c6a1be912192d910d47b79ac2cb3c5b42784
      Signed-off-by: default avatarpimodoo <pimodoo@users.noreply.github.com>
      800fa081
  6. May 19, 2020
  7. Jul 10, 2020
  8. Jul 15, 2020
Loading