closes odoo/odoo#50961

X-original-commit: cdf3b380
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Write something in a many2one field, and click on 'Create "..."'
to quick create a record with the given value (name_create). When
the name_create fails (e.g. because there are mandatory fields in
the model), we open a form view.

Before this commit, when this happened for many2one fields inside
x2many editable lists, it crashed, since [1].

[1] 50bf8309

closes odoo/odoo#50948

X-original-commit: 43c513306094444ff25ad98584b426ddb8a3b525
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

With this fix, record.with_context(lang='fr').compute_url will have the url
with the slug in french.

Before, it was ignoring the lang since the field was not translatable.
The first compute was stored in cache, and next call just ignore the lang in
the context.

```py
for lang in ['en_US', 'fr_FR']:
    print(record.with_context(lang=lang).website_url)

> "/my-name-1"
> "/my-name-1"
```

now

```py
for lang in ['en_US', 'fr_FR']:
    print(record.with_context(lang=lang).website_url)

> "/my-name-1"
> "/mon-nom-1"
```

closes odoo/odoo#50951

X-original-commit: 43822ade
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Before this commit, the /event/event-id/page/inexisting_page crashes with an
internal error 500:
of1 ValueError: View 'website.404' in website 1 not found

X-original-commit: d493fdd2

Courtesy of Federico Zanuttini (fza), Odoo

closes odoo/odoo#50928

X-original-commit: 9b201746
Related: odoo/enterprise#10471
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Sub categories were missing and will be usefull to test the incoming
enhanced categories filtering.

task-2071602

closes odoo/odoo#37297

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

The following loop crashes on the second iteration:

    for record in records:
	record.display_name     # access non-stored computed field
        record.unlink()         # delete record

The cache has been invalidated by `unlink` on the first iteration, so
the field is computed.  The computation is done on the whole recordset,
which fails with a `MissingError` because of the first record.  The fix
is to retry the recomputation on the single record in this case.

closes odoo/odoo#50910

X-original-commit: 7f33ebf5
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

... instead of pulse.

task 2239617

closes odoo/odoo#49870

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

... when there is no data and user clicks anywhere in the no content
helper.

Task 2239617

Co-authored-by: Jinal Patel <jip@odoo.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>

Purpose
=======

Even if the routes are correctly updated and the existing data is
correctly updated, the emails that were already sent to the customers
will be problematic, as we will provide a value which is not handled
anymore (10 for example).

To provide a retrocompatibility, deprecated the old route and
introduce a new one.

closes odoo/odoo#46296

Taskid: 2083096
Related: odoo/upgrade#889
Related: odoo/enterprise#10312
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

- Rename the 'Use Rating on Project' feature into 'Customer Ratings'
- Rename the 'Set Email Template to Stages' link to 'Set a Rating Email Template on Stages'
- Add an optional list view for the Stages menu
- display warning if the rating_template_id field is set and if one of the selected project_ids doesn't have the rating_status field set to true
- Project form view revamp
- rename the '% on tasks' stat button into 'Customer Satisfaction'
- Remove the 'no option' for the rating frequency field because it is required
- project form : Add a 'Go to Website' stat button
- Project dashboard: remove the 'Customer Ratings' menu item in more
- Ratings page: the 'Last 30 days' filter include ratings from today
- remove the Appointment / Helpdesk Customer Satisfaction / Live Support menu items

TASK ID : 1251

Issue

	- Install sale_renting
	- Create a rental order
	- Add a "rental" product
	- In Modal, change start or end time

	In Firefox, user not allowed to change the time;
	time select not reacting well.

Cause

	The issue seems to be that in bootstrap when
	we click outside a modal, we focus on the modal:

	https://github.com/odoo/odoo/blob/27f67bfcb903/addons/web/static/lib/bootstrap/js/modal.js#L332-L337



	and the FieldDateRange widget contains a <select/> tag
	and is added outside of the modal, so when we click
	on the select, bootstrap will focus on the modal which
	in firefox seems to lose the focus on the <select/>
	which get closed.

Solution

	not propagating focusin event when the select of the
	daterange widget is focused => in my opinion this is
	the less risky solution, this could be done with a
	code such as (in the FieldDateRange._renderEdit method):

opw-2240220

closes odoo/odoo#50906

X-original-commit: 5a1e9e32
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Previously, when converting a number to a string we only kept 3
decimals, it turns out that when converting back and forth between rem
and pixels, we were losing enough precision that we had inexact pixel
values shown to the end user for odd number of pixels, even with the
default rem value of 16px.

This commit increases the precision to 5 to work around this issue and
allow us to convert exactly between rem and pixels at the default
16px/rem.

task-2248360

closes odoo/odoo#50881

X-original-commit: fdce273f4fe72a9e2555acecad3c2989110dac1a
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Activate a language which has comma as decimal separator
Go into POS settings, activate 'Global Discount'.
Open POS session, add some product and use global discount.
Input some number with decimals and confirm.
Discount will be not applied

This occur because of javascript type coercion:
 Math.min(100, "11.0") -> 11
 Math.min(100, "11,0") -> NaN

So in locales with thousands separator the statement would produce
different results. Forcing float parsing fix the issue

opw-2243482

closes odoo/odoo#50900

X-original-commit: 84a6c2a5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

In the sign application, it appeared that when using the default signature
in a signature SignItem that was higher the stroke at the bottom was doubbled.

This was caused by the fact that the bottom stroke is always added to the
template and that the default signature image had it already.

In order to solve this, we have added a setting 'show-stroke' that allows
controlling the stroke presence in the signature.

Task Id 2216067
Closes #48529

Related odoo/enterprise#9538

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

* The info mode was misplaced when running into iframe.

* Added static position to the tip when anchor position is fixed

Task Id 2216067
Closes #48529

closes odoo/odoo#50854

Related: odoo/upgrade#1163
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#48430

Related: odoo/upgrade#997
Related: odoo/enterprise#9500
Signed-off-by: Josse Colpaert <jco@openerp.com>

    Reverse charge is a mechanism under which the recipient of the goods or services is liable to pay the tax instead of the provider of the goods and services.

    GST Treatment:
       * Is show that how This purchase is treated in GST
       * Set default value in customer
       * This is help in GST retrun filing.
       * Value of treamtmnet as below
            - Registered Business - Regular
            - Registered Business - Composition
            - Unregistered Business
            - Consumer
            - Overseas
            - Special Economic Zone
            - Deemed Export
       * GSTIN is required in
            - Registered Business - Regular
            - Registered Business - Composition
            - Special Economic Zone
            - Deemed Export

    GST Treatment:
       * Is show that how This sale order is treated in GST
       * Set default value in customer
       * This is help in GST retrun filing.
       * Value of treamtmnet as below
            - Registered Business - Regular
            - Registered Business - Composition
            - Unregistered Business
            - Consumer
            - Overseas
            - Special Economic Zone
            - Deemed Export
       * GSTIN is required in
            - Registered Business - Regular
            - Registered Business - Composition
            - Special Economic Zone
            - Deemed Export

    Shipping GSTIN:
       * GST identification number or GST number
       * There can be multiple GSTIN for a single person, being an assessee under the Income Tax Act for every State or Union Territory in which such person operates from
       * So When specific invoice and delivery addresses is enabled then user can enter able to enter "Shipping GSTIN" on shipping address of partner
       * Add Validate of this number using regular expression

GST Treatment:
   * Is show that how This invoice or partner is treated in GST
   * Set default value in customer
   * This is help in GST retrun filing.
   * Value of treamtmnet as below
	- Registered Business - Regular
	- Registered Business - Composition
	- Unregistered Business
	- Consumer
	- Overseas
	- Special Economic Zone
	- Deemed Export
   * GSTIN is required in
	- Registered Business - Regular
	- Registered Business - Composition
	- Special Economic Zone
	- Deemed Export

GSTIN:
   * GST identification number or GST number
   * There can be multiple GSTIN for a single person, being an assessee under the Income Tax Act for every State or Union Territory in which such person operates from
   * Add Validate of this number using regular expression

remove field l10n_in_export_type and l10n_in_import_export becouse it's covered by GST Treatment
remove field l10n_in_partner_vat becouse not use anyware.

closes odoo/odoo#46749

Taskid: 2205057
Related: odoo/enterprise#9119
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

- Enable Include in Analytic Cost in purchase tax P
- Create an expense
- Select product, purchase tax P, set analytic account and tags
- Create report, submit to manager, approve, post journal entries

The tax `account.move.line` does not have the analytic account and tags
assigned.

The information is missing at the tax line creation, so apply the same
logic than:

https://github.com/odoo/odoo/blob/784d22bd005db7825375a97caf9661bd5d463efe/addons/account/models/account_invoice.py#L1055-L1057



opw-2250257

closes odoo/odoo#50879

X-original-commit: ec6fe8cd
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

Lable for the field `barcode` is `Badge ID`.

With this commit, We display the correct field name in the Warning.

closes odoo/odoo#50700

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Closes #37036
Forward-port of #50831

closes odoo/odoo#50872

X-original-commit: 27f67bfc
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Before this fix, in case you try to compute the pricelist_id with another
context, the computed value is set to the website with the new context,
and so another cache.

Now with compute for the env from self, and assign the computed value with the
website with ot without another context.

Before this commit, you was unable to add fields pricelist_id or currency_id in
a tree view.

opw-2233122

closes odoo/odoo#50705

X-original-commit: 2f83c5ba
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

* A step has been added to the sale tour in order to ask the user
  to update the company data. As a page reload breaks the tour test
  we need to prevent it in such situation.

TaskID :2187222

closes odoo/odoo#46167

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

* The first tour is starting in the sale app dashboard and ensures
  the user goes through the needed configuration steps

* The second tour starts in the new Quote form and shows the flow to
  send a quote to a customer

TaskID: 2187222
Closes: #46167

The ampersand (&) needs to be html encoded to be evaluated correctly

Cherry-picked from odoo/odoo#46526
Courtesy of Olaf
Closes odoo/odoo#46526

closes odoo/odoo#50852

X-original-commit: 28b977d4
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Restore the explicit call to action_invoice_paid introduced by:
https://github.com/odoo/odoo/commit/f028a5f410daf6974110f7c341b330f63fdd8885#diff-dd671a54296b170ea1393dca1a5f7798R3779

... probably lost in a bad rebase at:
https://github.com/odoo/odoo/commit/caeb782841fc5a7ad71a196e2c9ee67644ef9074#diff-dd671a54296b170ea1393dca1a5f7798L3955



closes odoo/odoo#50843

Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

Steps to reproduce:
 - Start the IoT Box with a monitor plugged in
 - Unplug the monitor
 - Restart the Odoo service (i.e. connect the IoT Box to a DB)
 - No devices are detected

The problem came from the fact that `tvservice -l` and `tvservice -n`
have different behaviors when a monitor is disconnected:
 - `tvservice -l` still says that a device is attached
 - `tvservice -n` cannot detect the name of the device so it logs an
error to stderr but still has a return value of 0 so we read an empty
string from stdout.

The `get_connected_displays` function raised an exception because the
format of the returned string was not the one we excepted. The other
loops were then not started and no devices at all were detected.

closes odoo/odoo#50839

X-original-commit: ab6ec2ab
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>

Access rights were added on transient models at odoo/odoo#43306
The _filter_access_rules method was still using the old logic of
transient, bypassing access rules

closes odoo/odoo#50828

X-original-commit: 7e0d6f7e0d725a2addb2821c16fce77aed54ca03
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Having _lt in the env doesn't make much sense, as it is useless
at run time, and it would incite people to require 'web.env' to
use it (at load time). The env should never be directly imported,
it is automatically propagated from parents to children.

To sum up, in Owl components:
 - when terms have to be translated at run time (e.g. in a function
   called when the user clicks on a button), the env is available
   and env._t must be used
 - when terms have to be translated at load time (e.g. a JS module
   defining a component with a translatable static property), one
   must require 'web.translation' and use function _lt it exports.

closes odoo/odoo#50656

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

Issue

	- Install Recruitment
	- Go on any application
	- Add an attachment
	- Go back, refresh
	- Returns on the application

	The attachment box is open but
	the attachments are not loaded.

	You must toggle it again to load them.

Cause

	When opening the box, this.attachments is empty
	so no attachments are shown.

Solution

	Load the attachments if the option is present.
	It will not cause supplementary RPCs thanks
	to "_areAttachmentsLoaded"

OPW-2246116

closes odoo/odoo#50825

X-original-commit: 40cea063
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>

Followup of 86c80d341846894c435b1c8f61ef946b06e72ec7 : currently portal users face an access issue
if they change attachments in their review. This commit fixes that by sudo-ing
access to the attachment as other access is already granted.

Task ID 2214795

closes odoo/odoo#50815

X-original-commit: 90152abef30e043d36f8a8aabfe18c46e807973f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Followup of 86c80d341846894c435b1c8f61ef946b06e72ec7 : currently portal users face an access issue
if they try to read their full review with attachments. This commit fixes that
by sudo-ing access to the attachment as other access is already granted.

Task ID 2214795

X-original-commit: ad7cd4bd38fdb0d92b22bb979637bb5623621378

As of 02e01dce the website menu is prefetched for the user and saved
in cache.

If the sequence of a menu is changed (eg. with the "Edit Menu" modal on
website), the cache was not cleared so it seemed like this did not work.

With this changeset, changing a menu sequence will clear ormcache.

opw-2244908
closes #50683

closes odoo/odoo#50703

X-original-commit: 8da3276e
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

The method `_get_work_interval` has several problems:

1) The name is not self explanatory in any way

2) It should be defined on the `resource.mixin`

3) It simply does not work (as described in its docstring).
   Here is a simplified example (only concerned about hours):
   Currently, given two attendances: 8-12 and 13-17,
   with parameters start=9 and end=18 it returns (9, 17)
   while it should return (8, 17).

   This leads to strange behaviors in the planning app:
   Given employee A with calendar 8-17 and employee B 8-16.
   Create a planning slot and assign employee A: the start and end times
   are set to 8-17.
   Then assign employee B, the start and end times are correcly set to 8-16.
   Now reassign employee A: the start and end times are not set to 8-17.

Task 2229296

closes odoo/odoo#50804

X-original-commit: 7dfab89bc0025cf6424f00b6992fef1f42463ffe
Related: odoo/enterprise#10426
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>