Skip to content
Snippets Groups Projects
Select Git revision
20 results
Search by author
  • Any Author
0 authors
  1. Feb 23, 2021
  3. Feb 22, 2021
  5. Feb 18, 2021
    • nie's avatar
      [FIX] event_crm: prevent access rights issues on leads · 29be9761
      nie authored 
      
Steps:
- Login as an admin user
- On a fresh branch install event_crm
- Give a "test" user access rights of "Own Document only" in the "Sales"
  app, nothing in "Events"
- Assign any lead to "test" user
- Login as "test" user and try to access your own leads

Bug:
Error: While parsing modifiers for button: for modifier "invisible":
Unknown field registration_count in domain

Explanation:
The button `event_registration_action_from_lead` tries to access event
registrations even if the user doesn't have access to events.

opw:2462127

closes odoo/odoo#66425

Signed-off-by: default avatarbackspac <backspac@users.noreply.github.com>
      29be9761
  7. Feb 17, 2021
    • Aaron Bohy's avatar
      [FIX] web: correctly close confirm dialog · 98f9cb4f
      Aaron Bohy authored 
      
Let's assume the following scenario:
 - have an action in target new (e.g. a form view)
 - in the dialog, have an action/object button with confirm
   attribute
 - when clicking on that button, a confirm dialog opens
 - if validated, the following action returned by the server
   is again an action in target new

Before this commit, the confirm dialog remained in the DOM.

This issue occurred because it's parent wasn't correctly set (wrong
use of `this`), so when the first dialog was destroyed, the confirm
dialog wasn't automatically destroyed in turn.

OPW~2440712

closes odoo/odoo#66345

X-original-commit: 2016fe31af970976775c9df160a31abfbec742ba
Signed-off-by: default avatarJorge Pinna Puissant (jpp) <jpp@odoo.com>
      98f9cb4f
    • Mohammed Shekha's avatar
      [FIX] web: fix issue of notebook page with invisiblity modifier · e695cb7c
      Mohammed Shekha authored 
      
before this commit: when there is only one page in the notebook tag and
there is a boolean field in form to show/hide that notebook page based on
invisibility attrs, if we toggle boolean field notebook hides, that's OK
but when we toggle boolean field again then notebook page is displayed but
it is not active and due to that content of notebook page is not displayed.

after this commit: when there is only one page in notebook and it has attrs
for invisibilty, when we toggle boolean field to hide/show notebook page
then notebook page as well as content is toggled.

task-2449053

closes odoo/odoo#66338

X-original-commit: a0b5ecd3
Signed-off-by: default avatarAaron Bohy (aab) <aab@odoo.com>
      e695cb7c
  9. Feb 21, 2021
  11. Feb 19, 2021
  13. Feb 18, 2021
  15. Feb 17, 2021
  17. Feb 18, 2021
    • Christophe Monniez's avatar
      [IMP] tests: add data_dir support in test_module_operations · 781c9178
      Christophe Monniez authored 
      
In some situations, like during tests on runbot, the data-dir location
may vary.

With this commit, the `data-dir` CLI argument is added to the
test_module_operations script.

closes odoo/odoo#66422

Signed-off-by: default avatarAdrian Torres (adt) <adt@odoo.com>
      781c9178
    • Nasreddin (bon)'s avatar
      [FIX] website_sale, *: display error message in "Extra Info" step · eb937352
      Nasreddin (bon) authored 
      
*: google_recaptcha, website_form

Issue

        - Install 'Ecommerce' module
        - In settings, fill the "reCAPTCHA: Easy on Humans, Hard
          on Bots" option with random wrong site key and secret key
        - Open your ecommerce (go to /shop )
        - Add any product to cart and and open cart
        - Activate "Customize -> Extra Step Option"
        - Process to "Extra Info" step
        - Click on next

        Stuck at this step since next button does not react.

Cause

        There is an error due to re-captcha feature that
        does not allowed to go to next step.

        The second issue is that the error is not displayed
        because missing message area in form.

Solution

        Do not check recaptcha if 's_website_form_no_recaptcha' class
        present in form.
        Add span 's_website_form_result' to display error messages.
        Replace 'public' by 'site' in error message to fit google
        'field' name.

opw-2456098

closes odoo/odoo#66382

Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      eb937352
    • Goffin Simon's avatar
      [FIX] project: Creating project via service product deletes contact's data · f3631036
      Goffin Simon authored 
      
Steps to reproduce the bug:

- Let's consider a customer C1 with email address A1 and phone P1
- Let's consider a project PR with C1 as customer
- Let's consider a service product P with:
   - Milestones (manually set quantities on order) as Service Invoicing Policy
   - Create a new project but no task as service tracking
   - PR as project template
- Create a sale order SO with C2 as customer with A2 as email address and P2 as phone
- Confirm the SO

 Bug:

 The email address and phone of C2 were changed into A1 and P1 instead of keeping A2 and P2

 opw:2439459

closes odoo/odoo#66307

Signed-off-by: default avatarSimon Goffin (sig) <sig@openerp.com>
      f3631036
  19. Feb 15, 2021
    • Anh Thao Pham (pta)'s avatar
      [FIX] sale_timesheet: fix (re-)invoiced amount computed as other revenue · 4d9305d1
      Anh Thao Pham (pta) authored 
      
- Install sale_timesheet and hr_expense
- Create a Service Product with "Create a task in sales order's project" as Service Tracking (i.e. Service X)
- Create a Product with "Can be Expensed" and "At cost" as "Re-Invoice Expenses" (i.e. Expense X)
- Create a SO with Service X (i.e. Unit Price: 50.0) and confirm it
- Go to Expenses and create an Expense:
  * Product: Expense Y
  * Unit Price: 25.0
  * Customer to Reinvoice: [select the created SO]
- Create Report, Approve and Post journal entries
- From SO, create an Invoice (Service Y + Expense Y) and confirm it
In Project Overview, the expense is computed in Other Revenues and
Re-invoiced costs. Therefore, the amount of the expense is added twice
in the Profitability total.
In Project > Reporting > Project Costs and Revenues, for Project linked
to SO, Untaxed Amount Invoiced and Untaxed Amount Re-Invoiced are also
computed in Other Revenues.

opw-2444237

closes odoo/odoo#66186

Signed-off-by: default avatarAnh Thao PHAM <kitan191@users.noreply.github.com>
      4d9305d1
  21. Feb 18, 2021
    • Laurent Smet's avatar
      [FIX] account: Set memo to ref if not payment_reference · 7a7dc212
      Laurent Smet authored 
      
Issue

	- Install "Accounting" module
	- Create a new bill :
	- Set vendor
	- Set no payment reference
	- Set a bill reference
	- Add products to bill
	- Confirm and click on Register Payment

	Memo field has no value.

Cause

	The memo field is based on lines name.
	Lines name is computed in `_onchange_payment_reference`
	and depends only on payment_referecence.

Solution

	If no `payment_reference`, fallback on `ref` to set line name.

opw-2440389

closes odoo/odoo#66158

Co-author: nboulif <bon@odoo.com>
X-original-commit: 10274903
Signed-off-by: default avataroco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: default avatarLaurent Smet <smetl@users.noreply.github.com>
      7a7dc212
    • Romeo Fragomeli's avatar
      [FIX] web: client report action mounted called twice · d3854dbf
      Romeo Fragomeli authored 
      
Before this commit, the 'mounted' method of the ControlPanel in
the client report action  was called twice.

It happened because the client report action updated the ControlPanel
before being actually mounted, so mounted was called once when the
traceability report was mounted, and once when the update was applied.

Ideally, this should not be an issue (this isn't an issue with owl).
However, in Odoo, we mix layers of Owl Components and legacy
widgets. In these situations, the above scenario isn't properly
handled (and can't be).

As a consequence, in mobile (enterprise), it crashed because an
handler bound in mounted (thus twice) was only unbound once.

This commit avoids the issue as the update was actually useless.

Steps to reproduces (Mobile):
* Go to Inventory (Stock)
* Open the "burger menu"
* Select "Products" -> "Products"
* Select one product in the list
* Click on the "Forecasted" ("stat button")
* Select one "SO line" (sale order) to go to the form view
* Go back to the previous view using breadcrumb
* Optional: Go to another app if the screen can't scroll (e.g. go to Sales)
* Scroll the view => Bug

closes odoo/odoo#65522

Related: odoo/enterprise#16033
Signed-off-by: default avatarAdrien Dieudonné (adr) <adr@odoo.com>
      d3854dbf
    • Romeo Fragomeli's avatar
      [FIX] stock: traceability report mounted called twice · bbcd8ce0
      Romeo Fragomeli authored 
      Before this commit, the 'mounted' method of the ControlPanel in
the traceability report was called twice.

It happened because the traceability report updated the ControlPanel
before being actually mounted, so mounted was called once when the
traceability report was mounted, and once when the update was applied.

Ideally, this should not be an issue (this isn't an issue with owl).
However, in Odoo, we mix layers of Owl Components and legacy
widgets. In these situations, the above scenario isn't properly
handled (and can't be).

As a consequence, in mobile (enterprise), it crashed because an
handler bound in mounted (thus twice) was only unbound once.

This commit avoids the issue as the update was actually useless.

Steps to reproduces (Mobile):
* Go to Manufacturing (MRP)
* Open the "burger menu"
* Select "Products" -> "Lots/Serial Numbers"
* Select one product in the list (unfold group first)
* Click on the "Traceability" ("stat button")
* Select one line to go to the form view
* Go back to the previous view using breadcrumb
* Optional: Go to another app if the screen can't scroll (e.g. go to Sales)
* Scroll the view => Bug
      bbcd8ce0
  23. Feb 15, 2021
    • Nasreddin (bon)'s avatar
      [FIX] account_facturx: Parse pdf attachment · 0f6ad2a6
      Nasreddin (bon) authored 
      
Solution is different in the case of the foward-port, see bellow.

Issue

	- Init an instances of Odoo v13.0 'A' and v14.0 'B'.
	- Install "Accounting" app on instance A & B.
	- Set your email server on instance A & B.
	- Activate 'External email server' in settings of instance A.
	- Set an email alias for "Vendor Bills" on instance A.
	- Send a "Customer Invoice" from instance B to alias of instance A.
	- Fetch for new mail (in case new vendor bill don't appear) on instance A.
	- Open the new Vendor bill on instance A.

	Data are not parsed from pdf attachment.

Cause

	No managing all attachements types:
	- list(tuple(str,str), tuple(str,str, dict) or int) attachments : list of attachment tuples in the form
          ``(name,content)`` or ``(name,content, info)``, where content is NOT base64 encoded
	- list id attachment_ids: list of existing attachement to link to this message
          - Should only be setted by chatter
          - Attachement object attached to mail.compose.message(0) will be attached
            to the related document.

Solution

	In this fw-port, we override `_message_post_after_hook` instead of
	`_message_post_process_attachments` because the later is also called
	from portal and with sudo rights. We don't want to update invoices with
	files coming from portal, since it could cause a security issue.
	Also, because of the way attachments are parsed for invoice, this could
	cause the OCR not to work any longer because at the time
	`_message_post_process_attachments` is called,`move.message_main_attachment_id`
	is not set yet, and OCR relies on it.
	The solution is rather to override `_message_post_after_hook` because
	it ensures that all the attachments have been properly treated and are
	present in `new_message.attachment_ids`, and `message_main_attachment_id`
	is properly set.

opw-2411002

closes odoo/odoo#64286

X-original-commit: 9076b1ba
Signed-off-by: default avatarbon-odoo <nboulif@users.noreply.github.com>
Signed-off-by: default avatarLaurent Smet <smetl@users.noreply.github.com>
      0f6ad2a6