Steps to reproduce:
-> Install Stock+Accounting+Purchase
-> Enable landed costs on setting
-> Anglo-Saxon accounting Active
-> Create a service-type product with active landed cost.
-> Product category: ( Standard/FIFO/Average - Automated )
-> Confirm a PO with that product
-> Create a vendor bill

Bug:
default accout for the landed cost is (600000 Expenses)

Fix:
apply the correct account (set on product category) when creating
the invoice lines

opw-3129528

closes odoo/odoo#114449

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

## To reproduce:
=> Import 5 units of P1 at $5
=> Import 2 units of P1 at $2
----> Current valuation: Qty 7, Value $37, Std Price $5.29 (rounded)
=> Change standard Price to 7
----> Current valuation: Qty 7, Value $48.97, Std Price $7

## Solution:
To compute the value delta, we don't use the current standard_price (which may be rounded), but the current value_svl.

OPW-3233260

closes odoo/odoo#115311

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Signing CLA to be able to merge other pull requests.

closes odoo/odoo#115301

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

In large database, to compute picking_count on orders and sessions, can take lot of time.

closes odoo/odoo#114553

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

"Non-stored fields like product.template.location_id/warehouse_id cannot
be searched" log error is generated because the non-storable fields are
not searchable, so it shows a log error for those fields.

This commit added the blank filter_domain in the above fields to avoid
the log error in search.

This fix is for the "product.product" search view for the "product.template"
search view has already been fixed in https://github.com/odoo/odoo/commit/a5835a160ea3f7aea37644ed4e1a49e2e4a6effd



sentry-3933983991

closes odoo/odoo#115018

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Problem:
 When point_of_sale and pos_mercury are both installed,
  _gc_old_tokens will get called by the scheduled action "Base: Auto vacuum internal data"
   and it will try to remove the Vantiv tokens from POS orders that are 6+ months old.
    However, there are fields named ref_no and record_no that exists for pos.order;
     so the AttributeError will get thrown.

Solution:
 It is safe to remove the entire method since the Mercury API documentation
  does not explicitly mandate the tokens be removed from old POS orders.
   It was recommended by JOV to not modify the method to prevent the modification of
    potentially 8 years old POS orders from client's databases.
     Since the method is removed, the error will not be thrown when auto vacuum is called,
      pos_mercury is installed, and POS orders are 6+ months older.

opw-3082616

closes odoo/odoo#114620

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Bug: Users are able to modify their eCommerce cart, while a payment for
said cart is being processed. This means that the users can be charged
an amount that is different from the total listed on the associated
sales order. This also prevents the cart from being confirmed.

Steps to reproduce:
1. Install `website_sale` and `payment_test`.
2. Go to the /shop page, add a product to the cart and process checkout
3. On the payment page, select the `test` payment method and use the
   card number `4111 1111 1111 1111` with the expiry date 06/28 and the
   secret code `900`.
4. Open a product's page in another tab
5. Go back to the payment tab, click 'Pay Now' and quickly switch to the
   second tab and add the product to the cart
6. Check the cart's chatter: the confirmation failed because the cart's
   and transaction's amounts mismatch.

Fix: Force creating a new cart if the current one has started the
payment process

This commit is a backport of b261b85da0e8385a63efa4eeee883f92e3dcf58d

opw-3122102

closes odoo/odoo#114660

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Co-authored-by: Antoine Vandevenne (anv) <anv@odoo.com>

When closing a POS session, a journal entry is generated for it. By
default, first we try to create that entry as the logged in user, and if
that fails we try again with sudo.

Suppose you only have the Point of Sale and Accounting apps installed,
and the user has the Auditor role in Accounting. In that case they won't
be able to create account moves. If the user closes a POS session, the
creation of the account move in `_create_account_move` will fail with an
AccessError and the creation will be retried with `sudo` by
`_validate_session`. This works fine.

Now suppose that you have the Purchasing app installed as well. By
default that will give the User role in Purchasing. That role introduces
a restriction on which account move types the user can write to. The
permissions do not include 'entry', which is the move type of the POS
journal entry. If the user again tries to close a POS session, the
creation of the move is able to proceed further, because the role from
Purchasing granted additional rights. The SQL statement inserting the
account move data gets executed inside the transaction. When it
validates the Python constraints afterwards, another AccessError is
raised, because of the rule on `move_type` failing due to the move being
an 'entry'.

If at this point the operation is simply tried again with sudo, the
original database changes inside the transaction will still there, and
will be committed together with the journal entry created with sudo.
This results in an empty draft entry showing up in addition to the POS
journal entry.

To prevent this from happening, the initial attempt is wrapped in a
savepoint so that the transaction gets rolled back fully if the creation
of the account move fails, no matter at which point.

opw-3160140

closes odoo/odoo#114443

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Before this commit, you could search `account.tax.repartition.line`
and get records from all the existing companies,
which is not supposed to happen.

It should only return records of the `active_company_ids`.

That was because there were no `ir.rule` preventing that.
This fixes the issue.

closes odoo/odoo#114718

Related: odoo/enterprise#37931
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Current behavior:
When a fiscal position was applied in the PoS, it was considered as a
discount and was shown in the receipt and on the product screen.

Steps to reproduce:
- Create a product with a price of 10€ with 15% tax included in the
  price
- Create a fiscal position that map the 15% tax to 0% tax
- Open a PoS session
- Add the product to the order
- Apply the fiscal position
- The price of the product is now 8.70€ but the order show it as a
  discount of 1.30€ (e.g 10€ -> 8.70€).

opw-3154499

closes odoo/odoo#113760

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

Steps to reproduce:

  - Install 'Sales' module (for test purpose)
  - Configure the outgoing mail server
  - Change Demo user email to an Outlook account
  - Create or Open a quotation
  - In the chatter, send a log note with `@Marc Demo`
  - Check the email received in the windows Outlook mail client

Issue:

  The button is not well displayed (the padding between the text and
  the border is not filled with the background color).

Solution:

  Use a `table` around the button(s) and move some CSS to the `td`
  around the button to display it correctly.

  [More info here](https://medium.com/email-design/outlook-rendering-issues-5-tips-to-ensure-your-emails-display-properly-9520b2456166

)

opw-3142132

closes odoo/odoo#115012

Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

The `/web/binary/company_logo` controller returns an image with a
maximum of 180px wide, while the point of sale data loader tries to
resize such image to 300px wide. The result is an image with blurry
edges.

A better option is to use the standard `/web/image` controller that
recovers the original image from the proper attachment. This is a tiny
overhead since it's done just once when session is loaded.

closes odoo/odoo#98249

Signed-off-by: Trinh Jacky (trj) <trj@odoo.com>

*: web_editor, website_sale

Since [1] when the Dynamic Snippet was first introduced, it also
introduced a concept of "inherited" snippets. Specific snippets would
all `t-call` the same template for their rendering.
A mechanism was introduced to deduce the `data-snippet` from the caller
template, but it stored the obtained value in the `t-called` template
itself. Because of this if several "specific snippets" that used that
template had to be rendered, they would all have the `data-snippet`
value of the first one that got compiled.

We could compile the snippet template into something having a
dynamically obtained `data-snippet` value, but then that would be
equivalent to just using a `t-attf-data-snippet`.
All specific snippets already do set a `snippet_name` in the context
because it needs to be added in the classes.

This commit therefore adds a `t-att-data-snippet` attribute on the
base template, and populates with that same value in `onBuilt` for
stable versions.

During forward ports across stable versions, each new caller must be
patched as well - and all patches must be removed in master.

[1]: https://github.com/odoo/odoo/pull/53175



task-2922635

closes odoo/odoo#98924

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Chrome 111 enabled checking of websocket origin: if the WS connection
sends an Origin head which is not whitelisted with the new
`--remote-allow-origins` switch it is rejected.

Turns out websocket-client (amongst others) *does* send an `Origin`,
which trips the check, and means tours immediately break when trying
to run them as Odoo's test harness is unable to connect to (and
control) the devtools.

Suppress sending `Origin` to fix the issue.

Note: this also prevents using the remote developer tools by opening
the devtools URL, user needs to go through chrome://inspect from the
client and find / select the headless browser from there.

Chrome 111 changeset: https://chromiumdash.appspot.com/commit/0154caeefc74530d5cb57ce71608beb1b77bca39

Chrome tracker issue: https://crbug.com/1422444



closes odoo/odoo#115021

X-original-commit: d12d292c
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

During revision 415525ce
the code comparing the connections without password has been
dropped, for an unknown reason.

Because of the above, and the fact psycopg2 alter the password
with 'xxx' for security reasons, the connections recycling was
no longer working as expected, and was recycling less connections.

closes odoo/odoo#37005

Signed-off-by: Rémy Voet <ryv@odoo.com>

This commit removes all links to the `Awesome Timesheet` app since
this app has been recently removed.

closes odoo/odoo#114890

Related: odoo/enterprise#38004
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

This commit fixes an issue that causes thin spacing to appear between
two snippets containing shapes. This bug had already been fixed in this
commit [1] but the theme snippets have not been adapted to the changes.

With this commit, the shapes of theme snippets are automatically adapted
when they are dropped on the page.

Steps to reproduce the bug:

- Choose the "Clean Theme" for a website.
- Drag and drop a "Call to action" snippet on the page.
- Drag and drop a "Text" snippet with a dark background before it.
- Resize the window to change the window width.
- At some points, the gap will appear.

[1]: https://github.com/odoo/odoo/commit/42b3ad10e0b32b7fc72f801e2c67d6baf938c566



task-2824607
opw-3069213
opw-3057533

closes odoo/odoo#108847

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Some users were updating their access rights to allow for direct
deletion of quants. This could lead to the infamous:

"It is not possible to unreserve more products of %s than you have in stock."

error since directly deleting a quant bypasses the flows of correctly
unreserving the amounts you are deleting. Therefore we now restrict
the unlinking to:
- when in sudo mode, since the automatic unlinking of zero quants always
  occurs in sudo mode.
- stock manager when unlink access right = True. Normally we would allow
  any user with the unlink access to do it, but since we are using the
  existing `inventory_quantity` to ensure that reserved qtys of the
  quant are correctly unreserved before the unlinking, only stock
  managers will correctly do this unreservation.

It is expected that some custom code may break due to this restriction,
but if custom code is directly unlinking quants without a sudo or with a
non-stock manager, then the code in these cases probably need to be
fixed anyways since this will cause inconsistent db data and lead to
the error above.

closes odoo/odoo#113349

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

Incorrect error (ValueError) was being thrown instead of the proper
ValidationError.

Fixes: odoo/odoo#92799
Part-of: odoo/odoo#113349

Due to the domain dependancy of `product_uom_id` on
`product_uom_category_id`, a JS error was occurring since the field
wasn't available in the view.

Steps to reproduce:
- create a scrap
- select scrap in list view
- try to edit the UoM

Client Error occurs instead of allowing user to edit the UoM.

Fixes: odoo/odoo#92800
Part-of: odoo/odoo#113349

This commit fixes a bug where in some cases a shape disappears after
applying a flip to it. This bug has been present since commit [1].

Steps to reproduce the bug:

- Choose the "Clean Theme" for a website.
- Drag and drop a "Call to action" snippet on the page.
- Click on one of the two buttons to flip the shape of this snippet.
- Bug => The shape disappears.

This was due to shape colors set by theme variables in some theme
snippets (e.g. 'o-color-1'). When the background image url was recreated
to apply the "flip", the color was not converted to hexadecimal.

[1]: 42b3ad10

task-2824607
opw-3069213
opw-3057533

closes odoo/odoo#114684

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Some Luxembourg public institution do not have a VAT number but have
been assigned an arbitrary number (see:
https://pch.gouvernement.lu/fr/peppol.html

).

This requires a new field: `l10n_lu_peppol_identifier`. For Luxembourg,
the flow is then as follows: when exporting an electronic invoice, if
the field exists and is set, we read it. Otherwise, we read the VAT.

opw-3186147

closes odoo/odoo#114822

Signed-off-by: Laurent Smet <las@odoo.com>

When trying to invoice undelivered quantities the error message
was somewhat misleading: it indicates as a possible solution a
Stock app feature even when Stock is not installed.

After this commit the message will be more appropriated.

opw - 3206001

closes odoo/odoo#114754

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Steps to reproduce:
- Create 2 accounts:
  1)
  * Code: 1000
  * Account Name: Test
  2)
  * Code 1000A
  * Account Name: TestA
- Create a journal item for each account
- Go to Accounting / Accounting / Journal Items (list view)
- Add custom filter: ("Account", "is equal to", "1000 Test")
Journal items from both the created accounts are retrieved.
As a strict equal is requested, it shouldn't find the journal item
linked to account "1000A TestA".

Cause:
When searching on an account, the first part of the search is used
to find a code that begins with that part (ilike operation), regardless
of the actual operator (i.e. "=" in this case).
It has been done that way because we suppose that most of the times
customer is starting his search with the beginning of the code of the
account he is searching, which is not incorrect.
But the case of the "=" operator has not been handled.

opw-3179681

closes odoo/odoo#113860

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Steps to reproduce:

- Install mass_mailing
- Create mailing, use a template that contains links (e.g. the 3rd one)
- Double click on a regular link (e.g. More Info)
- Link dialog pops up, Save

Issue:

The link in the template loses the `btn` and `btn-link` js classes.

This happens because of the `isButton` variable introduced in fc83af4b,
which is used to define the link classes, through the `colorsData` dict.
By default, a link is not a button, so the variable will always be false
for links. The previous version did not add any classes to links.

Solution:

Add the `btn` and `btn-link` classes to all links in templates.

opw-3133902

closes odoo/odoo#111350

Signed-off-by: Stefan-Calin Crainiciuc (stcc) <stcc@odoo.com>

on clicking the graph view of the Partnership Analysis, currently the tree
view and form view is opened. actually the tree and form view for this model
are not defined in the code and thus the end user get the tree view with only
ID field in it.

As those view have no sense, prevent from jumping on those.

closes odoo/odoo#106375

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Steps:

install calendar app.
enable sms template of calendar.
go to calendar event form view.
try to send SMS.
Issue:

traceback clicking `Send SMS' of Send SMS wizard.
Cause:

trying to write on field even though field does not
exist in model.
Fix:

check field exist in model before write on it.
task-3084701

closes odoo/odoo#107472

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

closes odoo/odoo#112177

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Part-of: odoo/odoo#112177

Before this commit all mrp.production are load in cache to compute the field is_planned.
It can take lot of time, and a memory error can appear.

closes odoo/odoo#113247

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

- Create an Order, send to customer
- Create an invoice from this sale
--> Issue the customer can show the invoice in draft mode
This prevent customer to print a draft invoice with wrong value.

Only show send invoice.

closes odoo/odoo#113211

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

When importing a vendor bill/invoice, a matching partner is searched. If
no match is found, a new partner will created.

task-3141337

closes odoo/odoo#112412

Signed-off-by: Laurent Smet <las@odoo.com>

Sometimes the invoice import fails, because `payment_terms_node.text`
can be None and we're trying to concatenate it with a string. This
commit makes sure that `payment_terms_node.text` is there first.

task-3132980

Part-of: odoo/odoo#112412

Before this commit, in large database, openning a sale.order can take 3s.
Because in module sale_purchase_stock, _get_purchase_order use a On2many field : stock_move_ids, with inverse field group_id.

Now it takes 200 ms.

closes odoo/odoo#110128

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

When sending an invoice by email the reports for ISR and QR are
automatically added if it is possible.

But for some systems, those reports are already joined to the base
report linked to the template and adding them is redudant.

This improvement adds the option to skip the addition of those reports
through a context variable.

closes odoo/odoo#79318

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

before this commit, the cancel button is visible in the done state and on clicking showing the validation that it cannot be cancelled.

by the commit: https://github.com/odoo/odoo/commit/8d37cf462badc25d911d3fa6d3382c6f7418904f one of the cancel button in the form is made hidden in the done state, similarly applying for the other cancel button also.

also currently on trying to delete a done repair order, it says to cancel first and then delete the order, from the commit:  https://github.com/odoo/odoo/commit/8d37cf462badc25d911d3fa6d3382c6f7418904f

 cancelling a done record is prevented, thus modifying the warning message and its related pot file

after this commit, the cancel button will not be visible in the done state.

closes odoo/odoo#113076

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Steps to reproduce:
- select a different company from the main one
- under settings/discuss enable External Email Servers
- set up an alias domain
- create an SO and send it by email
(you can catch the sent email using mailhog)
- reply to that email
(you can use the support-tools[1] and set In-Reply-To: "previous message_id")

Bug:
the reply_to field of incoming message defaults to the first company

Fix:
set the reply_to field to the company asociated to the record
(there's already a fallback to self.env.company  in
"_notify_get_reply_to_formatted_email")

opw-3060214
[1]: https://github.com/odoo/support-tools/tree/master/scripts/mail



closes odoo/odoo#108823

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

If an invoice is send to the Tax Agency, we should block the fact
that the user can delete it. In that case, we can have issues when
the tax agency sends back notifications.

Task link: https://www.odoo.com/web#id=3192962&model=project.task


Task-3192962

closes odoo/odoo#113079

Signed-off-by: Josse Colpaert <jco@odoo.com>

Consider a form view with a one2many field, which has no form subview.
Also the form view of the comodel (the one2many field's lines) contains
the inverse many2one field of the one2many field.  When adding a new
line on some existing record, the form view shows the many2one field as
empty, instead of being the main record.

Explanation: the form view of the line invokes onchange() with the main
record's values (dict) as the value of the many2one field.  Inside
onchange(), the field is actually set to a new record corresponding to
the main record.  Alas, when that value is sent back to the form, the
new record is serialized as False.

Solution: let onchange() serialize the new record as its origin record
instead.

closes odoo/odoo#114614

Signed-off-by: Raphael Collet <rco@odoo.com>