Skip to content
Snippets Groups Projects
  1. Sep 27, 2019
  2. Sep 24, 2019
  3. Sep 09, 2019
  4. Sep 27, 2019
    • svs-odoo's avatar
      [TEST] stock: product responsible company_id · 90873323
      svs-odoo authored
      
      Adds a test to be sure `product.template` can be create with a
      responsible when:
        - The product has no `company_id` (the responsible must belong to the
          user's company in this case).
        - The product `company_id` is one of the companies of its responsible.
      
      And to be sure that we can't create a `product.template` if its
      responsible doesn't belong the product's company.
      
      closes odoo/odoo#37362
      
      Signed-off-by: default avatarSimon Lejeune (sle) <sle@openerp.com>
      90873323
    • svs-odoo's avatar
      [FIX] models: check_company on res.users field · a3281058
      svs-odoo authored
      Before this commit, when a record of a model who has a `res.users` field
      it could fail the `check_company` because the check looks for
      `company_id` who is the default company of the user.
      In the case of `res.users`, `check_company` must look after the
      `company_ids` of the user.
      a3281058
  5. Sep 26, 2019
  6. Sep 27, 2019
    • David Beguin's avatar
      [FIX] website : fix visitor email and phone computing · 218f1c63
      David Beguin authored
      
      When a lead entered a wrong email address in the contact form,
      this crashes when loading visitor view.
      We were doing a email concatenation to have all the email address
      of the leads linked to the visitor.
      But as it is a cornet case that shouls not happens often
      (to have multiplus email address linked to the visitor)
      we will only keep the last email addresse entered by the visitor.
      
      Task ID: 2077182
      PR #37472
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      218f1c63
  7. Sep 25, 2019
  8. Sep 27, 2019
  9. Sep 25, 2019
    • William Henrotin's avatar
      [FIX] mrp: generate wo line according to move and not product · 237e0b42
      William Henrotin authored
      
      Planning workorder will generate workorder lines according to reservation
      If some lines are already created into the workorder for the current product,
      The line generation will increase the quantity of the existing one instead of creating
      a new one. The issue occurs when the production have some stock move with the same
      product.
      
      This commit change the condition to find workorder line candidate. Instead of searching
      line with same product, we now search line with same stock move.
      
      closes odoo/odoo#37419
      
      Signed-off-by: default avatarArnold Moyaux <amoyaux@users.noreply.github.com>
      237e0b42
    • Antoine Vandevenne (anv)'s avatar
      [FIX] sale: fix returning to sale from rental portal · f976a108
      Antoine Vandevenne (anv) authored
      
      This commit changes the behavior of the 'Back to edit mode' button in the customer portal preview of sales order.
      If the sales order is a rental order, the user is sent back to the Rental app. If not, the button makes him return to the Sale app.
      This doesn't take into account the app in which the order was opened: if a rental order was opened in the Sale app, the portal will send the user back to the Rental app.
      
      task-2071281
      
      closes odoo/odoo#37423
      
      Signed-off-by: default avatarDamien Bouvy (dbo) <dbo@odoo.com>
      f976a108
    • Aaron Bohy's avatar
      [FIX] web: display action title in breadcrumb · 48b76921
      Aaron Bohy authored
      
      Create a simple subclass of AbstractAction (a client action), with
      property hasControlPanel set to true. By default, the name of the
      action should be displayed in the breadcrumb. Before this rev.,
      it wasn't the case, as it displayed 'Unnamed' instead.
      
      Bug spotted when doing an exercice for the JS smartclass.
      
      closes odoo/odoo#37465
      
      Signed-off-by: default avatarGéry Debongnie (ged) <ged@openerp.com>
      48b76921
  10. Sep 26, 2019
  11. Sep 24, 2019
    • Pierre Paridans's avatar
      [FIX] web: crash when resizing on tablet · 6ff9bd50
      Pierre Paridans authored
      
      When having a long systray (icons from different apps, mode debug,
      multi-company...) the resize of the window can trigger a crash for apps
      that have not too much top-level menus (e.g. Contacts).
      
      This also happens when loading those apps.
      
      Steps to reproduce (on an iPad, portrait):
      
      * use a Runbot with all modules installed (12.0+)
      * activate "debug mode"
      * ensure that the menu/systray bar is quite full
      * open the "Contacts" app
      => traceback with a "cannot call getBoundingClientRect of undefined"
      error
      
      The reason is that the resize's callback iterate over the systray/menu
      items to find which one should be folded behind a "more" ("+") menu
      item.
      
      Sadly in some cases (combination of screen width, systray size, app's
      number of menus) it can lead to a traceback.
      
      This commit ensures that when looping for menu items, we don't try to
      reach an non-existing item.
      
      closes odoo/odoo#37327
      
      X-original-commit: odoo/odoo@d7bae0329990171710acf2d9c0d4d9579cba2c0e
      Signed-off-by: default avatarAdrien Dieudonné (adr) <adr@odoo.com>
      Co-authored-by: default avatarRomeo Fragomeli <rfr@odoo.com>
      6ff9bd50
  12. Sep 25, 2019
    • Xavier Morel's avatar
      [FIX] core: o2m modifiers in the SSF · 77099c54
      Xavier Morel authored
      
      Because the sub-record values would not necessarily get fetched
      ever (whether default or stored), the computation of modifiers might
      blow up if it relied on one of the un-fetched un-specified fields.
      
      One such situation is trying to create a partner with child partners
      if base_address_city is installed: the module adds a readonly attr
      predicated upon the parent_id, without explicitly providing such the
      field would be missing from the O2M record's values.
      
      Closes #37176
      
      closes odoo/odoo#37452
      
      X-original-commit: 184d1b69
      Signed-off-by: default avatarXavier Morel (xmo) <xmo@odoo.com>
      77099c54
    • Rémy Voet's avatar
      [FIX] mail: fix email template preview action · 98b7129e
      Rémy Voet authored
      
      SPECIFICATIONS
      
      In the mail template views, remove the contextual action "Template preview"
      from action dropdown. It was a duplicate of smart button in the template
      form view and makes no sense in the tree view.
      
      Task ID 2075733
      
      closes odoo/odoo#37425
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      98b7129e
    • Rémy Voet's avatar
      [FIX] sms: fix some usability issues · 8636fd83
      Rémy Voet authored
      - In the portal chatter, when a message was send by sms and failed
      the icon was grey. Change it to make it red when there is a failure
      (revert by another task).
      
      - In the sms composer wizard, if the sanitized number is wrong,
      show 'Raoul Grosbedon (Invalid number)' instead of 'Raoul Grosbedon (False)'.
      
      Task 2075733
      8636fd83
    • Rémy Voet's avatar
      [FIX] crm: correctly set phone / SMS widget on phone / mobile fields · 859428ef
      Rémy Voet authored
      SPECIFICATIONS
      
      In the crm lead form view : missing mobile widget in the form.
      Add it to be able to send sms from leads.
      
      Task ID 2075733
      859428ef
    • Florent Lejoly's avatar
      [IMP] crm_iap_lead_enrich: improve settings of enrichment · 211dba4a
      Florent Lejoly authored
      
      Before this commit it was not possible to enrich leads manually as
      only a cron enriches leads. It is considered as sub optimal since people
      would like to do it manually on some leads and not activate it only for
      all leads, using a cron.
      
      After this commit an option is added in CRM settings to choose the type of
      enrichment: either manual, either automatic.
      
      In manual mode, a button appears on the lead to enrich if certain conditions
      are met (email_adress present, not already enriched,...). It also deactivates
      the enrich cron.
      
      In automatic mode, the button on lead is not displayed and the cron is
      activated.
      
      A config parameter is defined in CRM as it is requested to be able to configure
      it directly in CRM without having to first install the app then configure
      it. A post install hook to synchronize cron status with config parameter
      is therefore required.
      
      FP/AJU request
      
      Task 2075817
      
      closes odoo/odoo#37367
      
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      211dba4a
    • Kaushalya Mandaliya's avatar
      [IMP] account, *: adding domain in analytic account fields · b7b3c33a
      Kaushalya Mandaliya authored
      
      *: hr_expense, project
      
      Adding required domain which will allow to only select analytic accounts whose
      company is same as current one or blank.
      
      task-1966016
      
      closes odoo/odoo#37450
      
      Closes: #34270
      Signed-off-by: default avatarQuentin De Paoli (qdp) <qdp@openerp.com>
      b7b3c33a
    • fw-bot's avatar
      [FIX] tools: crop & resize image crashes · c8d09167
      fw-bot authored
      
      - When trying to access an image that need to be resized and cropped,
        the code could crashes.
      
        This is due to the fact that PIL expect to work with integer for
        sizes, but in some cases we provide floats
      
      closes odoo/odoo#37442
      
      Signed-off-by: default avatarToufik Benjaa (tbe) <tbe@odoo.com>
      c8d09167
    • Mathieu Duckerts-Antoine's avatar
      [FIX] web: avoid multiple displays of the "same" discard warning · b0d83b73
      Mathieu Duckerts-Antoine authored
      
      Partial forward port of a7a60f7c
      
      closes odoo/odoo#37437
      
      Signed-off-by: default avatarGéry Debongnie (ged) <ged@openerp.com>
      b0d83b73
    • laa's avatar
      [FIX] eLearning, forum : tab visibility · 69ea10d2
      laa authored
      
      From Website (Frontend) --> From the Courses --> From a course (with settings course : Course type = "Documentation" & Forum mentioned):
            The tab for the forum isn't there
      
      From Website (Frontend) --> From the Courses --> From a course (with settings course : Course type = "Documentation" &  "Allow rating on Course" disabled):
            The tab for the review is always there
      
      From Website (Frontend) --> From the Forum --> From a course (with settings course : Course type = "Documentation" & "Allow rating on Course" activivated):
           Click the tab for the review, the returned view is the course tab and not the review tab
      
      From Website (Frontend) --> From the Forum  --> From a course (with settings course : "Allow rating on Course" disabled):
           The tab for the review is always there
      
      closes odoo/odoo#37436
      
      Task-id:  2074030
      Signed-off-by: default avatarThibault Delavallee (tde) <tde@openerp.com>
      69ea10d2
    • Nicolas Lempereur's avatar
      [FIX] web_editor: change do not bold nobold after bold · beb80c20
      Nicolas Lempereur authored
      
      If we have a content such as:
      
      `aaa <B>bbb</B> ccc`
      
      and you eg. change size of `a bbb c`, the c gets bold because of an
      issue in the merging after style is applied.
      
      reason: we check that the style was same as previous nodes, but because
      walkpoints text[a]->B->text[bbb]->B->text[c] is expurged of duplicates
      it becomes text[a]->B->text[bbb]->text[c] so we erroneoulsy think that
      the node before text[c] is text[bbb] (instead of B tag)
      
      note: 12.5 forward-port (skipping [12.3,12.4]) of 11.0 #37254 (also
      contain #37345)
      
      opw-2071930
      closes #37295
      
      Signed-off-by: default avatarNicolas Lempereur (nle) <nle@odoo.com>
      beb80c20
    • Priyanka Kakadiya's avatar
      [FIX] web: visible studio hooks in listview · c536b369
      Priyanka Kakadiya authored
      
      Before this commit, there are no hooks when dragging a field over an
      editable listview. This was caused by wrong computation of column
      width in studio mode.
      
      This commit isolate the computation of column width, so that studio
      can override it and make the correct computation.
      
      Task-Id 2057829
      
      closes odoo/odoo#36959
      
      Signed-off-by: default avatarAlexandre Kühn (aku) <aku@odoo.com>
      Co-authored-by: default avatarMohammed Shekha <msh@odoo.com>
      c536b369
Loading