This commit adds an option to disable horizontal scrolling in the
smoothScrollOnDrag feature options and use it when dragging and
dropping a snippet into the editor to prevent the wrapwrap from
scrolling horizontally when an element overflow the page (e.g. an
animated element).

task-2215118

closes odoo/odoo#74069

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

1. Activate 'Deliver Content by Email' in the Sales>Configuration>Settings
2. Create a mail template with Product Template for 'Applies to' and
a dynamic field (e.g. ${object.company_id.name}) in the body
3. Add this mail template on a [DEMO] product 'Automatic Email at
Invoice' field, in the Sales tab
4. Create an invoice with [DEMO], confirm it.
5. If the ID of the invoice does not exist as a product.product, you get a
traceback

The reason is that the model used for the template rendering is the
one specified on the template, but the res_id given to the composer
is the one from the invoice.

opw-2476169

closes odoo/odoo#68339

X-original-commit: 9c7d7f01
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

Edit a website menu label with:

    & < > " ` '

This is what is shown after saving:

   &amp; &lt; &gt; &quot; &#x60; &#x27;

This is happening since ea4dbcd2: characters &, <, >, ", `, and ' are
now always escaped. Before that commit, only < and > where escaped and
only when an image was inside the label.

With this change, we unescape the label when we are editing a menu.

opw-2609413

closes odoo/odoo#74429

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When combining a reordering rule, the 3-steps manufacture and
by-products option, the picking from the post-production to the stock
will not contain the residual products produced by the MO (by-products)

To reproduce the error:
1. In Settings, enable:
    - By-Products
    - Multi-Step Routes
2. Inventory > Configuration > Warehouse Management > Warehouses, edit
company's warehouse:
    - Manufacture: 3 steps
3. Create 3 products P_compo, P_finished, P_secondary
    - P_compo is consumable
    - P_finished and P_secondary are storable
    - Routes of P_finished: Manufacture
4. Create a reordering rule for P_finished:
    - Min = Max = 1
5. Create a BoM:
    - Product: P_finished
    - Type: Manufacture
    - Components: 1 x P_compo
    - By-products: 1 x P_secondary
6. Inventory > Operations > Run Scheduler
7. Open the generated MO
8. Check Availability, Produce, Mark as Done
    - Note that in the "Produce" wizard, we mention that one P_secondary
is also produced
    - Also note that in "Finished Products" tab, there are 1 x
P_finished and 1 x P_secondary
9. Open the Transfers > Select the one from Post-Prod to Stock

Error: P_secondary is missing

When creating the byproducts move
https://github.com/odoo/odoo/blob/ad62f877c174d56b90ec516cf24494d751383db9/addons/mrp/models/mrp_production.py#L587
the field `move_dest_ids` is present (is the move created after
evaluating the RR)
https://github.com/odoo/odoo/blob/ad62f877c174d56b90ec516cf24494d751383db9/addons/mrp/models/mrp_production.py#L580
so it is used, but this will cause the `_push_apply` to skip the
evaluation of the move
https://github.com/odoo/odoo/blob/f0eaa756c4947e2a595359959b34b14bfda81a07/addons/stock/models/stock_move.py#L678-L679


and `_assign_picking` will not run, as it normally do when creating the
manufacture

OPW-2581762

closes odoo/odoo#74479

X-original-commit: e2b2fe5f
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

Usecase:
- Product A 10 units in stock
- Do a planned transfer of 7 units to customer
- Reserve
- Do an rpc or execute code to call copy on the stock.move.line

It will result with 2 sml that have 14 units reserve and 7 units
reserved on stock.quant

It's the same result if you create twice the stock.move.line without
updating the stock.quant at the same time. However in stable we
try to only use _update_reserved_quantity on stock.move or some
override in create/write method for 'done' stock.move.line in unlock
cases.

So we never use the copy in stable and define the basic behavior as
'we don't copy the reservation' could prevent some usecase where
the update on the stock.quant is forgotten after.

closes odoo/odoo#74475

X-original-commit: e5041ee1
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Task ID: 2613031

closes odoo/odoo#74305

Signed-off-by: Josse Colpaert <jco@openerp.com>

*: web, website_livechat, website_sale_comparison

Before this commit, bottom fixed elements (e.g. the livechat button)
hid the buttons to go to the next step in website sale when these
buttons are located at the bottom of the page, on some screen sizes.

After this commit,

- A bottom fixed element is hidden if this element hides a button at
the bottom of the page.

- Bottom fixed elements are hidden if a modal is open
to prevent it to hide buttons or any important part of the modal.

task-2501400

closes odoo/odoo#69296

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

By Sunat regulations from 08/01/2021 two new types of identity documents
will be accepted: Temporary Residence Permit and Safe Passage.

Legal ref:

Website: https://cpe.sunat.gob.pe/node/88
Document with Catalog Update No. 8:
https://cpe.sunat.gob.pe/sites/default/files/inline-files/AjustesValidacionesCPEv20210727%20%28ultimo%29.xlsx



Replaces #74342

closes odoo/odoo#74403

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Because there are some restrictions with the HTTPS and trusted certificates
We forward, in some cases,  the POS and the POS RESTAURANT to a specific url.

HTTPS: /pos/ui
HTTP: /pos/web

To allow rules for webserver

We make this change when we check 'Direct Devices'
And when we use a 'Order Printer' type 'epson_epos'

closes odoo/odoo#74363

Tasks: 2597021
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

Steps to Reproduce Bug:

- Create PO
- Remove default Currency
- Add a Line

Bug:
```ValueError: Expected singleton: res.currency()```

With this Commit, we are using default currency to round amount.

closes odoo/odoo#74208

X-original-commit: d9ff2e8e
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

When generating coupons for customers, the email was sent twice due to the values
given on the email_values that is generating a TO (email_to) value (plus using the one given on the template
(recipients_ids))

opw:2574046

closes odoo/odoo#74406

X-original-commit: c99b6ab0a79cf605d78aaa2f9bb00faa192f7fcc
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Co-authored-by: simongoffin <sig@odoo.com>

closes odoo/odoo#74438

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#74393

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

closes odoo/odoo#74391

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Incorporate Luigys TOro (desdelinux) as Vauxoo's contributor

closes odoo/odoo#74343

Signed-off-by: Josse Colpaert <jco@openerp.com>

closes odoo/odoo#74090

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

[FIX] l10n_nl: set 'Cost of Revenue' in allowed account types for Vendor Bills journal created for a l10n_nl chart of account

Allow Cost of Revenue accounts to match the default expense account

closes odoo/odoo#73645

Ticket: 2458146
Signed-off-by: William André (wan) <wan@odoo.com>

When running the scheduler manually with a user who has no read access on pos.session (and point_of_sale is installed),
the run fails silently for the user, and shows an error in the logs.
"_alert_old_session" runs with the user's rights, who might have POS access.

This commits runs the problematic search with sudo to work around this
issue.

closes odoo/odoo#74409

X-original-commit: 5ab9a317
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

When setting a Bill or Material to subcontracting, the "Operations" tab
is hidden. But it still effect eg. BoM Structure & Cost report.

With this changeset, we get an error when we save a subcontracting BoM
that has operations.

opw-2513637

closes odoo/odoo#74382

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps to reproduce the bug:
- Install Accounting and Expense app
- Go to accounting settings > enable cash basis option
- Go to accounting > configuration > accounting > taxes
- Create a new tax or choose an existing one e.g “Tax abc”:
Tax Computation = `”Percentage of Price”`
Tax Type = `”Purchases”`
Choose any value for amount
Select "Based on Payment" in tax due
choose an account with the "Allow Reconciliation" option activated in the Cash Basis Transition Account field
Save

- Go to expenses > Expense Reports > All reports > Create a new one :
	- Add 2 expense and for both set up the taxes to "Tax abc" and unit price > 0
- Submit to manager
- Approve
- Post journal entries
- Register a payment

Problem:
A user error with the following message is triggered: “You are trying to reconcile some entries that are already reconciled”

In the use case we have two expenses and for each, an `" account.partial.reconcile "` will be created,
so we will loop twice and therefore add twice all the `”account.move.line”` linked to the taxes
in the dict `" to_reconcile_after "`: https://github.com/odoo/odoo/blob/beccf82e09d536255d9d9cb9bfe58ebae2559843/addons/account/models/account_partial_reconcile.py#L585



Then we loop to reconcile all the `" account.move.line "` which are in the dict `" to_reconcile_after "`,
but since we added them all twice, at each turn of the loop we give them all as a parameter
of the “reconcile” function without checking whether they are already reconciled or not.

opw-2565934

closes odoo/odoo#74373

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Current approach is:
- In case it's a public user, show only acquirers with flow
  "Redirection to the acquirer website"
- In case it's not a public user, show also the flow "Payment from Odoo"

The above may not be the case for all acquirers and there may be custom flows, so that
code is made inheritable, so custom payment acquirers may change that behavior.

closes odoo/odoo#73026

Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>

And forced sync of pos_discount

opw-2612642

closes odoo/odoo#74394

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

before this commit: when purchase order kanban view grouped then it is not displayed
below dashboard value div, it is displayed besides it so grouped kanban view is not
displayed and screen has horizontal scroller, to view kanban view user have to
scroll screen.

after this commit: purchase order grouped kanban view will be displayed below
dashboard value div.

task-2366797

closes odoo/odoo#60597

Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>

Step to follow

Do not activate multiple companies, keep it standard to 1
Enable multi-locations and routes
Create a second location for raw materials and a new Receipt operation type with the new location as destination location
Go to routes -> edit the buy route -> add a second rule with "Buy" and save.

Cause of the issue

When a stock rule is created from a stock route, the default company
cannot be found as there is none assigned to the stock route.

Solution

Override the default_get method for stock rules in order to use the
current company

opw-2578984

closes odoo/odoo#74367

X-original-commit: 2b8d7d76
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Issue: traceback when website editor is entered and theme options are
clicked on themes using an unknown-to-the-editor font family (see for
the theme repo fix for such an example).

opw-2559735

closes odoo/odoo#74294

Related: odoo/design-themes#268
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When using the online synchronization, you could have a wrong balance in 'processing' state.
In that case, don't force the user to reset the whole statement to 'open' and allow him to edit balances directly.

closes odoo/odoo#74093

Task: 2606857
Signed-off-by: William André (wan) <wan@odoo.com>

How to reproduce the problem:
- Install the delivery module
- Create an SO and add a product. Click on Add Shipping.
- Choose one of the demo Shipping methods
- Deliver the main product.
- Create an invoice: the Delivery Product is not present in the invoice, unless previously manually set as delivered in the SO.

Cause of the problem : the demo values were having their Invoicing Policy set to Delivered Quantity instead of Ordered Quantity (due to the Sale app changing the default Invoicing Policy in 14.0)

Solution : The demo products now have their Invoicing Policy set to Ordered Quantity manually.
No further modification are needed in the creation of Delivery Products, as they have the correct values (when created from the Shipping Method form)

opw-2496202

closes odoo/odoo#74349

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Fine tuning of https://github.com/odoo/odoo/commit/c7b32e0795bc1573d81563f31a75fa44c64b39c2



closes odoo/odoo#74004

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

The current behaviour does not filter the cancelled moves when getting
the related BoM. This implies that, if a new BoM is created for the
same product but with some changes, and the original delivery is cancelled,
the sale order line will still consider the previous BoM.

This causes that the relevant_bom ends up having more than one BoM, which
should not be the expected result.

After the fix, the cancelled moves will not be considered, as this is what
should be expected from cancelled operations.

closes odoo/odoo#74243

X-original-commit: 1e2feaa2
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

When the final receipt of an order is printed, the order is marked as
printed, as it can be then removed, and nothing can be added to it
anymore.

When the Bill is printed, we should not mark it as printed, as there
can be some modifications made after the bill is printed.

So as the bill receipt is an inherited object from the final receipt, we
have to change the behavior for the bill receipt to not mark the order
as printed.

OPW-2555272

closes odoo/odoo#74317

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

Have 3 products:
- Product A, manufactured from Product B, RR min 20 max 200
- Product B, manufactured from Product C, RR min 20 max 200
- Product C, stored, not manufactured, RR min 20 max 200

1. When triggering the scheduler, reordering rule are evaluated in
batch, so procurements will be generated both for A and B.
2. The manufacture orders are created from procurement values:
2.A When manufacturing A, B is needed: the RR is triggered again and
will evaluate again ALL the quantity needed for B (400, including the
quantity already processed at step 1, but not yet written in a MO)
2.B Manufacture order for B is created from procurement values at step1,
 creating a MO for another 200 units

We end up manufacturing 600 instead of 400 of Product B

Fix by partially backporting bf5e1deb
along with a test

opw-2509399

closes odoo/odoo#74314

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

On Chrome, the browser displayed an horizontal scrollbar because the
sr-only item inside the 'next' arrow was positioned absolutely, outside
of the arrow, and thus outside of the window. This happened for the
website carousel snippet when added in pages for instance.

opw-2585526

closes odoo/odoo#74306

X-original-commit: 5bb45452
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Explain the situation when a manual change has been done to the sequence
of `account.move`. This was needed because some user didn't realize that
they changed the sequence, and when they realized it, it had polluted
multiple numbers after that.

closes odoo/odoo#70941

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

When sending the same invoice from Invoices > list view > select an invoice > action > Send and print, the email received by the client does not contain the header and the link to the invoice

This PR adds the custom_layout attribute to the context of "Send & Print" action

opw-2544654

closes odoo/odoo#74250

Signed-off-by: Josse Colpaert <jco@openerp.com>

A tax line affecting the base of subsequent taxes is a line having some values in 'tax_ids' & 'tag_ids'.
When creating a refund, tags was wrongly computed in this case.

closes odoo/odoo#74223

Issue: 2596368
X-original-commit: 97ac9d1c
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Excluding non-active records decreases number of combinations generated in
_cartesian_product. The excluded combinations have to be rejected anyway [1], so
don't waste time on it.

STEPS:
* activate "Product Configurator"
* create a product with many attributes
* make some `product.template.attribute.value` inactive (ptav_active = False):

  ** create a sale order with that value (e.g. color "Black" in "Customizable Desk (CONFIG)")
  ** delete that value in `product.template` form (tab "Variants")

* add the product to a sale order
* RESULT: `_cartesian_product` doesn't generates combination with archived attribute

[1]

https://github.com/odoo/odoo/blob/f9d26509a714ecd290c42e1d58e416bb01268447/addons/product/models/product_template.py#L839-L841



---

opw-2540675

closes odoo/odoo#74119

Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

- Create 2 companies (i.e. Company A & Company B)
- Create user with access to both companies and default company set to Company B
- Log with created user
- Switch to Company A
- Go to Project and create a new Project (i.e. Project X)
- Go to Timesheets and add a line for Project X
- Display all timesheets in list view
- Select created timesheet and print "Timesheet Entries"
Logo and address printed on timesheet report are from Company B.

Company used for timesheet report is default company of current user.

This fix will use company linked to the project if it is unique.
Otherwise, it will use current company.

opw-2502182
opw-2509463

closes odoo/odoo#74265

X-original-commit: 08126415
Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

Before this commit,
User was allowed to create new records from form view through
Graph view' action. Since we do not have a way to prevent opening
form view from Graph and also we should not Introduce new form view
on stable version.

With this commit,
we are disabling create/edit/copy from action.

closes odoo/odoo#70820

Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

Sales > Reporting > Sales
Select the measure "Customer (count)"

TypeError: Cannot add property group_operator, object is not extensible

As the object is immutable we need to workaround the assignment.
The previous fix 35967fab
will be moved in the `documents_spreadsheet` code

opw-2606424

closes odoo/odoo#74211

Related: odoo/enterprise#19859
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>