For performance reason, we avoided computing goals for the set of users
that didn't log in recently (See ec0c0f29).
However, users can stay logged in for a while without having a new "log
in event" (password asked), such that active internal users can keep
old values in their challenges when reports are sent, which is not good.

Until an improvement can be implemented in master, we drop this time
constraint for active internal users.

A test is added, checking the behavior of the method called by the cron.

Task-3226408

closes odoo/odoo#121483

X-original-commit: 6c77dd82
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Since 960360af, when computing badge stats, a datetime was compared to a
string leading to a traceback.  e.g. when clicking in employess >
badges.

Also, due to a typo, the compute method was assigning the stats result
to the wrong attributes.  e.g. 'stats_my_this_month' instead of
'stat_my_this_month'.

With this commit, the above mentioned issues are fixed and a test is
covering these issues to avoid regression.

Includes compatibility-change to website_forum: a selection(callable)
converted to a Selection(list) since that can easily be extended in the
new API.

update is a method from the ORM with a different signature.
Avoid name clash. Issue 646610

- Preserved explicit 3rd-party copyright notices
- Explicit boilerplate should not be necessary - copyright law applies
  automatically in all countries thanks to Berne Convention + WTO rules,
  and a reference to the applicable license is clear enough.

bzr revid: mat@openerp.com-20140416153153-f6r85uc8ibztzvup

bzr revid: mat@openerp.com-20131224152902-i2ozrf41y1ou2vdm

bzr revid: mat@openerp.com-20131224151543-oofn9wc2w3933gjy

bzr revid: mat@openerp.com-20131218111243-npnauv6mxhb4nttg