Merge branch 'fix/add-second-lastname-to-portability-contract-data' into 'master'

Concat second lastname to portability contract data

See merge request coopdevs/odoo-somconnexio-python-client!16

CHANGELOG.md

@@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+* Concat second lastname to portability contract data [#16](https://gitlab.com/coopdevs/odoo-somconnexio-python-client/-/merge_requests/16)
+
 ## [0.1.13]
 ### Fixed
 * Use the company_name and company_email in company SR [#15](https://gitlab.com/coopdevs/odoo-somconnexio-python-client/-/merge_requests/15)

odoo_somconnexio_python_client/tryton_mappers/crm_lead_from_contract_form.py

@@ -132,7 +132,10 @@ class CRMLeadFromContractForm:
                         "mobile_vat_number"
                     ),
                     "previous_owner_name": (
-                        self.contract_data.get("mobile_surname")
+                        self._concat_lastname(
+                            self.contract_data.get("mobile_surname"),
+                            self.contract_data.get("mobile_lastname"),
+                        )
                     ),
                     "previous_owner_first_name": self.contract_data.get("mobile_name"),
                     "icc_donor": self.contract_data.get("mobile_icc_number"),
@@ -202,7 +205,10 @@ class CRMLeadFromContractForm:
                         "internet_vat_number"
                     ),
                     "previous_owner_name": (
-                        self.contract_data.get("internet_surname")
+                        self._concat_lastname(
+                            self.contract_data.get("internet_surname"),
+                            self.contract_data.get("internet_lastname"),
+                        )
                         or self.contract_data.get("tradename")
                         or ""
                     ),
@@ -260,3 +266,11 @@ class CRMLeadFromContractForm:
         if previous_service == "fibre":
             previous_service = "fiber"
         return previous_service
+
+    def _concat_lastname(self, surname, lastname):
+        return " ".join(
+            [
+                surname,
+                lastname,
+            ]
+        ).strip()

tests/tryton_mappers/test_crm_lead_from_contract_form.py

@@ -98,7 +98,13 @@ class CRMLeadFromContractFormTests(unittest.TestCase):
             contract_data.get("mobile_vat_number"),
         )
         self.assertEqual(
-            mobile_isp_info["previous_owner_name"], contract_data.get("mobile_surname")
+            mobile_isp_info["previous_owner_name"],
+            " ".join(
+                [
+                    contract_data.get("mobile_surname"),
+                    contract_data.get("mobile_lastname"),
+                ]
+            ).strip(),
         )
         self.assertEqual(
             mobile_isp_info["previous_owner_first_name"],
@@ -237,7 +243,12 @@ class CRMLeadFromContractFormTests(unittest.TestCase):
         )
         self.assertEqual(
             broadband_isp_info["previous_owner_name"],
-            contract_data.get("internet_surname"),
+            " ".join(
+                [
+                    contract_data.get("internet_surname"),
+                    contract_data.get("internet_lastname"),
+                ]
+            ).strip(),
         )
         self.assertEqual(
             broadband_isp_info["previous_owner_first_name"],