Skip to content
Snippets Groups Projects
Commit d990f2ec authored by konykon's avatar konykon
Browse files

Concat second lastname to portability contract data

parent 57b05492
No related branches found
No related tags found
1 merge request!16Concat second lastname to portability contract data
......@@ -132,7 +132,10 @@ class CRMLeadFromContractForm:
"mobile_vat_number"
),
"previous_owner_name": (
self.contract_data.get("mobile_surname")
self._concat_lastname(
self.contract_data.get("mobile_surname"),
self.contract_data.get("mobile_lastname"),
)
),
"previous_owner_first_name": self.contract_data.get("mobile_name"),
"icc_donor": self.contract_data.get("mobile_icc_number"),
......@@ -202,7 +205,10 @@ class CRMLeadFromContractForm:
"internet_vat_number"
),
"previous_owner_name": (
self.contract_data.get("internet_surname")
self._concat_lastname(
self.contract_data.get("internet_surname"),
self.contract_data.get("internet_lastname"),
)
or self.contract_data.get("tradename")
or ""
),
......@@ -260,3 +266,11 @@ class CRMLeadFromContractForm:
if previous_service == "fibre":
previous_service = "fiber"
return previous_service
def _concat_lastname(self, surname, lastname):
return " ".join(
[
surname,
lastname,
]
).strip()
......@@ -98,7 +98,13 @@ class CRMLeadFromContractFormTests(unittest.TestCase):
contract_data.get("mobile_vat_number"),
)
self.assertEqual(
mobile_isp_info["previous_owner_name"], contract_data.get("mobile_surname")
mobile_isp_info["previous_owner_name"],
" ".join(
[
contract_data.get("mobile_surname"),
contract_data.get("mobile_lastname"),
]
).strip(),
)
self.assertEqual(
mobile_isp_info["previous_owner_first_name"],
......@@ -237,7 +243,12 @@ class CRMLeadFromContractFormTests(unittest.TestCase):
)
self.assertEqual(
broadband_isp_info["previous_owner_name"],
contract_data.get("internet_surname"),
" ".join(
[
contract_data.get("internet_surname"),
contract_data.get("internet_lastname"),
]
).strip(),
)
self.assertEqual(
broadband_isp_info["previous_owner_first_name"],
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment