extend tests

pyotrs/lib.py

@@ -491,7 +491,7 @@ class Client(object):
             self.session_timeout = 28800  # 8 hours is OTRS default
         else:
             self.session_timeout = session_timeout
-            
+
         self.https_verify = https_verify
 
         # dummy initialization
@@ -568,6 +568,8 @@ class Client(object):
         # TODO 2016-04-18 (RH): decide what to return here.. bool or result content?
         if self._session_create_json(url, payload):
             return self.response_json
+        else:
+            return None
 
     def session_restore_or_set_up_new(self):
         """Try to restore Session ID from file otherwise create new one
@@ -727,6 +729,8 @@ class Client(object):
         # TODO 2016-04-18(RH): decide what to return here.. bool or result content? Or full new?
         if self._ticket_create_json(url, payload):
             return self.response_json
+        else:
+            return None
 
     def _ticket_create_json(self, url, payload):
         """_ticket_create_json
@@ -785,6 +789,8 @@ class Client(object):
         # TODO 2016-04-13 (RH): decide what to return here.. bool or ticket content
         if self._ticket_get_json(url, payload):
             return self.response_json['Ticket'][0]
+        else:
+            return None
 
     def ticket_get_by_number(self, ticket_number, dynamic_fields=True, all_articles=False):
         """ticket_get_by_number
@@ -986,6 +992,8 @@ class Client(object):
         # TODO 2016-04-17 (RH): decide what to return here.. bool or result content? Or full new?
         if self._ticket_update_json(url, payload):
             return self.response_json
+        else:
+            return None
 
     def ticket_update_set_pending(self,
                                   ticket_id,
@@ -1023,6 +1031,8 @@ class Client(object):
         # TODO 2016-04-17 (RH): decide what to return here.. bool or result content? Or full new?
         if self._ticket_update_json(url, payload):
             return "Set pending till {0} with state \"{1}\"".format(pending_till_str, new_state)
+        else:
+            return None
 
     def _ticket_update_json(self, url, payload):
         """_ticket_update_json

tests/test_client.py

@@ -16,9 +16,10 @@ from pyotrs import Client
 from pyotrs.lib import NoBaseURL, NoWebServiceName, ResponseJSONParseError
 from pyotrs.lib import SessionError
 
-from pyotrs import Client, Ticket  # noqa
+from pyotrs import Article, Client, Ticket  # noqa
 from pyotrs.lib import NoBaseURL, NoWebServiceName, NoCredentials  # noqa
 from pyotrs.lib import SessionCreateError, SessionIDFileError, OTRSAPIError, OTRSHTTPError  # noqa
+from pyotrs.lib import TicketError  # noqa
 
 
 class ClientTests(unittest.TestCase):
@@ -305,6 +306,7 @@ class ClientTests(unittest.TestCase):
         """Tests _write_session_id_to_file not implemented"""
         # create object
         Client(baseurl="http://fqdn", webservicename="GenericTicketConnectorREST")
+        # TODO
 
     def test__remove_session_id_file(self):
         """Tests_remove_session_id_file not implemented"""
@@ -320,6 +322,44 @@ class ClientTests(unittest.TestCase):
                                'http_method, url and payload are required.',
                                Client._send_request)
 
+    def test_ticket_create_no_ticket(self):
+        """Test ticket_create - no ticket specified"""
+        obj = Client(baseurl="http://fqdn",
+                     webservicename="GenericTicketConnectorREST")
+        obj.session_id = "some_session_id"
+        self.assertRaisesRegex(TicketError,
+                               'provide Ticket!',
+                               obj.ticket_create)
+
+    def test_ticket_create_no_article(self):
+        """Test ticket_create - no article specified"""
+        obj = Client(baseurl="http://fqdn",
+                     webservicename="GenericTicketConnectorREST")
+        obj.session_id = "some_session_id"
+        tic = Ticket(dct={'Title': 'foo'})
+
+        self.assertRaisesRegex(TicketError,
+                               'provide Article!',
+                               obj.ticket_create, ticket=tic)
+
+    @mock.patch('pyotrs.lib.Client._ticket_create_json', autospec=True)
+    def test_ticket_create_no_ticket_mock(self, mock_t_create_json):
+        """Test ticket_create - no ticket specified"""
+        obj = Client(baseurl="http://fqdn",
+                     webservicename="GenericTicketConnectorREST")
+        obj.session_id = "some_session_id"
+        tic = Ticket(dct={'Title': 'foo'})
+        art = Article({'Subject': 'mySubject',
+                       'Body': 'myBody',
+                       'TimeUnit': 0,
+                       'MimeType': 'text/plain',
+                       'Charset': 'UTF8'})
+
+        mock_t_create_json.return_value = False
+
+        result = obj.ticket_create(ticket=tic, article=art)
+        self.assertEqual(result, None)
+
     def test__ticket_request_invalid_method(self):
         """Test Method Client._ticket_request """
         self.assertRaisesRegex(NotImplementedError,