-
- Downloads
[FIX] mrp: enforce constrains check for cost share of byproducts in MO
Steps to reproduce: Step 1: Create new MO Step 2: In page by-products click three dots to show column cost_share in tree by-products Step 3: Create new Byproduct and input cost share >100% or <0% or input two byproducts where their cost share adds up to more than 100% Expected result: Validation error: total byproduct cost_share cannot exceed 100 or Validation error: cost_share values must be positive Actual result: Values saves without issue Issue is due to `move_byproduct_ids` being removed in the mrp_production overrides of `write()` or `create()` and having the `_compute_move_byproduct_ids` populate its values. This removal is causing the constrains to not be enforced, therefore we set the constrains field to `move_finished_ids` since changing of this value will ensure that the values are correctly checked. Note: There will be a decrease in performance since this means the constrains will be called whenever the MO's product to produce is changed, but hopefully it will be minimal since there is no simple fix for this issue. closes odoo/odoo#120771 X-original-commit: 9d6ff93d Signed-off-by:Tiffany Chang <tic@odoo.com>
Loading
Please register or sign in to comment