[FIX] P3: list -> iterable builtins (#16811)
In Python 3: * various builtins and dict methods were changed to return view/iterable objects rather than lists * and the separate Python 2 view/iterable builtins and methods were removed altogether This is problematic when using these items as list (which the happens repeatedly in Odoo), but more viciously when iterating *multiple times* over them (which also happens, which I've messed up multiple times while writing this, and which is a pain to debug even when you've just created the issue). Convert all code using these to semantics-matching cross-version helper functions to get the LCD behaviour between P2 and P3, and forbid the builtins via lint. issue #8530
Showing
- addons/account/models/account.py 2 additions, 2 deletionsaddons/account/models/account.py
- addons/account/models/account_bank_statement.py 2 additions, 2 deletionsaddons/account/models/account_bank_statement.py
- addons/account/models/account_invoice.py 12 additions, 12 deletionsaddons/account/models/account_invoice.py
- addons/account/models/account_journal_dashboard.py 1 addition, 1 deletionaddons/account/models/account_journal_dashboard.py
- addons/account/models/account_move.py 1 addition, 1 deletionaddons/account/models/account_move.py
- addons/account/models/chart_template.py 4 additions, 1 deletionaddons/account/models/chart_template.py
- addons/account/models/partner.py 4 additions, 4 deletionsaddons/account/models/partner.py
- addons/account/report/account_balance.py 1 addition, 1 deletionaddons/account/report/account_balance.py
- addons/account/report/account_general_ledger.py 1 addition, 1 deletionaddons/account/report/account_general_ledger.py
- addons/account/report/account_journal.py 1 addition, 1 deletionaddons/account/report/account_journal.py
- addons/account/report/account_overdue_report.py 1 addition, 1 deletionaddons/account/report/account_overdue_report.py
- addons/account/report/account_report_financial.py 10 additions, 9 deletionsaddons/account/report/account_report_financial.py
- addons/account/tests/test_reconciliation.py 6 additions, 3 deletionsaddons/account/tests/test_reconciliation.py
- addons/account_asset/models/account_asset.py 3 additions, 3 deletionsaddons/account_asset/models/account_asset.py
- addons/account_asset/wizard/asset_depreciation_confirmation_wizard.py 1 addition, 1 deletion...nt_asset/wizard/asset_depreciation_confirmation_wizard.py
- addons/account_test/report/report_account_test.py 2 additions, 2 deletionsaddons/account_test/report/report_account_test.py
- addons/account_voucher/models/account_voucher.py 2 additions, 1 deletionaddons/account_voucher/models/account_voucher.py
- addons/anonymization/models/anonymization.py 1 addition, 1 deletionaddons/anonymization/models/anonymization.py
- addons/anonymization/wizard/anonymize_wizard.py 1 addition, 1 deletionaddons/anonymization/wizard/anonymize_wizard.py
- addons/auth_signup/controllers/main.py 3 additions, 2 deletionsaddons/auth_signup/controllers/main.py
Loading
Please register or sign in to comment