Before this commit, the states (collapsed/not collapsed) of the tabs
of the accordion snippet were not saved if it was the only changement
in edit mode.

After this commit, we trigger a content change when the states of the
tabs is changed.

task-2442237

closes odoo/odoo#67276

X-original-commit: 18af2eca
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

Steps:
- Install account,payment
- Go to Invoicing
- Create an invoice
- Click Actions > Generate a Payment Link
- Follow the generated link
- Pay

Bug:
The transaction is not linked to the sale order in the link table
`account_invoice_transaction_rel`

Explanation:
This fix is broadly mimicking the behavior of the sales module regarding
the link of an order to a transaction, adding `invoice_id`s where they
are needed throughout the payment process in order to link the
transaction to the invoice.

opw:2451534

closes odoo/odoo#67296

X-original-commit: 7c6d06fa
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: backspac <backspac@users.noreply.github.com>

Since 9c2ce1f1, more files are included in packaging.  The rpm build
failed because shebang lines of packaged files must not use
`/usr/bin/env` [0] [1] [2].

As it seems that those old files are not of any use anymore, this commit
removes them.

[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Multiple_Python_Runtimes
[2] https://pagure.io/packaging-committee/issue/738



closes odoo/odoo#67294

X-original-commit: 54b6a7a9
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

commit at each lead makes the system spend 80% of the time recomputing
bayesian probabilities. Avoid to commit too often speed up the process
while not altering final result.

Task ID-2475352

closes odoo/odoo#67275

X-original-commit: 34f6e38e68208b9509a429cdb09f8316a7ef566f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Field vehicle_id is missing on the account.move.line view of refunds.
This fix updates the domain to make visible the field in in_refund.

Task ID: #2466914

closes odoo/odoo#67269

X-original-commit: 97fb335e
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

A previous commit (8dbd1efe) fixed a
part of the basicmodel that used _.each to iterate on an object with
field names as keys, which does not work when a field is named "length".
To fix it, I simply used a native for ... in statement.  However, I
missed the fact that there was a second 'return' statement in the body
of the closure given to _.each, so the onchange method returned
prematurely.

The fix is to simply use the continue statement in that case.

closes odoo/odoo#67267

X-original-commit: d9834e65
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

closes odoo/odoo#67262

X-original-commit: 42291b95
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

This reverts commit a59f255ef33c47449d028930e15c5390c62e39ed.

github issue: 67098

closes odoo/odoo#67255

X-original-commit: 86e2c6b7
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

The test is running in sudo mode, so we need to specify the company in
the search.

Also do not load the demo data when installing as we would do the work
twice for most localization.

closes odoo/odoo#67235

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

PR #66910 has been created so the MX can print their receipts.
Eventually, this needs to be reverted since printing a receipt is
actually illegal.

closes odoo/odoo#67209

X-original-commit: 7e9261cacd9f6963dca517fe7b1f3de067af1366
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

opw-2451571

closes odoo/odoo#67163

X-original-commit: 9bafbca93150a55f8c8dcad19d5861bd05d40b99
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Currently, website_hr_recruitment(online job) is not auto
installed when hr_recruitment and website is installed.

So in this commit, auto install the online job(website_hr_recruitment)
when only website and hr_recruitment is installed.
so removed website_partner dependency from website_hr_recruitment as it's
not really needed. also make the website_hr_recruitment and
google_recaptcha auto install.

closes odoo/odoo#66737

Taskid: 2374617
Related: odoo/upgrade#2201
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Currently, user cannot group the timesheet by inv/so in portal view.

In this commit, add a group the timesheet by inv/so in portal view and
move the `view timesheets` button next th each sol to the top left pannel.

closes odoo/odoo#65932

Taskid: 2451359
Related: odoo/upgrade#2214
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Rename group "Attendance" to "Attendance/POS"

closes odoo/odoo#65537

Task-id: 2244289
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

We remove the "close session" button to prevent an employee to have access to the back end if not eligible.
For example:
User A start a pos session.
Employee B, not related to User A, could close the session and have access to the back end as User A.

This commit also allows to display the select cashier popup correctly in mobile view.

Task-id: 2244289

Display a confirmation dialog when a user creates duplicate expenses.

Two expenses (or more) are considered duplicates when they share the same
date, amount, product, employee, company and currency.

closes odoo/odoo#64190

Taskid: 2368636
Related: odoo/upgrade#2061
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

task-2438828

closes odoo/odoo#67227

X-original-commit: 49585b8ee726af7edd113c3012b1168d24dc4d7c
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

Before this commit, when the project is employee rate and the user sets
the sale order item to False in a task with this project, the linked
timesheets should have the sales order item to False, but if a
employee mapping is matched for this timesheet, the sales order item of
this mapping is given to the timesheet.

This commit checks if the sales order item in the task linked to the
timesheet and if no sales order item in the task then the sales order
item in the timesheet should also be empty (False).

closes odoo/odoo#67202

Forward-port-of: #67055
X-original-commit: a325e75a8565039d5120d169df67ef2d16c7fdc4
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

closes odoo/odoo#67073

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

# Purpose

This PR's primary objective is to ensure that the timesheet uom is working in accordance with the company settings in a multi company environment.

Prior to this PR:

 - The timesheet preferences sent to the front end were always those of the default
   company of the user.
 - The timesheet related widgets initialisation process (adding the correct ones in
   the fieldRegistry) was performed before the front end treatment of cids and coockies
   which prevented applying the front end selected company settings.

After this PR:

 - A dictionnary is used in the session in order to structure the companies info.
 - The company timesheet preferences are sent to the front end through the company dict.
 - The uom info is sent to the front end through the session.
 - The timesheet uom is now managed from the frontend and is now in sync with the settings.
 - Timesheet widgets are initialised during the AbstractWebClient init and are in sync with
   the multicompany front end settings

task-2168337

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#66551

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

[MERGE] mail, mass_mailing, event, various: improve usability across various marketing-related apps (activities, marketing)

# Purpose
General Marketing usability improvements based on what has been seen observing users on Fullstory.
As the changes are relatively minor and related to specific apps, the rationale and improvements will be explained in more details in each commit.
# Commits
##### [IMP] `base`: modify some displayed texts for res_partner
* Error messages when trying to delete/archive a partner linked to an active user
* Partner Form placeholders
* Update main_flow tour to be consistent with above changes
* Update test_orm to use a model with less functional constraints
##### [IMP] `mass_mailing_sms`: prevent raising an error in sms mailing
* Allow to launch a sms campaign without recipients without raising an error
##### [IMP] `mass_mailing`: add various usability improvements
* Mass mailing preview in a new tab (to prevent data loss when leaving the page)
* Data display adjustments (better wording...)
##### [IMP] `mail`: revamp the activity type form view
* Change "force_next" checkbox into "chaining_type" selection
* Update the Form layout and wording
* Renamed fields :
  * default_next_type_id -> triggered_next_type_id
  * next_type_ids -> suggested_next_type_ids
  * default_description -> default_note
##### [IMP] `event`: improve the event form editor and update the tour
* Fix an undesired behavior with duplicate lines when switching event_type templates
* Remove steps from the event tour
##### [IMP] `web`: add an initial_date context key for CalendarView
* Add a context key ('initial_date') to the calendar view (to open it around a specified date)
##### [IMP] `crm`: add a reschedule action for activities
* Add a reschedule action alongside snooze 7d, for event-related activities
##### [IMP] `crm`: change the search order for a won stage
* In case "not won" stages are placed between "won" stages, put an opportunity marked as "won" in the correct stage (higher sequence if possible)
##### [MOV] `website_event`: move the website_event tour to tests/tours
* The scope of another tour (event_tour) include the scope of this tour and actually starts from the Event module. This smaller tour is thus disabled and kept as a test.
# Links
Task ID : 2410217
ENT PR : https://github.com/odoo/enterprise/pull/15406
UPGRADE PR : https://github.com/odoo/upgrade/pull/2167



closes odoo/odoo#63370

Related: odoo/upgrade#2167
Related: odoo/enterprise#15406
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Prior to this commit:

- There were no tests on the timesheet_uom and the fact that the widget
  that is loaded in the fieldRegistry is corresponding to the current
  company preferences.

After this commit:

- Tests will be performed in order to check that the timesheet_uom that
  is loaded in the fieldRegistry is corresponding to the current company
  preferences.

task-2168337
Closes: #66551

This commit's primary objective is to ensure that the timesheet uom is working in accordance
with the company settings in a multi company environment.

Prior to this commit:

 - The timesheet preferences sent to the front end were always those of the default
   company of the user.
 - The timesheet related widgets initialisation process (adding the correct ones in
   the fieldRegistry) was performed before the front end treatment of cids and coockies
   which prevented applying the front end selected company settings.

After this commit:

 - A dictionnary is used in the session in order to structure the companies info.
 - The company timesheet preferences are sent to the front end through the company dict.
 - The uom info is sent to the front end through the session.
 - The timesheet uom is now managed from the frontend and is now in sync with the settings.
 - Timesheet widgets are initialised during the AbstractWebClient init and are in sync with
   the multicompany front end settings

task-2168337
Closes: #66551

Before this commit:

 - Some semicolon where missing
 - There was a typo in the variable name

After this commit:

 - The above problems are solved

task-2168337
Closes: #66551

Convert the override of method `power_on()` to an `@autovacuum` method.

closes odoo/odoo#67178

X-original-commit: f2122233
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

Steps to reproduce the bug:

- Let's consider an included tax T (10%) and a product P (11€) with invoicing policy based on delivery
- Create a sale order SO with one line L with 2 P and T
- Confirm SO and deliver it

Bug:

The untaxed_amount_to_invoice was 40€ on L instead 20€

opw:2457660

closes odoo/odoo#67188

X-original-commit: 56d92277
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

PURPOSE

Purpose of this merge is to improve reporting usability
and views in crm, lead generation and iap services.

SPECIFICATIONS

Some usability improvements going to be done by this merge are listed
below.

Improve the action helpers for the actions bound to below listed menus
for better usability:

  * My Activities
  * Leads
  * Leads Analysis

Along with that, this commit also improves the following:

  * while generating leads, make 'Industries' field required on the modal so
    that results obtained are actionable instead of random leads;
  * after trying to generate leads, if no result is found, the same pop-up
    opens again with same criteria and displays a waring in the pop-up. It
    informs users that leads are not found and no credits are spent for their
    last search;
  * improve the warning message for unsuccessful enrichment due to invalid
    email;

This merge adds the color_picker widget for setting valid color of
CRM tags in the form view.

With this merge, the 'Enrich' button on lead now appears only after the
email is set and valid, which previously appeared even if no email is set
or if the value is not a valid email.

Right now, for the fetched contacts through enrichment, we display
name and title in separate columns (in the chatter), that leaves
lesser space for email and phone.

With this commit, we merge name and title columns, and provide a bit
extra space to email and phone so that chances for them being wrapped
in a new line are less. Also, if phone number is not available in any
contacts, the 'Phone' column is hidden, giving even more space for the
Name/Title and Email columns.

LINKS

COM PR odoo/odoo#64075
ENT PR odoo/enterprise#15561
Task ID-2393253

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

The color_picker widget, that can be seen for example in the track form
view for event tracks, had an issue: if the user clicked on it, then
pressed TAB, a traceback was displayed.

The problem comes from the fact that the color picker widget inherits
from FieldInput, but is not a fieldinput, so many expectations made by
the FieldInput code do not hold, such as the code run when handling
navigation (by TAB and such keypress). Because of that, the code in
_onNavigationMove crashed, because it expected an input.

Since this is a bug fix, I simply disabled the navigation in that case,
so no crash happens.  Sadly, this widget has still a big issue: it
clearly does not work as most users would expect: pressing TAB or arrows
should update the selection.  But this would be a more complicated
refactoring, for a bug which is clearly not critical, therefore this
commit implements the simple and safe solution.

Also, we disable the focus outline to minimize the wrong expectation.
Seeing them kind of implied that one could update the selection with the
keyboard.

Note that the widget color_picker was moved from another addon to web/, without
any tests nor documentation.

OPW 2467369

closes odoo/odoo#67195

X-original-commit: 580456b6
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Right now, for the fetched contacts through enrichment, we display
name and title in separate columns (in the chatter), that leaves
lesser space for email and phone.

With this commit, we merge name and title columns, and provide a bit
extra space to email and phone so that chances for them being wrapped
in a new line are less. Also, if phone number is not available in any
contacts, the 'Phone' column is hidden, giving even more space for the
Name/Title and Email columns.

Task ID-2393253
COM PR odoo/odoo#64075

With this commit, the 'Enrich' button on lead now appears only after the
email is set and valid, which previously appeared even if no email is set
or if the value is not a valid email.

Task ID-2393253
COM PR odoo/odoo#64075

This commit adds the color_picker widget for setting valid color of
CRM tags in the form view.

Task ID-2393253
COM PR odoo/odoo#64075

This commit improves the action helpers for the actions bound to below listed
menus for better usability:

  * My Activities
  * Leads
  * Leads Analysis

Along with that, this commit also improves the following:

  * while generating leads, make 'Industries' field required on the modal so
    that results obtained are actionable instead of random leads;
  * after trying to generate leads, if no result is found, the same pop-up
    opens again with same criteria and displays a waring in the pop-up. It
    informs users that leads are not found and no credits are spent for their
    last search;
  * improve the warning message for unsuccessful enrichment due to invalid
    email;

COM PR odoo/odoo#64075
ENT PR odoo/enterprise#15561
Task ID-2393253

This line was an hack to manage the custom register payment wizard of hr_expense.
Since this wizard is gone and 'payment_id' is a related stored field in account.move.line, we should not write such data explicitely.

closes odoo/odoo#67162

X-original-commit: 2d7f45e7
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

PURPOSE

Improve certification templates and make them more aligned with current
state of the art certifications.

SPECIFICATIONS

Design has been completely redone to be more modern.

Also displays dynamic certification number based on the ID of
certification record for both modern and classic layouts. It consists in
minimum 10 digits. It means that if the ID of the record is 5 it is displayed
as 0000000005.

Also improves the behavior by adding name of the certification in page title
so that use can see the proper string on browser tab. For doing so, we create
a new wrapper template that sets the title for the page, and use an iframe
to loads the pdf file from existing controlloer (which returns response for the
preview pdf).

LINKS

Task ID-2341847
COM PR #66028

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Right now while previewing the certification template, the proper title is not
displayed on the tab of browsers.

This commit improves the behavior by adding name of the certification in title
so that use can see the proper string on browser tab. For doing so, we create
a new wrapper template that sets the title for the page, and use an iframe
to loads the pdf file from existing controlloer (which returns response for the
preview pdf).

Task ID-2341847
COM PR odoo/odoo#66028

This commit displays dynamic certification number based on the ID of
certification record for both modern and classic layouts. It consists in
minimum 10 digits. It means that if the ID of the record is 5 it is displayed
as 0000000005.

Task ID-2341847
COM PR odoo/odoo#66028

Improve certification templates and make them more aligned with current
state of the art certifications.

Task ID-2341847
COM PR odoo/odoo#66028

Co-Authored-By: Elisabeth Dickinson <edi@odoo.com>
Co-Authored-By: Dharmrajsinh Jhala <dja@odoo.com>

Fine tuning of 2d63fff1

closes odoo/odoo#67173

X-original-commit: d4210430
Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>

The underscore (_) library has a bug in which the _.each method does not
work with object which contains a "length" property. This is because it
does look for that key and if it is a number, it will assume that it is
an array with that length value.  Nicely done...

If that length value is set to 0, then it will just do nothing, since it
thinks that it is dealing with an empty array.

Note that if the value is set to an object, _.each is smart enough to
notice that it cannot be an array, and will do the correct thing in this
case.

Usually, our _.each calls are safe, since we usually iterate on arrays,
or on object with safe keys, or on object with values that cannot be a
number.

But there was 2 unsafe calls in basic_model, which leads to strange
bugs: some code is skipped, and the form view is then confused.  The
motivation for this fix is the fact that onchanges are not applied at
all, if there is a length field set to 0.

To fix this, we can just avoid using _.each.  Note to every Odoo JS
developers reading this: new Odoo code should avoid using the _ and $
libraries, because we do not really need them, and we want to keep our
dependencies to the strict mininum.

OPW: #2465808
closes odoo/odoo#66126

closes odoo/odoo#67172

X-original-commit: 8dbd1efe
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

* Reassign the "event" tour to a classic test
  - Only the "event_tour" that starts from the Event App should be kept from a
    user perspective.
  - The "event" tour that launched itself once upon installing the Event App
    from the Website (Website App) and only covered the front-end part of
    the event creation will now only be kept as a classic test tour.
  - This tour is renamed "website_event_tour" instead of "event" for
    disambiguity with the other tour called "event_tour"

* This tour is now only intended to be used as a test, and as such, is moved
  to `tests/tours`

Task ID : 2410217
PR : #63370