When converting a lead to an opportunity and merging with existing
opportunities, the list view showing opportunities is very tiny.

This is caused by the field not having the correct colspan, as its label is
hidden with the "nolabel" attribute.

This commit fixes it by assigning a colpan of 2.

Task-3179173

closes odoo/odoo#119689

X-original-commit: 6a003a12
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

Steps:
Say 3 existing tasks :
t0 (from which the recurrence has been created), t1, t2;
and t4 (not created yet).
When you change t0, t4 is updated as expected.

Issue:
But when you change t1, t4 doesn't take it into account.

Cause:
`ProjectTaskRecurrence._create_next_task` takes
`recurrence.task_ids[-1]` as template to create the next occurence.
Yet ProjectTask is ordered by "priority desc, sequence, id desc".
All occurrences being likely to have the same priority and sequence,
we the result ordered by id desc. So `recurrence.task_ids[-1]` has the
smallest id and so it is the oldest one.

Fix:
Take the task with the max id.

opw-3237168

closes odoo/odoo#119700

X-original-commit: 61bbd8e6
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

[FIX] stock_account: prevent stock account update on product change when using manual stock valuation

If the category of a product is using manual stock valuation, when changing the product on an invoice line,
the account should not be set to the `property_stock_account_input_categ_id`. It should be the case only if
we use automatic/real-time stock valuation.

opw-3226536

closes odoo/odoo#119662

X-original-commit: 1f888943
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Ricardo Gomes Rodrigues (rigr) <rigr@odoo.com>

## Bug

When sending an invoice to a recipient who is not the customer, they are
unable to view the invoice in the customer portal and are prompted to
log in.

## Steps to reproduce

1. Create and validate an invoice
2. Click on the Send & Print button, then add a recipient who is not the
   customer associated with the invoice.
3. Proceed to send the invoice.
4. Access the email that was sent to the added recipient (who is not the
   customer)
5. Using an incognito or private browsing window, open the link
   `View Invoice`

=> you should see that you are asked to log in, instead of being
directed to the customer portal.

opw-3114579

closes odoo/odoo#119644

X-original-commit: 95c585f6
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Nshimiyimana Serge Séna (sesn) <sesn@odoo.com>

Uninstallation does not cope well with `setup_models` being performed
unconditionally as those will dramatically alter registry states, and
resurrect computes which the uninstallation has disabled: rather than
try to update registry models in-place (which is rather fraught) the
uninstallation deletes the columns, tables, and `ir.*` reflection
records and only after all of that is done does it reset the registry.

This means while it does fix up the registry caches (`field_depends`
and `field_triggers`) as it goes, resetting those may cause the
recomputation of fields whose columns have been deleted, possibly
based on dependencies whose columns have also been deleted.

As such these kinds of manipulations should either be performed in
`@ondelete` methods which don't get executed during uninstallation, or
they should be gated behind an uninstallation check.

In crm the latter is necessary, as `ondelete` runs before `unlink`
actually executes, and the registry reset would run too early (and
unnecessarily).

In base, only the latter is possible as we're not in `unlink` itself,
instead `IrModelFields._prepare_update` is called *during*
uninstallation and its trailing `setup_models` causes the issue.

closes odoo/odoo#119606

Related: odoo/enterprise#40284
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

When modules get uninstalled, first the uninstall process will drop
all the fields (removing all the columns) then it drops all the
models (removing the tables).

When uninstalling mail, this means the various (res_)model(_id) fields
don't exist anymore by the time we're deleting models, so the queries
blow up.

Skip this step if we're unlinking the mail models, it means the tables
have already been dropped, so there's nothing to delete anymore. This
should not use `ondelete` because we *do* want to delete records from
those tables when deleting modules which depend on mail, and thus have
mail stuff associated with their own models which we're deleting.

Part-of: odoo/odoo#119606

Confusion between uninstall hooks can apparently trigger errors during
uninstallation as two hooks can confuse one another?

In this here case, the issue triggered during the uninstall hook of
`account_accountant`, which apparently combines with the uninstall
hook of `industry_fsm_sale` to trigger an invalid in-memory state for
`project_project`. An implicit flush during the hook then blows up
with a check constraint error.

Flushing at the end of the `industry_fsm_sale` hook or at the start of
the `account_accountant` hook fixes the issue, so might as well flush
after each hook to ensure whatever they did using models is pushed to
the database and in good shape (hopefully).

Part-of: odoo/odoo#119606

[1] hides the length UoM if the package is related to a specific
carrier (BPost, Fedex, etc). However, there will still be an issue when
the carrier is not defined: if the length UoM of the database is `ft`,
so will the length UoM of the package type. Moreover, the dimensions
fields are integer:
https://github.com/odoo/odoo/blob/b1012175393ca5612899c1a0f1d3803ed8d4fe94/addons/stock/models/stock_package_type.py#L19-L21


As a result, it will be impossible for a user to encode a package type
with a length equal to 10in

[1] 9250accb

OPW-2865471

closes odoo/odoo#119519

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Problem: When the user installs Inventory and uninstalls it,
the Inventory Valuation journal still exists in the database.
The user is unable to re-install Inventory
if the database not in English.

Example: Client's db is in Spanish
In method "_configure_journals" ,
it searches for the Inventory Valuation journal based on the name translated in Spanish.
However, the journal "Inventory Valuation" is not translated to Spanish in the database.
Therefore, no journal would be found
and an error "Journal codes must be unique per company" will be thrown
because it will try to create another "Inventory Valuation" journal with code  'STJ'.

Solution:
Since journal codes have to be unique, it is more logical to search for an
existing journal based on its code instead of the name
since it is possible to have multiple journals with the same name but different codes.

opw-3277498

closes odoo/odoo#119023

X-original-commit: 680ff54c
Signed-off-by: Tiffany Chang <tic@odoo.com>

In sentry we receive like 2k syncing issue from google_calendar.

This commit converts `_logger.error` to `_logger.warning` because we don't
need an erro for that

sentry-4121123364
https://online.sentry.io/issues/4121123364



closes odoo/odoo#119616

Signed-off-by: Arnaud Joset <arj@odoo.com>

Steps to reproduce:

- Install `E-learning` module
- Create a user X with only "Officer" as rights for `E-learning`
- Login with user X
- Go to `E-learning` and open any course
- Ensure that the user X is not the responsible and that the course
  enroll policy is set to "On invitation"
- Invite any user not already a member

Issue:

  No user was invited (not added as member) and no warning message
  raised.

Cause:

  Due to the ir.rule "Channel: officer: create/write own only", the
  `Officer` user can only edit (and therefore invite members) on
  courses where he is responsible.

Solution:

  In the wizard, we check if the user has the rights to invite members
  on the course when sending the invitation. If not, we raise an error.

opw-3133733

closes odoo/odoo#119607

X-original-commit: d341efaf
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

Create 3 invoices for customer (A: $100, B: $300, C: $200)
Have a customer payment of $500
Reconcile the payment, in the widget add the line in the order:
- Payment line
- Invoice A
- Invoice B
- Invoice C (partial payment)
Reconcile
Check invoices

Issue:
C will be fully paid, the partial payment will be applied to B
After 5b2c1d24
We order the lines by amount currency but the user provided order is
lost. Moving the original fix to point of sale

opw-3240586

closes odoo/odoo#119477

Related: odoo/enterprise#40173
Signed-off-by: William André (wan) <wan@odoo.com>

Description of the issue/feature this PR addresses:
In project module, when sub-tasks is created then recurrence boolean field
should not be visible in that task. It only visible in parent tasks.

Current behavior before PR:
recurrence field is visible in sub-tasks.

Desired behavior after PR is merged:
recurrence field is not visible in sub-tasks.

task-3252521

closes odoo/odoo#118561

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Before this commit:
When uploading a file, if the transaction fails due to a serialization
failure, Odoo will retry the request. However, if a file upload is read
during the transaction, the file pointer will be at the end of the file,
and calling `.read()` again returns an empty bytes object.

After this commit:
Upon retrying the request, rewind uploads to the beginning of the file,
if the file supports it.

opw-3228200

closes odoo/odoo#119613

X-original-commit: a856c465
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Signed-off-by: Walravens Mathieu (wama) <wama@odoo.com>

Steps to reproduce:
- put the currency of the bill to eur
- change the partner with a partner with no purchase currency set

Issue:
The bill is re-set to usd

Note:
addendum to https://github.com/odoo/odoo/pull/116852



opw-3233527

closes odoo/odoo#119624

X-original-commit: 647e289c
Signed-off-by: Cedric Snauwaert <csn@odoo.com>
Signed-off-by: Yolann Sabaux (yosa) <yosa@odoo.com>

Before this commit:

When using shift+enter to move to a new line, now applying bold, italics,
underline, etc and then trying to add a color to both lines would result in
lines merging.

After this commit:

Now when the both lines are bold and then applying a color to both the lines
would no longer merge.

closes odoo/odoo#118698

Task: 3269922
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Previously, LinkDialog always focused on the first editable input field.

This commit introduces a new option in the LinkDialog constructor,
`focusField`, that allows to designate a specific field to focus on.

This option is now used to focus on the second editable input field when
the first one is already filled (for example, from the user selection).

task-3224551

closes odoo/odoo#116555

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

When we try to import bank statement CSV file with all required columns and
set the encoding format as koir8_r we get (ValueError: Unsupported file format
text/csv, import only supports CSV, ODS, XLS and XLSX) this error.

steps to reproduce:
    1. Go to accounting and then import bank statement.
    2. Select a csv file to import with all required columns.
    3. Set Encoding format as koir8_r and then click on 'TEST' or 'IMPORT'.
    4. The error will occur.

see this traceback: https://tinyurl.com/24bxk7bt



Applying this commit will fix this issue.

sentry-4049996747

closes odoo/odoo#118615

Signed-off-by: Achraf <abz@odoo.com>

Steps to reproduce:

  - Install 'CRM' module (for test purpose)
  - Configure the google calendar credentials on Odoo
  - Go to CRM -> Configuration -> Activity Types and create a new one
  - Set 'Meeting' as Action
  - As default note, add some bullet points:
    ```
    Hello :
      - First point
      - Second point
      - Third point
    ```
  - Open any Opportunity and create a new Activity (in the chatter)
  - Select 'Meeting' as activity type and open the calendar
  - Add a new event (description should be field with the default note)
  - Open the event (on Odoo and/or Google Calendar)

Issue:

  The description of the event is broken (bullet points missing).

Cause:

  When syncing the event from Odoo to Google Calendar, the description
  is converted to plain text (using `html2plaintext` function).
  Then, when syncing the event from Google Calendar to Odoo,
  the description is also updated locally with the remote one.

Solution:

  Don't convert the description to plain text but use
  `tools.html_sanitize` on the html content instead to sanitize it.

opw-3105194

closes odoo/odoo#115304

Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>

In Switzerland, it is mandatory, when a QR bill is printed, to use a line to separate both the QR part from the rest of the page and, within the QR zone, the receipt from the payment part.

This was done using dotted lines on the bill.

However, while generating the PDF caused no problem, the snailmail provider can't print the bottom, far left and far right borders since those are outside of the printing zone.

After further research it does however seem that those are not mandatory, unlike the two separations aforementioned.

Removed those to allow for snailmail printing.

opw-3223714

closes odoo/odoo#119524

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>

closes odoo/odoo#119018

Signed-off-by: Josse Colpaert <jco@odoo.com>

Steps to reproduce the issue:

- Open a website page in edit mode.
- Drag and drop several snippets onto the page.
- Add a 'Fade In Right' animation to an element on the page.
- Exit edit mode.
- Change the website language to Arabic to display the scrollbar on the
left.
- Test the animation.
- Bug: the scrolling (using the mouse wheel) becomes stuck or very slow
during the animation.

The issue only occurs with Chrome or Edge browsers and seems to be a
browser display issue. It happens only when animated elements overflow
to the left.

This commit fixes the problem by adding an 'overflow: hidden' to the
main element during RTL page animations. This is not the best solution
because the animated elements become non-visible outside the main
element, creating a difference, for example, with the 'Framed' page
layout.

opw-3260399

closes odoo/odoo#118892

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Reproduction:
1. Create a 1 by 3 table, input something in the first cell
2. Go to the second cell, hit backspace
3. The second cell is deleted and the third cell is moved to the second
cell

Note: in 15, we don’t have the table selector to remove a row of the
table but that is another issue

Fix: when we try to delete the table cell and the offset is 0, nothing
should be done. Also added a test to make sure the cell is unchanged
when we try to delete in an empty cell which has a cell with content
at the left. Also we skip the rejoin block step if there's a table cell
element is invoivled because the cells are not deleted and rejoining
them is not needed

Task-3171904

closes odoo/odoo#114895

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

In some situation, Chrome "loses" an already loaded lazy-loaded image
when it is moved across nodes in the DOM. This typically happens when
wrapping an image inside a link.
Note that the DOM is actually correct: if the page is saved it then
displays it correctly.

This commit detects if this problem happens when adding a link on an
image, and forces Chrome to re-display the image by re-specifying its
`src` attribute. No alternative solution was found.

Steps to reproduce:
- Use a brand new incognito Chrome window. (Make sure you closed any
previously opened incognito Chrome window before)
- Drop a "Text - Image" snippet.
- Save.
- Edit.
- Select image.
- Press "CTRL+K".
=> The image was not displayed anymore.

task-2962619

closes odoo/odoo#98889

closes odoo/odoo#118432

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

There was an issue before this commit where some flags (basically all
the ones which are not tribands) would appear "broken".
This is the case for the China one where the symbol on the flag would be
squashed.
Using `object-fit` css property will keep the original flag ratio.

task-2929438

closes odoo/odoo#119547

X-original-commit: 32aca111
Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Some tags were not correct on taxes
IVA 0%.

closes odoo/odoo#119401

X-original-commit: 3ac980d4
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>

Before this PR with a malformated pdf with factur-X, it raise.
It should not raise.

closes odoo/odoo#119478

X-original-commit: 87b0c19b
Signed-off-by: William André (wan) <wan@odoo.com>

We can send service product details if there are any one goods in the Invoice.

task - 3276398

closes odoo/odoo#118871

Signed-off-by: Josse Colpaert <jco@odoo.com>

The new datepicker doesn't work properly with date formats using dots or
commas

Steps to reproduce:
1. Install Sales
2. Set the language date format to `%m.%d.%Y` and refresh the page
3. Open Sales and trigger the pivot view
4. Add a custom filter on field 'Delivery Date'
5. Click on the date to change it, the format changes
6. Try to enter a date, it is incorrectly parsed

Solution:
Add dot and comma as a possible character for static format

Problem:
Formats using dots were not considered as valid static format so the
value entered was parsed with the format `yyyy/MM/dd` instead

Partial backport of https://github.com/odoo/odoo/commit/5f17d8974652f9606cb57f909c143d15046f1854



opw-3222468

closes odoo/odoo#119235

Signed-off-by: Bruno Boi (boi) <boi@odoo.com>

Backport: https://github.com/odoo/odoo/pull/117343



__Current behavior before PR:__
The size of an image field is guessed using the field name. For instance, an image field with `field_name = "XXXX_123"` is resized to 123 pixels when fetched. This is can be an issue if a user creates an image field using studio in a form view. If the user sets the label of the field as "Image 1", the technical name will become `x_studio_image_1`. Therefore, the image field will be resized to 1 pixel width.

Note that in version anterior to 16, only the placeholder is resized since `image_guess_size_from_field_name` is never called when there is an actual image.

__Description of the fix:__
Refactor the `image_guess_size_from_field_name` method to return `(0, 0)` when the field name starts with `x_`.

closes odoo/odoo#118963

X-original-commit: c1d7eab2
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Current behavior:
If you add a sale description to a product, it will not be added to the
invoice created from the PoS.

Steps to reproduce:
- Add a sale description to a product
- Create a PoS order with this product
- Create an invoice from the PoS order
- The sale description is not added to the invoice

opw-3221481

closes odoo/odoo#118774

X-original-commit: fcf0fe54
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Heinz Robin (rhe) <rhe@odoo.com>

Like here https://github.com/odoo/odoo/blob/14.0/addons/payment/views/payment_templates.xml#L69

, if the acquirer have display_as, it is more logical to shpw everywhere this field.

closes odoo/odoo#119432

X-original-commit: 280454b0
Signed-off-by: Valentin Chevalier <vcr@odoo.com>

Before this commit, since https://github.com/odoo/odoo/pull/119014,
the audio context could be closed when already.

Until the implementation of AudioContext.state*, we have to catch the
error.

This commit also removes the forwarding to the destination that was
not necessary.

`* https://webaudio.github.io/web-audio-api/#widl-AudioContext-state



closes odoo/odoo#119392

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

For now, the sale margin is incorrectly computed in group by in the sales order.

This was done in the sales order lines in abdb85fb

opw-3180556

closes odoo/odoo#119378

X-original-commit: 09792602
Signed-off-by: Morgane Demesmaeker <edm@odoo.com>

Reproduction:
1. Create a /checklist, switch the direction by /swith
2. Type something and the list element is rtl, but the checkbox is on
the left

Fix: add margin to the right for checklist with the same value as what
we have on the left, reset left and right position for the li element
when we have rtl direction on the whole list. When we switch direction
on a li element when set the direction on the list level, e.g. we get
the cloest list element and set the direction for the whole list.

opw-3215701

closes odoo/odoo#115634

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

The Scheduled Date field is in readonly depending on the MO state, but
the `close` state does not exist, use the `done` state instead to match
the decoration-* attributes

closes odoo/odoo#119304

Signed-off-by: Adrien Widart <awt@odoo.com>

When the navbar hamburger type option is set to 'off-canvas', the 'call
to action' button of the 'boxed' header is located "next to" the navbar
instead of "in" the navbar as it should be.

This commit puts the 'call to action' button in the navbar when the
'off-canvas' menu is opened.

task-3063878

closes odoo/odoo#119105

X-original-commit: 54e58b3e
Signed-off-by: Bojabza Soukéina (sobo) <sobo@odoo.com>

Before this commit, when hovering the shopping cart in the "Boxed" and
"Centered Logo" header templates, the cart popover was not appearing.

This happened because the `websiteSaleCartLink` public widget was never
started with these templates and so, hovering the cart had no effect.
This is due to this widget selector which targeted a cart link located
inside an element with id `#top_menu`, which is not the case in these
templates where the cart link is located outside of it.

This commit fixes this widget selector, in order for the cart link to be
reachable in all header templates.

opw-3267114

closes odoo/odoo#119237

X-original-commit: ecefa679
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Bojabza Soukéina (sobo) <sobo@odoo.com>

The current view replaces the existing groups attribute of the inventory
page in the product template form view with two specified groups (with
only one of these groups being newly introduced in stock).

This commit changes the product view to utilise an xpath that adds the
single new group (stock.group_stock_user), instead of replacing the
content of the attributes.

closes odoo/odoo#119223

X-original-commit: 43c888bb
Related: odoo/enterprise#40085
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Signed-off-by: Daniel Kosky (dako) <dako@odoo.com>