Skip to content
Snippets Groups Projects
  1. Nov 29, 2022
  2. Nov 28, 2022
    • qsm-odoo's avatar
      [FIX] website: stop showing CSS variable assertion tour step to users · 696c45b4
      qsm-odoo authored
      Commit [1] introduced a website tour util to assert the value of a CSS
      variable. This was used at the start of theme tours to check we are in
      fact on the right theme before starting the tour.
      
      While it's great for those tours when they are started as a test, it was
      not meant to be shown to users following that tour. This commit fixes
      that. Notice that theme tours are currently broken so the issue was
      probably hidden. Those will be fixed at [2].
      
      [1]: https://github.com/odoo/odoo/commit/b29e17765f4e912b2dd472493b5be500b3a32c87
      [2]: https://github.com/odoo/odoo/pull/106703
      
      
      
      Related to task-3084175
      
      closes odoo/odoo#106725
      
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      696c45b4
    • qsm-odoo's avatar
      [FIX] website: properly flag website test tours as test tours · 101d83d4
      qsm-odoo authored
      Commit [1] and [2] introduced test tours but did not mark them as test
      tours properly, thus showing them to users (who are in debug=tests mode)
      by mistake.
      
      Note that [2] was silently fixed in the 16.0 forward-ported version...
      that is why nothing shows up in this diff starting from 16.0.
      
      [1]: https://github.com/odoo/odoo/commit/7655bface7f9e9bae8579e14e9a87b4f4801cc33
      [2]: https://github.com/odoo/odoo/commit/a0c33c5f896718d1c03a6a50c981d6d75ce0d169
      
      
      
      closes odoo/odoo#106689
      
      X-original-commit: 11d023f0
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      101d83d4
    • Ivan Yelizariev's avatar
      [FIX] base,web: fix address widgets in reports for RTL · a63f616c
      Ivan Yelizariev authored
      Address widget has `o_force_ltr` class [1] since Odoo 14 [2]. Somehow, it didn't
      work in Sale Order report and everything was RTL. But since Odoo 16 address part
      actually became LTR. It mixes things up, because partner name and phone number
      in the billing/delivery sections is still RTL [0].
      
      This commit fix it by forcing whole address block to LTR. Alternative solution
      could be removing `o_force_ltr` class, but this approach looks more risky and
      should be done in master instead.
      
      [0]: opw-3053457
      
      [1]: https://github.com/odoo/odoo/blob/1666ee5515996fab8a843b36b4fd93b776172f75/odoo/addons/base/views/ir_qweb_widget_templates.xml#L26
      
      [2]: https://github.com/odoo/odoo/commit/5b7c3805a045d8824dd1b4fa0de07d90b17392c1
      
      
      
      closes odoo/odoo#106695
      
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      a63f616c
    • Antoine Dupuis (andu)'s avatar
      [IMP] account: Change 'Miscellaneous' menu to 'Journals' · ee551d74
      Antoine Dupuis (andu) authored
      
      In Odoo 16, we redesigned the `Accounting > Miscellaneous` menu to
      provide a convenient interface for inspecting any journal entry or
      journal item.
      
      As such, it no longer makes sense to call it 'Miscellaneous'.
      
      This commit aligns the name with the new functionality.
      
      We also remove the default filter of the 'Journal Entries' view, which
      restricted it to miscellaneous entries, and replace it with a filter
      on posted entries, consistent with the purpose of conveniently
      inspecting the accounting journals.
      
      closes odoo/odoo#106687
      
      Task: 3083921
      Signed-off-by: default avatarBrice Bartoletti (bib) <bib@odoo.com>
      ee551d74
    • niyasraphy's avatar
      [FIX] sale_expense_margin: remove duplicated if condition · 63c85bf2
      niyasraphy authored
      
      closes odoo/odoo#106644
      
      Signed-off-by: default avatarKevin Baptiste <kba@odoo.com>
      63c85bf2
    • Antoine Guenet's avatar
      [IMP] web_editor: align editor columns with editable bounds · fb55f688
      Antoine Guenet authored
      
      Columns added with the "columns" Powerbox commands should be aligned
      with the editable element's bounds.
      
      task-3001988
      
      closes odoo/odoo#105208
      
      Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
      fb55f688
    • Younn Olivier's avatar
      [FIX] web_tour: fix the tooltip content font-size · 8703c01d
      Younn Olivier authored
      Before this commit, the tooltip content of a tour had a font-size set in
      rem. As its container dimensions were computed using the root element
      font-size, these dimensions were not correct if the tip was inserted in
      a document with another root element font-size.
      
      This was leading to a bug after [1] added an iframe to edit the website:
      the backend and frontend root elements font-size are different and the
      containers of tips targeting frontend elements were clipped.
      
      This commit fixes the tooltip content font-size in px (with the
      font-size used to compute the container dimensions), so that it can be
      placed in iframes with a different root element font-size.
      
      [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b
      
      
      
      task-3035156
      
      closes odoo/odoo#104039
      
      Signed-off-by: default avatarQuentin Smetz (qsm) <qsm@odoo.com>
      8703c01d
    • Younn Olivier's avatar
      [FIX] website_slides: fix slides_tour · 4f463092
      Younn Olivier authored
      Before this commit, the main website_slides tour, slides_tour, was
      broken after [1] introduced the WebsitePreview client action.
      
      This commit adapts it to work with an iframe.
      
      [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b
      
      task-3035156
      
      Part-of: odoo/odoo#104039
      4f463092
    • Younn Olivier's avatar
      [FIX] website: fix the homepage tour · d45ce39b
      Younn Olivier authored
      
      Before this commit, the website homepage tour was starting with an
      unresolvable "Wait for the editor to be started", useful only for tests.
      
      This commit removes that technical step for user tours.
      
      task-3035156
      
      Part-of: odoo/odoo#104039
      Co-authored-by: default avatarqsm-odoo <qsm@odoo.com>
      d45ce39b
    • qsm-odoo's avatar
      [FIX] website: hide backend navbar tour tips when entering edit mode · cdc8d4c8
      qsm-odoo authored
      When entering edit mode, the navbar is hidden. The problem is that since
      the merge of the website-in-backend feature at [1], it is only not shown
      via an animation (height 0 + out of screen) but not `display: none`. The
      tour system thus thinks it is still shown and keeps showing the related
      tour tips.
      
      E.g. with website_sale installed (and no demo data, to have the tours),
      go on the shop page, there is a tooltip pointing at "+ New", enter edit
      mode => the tooltip is still there and it even prevents to click on
      "Discard" to leave the edit mode.
      
      This commit fixes the issue by making the navbar `display: none` once
      the closing animations are finished.
      
      [1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b
      
      
      
      task-3082439
      
      closes odoo/odoo#106629
      
      Signed-off-by: default avatarRomain Derie (rde) <rde@odoo.com>
      cdc8d4c8
    • qsm-odoo's avatar
      [FIX] website: allow to exit fullscreen if not on website anymore · bd225ec7
      qsm-odoo authored
      While showcasing your website inside the website application, there is
      the possibility to hit the escape key to enter fullscreen (hiding the
      backend navbar outside edit mode and the editor panel during edit mode).
      
      There was a problem following this flow:
      
      - Go to your website inside your website app
      - Hit escape to enter fullscreen
      - Press CTRL-K to switch to another part of the backend
      => You are now somewhere in the backend, without the navbar (fullscreen)
         and you cannot exit it.
      
      As it was a one-line fix (except for the re-indentation), this commit
      now allows to exit fullscreen mode wherever we are.
      
      Discovered during task-3082439
      
      Part-of: odoo/odoo#106629
      bd225ec7
    • shsa-odoo's avatar
      [FIX] mass_mailing: should not crash when loading snippets · 634f6ae4
      shsa-odoo authored
      
      Current behavior before fix:
      
      In mobile view when we click invite button on events module which loads the
      snippet, at that time there was a traceback.
      
      Desired behavior after fix:
      
      Now the snippet gets loaded without any traceback.
      
      Task-2994261
      
      closes odoo/odoo#101238
      
      Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
      634f6ae4
    • Romeo Fragomeli's avatar
      [FIX] web: titles are smaller in reports · 76299a8d
      Romeo Fragomeli authored
      
      Since the Bootstrap 5 migration the "headings" `<h1>`, `<h2>`, ... are
      smaller than before.
      
      This commit, restores the old CSS rules from Bootstrap 4 for reports.
      
      Steps to reproduce:
      * Open Sales
      * Select a quotation
      * Print the Quotation (using Print dropdown) => BUG title is smaller
        than the old version of Odoo (e.g. Odoo v15)
      
      closes odoo/odoo#106668
      
      Signed-off-by: default avatarAdrien Dieudonné (adr) <adr@odoo.com>
      76299a8d
    • Samuel Degueldre's avatar
      [FIX] web: make originalError the root of the error chain · dd6f103b
      Samuel Degueldre authored
      
      Previously, when calling error handlers, we would give them a new error
      created by the error service, as well as an `originalError` which is the
      error that was caught by the error service. In some cases, this error is
      part of an error chain, eg: errors that happen in the owl lifecycle are
      wrapped in an `OwlError`, so that when an error occurs in a callback
      passed to a lifecycle hook, the position where the hook was called to
      register the offending callback is part of the stack trace.
      
      In practice, most error handlers only care about the error that caused
      the entire error chain (the root) when deciding whether they should
      handle the error or not, eg: an RPCError should be handled by the rpc
      error handler, regardless of whether it occured in an event handler or
      in a component's willStart. It already reads the traceback to display on
      the UncaughtError provided by the error service as this traceback
      contains the entire error chain stack information and is annotated with
      source maps by the error service.
      
      This commit makes it so that the `originalError` passed to handlers is
      now the root of the error chain, it also sets the `cause` of the
      UncaughtError which is passed to handlers as the error that was caught
      by the error service, so that if a handler needs to inspect the error
      chain to know whether it can handle the error or not, it can still do
      that.
      
      related to OPW-3069633
      
      closes odoo/odoo#106661
      
      Signed-off-by: default avatarMichaël Mattiello <mcm@odoo.com>
      dd6f103b
    • Kevin Baptiste's avatar
      [FIX] hr_holidays: take full day leaves on Day view · 1ea102d4
      Kevin Baptiste authored
      
      The default hours of a time off created from the Day view would be the
      range of hours that was selected in the calendar view, thus resulting in
      leaves of half an hour.
      
      closes odoo/odoo#106567
      
      X-original-commit: 5155f654420433176abde675bedc4afeeeb45a1c
      Signed-off-by: default avatarKevin Baptiste <kba@odoo.com>
      1ea102d4
    • Julien Van Roy's avatar
      [FIX] {l10n_}account_edi_ubl_cii{_tests}: handle price_include taxes · 7f93f72a
      Julien Van Roy authored
      
      In Factur-X, there is no way to represent a tax "price_include" because
      every amounts should be tax excluded.
      
      Currently in Factur-X, a line with a tax price_include = True will be
      incorrectly exported. Indeed, the Factur-X.xml is generated by setting the
      GrossPriceProduct as the price_unit. In Factur-X, this amount (and the others
      in the line details) should be tax excluded. Thus, it's wrong to set the
      GrossPriceProduct as the price_unit.
      
      To fix this, the GrossPriceProduct should be the price_unit if no tax
      price_include = True is set, otherwise, the gross price = price_unit/(1+tax/100).
      
      This way, the Factur-X file will be consistent with the norm.
      
      Note that the import of a Factur-X xml will thus try to pick taxes with price_include = False,
      and the price_unit will be tax excluded. If no matching tax with price_include = False is
      retrieved, a tax with price_include = True is searched, if found, the price_unit is
      recomputed accordingly. In both cases, the lines subtotals are the same.
      
      opw-3032382
      
      closes odoo/odoo#106563
      
      X-original-commit: 9a5ba15c
      Signed-off-by: default avatarWilliam André (wan) <wan@odoo.com>
      Signed-off-by: default avatarJulien Van Roy <juvr@odoo.com>
      7f93f72a
    • Tommy (tong)'s avatar
      [FIX] delivery: unit test · a1afad5a
      Tommy (tong) authored
      
      closes odoo/odoo#106161
      
      X-original-commit: 0ac1fd90
      Signed-off-by: default avatarArnold Moyaux (arm) <arm@odoo.com>
      a1afad5a
    • Romeo Fragomeli's avatar
      [FIX] web: kanban: quick create column text wrapped · 62b692b6
      Romeo Fragomeli authored
      
      In kanban view, the columns are in a flex container and as there is no
      specific flex rules on the quick create column and is shrink by
      default. So when the new column is above the edge of the viewport, it
      starts to shrink.
      
      To avoid this bug we have added the same flex rules has the kanban
      column.
      
      Steps to reproduce:
      * Open Note
      * Create many new column => BUG text wrapped when the new column reach
        the width of the viewport.
      
      closes odoo/odoo#106549
      
      Signed-off-by: default avatarPierre Paridans (app) <app@odoo.com>
      62b692b6
    • Patrick Hoste's avatar
      [FIX] mass_mailing: fix unsubscription_date when opt_out on create · e7c22094
      Patrick Hoste authored
      
      Before this commit when creating a mailing contact with a mailing
      list opt_out at creation the unsubscription_date wasn't set.
      Indeed, from the mailing contact view the mailing list uses an
      editable list that passes all the values at create even when not set
      contrary to when one update the contact only the changed values are
      passed. This commit fix this issue.
      
      Task-3070852
      
      closes odoo/odoo#106260
      
      X-original-commit: d6758919
      Signed-off-by: default avatarWarnon Aurélien (awa) <awa@odoo.com>
      Signed-off-by: default avatarHoste Patrick (pko) <pko@odoo.com>
      e7c22094
    • Nicolas Bayet's avatar
      [FIX] web_editor: check method addNeutralStyle · 065d3dc3
      Nicolas Bayet authored
      
      Because of css limitation, the child of a parent that define a
      text-decoration cannot "neutralize" that decoration defined by its
      parent with a css property (ie. the text-decoration cannot be
      overridden).
      
      When a block define an inline style or any tag that have a class, the
      method `formatSelection` tries to "neutralize" the style by calling
      `addNeutralStyle`. As it is impossible to "neutralize" the style for
      underline nor strikeThrough, there is no method `addNeutralStyle`
      defined for those properties.
      
      Before this commit the method `formatSelection` was crashing because
      `addNeutralStyle` was not defined.
      
      Task-3002123
      
      closes odoo/odoo#106632
      
      X-original-commit: ce068a31
      Signed-off-by: default avatarDavid Monjoie (dmo) <dmo@odoo.com>
      065d3dc3
    • Jérôme Hellinckx's avatar
      [FIX] purchase_stock: avoid PO exception propagation to DONE receipts on less received quants · 32e8fae2
      Jérôme Hellinckx authored
      
      Before this commit:
      1. Create PO with quantity 10, confirm (creates receipt-1)
      2. Receive 2 quantities on first receipt (receipt-1), backorder (receipt-1 is 'done', creates receipt-2)
      3. Receive 3 quantities on second receipt (receipt-2), backorder (receipt-2 is 'done', creates receipt-3)
      4. Change quantity to 5 in PO
      5. An exception is created on all receipts (1, 2 and 3)
      
      In the scenario above, receipt-1 and receipt-2 are partial receipts that are set to 'done'.
      It is not necessary to create an exception in these receipts when the quantity is changed to less than originally expected in the PO.
      Since the system checks that the new quantity has to be equal or greater than the received quantities, the already received quantities cannot be impacted.
      
      After this commit:
      The exception is only propagated to the receipts that are not done.
      e.g. in the example above, an exception appears only in receipt-3.
      
      task-2648209
      
      resolves #76297
      
      closes odoo/odoo#106627
      
      X-original-commit: d6fad232
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      32e8fae2
    • Florent de Labarre's avatar
      [FIX] stock: impossible to search correctly location · 55729e2b
      Florent de Labarre authored
      
      Before this PR Odoo don't pre-search on location.
      
      closes odoo/odoo#106604
      
      X-original-commit: 71a3b5b2
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      55729e2b
    • niyasraphy's avatar
      [FIX] lunch: timezone field alignment in alert form view · 4b0efa70
      niyasraphy authored
      
      closes odoo/odoo#104664
      
      Signed-off-by: default avatarYannick Tivisse (yti) <yti@odoo.com>
      4b0efa70
    • Jinane Maksoud's avatar
      [FIX] mrp: fix the filter order in _bom_find_domain · 2203f27a
      Jinane Maksoud authored
      
      Only active boms should be returned by the domain even if
      they match a product id.
      
      closes odoo/odoo#106608
      
      X-original-commit: 2a73890d
      Signed-off-by: default avatarWilliam Henrotin (whe) <whe@odoo.com>
      2203f27a
    • Donatas's avatar
      [IMP] website_sale: adds search_product to shop values · 63a18275
      Donatas authored
      
      closes odoo/odoo#106606
      
      X-original-commit: 3772da47
      Signed-off-by: default avatarWilliam Braeckman (wbr) <wbr@odoo.com>
      63a18275
    • Lucas Lefèvre's avatar
      [FIX] spreadsheet: update o_spreadsheet to latest version · 5c566918
      Lucas Lefèvre authored
      ### Contains the following commits:
      
      https://github.com/odoo/o-spreadsheet/commit/f83585f2
      
       [FIX] InternalViewport: compute the actual visible rect of a zone
      
      closes odoo/odoo#106578
      
      Signed-off-by: default avatarPierre Rousseau (pro) <pro@odoo.com>
      5c566918
    • Lucas Lefèvre's avatar
      [FIX] spreadsheet_dashboard_hr_expense: remove wrong dependency · 46636f23
      Lucas Lefèvre authored
      
      Module `spreadsheet_dashboard_hr_expense` depends on `hr_expense`
      but uses the field `sale_order_id` which is only introduced with
      `sale_expense`.
      `spreadsheet_dashboard_hr_expense`'s dependencies are wrong.
      
      To fix the issue:
      
      1) we remove references to `sale_order_id` in `spreadsheet_dashboard_hr_expense`.
      Note that it won't be applied to existing databases. The spreadsheet would
      need to be updated "by hand" by deleting the cells, the filter and the pivot
      object.
      
      2) we introduce a new auto_install module with the correct dependencies to restore
      the current dashboard.
      
      On the master branch, `spreadsheet_dashboard_hr_expense`'s
      dependencies is correctly changed to `sale_expense` by odoo/odoo#105148
      
      closes #103899
      
      closes odoo/odoo#104125
      
      Signed-off-by: default avatarRémi Rahir (rar) <rar@odoo.com>
      46636f23
    • Valentin Vallaeys (vava)'s avatar
      [FIX] product,web: color_field fixes for product variant color · c67c32c2
      Valentin Vallaeys (vava) authored
      
      There was a typo in the color_field xml not allowing to disable the
      pop-up in case of readonly. A test validates the feature is active.
      
      The color_field now displays the transparent symbol (instead of black
      color) in case the color is undefined.
      
      The product configurator also displays the transparent symbol for
      undefined non-custom colors.
      
      task-3013110
      
      closes odoo/odoo#103478
      
      Signed-off-by: default avatarVictor Feyens (vfe) <vfe@odoo.com>
      c67c32c2
    • Kartik Chavda's avatar
      [FIX] hr_timesheet: fix searching on is_project_overtime field · cbd091cb
      Kartik Chavda authored
      
      Before this commit Projects in overtime filter does not return
      project as expected after project has allocated hours to set
      on then.
      
      This commit fixes by taking allocated hours into account to
      search for project that are in over time.
      
      task-3000817
      
      closes odoo/odoo#106428
      
      X-original-commit: a6d652a85a428a28d3d6eab25e591c08809c2a34
      Signed-off-by: default avatarLaurent Stukkens (ltu) <ltu@odoo.com>
      cbd091cb
    • dbkosky's avatar
      [ADD] l10n_ke_edi_tremol: KE fiscal device · b0be9e07
      dbkosky authored
      
      This module implements communication with the fiscal device for
      submitting invoices to the KRA (Kenya Revenue Authority). The device
      supported in this module is the Tremol G03.
      
      -- COMMUNICATION FLOW SUMMARY --
      1. "Send Invoice To Device" on account move is clicked
      2. l10n_ke_action_cu_post triggers a client action, with serialised
         invoice data. (more details below)
      3. The client action uses the 'post_send' function defined in javascript
         to forward the request to the /hw_proxy/l10n_ke_cu_send endpoint on
         the proxy server (more details below)
      4. The proxy server wraps the serialised data with the appropriate bytes
         (for instance, a couple of a checksum bytes), and sends them to the
         device through serial communication (more details below)
      5. The data returned from the fiscal device is communicated back in the
         request. The client action 'post_send' then triggers the
         'l10n_ke_cu_response' with an rpc call, with the aforementioned data
         from the fiscal device
      
      (more details)
      2. The module l10n_ke_edi_tremol inherits from the account_move model in
      order to provide methods for serialising the data of the account_move
      and sending it to the proxy server. Fields have been added to the
      product template to define the HS Code and HS Name (data which is
      required by the KRA in some circumstances). A field has also been added
      to the company defining the address of the proxy server. The fields
      added on the account move are populated by the data returned by the
      fiscal device, this includes the device serial number, the invoice
      number on the device, the URL of the invoice on the KRA web portal, and
      the date/time the invoice was signed.
      
      3. Communication between the client database and the proxy server is
      defined using a client action defined in
      l10n_ke_edi_tremol/static/src/js/send_invoice.js. This allows users who
      aren't on-premise to communicate with the device, provided the proxy is
      accessible on the network that the user is on.
      
      4. The proxy server is an intermediary server that should be connected
      to the tremol G03, and running the IOT drivers from hw_drivers. The
      driver that supports communication between the proxy server and the
      fiscal device has been defined in this commit inside of
      hw_drivers/iot_handlers/drivers//L10nKeEDISerialDriver.py.
      The proxy server can be run on the IOT box, or on odoo community by
      running:
      ./odoo-bin addons-path=.... -d dbname --load hw_drivers --proxy-mode
      
      ** all messages are encoded/decoded with cp1251, as defined in the
      protocol. The company vat code is sent along with the request to compare
      that sent with that of the device. The 'serial_number' of the device is
      always returned along with the request, since it is required for the
      invoice details, and it is retrieved as part of the query to find the
      registered VAT code on the device.
      
      --- DATA and VIEWS ---
      product_view:
      adds HS Name, and HS Code on the product product and product template
      form views.
      
      report_invoice:
      adds to the invoice qweb template such that a section including the
      fiscal device / KRA details is included at the bottom of the invoice
      when the invoice is rendered as a pdf.
      
      res_config_settings_view:
      adds makes the proxy address field editable from the config settings.
      
      account_move_view:
      add a tab for the tremol device details and the qr code on the account
      move form view. The KRA invoice number is also added as an optional
      field on the account move tree view, and the invoice search view is
      inherited to make this field searchable too.
      
      (l10n_ke) account_tax_report_data, account_tax_template_data:
      The tax report is defined for Kenya, and tax tags that link to the lines
      on this tax report are defined on the existing taxes. This allows the
      classification of the tax, between zero-rated and exempt, during the
      serialisation.
      
      closes odoo/odoo#106653
      
      Task-id: 2950308
      Signed-off-by: default avatarJosse Colpaert <jco@odoo.com>
      b0be9e07
  3. Nov 27, 2022
Loading