Complement of this commit 7d7c53ed
because added records were missed during fw-port.

opw-2862296
opw-2877133

closes odoo/odoo#95284

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

By trying to avoid concurrency issues while assigning the sequence [1],
we are locking too many operations even when not in the process of
assigning a new number.
* when computing `highest_name`, we don't need to lock as this is mostly
  an information on the form that can possibly change anyway while the
  form view is open (without any lock anymore)
* when computing the accounting date, we don't need to lock, the only
  information we want is the format of the sequence (yearly, monthly, no
  reset), which is not likely to change on a same journal.
* when changing the `journal_id`, it is only a helper for encoding, if
  there is a concurrency error it will be shown during the post anyways.
  Also same argument as for `highest_name`

[1] https://github.com/odoo/odoo/commit/ba6ee0b75d66d6f22a592b1b6a7c5158461bec41



closes odoo/odoo#94852

Related: odoo/enterprise#28957
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>

Steps to follow:

  - Go to a crm.lead
  - Schedule an activity
  - Click on edit
  - Click on mark as done in the popup
  - Move the lead to a new stage
  -> A missing record error is displayed for the activity

Cause of the issue:

  Once the activity has been mark as done (deleted),
  The crm.lead record is not updated. The old activity is then
  passed to the server where an error is thrown

Solution:

  Update the main view after editing an activity

opw-2878984

closes odoo/odoo#94877

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Fixes to:  https://github.com/odoo/odoo/pull/94406
backported from its fw-port:  https://github.com/odoo/odoo/pull/95176



1) The test for reverse charge should only consider tags for
its country (Italy)
2) The report template shouldn't change its structure, even
if one field is not shown.
3) (enterprise) Mexican invoice template should target the note by
name and not by t-if condition

closes odoo/odoo#95244

Related: odoo/enterprise#29088
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Before this commit: syncing with google led to sending emails to
attendees of existing future events on Odoo.

Steps to reproduce the first issue:

	- Install 'google_calendar' module
	- Integrate with Google Calendar in setting
	- Add an event to the Odoo calendar for future date
	- Add one external attendee to the event
	- Sync with Google

	Invitation emails would be sent to the attendees of the events.

Solution

	It's possible to not send emails to the attendees in api calls. So
the solution is to not send emails to the attendees for the syncing
time.

opw-2819046

closes odoo/odoo#92953

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Reproduction:
1. Install recruitment
2. Create a new job position with an extra-long title
3. Save and the title of this record is exceed the kanban card

Reason: CSS style doesn’t take account of long title

Fix:  Backported the overflow changes in V15 and added o_text_overflow
to the title of the job's kanban view, so the title does not exceed the
border of the kanban card

opw-2849601

overflow change in V15: https://github.com/odoo/odoo/commit/a0ebb4609848a65f9b6a14a94030ad3144a95038



closes odoo/odoo#95255

X-original-commit: da6b5e17
Signed-off-by: Liu Jinjiu (jili) <jili@odoo.com>

Before this commit:

Attachments are not properly supported in livechat, so there is no point in
allowing attachments to be uploaded via drag and drop.

After this commit:

Disable attachment upload via drag and drop in livechat channels.

Task-2824502

closes odoo/odoo#92124

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

Upon save, uploaded images are saved because they are tagged with the
`o_modified_image_to_save` class.
Because of this is an image is uploaded then replaced by an icon, upon
save it does not make sense to obtain the actual source of the image
that is not on the page anymore.

After this commit upon replacing an image by an icon, the
`o_modified_image_to_save` is removed so that summernote does not try to
adapt its source upon save.

task-2829971

closes odoo/odoo#89010

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

When replacing an image by a pictogram, the classes of the previous media
are copied to the new icon's `<span>`. This potentially includes the
`w-100` class which prevents the alignment from behaving correctly.

This commit removes the `w-100` class if it exists - in addition to
removing the inline `width` attribute which was done before.

Steps to reproduce:
- Drop a "Media List" block
- Replace first image by pictogram.
- Align icon to the right.
=> Icon was displayed aligned to the left.

task-2829971 (was task-2729177)

Part-of: odoo/odoo#89010

Now the way of access to an action is using the method `_for_xml_id` of
the model `ir.actions.actions` and not reading the action itself because
they need the access of the group "Administration/Settings" which not
all the users have it, so we were having an error with users that have
the permissions to see MRP Picking Types but they didn't have the group
mentioned above.

closes odoo/odoo#95156

Signed-off-by: Tiffany Chang <tic@odoo.com>

Steps to reproduce the bug:
- Enable “Expiration date” in inventory settings
- Create a Storable product “P1”
    - Tracking: by serial number
    - Enable the expiration date option
    - Update the quantity:
        - Create a new Lot “SN1”:
            - select today's date as the alert date

- Go to inventory > reporting > Inventory Report
- Try to filter by “Expiration Alerts”

Problem:
The product P1 is not selected, because the filter checks the removal
date instead of the alert date

Solution:
The filter should check if the alert date is less than or equal
to today's date to display products or not, as it is for lots:
https://github.com/odoo/odoo/blob/14.0/addons/product_expiry/views/production_lot_views.xml#L30-L39



opw-2889737

closes odoo/odoo#94654

Signed-off-by: Christophe Simonis <chs@odoo.com>

Sometime Paypal took 3 or 4 days for some payment verification due to
weekend. This raises the retry limit days for 4 days instead of 2 to
solve the issue

closes odoo/odoo#95166

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Issues
------
Purchase Dashboard gives wong value for PO in RFQ and RFQ sent when
user's language is not English

Current behavior before PR:
---------------------------
1. Create some RFQ and RFQ Sent to see its statistic in dashboard
2. Swith user language to another one that is other than English
3. Statistic in the dashboard is wrong now

Solution
--------
Passing translated RFQ and RFQ Sent into the dashboard query in stead of
passing pure text without translation.

closes odoo/odoo#88635

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

From July 2022, External Reverse Charge (for Import/Export)
has to be sent through the SdI to the Agenzia delle entrate.
Exports will be 0% VAT
    (Reverse charged to the buyer)
Imports will have a -100%/+100% VAT tax
    (We are the buyers, and in charge of VAT)

See specification in the Task description.
Task: https://www.odoo.com/web#id=2823646&model=project.task



opw-2823646

closes odoo/odoo#94406

Related: odoo/enterprise#28798
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

Leftovers of previous fixes of this issue.

closes odoo/odoo#95123

X-original-commit: fec84116
Signed-off-by: Christophe Simonis <chs@odoo.com>

Improvement of the current fixes:
https://github.com/odoo/odoo/commit/ac3cf2ed59c1dd5a6c91da201a0d4093212b26ae
https://github.com/odoo/odoo/commit/feb4e839dc4e35ab16527e5e264b5cc1c0a76c8e



- A tax line is linked to a tax repartition line. If you suppose a tax with 2 repartition lines then, removing one tax line should recompute the tax line.
- There are multiple taxes configuration leading to a tax line with a zero amount. For example, python tax, fixed tax with quantity = 0, a tax with a tiny amount...etc

closes odoo/odoo#95094

X-original-commit: 11e74861
Signed-off-by: William André (wan) <wan@odoo.com>

Reproduction:
1. Install Expense in V15
2. Go to Expense->Configuration->Expense Products
3. Create a new product, after selecting a vendor tax, click save, the
selected vendor tax is erased and is not saved.

Reason: When creating a new expense product in the normal flow, it still
falls in the condition thus the vendor tax is not updated for the first
time.

Fix: This issue is fixed in the V15 and onwards. The new code just needs
to be backforwarded to V13 and V14.

opw-2852894

Related fix in V15: https://github.com/odoo-dev/odoo/commit/0937ed8d18e4b9ebcaeba6508bd6ffdf1d8e58b7#diff-b294a9786d016b2eda726753fbf75bf749227c2f102d154aa094b2c635334e7e



closes odoo/odoo#95086

X-original-commit: e90005a6
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Signed-off-by: Liu Jinjiu (jili) <jili@odoo.com>

When sending an invoice to the SII edi, the field TipoDesglose is
required. In case we have a foreign customer outside of Spain, we are
filtering the taxes information based on the tax scope (services or
goods). In case the tax scope is not filled in, TipoDesglose is not
provided and this will cause the request to fail, with no clear reason
for the user. We should add an UserError message to make it clear enough
so the user can fix it himself.

closes odoo/odoo#94688

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

The total value of the invoice can be reported in the edi using the
field <ImportoTotaleDocumento>. This commit uses the amount_total of the
invoice to occupy this field.

Adapt the l10n_it_edi_sdicoop tests to include this field in the
expected xml.

closes odoo/odoo#94553

Task-id: 2894623
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

[FIX] account_edi_ubl_cii: Prevent error when zip is not set (since https://github.com/odoo/odoo/commit/b467c2c6536d291ac9b4d426f964fb1d9e309e3f

).

TT36147

closes odoo/odoo#94333

Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>

(To be commited with  [#94024](https://github.com/odoo/odoo/pull/94024)

)

Duplicating an email sent from Odoo would raise an error because some required fields could not be set.
Setting those fields on duplication does not make sense, duplication is to be disabled on e-mails.

As this applies to some messages and no use-case could be found for the duplication of messages or notifications,
both also had duplication disabled.

Task-2857244

closes odoo/odoo#94026

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Actually we send request to check if the terminal is available when we poll
the status of a payment.

We remove it and need check the availablity before we start the session

closes odoo/odoo#94859

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

If we use the auto-complete feature to add PO's lines to an bill or we select multiple PO's then use
'create bill' button, the generated invoice line will copy the sequence line from the PO's line. This
can lead to situation where we will have all the first lines of each PO then all the second, etc, ending
with a mix of all PO's in the bill.

Example:
Purchase order 1
- seq 10 line A
- seq 11 line B
- seq 12 line C

Purchase order 2
- seq 10 line A'
- seq 11 line B'
- seq 12 line C'

Invoice created from those PO's
- seq 10 PO1:line A
- seq 10 PO2:line A'
- seq 11 PO1:line B
- seq 11 PO2:line B'
- seq 12 PO1:line C
- seq 12 PO2:line C'

After this PR this PR the lines from the same PO's will be contiguous like:

Invoice created from those PO 1 and 2
- seq 10 PO1:line A
- seq 11 PO1:line B
- seq 12 PO1:line C
- seq 13 PO2:line A'
- seq 14 PO2:line B'
- seq 15 PO2:line C'

opw-2749682

closes odoo/odoo#93673

Signed-off-by: Steve Van Essche <svs@odoo.com>

In April 2022 efaktur standard has been updated to version 3.2
Transaction code 05 has been introduced
https://atpetsi.or.id/kode-transaksi-05-pada-faktur-pajak-digunakan-untuk-ppn-ini



opw-2830864

closes odoo/odoo#95008

X-original-commit: f65d2b69
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Grazioso Andrea (agr) <agr@odoo.com>

Cause:

  The tests fails because the expected price is not the right one.
  It is because that when installing the l10n module, it changed
  the current company currency (if no localisation set) but not the
  pricelist.

Solution:

  For the tests, change pricelist currency of the main website
  with company currency.

opw-2899730

closes odoo/odoo#94983

Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>

Only users with admin rights are able to confirm and send an invoice to
the SII

Steps to reproduce:
1. Install l10n_es_edi_sii module
2. Switch to company 'ES Company'
3. Go to Settings > Invoicing > Spain Localization > Registro de Libros
   connection SII and select 'Hacienda Foral de Gipuzkoa'
4. Go to Invoicing > Configuration > Accounting > Journals and open
   'Customer Invoices'. In the 'Advanced Settings' tab, enable EDI
   functionality 'SII IVA Llevanza de libros registro (ES)'
5. Go to Invoicing > Configuration > Spain > Certificate (ES) and import
   the certificate (file named sello_entidad_act.p12 in
   l10n_es_edi_sii/demo/certificates/) with password "IZDesa2021"
6. Connect as demo in 'ES Company'
7. Create an invoice with any customer and product and confirm it
8. Click on 'Send now', an access error is raised

Solution:
Call `_decode_certificate` with sudo to allow any user to send invoices
to the SII

opw-2767288

closes odoo/odoo#94835

Signed-off-by: Guillaume Merlin (megu) <megu@odoo.com>

Current behavior:
When creating a backorder for a MO the smart buttons showing
the MO counts had the wrong value

Steps to reproduce:
- Have a product that has MTO and Manufacture in his routes
- Create a quotation for 5 of this product
- Validate the order and click the manufacturing smart button
- Set the quantity to 3 and validate
- Create backorder
- Go back to the sale order, the manufacturing count is still 1
  but should be 2

Solution:
Backport of saas-15.2: b3fffea6

opw-2877348

closes odoo/odoo#94091

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Overriding method has_group() in some extension of model 'res.users' is
not possible because of code invoking model.has_group.clear_cache().

As clear_cache() is no longer invoked on ormcached methods, we can
simply replace the code by a global cache invalidation.  In this case,
it is not even necessary, since method call_cache_clearing_methods()
does it already.

closes odoo/odoo#94907

Signed-off-by: Raphael Collet <rco@odoo.com>

In some cases, replanning a work order does not change anything.

To reproduce the issue:
(Use demo data):
1. In Settings, enable "Work Orders"
2. Create two manufacturing orders (MO01, MO02) with 1 x [FURN_8522]
Table Top
3. Confirm MO01 and MO02
4. Set the same Scheduled Start Date (SSD) on the WO of each MO
    - A warning should be displayed on the work order line because of
the conflict
5. Open the warning and click on "Replan"

Error: Nothing happens, the warning is still displayed and the scheduled
start date does not change.

For the warning symbol to be displayed, we check (through
`_compute_json_popover`) if two work orders are in conflict:
https://github.com/odoo/odoo/blob/8cb5aad6126e3f63ee4ef91115c8b4a6be571828/addons/mrp/models/mrp_workorder.py#L719-L722
So, we base this information on the `mrp.workorder`

However, the planning logic is based on another model:
`resource.calendar.leaves`. When planning a WO, we create a
`resource.calendar.leaves` and we link this slot to the WO thanks to the
field `leave_id`:
https://github.com/odoo/odoo/blob/4870606b00a758e63713e6e82c0cba9b1e7dd4aa/addons/mrp/models/mrp_production.py#L1238-L1248
Therefore, when replanning a WO, we ensure that the new slot does not
overlap any existing slot in the same workcenter. But, here is the
issue: when writing the start date (step 4), we try to replan the WO of
the MO only if this MO is already planned:
https://github.com/odoo/odoo/blob/4870606b00a758e63713e6e82c0cba9b1e7dd4aa/addons/mrp/models/mrp_production.py#L723-L724


Wich is not the case in the above steps. So, we don't (re)plan anything
=> we don't create any slot.

As a result: the warnings are displayed, which is correct, but when
trying to replan one of the WO (step 5, viathanks to
`_plan_workorders`): There isn't any slot starting from WO's start date
(there isn't any slot at all!), so we can create a new slot -> the start
time of the WO does not change -> considering their start times, there
is still a conflict between both WOs.

Comment: if after the step 5, the user tries to replan the other WO, it
will work: the first replanning fails but a slot has still been created.
Therefore, when replanning the second WO, the newly-created slot will be
detected, a second slot will be created after the first one and the
start date of the second WO will be postpone (according to the second
slot).

(!) Note that nothing creates any slot if we directly define the start
time of the WO during the MO creation (step 2). So this use case will
fail too.

We should ensure a perfect coherence between both models
`resource.calendar.leaves` and `mrp.workorder`.

OPW-2887413

closes odoo/odoo#94765

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

Using `./odoo-bin` to start Odoo, the addons path can contain a `~`, eg
`~/Documents/whatever`.
Those `~` are accepted and work both with the `--addons-path` passed as
the command argument, or in the `.odoorc` config file.

The `@standalone` tests (launched with `./test_module_operations.py`)
however did not work with that `~` as the path was not "normalized".
Neither a `~` in the config file or in the `--addons-path` argument were
working.

While it is not very critical, it is a nice to have to have the same
behavior as the `./odoo-bin` as this made me lose quite some time
figuring why I couldn't use my usual `design-themes` repo addons path.

closes odoo/odoo#92995

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Co-authored-by: Xavier-Do <xdo@odoo.com>

It could happen that there are other objects than stock.move linked to
the manufacture order. This is currently creating an error when
concatenating the objects. As we are only keeping stock.move objects to
log the exception on those, we should filter them before the concatenate
operation to avoid the error.

closes odoo/odoo#94849

X-original-commit: 1cdb6821
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Alex Thuyls (alt) <alt@odoo.com>
Co-authored-by: vancleeff <mvw@odoo.com>

A forum tag is always linked to a forum.
But some flows are not considering that part and are returning/using
tags from other forum too.

Step to reproduce, having 2 forum `Cats` and `Dogs`:
- Create a `Food` tag on the `Dogs` forum
- On the `Cats` forum, type `Food` in the tag input
- First error: the `Food` from `Dogs` incorrectly shows up
  It means that the user can't create a new one from the `Cats` forum
  but will actually have to select (without know it) the one from the
  `Dogs` forum.
- Select that tag anyway
- Second error: The tags displayed on the post is redirecting to the
  wrong other forum, ultimately not showing the post from all forums
  (and the one you just came from).
- Third error: The /tags page won't list the `Food` tag on the `Cats`
  forum.

Note that there is probably some access traceback involved in a multi
website and/or multi company setup.

After this commit:
- only the tags from the current forum will show up and be selectable
  when creating a post.
- it will be possible to create a new tag for a forum is another forum
  already has a tag of that name
- the tag on the post (next to its title) will not redirect to the
  incorrect (and possibly not accessible) forum

Note that the method was already reading multiple properties of `self`,
it was already not an `api.model` method anymore.

closes odoo/odoo#94905

X-original-commit: 53e57771
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Co-authored-by: hoangtiendung <hoangtiendung070797@gmail.com>

This commit fix 3 problem

Don't count studio field
------------------------

the commit https://github.com/odoo/odoo/commit/75b8c4eb1ed6e44f427886eea06ad216995e16c8
was supposed to stop counting count field generate by addins a smart
button with studio.

It works fine when base import module is not installed which is never
the case.

When base_import_module the field is counted as a field that belong
to a imported module installed : studio_customization

studio_customization should not be counted as an imported module
installed

Count Field with standard xml_id
--------------------------------

With https://github.com/odoo/odoo/commit/9afce4805fc8bac45fdba817488aa867fddff69b


Each manual can end up with an xml_id from a standard module:
the original module of the model

A standard module should never create a manual field so we can consider
they should be counted unless they match the criteria of the first
problem

If a field has a standard module xml_id and no other the module
should be odoo/studio and not the name of the standard module

Make possible to exclude some db record from cloc
-------------------------------------------------
It's possible to exclude some file in python module
but it's not possible to exclude some field or SA in
the database from the count

Make it possible if they are link to an xml_id
from the module __cloc_exclude__

The exclude record will be shown in cloc report with
the verbose mode

closes odoo/odoo#94803

X-original-commit: 58c3b45c
Related: odoo/enterprise#28947
Signed-off-by: Christophe Simonis <chs@odoo.com>
Signed-off-by: Thibault Francois <tfr@odoo.com>

Consider two models A and B, a many2many field F from A to B and its
inverse relation G from B to A.  When F is modified, G is updated
accordingly in cache.  The statement

    records.write({F: [(4, b.id)]})    # link b to records

is expected to add b.id to records.F, and add records.ids to b.G.  In
order to avoid nondeterminism, the additions should be done at the end
of the recordset, and in order.  In other words, if none of "records"
are in b.G, then after the statement above, b.G should be updated as

    b.G = b.G + records

This patch ensures that "records" are added in order.

closes odoo/odoo#94782

Signed-off-by: Vincent Schippefilt (vsc) <vsc@odoo.com>

Adyen announced the deprecation of their Hosted Payment Page (HPP)
solution for the year 2022. They plan on stopping providing support on
July 1st and on disabling the API on October 1st.

This commit adds a new `payment_adyen_paybylink` module to migrate the
current implementation of Adyen from the HPP API to the equivalent (with
redirection) Pay by Link API.

task-2607397

closes odoo/odoo#94651

X-original-commit: a3236517
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

Steps to reproduce:
- Create a sale order
- Set a very long message in the chatter
- Clink on the customer preview

Current behavior:
There is a empty space in the top right corner

Expected behavior:
The preview is a usual

Explanation:
The very long word in the chatter created at the
bottom of the page a very long message that increased
the page width, modifying the usual view. To fix that
we allow long words to broken to keep the same width.

opw-2880050

closes odoo/odoo#94763

X-original-commit: 775290e1
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Fockedey Martin (mafo) <mafo@odoo.com>

Current behavior:
When returning a delivery that had a quanity lower than 1
the inventory valuation showed a value of 0 for the return

Steps to reproduce:
- Create a product that use "m" (meters) as UoM
- Change the configuration of the product Category
  and set Costing method to FIFO and Inventory valuation to Automated
- Create a SO for this product with a quantity of 0.15
- Validate the order and validate the delivery with full quantity
- Now click on return and make a return for the delivery
- Validate the return and go in the inventory valuation
- Show the inventory valuation for the created product
- The return has a value of 0 when it should have the same value
  as the delivery

opw-2880153

closes odoo/odoo#94797

X-original-commit: 9bc3d5eb
Signed-off-by: Adrien Widart <awt@odoo.com>
Signed-off-by: Anh Thao PHAM <pta@odoo.com>

In some cases, empty messages can be displayed in the portal chatter.

For instance, if a customer sends a message with no body and just
an attachment, and the attachment then gets deleted, it will still
be displayed as an empty message in the portal chatter.

To solve this, this commit filters out empty messages from the portal chatter.

Task-2833919

closes odoo/odoo#89742

Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>

When the user clicks on "Add Images" at a specific timing after dropping
the "Images Wall" block but before the media dialog opens automatically,
the media dialog gets opened twice.

This commit prevents the media dialog from opening until it has been
closed.

task-2818919

closes odoo/odoo#94048

Signed-off-by: Romain Derie (rde) <rde@odoo.com>