To reproduce the error:
(Need MX configuration)
1. Go to Accounting > Customers > Receipts
2. Create a Receipt
3. Post and Print it

Error: An error message is displayed: "Only invoices could be printed."
However, MX should be allowed to print the receipts.

OPW-2456374

closes odoo/odoo#66910

Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

The following warning is very long in absolute position. The following
text: "Calendar Mismatch : The employee's calendar does not match its
current contract calendar. This could lead to unexpected behaviors."
is invisible but takes a lot of width on the same line.

Now, the item is a block of 0px height and doesn't take space.
This avoids the horizontal scroll on mobile.

Note that the item is displayed at the wrong place anyway.
This will be fixed in master.

Steps to reproduce:
- Payroll / Employees / All contracts
- Change "Working Schedule" field

closes odoo/odoo#66858

Task-id: 1929043
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>

When comparing the values of a new record with its origin, x2many fields
are always different because we compare new records with real records.
For instance, converting the value of a one2many field where lines have
a many2many field always returns update commands for the many2many
field.

closes odoo/odoo#66914

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

When downloading the digital file, if there exists one SO linked to the
current customer and that contains a Note/Section, the web page will be
redirected to the "Internal Server Error" web page.

To reproduce the error:
(Need sale_management)
1. Create a customer C
2. Grant C portal access
3. Create a product P
    - Add a digital attachment
4. Create a SO
    - Customer: C
    - Add product P
    - Add a note
5. Save, Confirm, Create Invoice, Register Payment
6. Sign in with P
7. Consult the SO web page
8. Download the file attached to the SO line

Error: The page is redirected to the "Internal Server Error" web page.

When downloading the document, the module checks the customer's access.
To do so, it gets all relevant invoices and free products. Here is the
problem, when getting the free products, the domain includes the SO
lines used for Section and Note. As a result, when it tries to read the
product of such a line, this will raise an error.

OPW-2419478

closes odoo/odoo#66904

Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

The condition on computation of `l10n_ch_isr_number_spaced` was not in line anymore with
`l10n_ch_isr_number` computation.
With fixes on the ISR number the use of `l10n_ch_isr_postal` is rightly not
mandatory anymore.

This lead to an empty field, visible on the ISR report.

closes odoo/odoo#66854

Signed-off-by: Josse Colpaert <jco@openerp.com>

When submitting a ticket, if the user adds an attachement, he will not
be able to see it on the ticket web page.

To reproduce the error:
(Need helpdesk,contacts)
1. Go to the settings of a Helpdesk Team (e.g., "Customer Care")
2. Enable "Website Form", Refresh
3. Go on Helpdesk web page and Publish the form
4. Create a partner P and grant him the portal access
5. Sign in with P
6. Submit a ticket with one attachment
7. Consult the ticket's web page

Error: in "Message and communication history", OdooBot's message with
the attachment is not displayed. However, when consulting the
same page with the admin account, this message is considered as
"Published". Thus, P should see the message and the attachment.

When getting the messages, if the user is not an employee, the domain is
restricted:
https://github.com/odoo/odoo/blob/e92ac60a75462dfd830254a3d0dd5d7effe1528e/addons/portal/controllers/mail.py#L128-L130
with
https://github.com/odoo/odoo/blob/cc32b7d1b396a42dd4575c681ceb422f99b6015a/addons/portal/models/mail_message.py#L30-L32


Problem is that, when creating the message with the attachement,
`subtype_id` is not defined.

OPW-2440069

closes odoo/odoo#66896

X-original-commit: b05a72d3
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

When changing an image in the image gallery snippet, the miniature was not
updated. It was due to the 'save' event that was not triggered.

task-2438556

closes odoo/odoo#65461

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Add new members

closes odoo/odoo#66856

X-original-commit: 3d766361
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

Steps to reproduce the bug:

- Let's consider an employee E with 8.00 hours as Average Hour per Day
- Create an Allocation for E with a Time-off Type in Hours
(be sure the number of hours is different from the average hour per Day)
- Open the form view of E

Bug:

The smart button Time Off(remaining leaves) was completely unreadable

opw:2441019

closes odoo/odoo#66760

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Before this commit:

In edit mode, glitching of chatter is visible in project.task's form view
(without sheet tag).

After this commit:

Removed this glinch of chatter and displaying it with full width in the form
(without sheet tag).

Links

PR https://github.com/odoo/odoo/pull/65447


Task- 2411632

closes odoo/odoo#65447

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

Zeep replaced suds but Debian and Rpm packaging were not updated.
Ofxparse is required but did not appear in Debian nor Rpm packaging.

closes odoo/odoo#66780

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Some json files are necessary for some modules but are not included in
packaging.

closes odoo/odoo#66768

X-original-commit: d33c05b6
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

Create a product with mor than one tax > Create a down payment with %
Traceback

opw-2464291

closes odoo/odoo#66770

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

When printing an invoice, the server tries to register one attachment as
main one (see #65320). However, if there is not any attachment, this
will raise an error.

OPW-2465995

closes odoo/odoo#66706

Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

AFIP give us new resolution 4291 that request to print QR code in
printed version of electronic invoices. For that we:

1) update the xml report footer style
2) add generic method to sanitze the identification number we are
sending, the sanitize method is added here in order to be re used for
other functionalities across electronic invoice and reports. If we are
not able to sanitize the number then we show an error to the user
3) update translations to add new raise message translated term

closes odoo/odoo#65032

Related: odoo/enterprise#15947
Signed-off-by: Josse Colpaert <jco@openerp.com>

[FIX] l10n_cl: in report date, use the invoice_date directly instead of passing. (otherwise was not printing the date)

closes odoo/odoo#65892

Signed-off-by: Josse Colpaert <jco@openerp.com>

Steps to reproduce the bug:

- Create a multi-company environment with two companies A & B
- Create two sales taxes TA & TB, one for company A & one for company B
- Created a shared product P and assign both TA & TB
- Create a fiscal position FP that maps TA and TB to other taxes
- Login with user having access of both companies
- Enable a POS session S with fiscal position and select FP
- Open S and select P as product

Bug:

A traceback was raised

PS: Only the taxes of company's user are loaded in taxes_by_id
So when trying to fetch taxes from a product with function get_taxes,
the taxes from other companies than company's user must be ignored.

opw:2448785

closes odoo/odoo#66684

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Issue

	- Install Inventory module
	- Go to Inventory -> Reporting -> Inventory Valuation
	- Click on "Inventory At Date" button
	- Select any date

	The datetime in breadcrumb is displayed in UTC.

Solution

	Display datetime in current user timezone.

opw-2464744

closes odoo/odoo#66533

Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

Commit e5ab8cf9 missed a use case.

Steps to reproduce:

- Activiate "Packages" setting in Inventory
- Configure an operation type to "Move Entire Packages"
- Create a "Planned Transfer" picking with that operation type and add a
  package to be moved
- Turn off "Move Entire Packages" and try set the destination
  package of the move line to nothing (False).

Expected result:
Move line has no destination package + package level is deleted as
expected.

Another bug will still exist due to the design of package_level where if
in addition to the above use case, if a different package is used instead
of deleting it and "Move Entire Packages" is reactived => final package
shown in the Detailed Operations will show all move lines as being part
of the same package even though they are not. Data appears to be correct
in the database otherwise and a reasonable fix doesn't seem feasible for
now so we leave this bug as is.

Related to Task: 2418907

closes odoo/odoo#66619

Fixes: odoo/odoo#66542
Fixes: odoo/odoo#66517
X-original-commit: a73505dd
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

This fix (odoo/odoo#46850) was too permissive and fix too much
stock valuation issues (other than rounding error) under the hood.
The problem of the "too permissive" is will hide some errors
without get any feedback about them. Also, it changes the SVL value
without any explanation.

To avoid the first issue, apply a threshold on the rounding adjustment.
This threshold is '(quantity_out * smallest_value_of_the_currency) / 2'
(`smallest_value_of_the_currency` = `rounding` field of the related
currency).
Also to improve debugging, add a line in the description
about the rounding adjustment done in a SVL

task-2452786

closes odoo/odoo#65567

Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

instead of using ad-hoc weirds

closes odoo/odoo#66612

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

Before this commit, 'hours' was on the next row instead of the same line.

closes odoo/odoo#66615

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>

Steps:
- Install sales,payment
- Go to Sales
- Create a quotation
- Click Actions > Generate a Payment Link
- Browse the link in a private window
- Pay

Bug:
The transaction is not linked to the sale order in the link table
`sale_order_transaction_rel`

Explanation:
When not connected, the user doesn't have the rights to read the order.
This leads `order_id` to be set to `None`:
https://github.com/odoo/odoo/blob/d2f3c9e7975188753fa17c06db3fc5c73c773944/addons/payment/controllers/portal.py#L177-L178
When paying without `order_id`, the app is not able to make a link
with the transactions:
https://github.com/odoo/odoo/blob/d2f3c9e7975188753fa17c06db3fc5c73c773944/addons/payment/controllers/portal.py#L276-L277
This raises problems such as not being able to capture an amount as seen
here:
https://github.com/odoo/odoo/blob/d2f3c9e7975188753fa17c06db3fc5c73c773944/addons/sale/views/sale_views.xml#L254-L257



If we ensure a `partner_id` is present, using `sudo` here shouldn't be a
problem as the data is protected by the token. Everything we get from
`order_id` should already be in the URL.

opw:2451564

closes odoo/odoo#66565

Signed-off-by: backspac <backspac@users.noreply.github.com>

The problem comes from #65789

closes odoo/odoo#66547

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Context:
1) Edit mode
2) Click on anchor edition button of website form submit button
3) Traceback occurs

The "focus" triggered on $editable element in editor's 'getLinkInfo()'
discards user's text selection on submit button, as a result,
'range.create()' method returns null since no selection is found.

Note: the bug only occurred in Chrome.

Note 2: [1] apparently tried to solve the same issue but the fix was not
        solving it correctly, at least not in all cases.

[1]: https://github.com/odoo/odoo/commit/da14e4449e5e318eb72e1b9f268fb797adb0c6a6



opw-2443441

closes odoo/odoo#65875

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

closes odoo/odoo#66254

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Currently, the quotation amount field added in the CRM Sales Teams Kanban view is overflowing the kanban card once the number is too large.

The fix adds the class text-truncate in the corresponding div to avoid the overflow. Notice that this class is the one already used in the parent view implemented in the CRM module, for the other amount fields.

When printing a draft invoice, it raises an error.

The error comes from fix #65320: the latter registers the printed
invoice as main attachment, but this needs to be done only with posted
invoices.

OPW-2427247

closes odoo/odoo#66516

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Steps to reproduce the bug:

- Let's consider a product P with a subcontracting BOM B and subcontractor S
- Create a purchase order PO with S as vendor
- Add P on PO and confirm it
- Change quantity of P two times

Bug:

A traceback was raised

opw:2419222

closes odoo/odoo#66440

Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

Using `read_group` to gather such a sum is always more performant
than a `search` followed by a `mapped`.

In the case of the studied database,
the computation never ended,
while it ends in a few seconds
using `read_group`.

upg-7528

closes odoo/odoo#66502

X-original-commit: 8547bb6145c3ddf9c7205ea10deef22473362cce
Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

When importing some invoice lines, if the analytic account field of a
line has changed, the new invoice line will still keep the initial
analytic account value.

To reproduce the error:
(use demo data)
1. Create an invoice I01
    - Add one line with one analytic account (e.g., "Administrative")
2. Save
3. Go to Accounting > Customers > Invoices
4. Export I01:
    - Enable "I want to update data (import-compatible export)"
    - Fields to export:
        - Invoice lines
        - Invoice lines/External ID
        - Invoice lines/Analytic Account
        - Invoice lines/Analytic Account/Analytic Account
5. On exported file:
    - Delete column "invoice_line_ids"
    - Change the analytic account (e.g., "Operating Costs")
6. Import the file
7. Open I01

Error: The analytic account is still "Administrative". It should be
"Operating Costs".

The issue comes from both `._origin`: the module keeps the initial
values. Both `_origin` were introduced to fix an issue (see #49110), but
they are not useful anymore.

OPW-2452428

closes odoo/odoo#66433

Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

Neither server, no browser cannot handle unlimited number of lines at the same
time. On server side it leads to series of heavy sql requests. On client side,
browser will eat all the memory on trying to render all of those lines.

This also prevents loading reconciled lines ids to browser.

Size of the batches can be customized via System Parameter
``account.reconcile.batch``

Details:
* ``action_bank_reconcile_bank_statements`` is used on clicking `[Reconcile]`
button in ``account.bank.statement`` form
* ``action_open_reconcile`` is used on clicking `[Reconcile]` for a journal in
Account Dashboard

---

opw-2424992
opw-2344807

closes odoo/odoo#65789

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

Issue

	- Install "Sales" module
	- Go to settings and activate "Product Configurator" feature
	- Create a product X with mutilple color (variants)
	- Create a quotation
	- Add product X (Product Configurator should open)
	- Hover any color

	Popup with color name does not appear.

Cause

	'title' attribute value is removed.

Solution

	if element have 'value_name' data attribute, set it back as title else set no title.

opw-2438704

closes odoo/odoo#66451

X-original-commit: efa36bc522771e17805ee965bdc0f0315b5f34ff
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>

If a field is sanitized, a6e2b484 would hide the video button because
the video does not show in backend. It is better for the consistency but
if the field appear in frontend, the video would still show so we
prevent something that worked (but is very not user friendly when
editing in backend).

This changeset go back to the previous behavior (keeping the code
simplification), at one point there should be a fix so at least when
editing we see the video (currently we see an empty div in given
conditions).

opw-2463746

closes odoo/odoo#66434

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Enter keypress browser event were removed in 3c372d1d.

It was reintroduced in text fields with d2f024d2 and in source mode
of html field with b10ca1f6.

When doing ENTER in the editor, we do our special case of ENTER (eg. it
will split the container in two and have other custom behavior) but when
doing SHIFT+ENTER we let the browser handle it and add a normal newline.

With the "Enter" prevention, SHIFT+ENTER did not work.

opw-2463746

closes odoo/odoo#66426

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Steps:
- Log in as admin
- Install calendar
- Activate the developer mode
- Go to Calendar
- Create a new event:
  - Attendee: demo (1)
  - Misc tab:
    - Owner: demo (1)

Bug:
Access Denied:
(Document type: Message, Operation: read) - (Records: [84], User: 2)

Explanation:
The author of the message is not the current user from this commit
onward: https://github.com/odoo/odoo/commit/160d321b821c669185054b7fb8515e88fc22bd5a


The access denial appears when trying to add the ICS file to the
message. The current user is not allowed to read the old attachments
since they are not a part of the discussion.

opw:2454395

closes odoo/odoo#66166

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Currently a package level is created and has the newly created package
assigned to it when "Put In Pack" is used. Unfortunately if a move line
has its result_package_id changed after having a package assigned via
the Put In Pack, then the package level's package_id isn't correctly
updated. This leads to incorrect data in the db. This incorrect data
doesn't affect much since result_package_id from an entire package move
cannot be changed in any views, but it does mean that the created
package associated with the package level can never be deleted even if
it's never used.

Steps to reproduce:
1. active (delivery) packages in settings
2. create a picking and create some done values
3. use "Put In Pack" to put done move lines into a package
4. change the newly created Destination Package to another package
5. Go to Packages and try to delete the package created by Put In Pack

Expected result: able to delete the package
Actual result: Server error that package is still required by Stock
Package Level.

This is a short term fix. In the long run it would be better to fix the
package_level logic so it isn't unnecessarily assigned to moves/move
lines and/or updates in a cleaner way.

Task ID: 2418907

closes odoo/odoo#66386

X-original-commit: e5ab8cf9
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

Go to Website
Go to conatct us form
Switch in Edit mode
Click on “send” (or "submit")
click on edit link

A js traceback will apper. This occur because we refocus an elements
which may not be the correct one. In this case $editable will contain
all the contact form instead of just the relevant div of the submit
button

opw-2439090

closes odoo/odoo#66081

Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

The access rule on a project with invitation only will for example
check if the user is follower of a task inside this project.

Currently it used task_ids to do that, so:

- you would not see a project where you have access to project if the
  tasks you have access to are in folded columns

- there is an odd issue with computation of the field value and the
  domain where is might cause an error and make Project app
  inaccessible (when searching it doesn't filter on task_ids domain,
  so find too many results, when checking security for compute fields
  it filters on it

In any case, we should use tasks which also contains task in folded
stage and not just task_ids.

opw-2455780

closes odoo/odoo#66375

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>