Problem: The error "There is no chart of accounts installed for this company..." appears for POS shop configurations
if they don't have a chart template configured for the company. It doesn't take into account if the company has its
own set of accounts so it will always show the error unless the chart template is set.

Solution: Include an additional condition to check if the company has accounting entries which is used to check
if the company has used its own set of chart of accounts for accounting.

Purpose: The error will only appear if the company has no chart template set or no accounting entries.

opw-3291399

closes odoo/odoo#121309

X-original-commit: b5106da3
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Mylyna Hy (myhy) <myhy@odoo.com>

When the user configures PayPal/Alipay and in his PayPal/Alipay account he set
the IPN address to the webhook_url he receives a notification from PayPal/Alipay
with data. Then origin of that notification is checked and when PayPal/Alipay
sends 'invalid'/'false' as a response the error occurs.

To fix this issue the log is updated into a warning.

sentry-4116633764

closes odoo/odoo#121235

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>

The taxes update migration method didn't handle properly the creation
of taxes with `children_tax_ids`. Such taxes caused an infinite loop
when entering the `_generate_tax` method.
To fix this we have batched the creation of taxes.

We also fixed the comparison method that checks whether an existing tax
is close enough to the template we are evaluating to handle properly
taxes with an `amount_type='group'`. If we are evaluation such a tax
we ignore the usual checks on repartition lines.

closes odoo/odoo#121225

Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Claire Bretton <clbr@odoo.com>

Swiss taxes retrieved by module update (and the update of taxes it triggers)
need to be active, even if the template data was set to inactive.

Part-of: odoo/odoo#121225

When we were updating taxes from templates in a multilang localization,
newly created taxes were not translated in languages of the localization.
We also need l10n_lu migration script to be run in `end` instead of `post`
to have translations loaded.

Related: #108667
Part-of: odoo/odoo#121225

The tax with xmlid vat_0_import was missing its repartition
lines which caused validation errors.
This PR adds empty repartition lines to fix this problem.

Part-of: odoo/odoo#121225

If a tax is an aggregation of its sub-taxes it makes sense to have no
repartition line. This PR relaxes the validation in that case.

Part-of: odoo/odoo#121225

Switzerland changes its rates at the beginning of next year,
this change already has some implications on client's flow so
we add them to the localization so they can coexist with old rates till
the end of the year.
Changes:
- Added new taxes (2.5% -> 2.6%, 3.7% -> 3.8%, 7.7% -> 8.1%)
- Added tax fiscal positions to match those taxes
- Added tax groups
- Adds migration script to l10n_ch to apply those changes

Task: 3162286
Part-of: odoo/odoo#121225

There is no notification telling which field are invalid when we try to
save a form in a dialog

Steps to reproduce:
1. Install Survey
2. Go to Survey and open any survey
3. Add a question in the survey and try to save it (without entering a
   title)
4. There is no notification. Although the invalid field is highlighted
   in red, it could be tricky to see it if the field is in a tab

Solution:
Create a method in Record that sends the notification and call it when
the record is not valid in X2ManyFieldDialog

opw-3196166

closes odoo/odoo#121205

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

This issue only occurs on Firefox because ´has´ is not supported
and the following rule is not applied:
https://github.com/odoo/odoo/commit/2cd0106e63785dd34553c2b4747d72b93b9a7afd



Anyway, there is an existing css rule that is applied if the field
class is correclty added.

Steps to reproduce:
- Open Sale
- Add some content in the sale order line

opw-3201461
opw-3285854
opw-3266130
opw-3244581

closes odoo/odoo#121182

Signed-off-by: Pierre Paridans (app) <app@odoo.com>

Steps to reproduce:

  - Log in as admin
  - Install `eLearning` module
  - Create a course and add a youtube video as a lesson
  - Publish the course
  - Go to the website and click on the course
  - Enable `Editor` mode (top left corner)
  - Click on lesson to open it in fullscreen
  - Click `Back to course` button

Issue:

  Video is playing in the background.
  Same issue occure with video snippet in the website editor (by default
  video is mute but still playing in the background).

Cause:

  When editor mode is enabled, there is a fallback iframe that clone the
  content of the current page that we leave into it.

  Since the youtube video has `autoplay=1` in the URL, it will
  automatically start in the fallback iframe.

Solution:

  For regular website pages, remove the `autoplay` param from all
  media video iframes urls (targeting all `div.iframe` that have a class
  `media_iframe_video`).

  For eLearning, override the `WebsitePreview._cleanIframeFallback`
  method to remove the `autoplay` param from youtube videos URLs.

opw-3226002

closes odoo/odoo#121157

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Before this commit, when a cookie bar was displayed on a page and
elements of that page were animated (on scroll and on appearance), those
animations did not work while the cookie bar was present. This commit
fixes that and enables animations even if a cookie bar is displayed. The
problem was that we were looking to see if a modal (cookie bar, popup)
was displayed and if it was, all animations were based on the scroll
height of that modal. However, this should only be done for elements
that are in the modal. The other elements should always base their
animation on the scroll height of the page.

task-3151000

closes odoo/odoo#120294

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

closes odoo/odoo#119637

X-original-commit: efbaf72c
Signed-off-by: Josse Colpaert <jco@odoo.com>

Steps:
- Install timesheet.
- Start timer.
- Make sure there is enough record to show search more on
task or project field.
- Click on search more button.
- Click on Create button on search more button.

Issue:
- Traceback.

Cause:
- Can not find owl form view in legacy form registry because
recent removal of old legacy code.

Fix:
- Add a widget to open owl form view in search create dialog
instead of legacy form view.

task-3051478

closes odoo/odoo#115062

Related: odoo/enterprise#40581
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

Before this commit task action from kanban click and from
stat button does not have same behavior like kanban click
does show archive task for archive project and does not
display New button while other on does not.

This commit make both action consistance to have same
behavior in both actions.

task-3224627

closes odoo/odoo#114749

Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>

    Steps to reproduce:
    1- Create a BOM for a product, define an Operation on the product
    2- Link a Google Slides document to the Operation as the Operation Worksheet.
    3- Define an instruction on the Operation
    4- Set Step Document to Specific Page of Operation Worksheet and define a page.

    Issue: The step will not load the document.

    Cause: tablet.js passes the wrong value to let know the viewer is a google slide url. Also when the good
    value is passed the viewer always show the first page. That's because the SlideViewer has the page set in the
    setup() method so it never change despite we change the step in the same document.

    opw-3165142

closes odoo/odoo#113727

Related: odoo/enterprise#37558
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

Allow extending tests for any modules, regardless of existing ones
in another entry of the `upgrade-path`.

Bonus point: tests no longer need to be imported in the `__init__.py`
file.

closes odoo/odoo#121304

X-original-commit: 08adb3e6
Signed-off-by: Christophe Simonis <chs@odoo.com>
Co-authored-by: Alvaro Fuentes <afu@odoo.com>

Before this commit
==================
when SO is confirmed and Delivery is created then add the shipping method
in SO, in this case, the shipping carrier is not set in the existing undelivered
delivery of that SO.

After this commit
=================
So in this commit, we set the shipping carrier for undelivered delivery.

taskId - 2946360

closes odoo/odoo#121300

X-original-commit: 51523c0dbf6ce9dd1a1ff35e03fa6a51267da14b
Signed-off-by: Tiffany Chang <tic@odoo.com>

__Current behavior before PR:__
When someone joins a call in the discuss public view and receives a message in the chatter, the part of the screen supposed to display the video streams of the participants goes black.

This happens because it is trying to open a chat window in the bottom right as it is done usually. However since we are in the public view it removes it instantly together with the participants cards.

__Description of the fix:__
If we are in the discuss public view, it is useless to make chat windows. This will prevent opening of chat windows.

__Steps to reproduce the issue:__
1. Open the discuss app and start a meeting.
2. Copy the Invitation Link
3. Open a new private window to join the call with a guest user.
4. Then go back to the non-guest user page and send a message in the chatter.
5. Notice that the participants cards vanished on the private window page.

opw-3229747

closes odoo/odoo#121195

X-original-commit: 49d56c5449e1bd9457fb935e98134cafc75931dc
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>

before this commit, on clicking on Go To Website
smart button in forum is not redirecting to the
corresponding forum due to missing parenthesis
to the function.

after this commit, on clicking the Go To Website
smart button, user is redirected to the forum.

introduced in: https://github.com/odoo/odoo/commit/36c734ab37fdf1d6a245e0e29cfefe3cc46c6d92



closes odoo/odoo#121338

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

Before this commit, there were cases where toggling the grid mode did
not work correctly. These cases are:
- when a snippet has None columns (e.g. Cover) and that an inner snippet
containing a row (e.g. Form) was dropped into it,
- when a snippet has some content outside its row (e.g. Picture) and
that an inner snippet containing a row was dropped in this outer
content,
- when a snippet has some content outside its row (e.g. Picture) and
that an inner content (e.g. Alert) was dropped in this outer content.

The first two cases happen because the row that was taken into account
when toggling the grid mode was the first `.row` element found in
general, instead of only considering the container children. Therefore,
what happened in these problematic cases is that the row found was the
inner snippet one, which should not be the case and caused the toggle to
fail because it was trying to put the element inside itself.

The third case happens because the `div` elements were excluded when
placing the outer content in a column, instead of only excluding the row
element.

This commit fixes these issues by only considering the container
children when looking for the row element when toggling the grid mode,
and by filtering out only the row element instead of every `div` when
creating a column for the outer content.

task-3279191

closes odoo/odoo#119965

Signed-off-by: Dieleman Guillaume <gdi@odoo.com>

When importing data and checking the possible values of a field,
clicking on one of the records to open it throws an error

Steps to reproduce:
1. Install Projects
2. Go to Project > My Tasks and trigger the list view
3. Select any record and export it (check the import-compatible export
   option)
4. Open the exported file and modify the `project_id` to a non-existing
   project name
5. Click on Favorites > Import records
6. Upload the modified file and click on 'TEST'
7. In the `project_id` field, click on 'See possible values'
8. Click on any project, an error is thrown

Solution:
Prevent the form from being opened when the action is in target "new"

Problem:
Opening the record in a target new throws the error `switchView
called but the current controller isn't a view`

opw-3161777

closes odoo/odoo#119643

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

### Contains the following commits:

https://github.com/odoo/o-spreadsheet/commit/115eda75 [REL] 16.0.10
https://github.com/odoo/o-spreadsheet/commit/80667964 [FIX] evaluation: compute format from empty cell
https://github.com/odoo/o-spreadsheet/commit/dbeb370a [FIX] ChartFigure: chart/image menu options in readonly mode Task: 3284659
https://github.com/odoo/o-spreadsheet/commit/3b3e49f6 [FIX] SelectionInput: Fix cross symbol
https://github.com/odoo/o-spreadsheet/commit/1fb31b93 [FIX] SelectionInputPlugin: prevent multiple range in 'singleRange' input Task: 3237798
https://github.com/odoo/o-spreadsheet/commit/644c6761

 [FIX] collaborative: ignore bad snapshot revision

closes odoo/odoo#121270

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>

- Add missing account tag on repartition line taxes to fix the report 104 amounts for per tax

closes odoo/odoo#121095

Signed-off-by: Josse Colpaert <jco@odoo.com>

The cookie policy banner template includes nested selectors, such as
o_cookies_bar_text_policy within o_cookies_bar_text_secondary.
The process for switching the banner layout involves copying selectors
based on the order defined in CookiesBar::selectLayout()::selectorsToKeep.
However, a bug caused o_cookies_bar_text_policy to be copied before
o_cookies_bar_text_secondary, resulting in its content being overridden
by its parent content. The fix involves reordering the selectors so that
o_cookies_bar_text_secondary is copied before o_cookies_bar_text_policy.

opw-3302511

closes odoo/odoo#120914

Signed-off-by: Romain Derie (rde) <rde@odoo.com>

Steps to reproduce the bug:
- Enable subcontracting in mrp settings
- Create a storable product:
    - add “azure interior “ as supplier
    - Create a BoM:
        - Type: subcontracting
        - subcontractor: azure interior
        - save
- Click on BoM overview

Problem:
Traceback is triggered: “OwlError: Invalid props for component
'BomOverviewSpecialLine': 'precision' is missing (should be a number)”

opw-3321346

closes odoo/odoo#121245

Signed-off-by: William Henrotin (whe) <whe@odoo.com>

To Reproduce
============
- create two Vendor Bills and attach to each one a PDF from the ones
provided by the client on the ticket.
- select these two bills and and try to print Original Bills an error will be raised

Problem
=======
while merging these PDFs, PyPDF2 throws a `TypeError` which is not caught by the server

Solution
========
catch `TypeError` to raise a UserError

opw-3285540

closes odoo/odoo#121220

X-original-commit: d2b97524
Signed-off-by: abla001 <abla@odoo.com>

The key chosed in the SaleDetailsReport.xml file following
t-foreach instructions were not properly chosen. When 2 products were
bought but with different price or different discount, the key
was the same leading to an error. This fix aims at resolving
this problem.

closes odoo/odoo#119026

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

With a slow network, make a new search in the search bar of a graph view
would lead the graph renderer to be rendered twice. This was due to the
fact that in the graph controller template an arrow function is passed
as a prop to the graph renderer. The reactivity system treats that prop
as changing at each graph controller rendering and ask unnecessarily (in
this case) the graph renderer to render.

closes odoo/odoo#121252

Signed-off-by: Géry Debongnie <ged@odoo.com>

In 14.0 the menu items in the navbar sections menu could have any level.
Since the webclient refactoring landed in 15.0 0573acae this feature has
been unintentionnally limited to two levels.
More sub menus would simply not be displayed.

**Before this commit**
- Have a menu item with the following path:
  `App/Menu/Group/Sub-group/Item`
- The `Sub-group` is displayed as an item. It is clickable but nothing happens.
- The `Item` is not displayed.

**After this commit**
Works properly as it should. See screenshots on the PR description.

closes odoo/odoo#121196

X-original-commit: 5080ecf11be87a5ba29041b82163197a7487343c
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>

Add local date and time at the end of the printed in/out cash ticket

closes odoo/odoo#119835

Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

Steps to reproduce:

- Install l10n_jp before the original commit
- Update code to latest
- Try to upgrade the l10n_jp module

Current behaviour:
Error shown because of missing account tax group.

Expected behaviour:
No error should be shown.

Explanation:
The new version of localisation changes the xmlid which caused the original tax group
cannot find the reference. Migrate them to prevent the error.

X-original-commit: 7a914a0e
Close #118867

closes odoo/odoo#120377

Signed-off-by: Josse Colpaert <jco@odoo.com>

Set "Cash Discount Tax Reduction" to "Always"
Create an invoice with a tax line
Set Payment term to "2/7 Net 30" [1]
Go to "journal items" tab
Early payment discount lines are set correctly
Set payment term to "30 Days", Save
Set Payment term to "2/7 Net 30", Save

Issue:
An extra tax line appear in journal items because an old tax line was
not deleted and a new one is created

[1] Payment terms: 30 Days, 2% Early Payment Discount under 7 days

opw-3285534

closes odoo/odoo#120014

Signed-off-by: William André (wan) <wan@odoo.com>

Previous commit 1b840d06 tried to fix
the issue action_generate_serial may try to generate a existing lot.
But it made the lot number completely product specific. This change is
too big for stable, we revert the change in this commit.

Also to fix the issue, when action_generate_serial tries to generate a
lot, we always try the result from ir.sequence frist, only when the lot
already exists, we then try create one based on the product's lastest
lot number.

Task-3187003

closes odoo/odoo#121194

X-original-commit: 95214ab6c133553371926804e788766edab2b8ca
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Yuchen Huang (yhu) <yhu@odoo.com>

mimic what is done for `odoo.addons` __path__.

closes odoo/odoo#121183

X-original-commit: 2a981e6a
Signed-off-by: Christophe Simonis <chs@odoo.com>

Since e6415be5ce6077702836779cf784e16f7e72a9c7, it is
forbidden to use taxes on Sales Order Lines from another company
than the Sales Order one (it was breaking later in the flows anyway).

Nevertheless, in some flows, modifying the company of an existing SO
can make sense, but you wouldn't be able to save the change if taxes
were set on the lines (unless you trigger the 'Update Taxes' button).

This commit will make sure that taxes are automatically recomputed
on company change, s.t. the user doesn't face multi-company errors.
It'll magically change taxes & amounts, but we consider that it's
an expected behavior when modifying the order company (and an
advanced flow for which users must be aware of the consequences).

Anyway, the user will always be able to discard the changes (company
& company-based recomputations) if needed.

opw-3234905

closes odoo/odoo#120774

X-original-commit: e2e97ae66604a441e91e0efedd8d3b10c4219d24
Related: odoo/enterprise#40844
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>

Commit [1] defined a value for the `onWysiwygBlur` option of `Wysiwyg`
in the `mass_mailing` `html field`. This had the side effect of
overriding the value set by its parent `html field`, which was to call
`commitChanges`. As a result, the `mass_mailing` `html field` was not
saving its content on blur. This restores that behavior by explicitly
adding the call to `commitChanges` where it was missing.

[1]: https://github.com/odoo/odoo/commit/e212e873eb35eb9b9a931fb1521109475c008074



task-3288881

closes odoo/odoo#120113

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

When mass_mailing was installed, the website snippets demo page did not
work anymore. This is due to a combination of two factors:

A. [1] marked views for removal just before the release of the 16.0 (so
   that they could be removed via an upgrade script later on after
   runbot things) but we forgot to remove them before the release.

B. The views that [1] tweaked and should have been removed contain an
   apparently simple `<div>` with a comment... but it actually acts as
   an xpath looking for a div as it is an extension view. Unfortunately,
   there is a bug in the t-call/inheritance system regarding this: when
   the main view containing this xpath is rendered directly, there is no
   issue (that's what edit mode works: a div is found and nothing is
   added inside). But when it is t-call'ed (as it is the case in the
   snippets demo page), the div cannot be found anymore (it seems to
   look for `/data/div` instead of `/t/div`).

The bug described at B (if it is really a bug) could be worth checking
but this is probably not worth the time until a real usecase occurs. For
now, this commit fixes the broken demo page by using a real xpath to
target the div. This is technically not a stable change but really,
users should not have targeted a template which was clearly marked for
removal. So hopefully, there should not be any issue.

[1]: https://github.com/odoo/odoo/commit/3201eba9fd31602d709b962965e9c1411d1eeb6f#diff-b26221e9411fb6f3725ce5a30c4659a22d81a9a69f666bdbd6daa77e03ec3253R302-R308



task-3233465

closes odoo/odoo#121134

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

Bug:
When the `sale_loyalty_taxcloud` is installed and 'Lock Confirmed Sales'
is enabled, confirming a SO impossible.

Setup:
- install `sale_management` and `sale_loyalty_taxcloud`
- activate Taxcloud (with test credentials)
- enable 'Lock Confirmed Sales' in the settings

Steps to reproduce:
- create a quotation, fill the necessary fields and add a product
- in the 'Other Info' tab, set the fiscal position to
  'Automatic Tax Mapping (TaxCloud)'
- attempt to confirm the quotation

You should be met with a message stating that you can't modify the tax
on a locked order.

Cause:
This issue was introduced by odoo/enterprise@ea954b818b9582c2f63f103019b61d3fa73c7a29

Enterprise PR: odoo/enterprise#40880

opw-3289657

closes odoo/odoo#120998

Signed-off-by: Nshimiyimana Serge Séna (sesn) <sesn@odoo.com>