Skip to content
Snippets Groups Projects
  1. May 03, 2017
  2. May 02, 2017
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
    • Fabien Pinckaers's avatar
    • Christophe Simonis's avatar
      6441ea28
    • Fabien Pinckaers's avatar
      a5cf0cc8
    • Fabien Pinckaers's avatar
      [IMP] hr_recruitment: improved kanban view of applicants · f72d87ab
      Fabien Pinckaers authored
      [IMP] hr_org_chart: help sentence
      [IMP] sale: search on customer in main search
      f72d87ab
    • qsm-odoo's avatar
      [FIX] web: edit correct list line on click after line deletion · 2c59d81d
      qsm-odoo authored
      Before this commit, if the user created a line (thanks to the create
      button) then deleted it, the rows were in a broken state which made the
      list edit the wrong line on line click (it opened the next one). This
      was due to row indexes which are kept as data on rows: they were not
      updated on row deletion. This commit simplifies the code by getting rid
      of this indexes data and instead compute those when necessary.
      2c59d81d
    • Christophe Simonis's avatar
    • Nicolas Martinelli's avatar
      [FIX] account_tax_cash_basis: raise if no account · 279b3a8a
      Nicolas Martinelli authored
      Since the account is a mandatory field, we raise an clear error is no
      account is defined.
      
      This is necessary when running an automatic reconciliation on the POS.
      The POS uses a try/except to avoid any error, but in the case of an SQL
      error, the cursor is invalidated, so the transaction fails.
      
      opw-741677
      279b3a8a
    • Christophe Simonis's avatar
      73527d0f
    • Nicolas Martinelli's avatar
      [FIX] web: min/max integer · be1ca7b1
      Nicolas Martinelli authored
      In PostgreSQL, a field of type `integer` must be in the range
      -2147483648 to +2147483647. If the user enters a lower or a larger
      value, a traceback is thrown.
      
      opw-740286
      be1ca7b1
    • Aaron Bohy's avatar
      [FIX] web: BasicModel: apply onchange after x2m edition · c891463e
      Aaron Bohy authored
      When a record is added in an x2many field with an onchange, the
      onchange is only triggered once the new record is valid (i.e. when
      all its required fields have a correct value).
      
      However, there was an issue in the code checking the validity of
      a record, as it iterated on all known fields of the model (instead
      of those in the view), so if there were required fields that
      weren't, the record was always invalid (as those fields obviously
      never had a value), and thus the onchange was never done.
      
      This wasn't a problem with embedded views as in this case, the
      known fields are those in the view. But when the view isn't
      embedded, all fields of the related model are known, even if only
      some of them are in the view.
      
      This was the case for example in the stock.picking form view, when
      adding a line in the stock.move o2m: the onchange wasn't done and
      thus, the schedule date wasn't correctly set.
      c891463e
    • Aaron Bohy's avatar
      [FIX] web: don't fetch invisible relational fields · e9dce2c7
      Aaron Bohy authored
      Relational fields with attribute 'invisible' set to true are in
      views because they are used in domains or contexts. In this case
      their relational data is useless, only their ids matter. Before
      this rev., their relational data was fetched anyway. More
      precisely, it was the case for many2ones after a default_get, and
      for x2manys with inline views, or without view (e.g. with widget
      'many2many_tags').
      e9dce2c7
    • David Monjoie's avatar
      [FIX] web: keep positional args for search_read · d99ae3fd
      David Monjoie authored
      The previous code used to create its own args array
      for the search_read method, replacing the one that
      was originally given to it.
      
      This lead to silent errors since positional arguments
      to this function were completely ignored in the case
      of search_read.
      
      I took this commit as an opportunity to improve a
      bit on the current state of these rpc helpers.
      Namely, the basic args/kwargs priority is the following (top-to-bottom):
      - kwargs defined in the rpc call
      - kwargs defined in the kwargs key of the params kwarg of the rpc call
      - positional arguments are passed as is
      
      For read_group and search_read methods, the priority is the following:
      - kwargs defined in the rpc call
      - kwargs defined in the params kwarg to the rpc call
      - kwargs defined in the kwargs key of the params kwarg of the rpc call
      - positional arguments are passed as is
      
      For the /web/dataset/search_read controller, only the params kwarg is
      supported, resulting in the following priority:
      - kwargs defined in the rpc call
      - kwargs defined in the params kwarg to the rpc call
      - positional arguments are passed as is
      
      If both a kwargs and a positional arg is given for the same parameter,
      it will be sent as is to the server which will crash with a typical
      "got multiple values for keyword argument" TypeError. However, in the
      MockServer however, we give priority to kwargs over args in this case.
      
      Please note that I also chose to remove unnecessary default values so
      that the ones actually used are the ones from the server, not the ones
      that were duplicating those in the rpc js file.
      d99ae3fd
    • David Monjoie's avatar
    • David Monjoie's avatar
      [FIX] web: fix missing idForLabel on some widgets · e02cee4e
      David Monjoie authored
      Widgets which manipulates their dom in _renderEdit were left out
      from the previous implementation since this processing was done
      only once when the widget is rendered the first time. If the
      widget regenerates a new input upon reset for example, then it
      would lack the idForLabel.
      e02cee4e
    • David Monjoie's avatar
      [FIX] web: fix FieldStatus tests on extra small screens · 4e4c8996
      David Monjoie authored
      When enterprise is installed, the rendering of these widgets on
      extra small screens is different, thus breaking these tests. We
      need to force the test to run on normal screens.
      4e4c8996
    • Goffin Simon's avatar
      [FIX] sale: Wrong access_name button in Sales Order - Send by Email · e645d38c
      Goffin Simon authored
      When the online SO was already confirmed and paid, the button "Accept and pay"
      was displayed instead of "View".
      
      opw:728306
      e645d38c
    • Martin Trigaux's avatar
      [FIX] sale: avoid updating layout sequence at creation · ceeee8e6
      Martin Trigaux authored
      When a invoice line is create a default layout_category_sequence was created
      with a value of 0, updating the value of layout_category_id.sequence instead
      of fetching it.
      
      This operation was very slow on the invoice creation wizard
      
      opw-741517
      ceeee8e6
    • Christophe Simonis's avatar
    • Christophe Simonis's avatar
      671864e7
    • Quentin De Paoli's avatar
    • Quentin De Paoli's avatar
      [FIX] account: fix consistency for fiscal positions and reconcile model with... · a7838954
      Quentin De Paoli authored
      [FIX] account: fix consistency for fiscal positions and reconcile model with their respective templates.
      
      - Some fields were simply missing on templates, making impossible to give them a value on chart template installation.
      - Added a real link between account.reconcile.model.template and its chart template instead of using account_id.chart_template_id
      - Added tests for checking the consistency of those objects in the future.
      a7838954
    • Géry Debongnie's avatar
      [FIX] web: prevent crash in some cases in list editable · 6f0be0df
      Géry Debongnie authored
      Before this commit, when we moved from one line to the next, we did not
      wait for the unselectRow to end.  This means that if the read (from the
      unselect row) completes after the default_get, the list renderer was not
      in a coherent state (currentRow was set to null), which could (and did)
      cause a crash.
      
      This was found by pressing the TAB key a few times, and editing some
      values.
      
      Also, we slightly improved the logging in the mock server.  Before this,
      the responses from the mock server did not show from which route it came
      from.  But in this test, we specifically make sure that the rpcs
      complete in a different order, so it was not really optimal.
      6f0be0df
  3. May 01, 2017
  4. Apr 30, 2017
  5. Apr 28, 2017
Loading